From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4866AC0015E for ; Tue, 11 Jul 2023 16:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C01D56B0072; Tue, 11 Jul 2023 12:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB1DE6B0074; Tue, 11 Jul 2023 12:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7A9D6B0075; Tue, 11 Jul 2023 12:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 96ED56B0072 for ; Tue, 11 Jul 2023 12:34:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7098616031A for ; Tue, 11 Jul 2023 16:34:55 +0000 (UTC) X-FDA: 80999880150.13.E81DCE1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id AB7601C002A for ; Tue, 11 Jul 2023 16:34:53 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qtGGN+ay; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689093293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KHNOblbzEFsi8whYUCPDw0HA4EV8dAtkQKJLjLuAfUA=; b=53wJGUNv5ktaZgoIkiS5qgpupSFoAMlLZ+SJSBeTn0LQcRI2pYhxsTvdEcMr2bSrz3t62b LKpcbBLjyuyk8JSN14MJmRFgDr+wVqEVE+zm7MFsoMdFj2+6CYvPeMCm2o3gF2Bfi3bzSb xI70cxUWR2bx4ZbfZ2b0CbckRN67knc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qtGGN+ay; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689093293; a=rsa-sha256; cv=none; b=W0D7GfwOiRU3EnZimNxodGrIPeA2El1NmEnw6I9QXpJEfFNsEAi5iQe2TEZdUyspA6GiXp LB7P0+w9WVvU/oaGEAYf/1UkBXmU/hsa6xjvXLiO5rkSq6AFqbS+77tUGMuLNwqNV/d2EH xaH3ABTbfVv4gJi6w1b71WYdLXHa3eQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8365261554; Tue, 11 Jul 2023 16:34:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 825BBC433C7; Tue, 11 Jul 2023 16:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689093291; bh=cpSt6wSp9MML3SCZgntwF/5xJMCrBIMrNErWPgETwrg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qtGGN+ayDJvNn7CYl0Y6Mg8Nol64sZSdGU4J7QFWWHQhkiRUhok+ZgtO0zhzd6fI8 IwYKeAf56hI07dIlmXNAJJ+xokzwk08MJLgMD52cZ5rMNmSqAiRXM5GaL6OAxrq+Ca GX5lMtEJY+ucpQ6gRkNa/0MzBqyDLLvpjx3k6YMQJqvrC4iLB0GgVKlPfecai4fddH 52hS5OWCI4FfdYs1Qn6ZFZ/BTbJ/+/+Fo5G2dvoQmDmeD9UbUy3D8jWaM1/4vWNV5G +KmtFpmEbrXJOFav1A2qyDpkr+vyrhUlsqQj1FpwRn8DS2x2mrDXgWMKLyn8VcqTz3 a6P1FGhOpAEQg== Date: Tue, 11 Jul 2023 17:34:41 +0100 From: Mark Brown To: Hugh Dickins Cc: Lorenzo Stoakes , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@leemhuis.info, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> <901ae88d-ad0c-4e9d-b199-f1566cc62a00@lucifer.local> <977ddee4-35f0-fcd1-2fd-1c3057e7ea2a@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GzGnTnQhN99CmdXE" Content-Disposition: inline In-Reply-To: X-Cookie: marriage, n.: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB7601C002A X-Stat-Signature: iqiwssecey5b8xxonot1pfx35c7eq68f X-Rspam-User: X-HE-Tag: 1689093293-666353 X-HE-Meta: U2FsdGVkX19e5trwNHFS/GNaJ2EKEvDF0pFEE4QYpPpLUNjbg4/amTU00XRaPA6cW/ngq76os8KEvyNSbCOaQE+UC10dwy6yhboS4J9rvGi9BflAMtV0+C6gQONX9wsRkvbQfaK/yHISdzom5uaBLMxcUwmA+LqXXT9biDse4NqcE9LYM3GJyt8dQYU8BVBjNGYVpmhJtpiZAdhQH+aR/4bIH6zjnSlq7gFglSBQ3kLh8a9l7WjFj9OYga159Mfh6e2FbKEsIkoyHCYjjt/zFKdqH93gArToyol/YKxQhgk3Kzz4AVIZSn3KfQ4Li5xUe4v9/iGrwrR40S3brEEp9LymYVo4tn5Rf4wb0+GGbwj8Xkt/eZFF835ueW1YAn79S69yF3xY7124ZQxpJulD5vgckZYc0GIR2aY3eTk/yKgwxsdNa36nN/xnF+rGm4gP9n1gr9Iecb7mpc0z716vsblhy9oR2eifvuYMz6OcqCiabBSMunvOjx8vAOl3JUqVRaDXSjFjiAZHpknUJ2t1zaYGhAwQRUffrouKH+/Jo4KtzqaAM8kRFIWS0omcxp0mF2l4x3zRZ7+68V/biwNkc6U4YHlS2yg4iBX1aD+cFZPEv3KTuoCxa3H0KMXyaaX4bvVCG0vHhAmUfeOfYKMyMviK9oRAhrUOvSvgAvL6pReBkrR02vLeiYxw5WNvIzxkEBirQmFZRZWXTwKaor2bOB+KrUWPpMghyg6epU3UQDTwXhS+Ao1K+RvMIfDM4UrljQnrJz68ahWa8Meb6iYZsyg9AHLXzCbLQu/DQ6APzo02dM0oRAshk1DDda76/iEOWbhZfKeDex0GFDWuL16sF8og6hVZ01wr1FkL3flCZ+HeZB/BPrLKdBYmOFl8yg5wScixJi67O9G0XKYyjtLepSvURwpIyT6Zn5eWL/1ZPiDAo1svhj3Qno+QCF8xd231ekztdlYu5mxV//+mhHt 58WriCZx dwcilLY/LzIfZT1F0BXTJoH6pCQfwFj3e8fd0bKk5YzLzm6Z55f6cthK++k9+k0sdc6ZY9817nyVegSjkj3Yt3/QnCROZMjWpGajOhe3id5FGf4JNLkuzw/FmZD1cbTBDJfaup4Fi9o23w+ZhRsLL2I75D3YMyKCEQQqYX6gUgJ4mC95PBEBOWJyABjzbceKx8jFjqMbJTmfe/hlFoviM2RYV3yt/QzR2ymBoPufazq91tirhIa1onQXv0DozC1p5rGNJXM1QfQAj7VzK+mVby8SD/pyLZu2l7EtikIPs21d53R9y31JYGNr2dpGm0dfdmjXq7WgCxwKLU+sXShekXyPy5RBwkmmHcVoEdmxkGOjNFY6+E6vwI09NWz3humziQVIP8flyEnsdEzU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --GzGnTnQhN99CmdXE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 11, 2023 at 09:13:18AM -0700, Hugh Dickins wrote: > On Tue, 11 Jul 2023, Mark Brown wrote: > > On Mon, Jul 10, 2023 at 09:34:42PM -0700, Hugh Dickins wrote: > > > I suppose I should ask you to try reverting this 0d1c81edc61e alone > > > from 6.5-rc1: the consistency of your bisection implies that it will > > > "fix" the issues, and it is a commit which we could drop. It makes > > > me a little nervous, applying userspace-pagetable validation to kernel > > > pagetables, so I don't want to drop it; and it would really be cargo- > > > culting to drop it without understanding. But we could drop it. > > I did look at that, it doesn't revert cleanly by itself. ... > Right, that ptep_get() wrapper on the next line came in on top. > The patch to revert just 0d1c81edc61e is this: Thanks, tried that and it's still exploding in a similar way (though this time inside a regulator call from the pinctrl code which was happening in other cases). --GzGnTnQhN99CmdXE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSthKAACgkQJNaLcl1U h9B2aAf8C8X78iHr1+jlI1B9Sc2Jl67lIJJk807nXppJ2iudYWfWYcfQEQuUHL7E K/ywaUbPz/TJ+uaIBHKvc98E3JxkSDr0SKZs2HtSv+bTNhPP3F7fyU7VG/Ea6EiC 0bSwjlSmWn4rri1K4P8TMOsdC0lpZl4yMpTLHFV64/atLAtMACpKXnpKLbc+fr3U y32n809VR2e/QlYyI0rrZ8ZWMiW8HOitDbWrXPZESI5aKWVkXvjYF9D+C/OTqxbC smxEv4tAwTAvHv9qmdZPTHoyv0dEaSIFeDVi885pDtpQjj6vb7HgmfSJBWn6tGH7 InOST+lI6sT293TXfUzBvpxuDdbY8A== =ED9C -----END PGP SIGNATURE----- --GzGnTnQhN99CmdXE--