From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513A0C54EBE for ; Mon, 16 Jan 2023 15:12:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E30C86B0071; Mon, 16 Jan 2023 10:12:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DE01E6B0072; Mon, 16 Jan 2023 10:12:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80A46B0073; Mon, 16 Jan 2023 10:12:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA0BF6B0071 for ; Mon, 16 Jan 2023 10:12:55 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 95ECD80A07 for ; Mon, 16 Jan 2023 15:12:55 +0000 (UTC) X-FDA: 80361004710.29.DC62F6B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 54D1B40016 for ; Mon, 16 Jan 2023 15:12:53 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idC36IR4; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673881973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n8GPUBKE/NuQUsbNLJNTHyoSEwq0B/JvfXQkuCQI2A8=; b=nl6+COMKSkrkzZBveTQ6MSubn+Y5k2ER57+DkJkEvbDxGM2V5OEehAf6VbaANRk9RV3oUz KgB75o1HLOBLnl4x7onVye8zTUQwGsrxZL26CPVulQo1CePuEtT4B2rKTP2SkFfFYoLZg0 guzODNSqcroSK0eNBkfoesWCLFJgMU8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idC36IR4; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673881973; a=rsa-sha256; cv=none; b=XYCdWHeILRtrrxOjk80n9Vu5q3mtaVEiXPwLHXCpBWmqZsMJ1jDztKXYAzUg8BsmR94VYh WJfVWhDHsHZkIh0PIlKqCR21QRSAXKi/gNNeiuSFArj1/UmHdgN56ZIq58kur3i9rMm+oU 852nZwaVl5RRzR3ErRkSWIRvVacQnP8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673881972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8GPUBKE/NuQUsbNLJNTHyoSEwq0B/JvfXQkuCQI2A8=; b=idC36IR4LPDpNv81yqOPbPfR73TcyM/WR1O3JiWR3bJsX31IVn9GWNHU1039FcZCZodsbZ 886Xior5pK/OYqLxNB9NZVwFmdTfqPtElBB8Yr5SlaVQmpHMsBGRkhoe7254iTx3u1zZCG oiAsTAECeKCkouDNQQNrjjp7g+zbtFI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-247-bjLyajHUM_e0fURAE2onfQ-1; Mon, 16 Jan 2023 10:12:51 -0500 X-MC-Unique: bjLyajHUM_e0fURAE2onfQ-1 Received: by mail-wr1-f70.google.com with SMTP id k18-20020adfb352000000b002bdd0a7a2b5so2437864wrd.0 for ; Mon, 16 Jan 2023 07:12:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n8GPUBKE/NuQUsbNLJNTHyoSEwq0B/JvfXQkuCQI2A8=; b=pfEt8Wmw9JS7fa8gC0JiW9rRd/4lvzmgdXuDLKd4NEFVH75d2ziOQibeYf1MFz7hhU sH+nThY78BzWIb9i0Y5eWsPD+4y5MkwQS25DxtGvsbXDPYI9GjUeFoK0SFLSS/AZ2Mup /Tbkr9C7Nxy5jg/+fZ5KyKHjmNLjfzWqqnOPENWriwHbmEXo8dulO4j1lgHUEJYHnIHK nHi/GrMKJGcHlB9MdyhsXFlFjAgxGbQDJUdhKLH08aXGEjd5YL9EAxyIDBjCD83eAvK4 YxKb5tv7nvLWL1sUFwGNcdu88EfL+EONagiGkLk+H7+R3y4PMU5/9oHdsJo9zrEP6zGb 4Lig== X-Gm-Message-State: AFqh2kp0kBW5ovrFrUt5BU+I500D0Yi+i8cErmi2G+8hKGn2SK2gDqs8 gIOEalc8zviGzSViyobIVoeKAH6eh87JMxaPoqrTXL/aZIshi/4tg74cZS1dPEDW2bZckD0Y12w N0ts8JHnRHhk= X-Received: by 2002:a05:6000:120e:b0:2bd:d948:3c3e with SMTP id e14-20020a056000120e00b002bdd9483c3emr12425229wrx.19.1673881970300; Mon, 16 Jan 2023 07:12:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXuYQj0NYJaAaPUwl6DhsnV5BhYVrjbmEgaQQaWjKL2U5u+qrkhqwf+J8sfH/rU5oiS9MVZzwA== X-Received: by 2002:a05:6000:120e:b0:2bd:d948:3c3e with SMTP id e14-20020a056000120e00b002bdd9483c3emr12425214wrx.19.1673881970037; Mon, 16 Jan 2023 07:12:50 -0800 (PST) Received: from ?IPV6:2003:cb:c704:1000:21d5:831d:e107:fbd6? (p200300cbc704100021d5831de107fbd6.dip0.t-ipconnect.de. [2003:cb:c704:1000:21d5:831d:e107:fbd6]) by smtp.gmail.com with ESMTPSA id bt14-20020a056000080e00b0027cb20605e3sm3243298wrb.105.2023.01.16.07.12.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 07:12:49 -0800 (PST) Message-ID: Date: Mon, 16 Jan 2023 16:12:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH mm] mm: hugetlb: Add checks for NULL for vma returned from find_vma. find_vma may return NULL, that's why its return value is usually checked for NULL. To: =?UTF-8?B?0JXQutCw0YLQtdGA0LjQvdCwINCV0YHQuNC90LA=?= , Mike Kravetz Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20230116100520.71277-1-eesina@astralinux.ru> <6f5ac7ee-0af3-a466-cf7f-b17270bc1391@redhat.com> <182575210.374192581.1673881818398.JavaMail.zimbra@astralinux.ru> From: David Hildenbrand Organization: Red Hat In-Reply-To: <182575210.374192581.1673881818398.JavaMail.zimbra@astralinux.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 54D1B40016 X-Rspam-User: X-Stat-Signature: qa8swn1w9gsf9981r31u9gtyzco4pqwx X-HE-Tag: 1673881973-424426 X-HE-Meta: U2FsdGVkX19faDceuaH7vI38f5IIGnKgdYBEVmRe+k1xAVguY61G41kkPouo+ggMV+DRO7oVPpmhe9m7UwPDIvfPX6dFVyPIznRLuWQaF3C8mNkWCPLHjxvF0Pxj0NS+o/SEd96O+yrGL7aP5B55BO6JHASCErLan7Tet29OZpKt+Gn9e5st21907K5aIRK13LLxO0bv0hYyDsq7q6vtOrQCbc3fUKDgB+Yjdgj6UO5QmDf3Q4FNmRHbo34KqB89AIa3ALgId9H8h1wkX//mPTAux+V/pleu2dPx2YIhsdfawsq//+ymJ753CrJP9bEADGbyBCCST9YAcT7qlWVqKbEp2CewEyvbxNEGyi1z8dWsp0P7+jKTMmBkUC4fl+Acfmm425+DQKJD4TtZB/dYP+p3y9iM5kdt+GsFjefuXj21KKlsg071+1zW0BwEnbNNSgx9t9tE5K6lnEW/KuPWvEmCGM5NQ5DdIO9ZObjKAVKex5VrlidKlR091hvcWEEe7eZeol9hFDZYeo6bWQ/H6SWgB1y0VVFEIxgNaKRUYyXLG0HBx2wBSho/9wvJOIqcG7ia7E14ZwnHMQoH/xghmCJ7WUy5fhPSlf1092Jj+3l2/nEEFZh7RBXMaVK78XUp3BP5ZpX9nMQUGXCzKswQmt+NyLp0tYzr6+nhBIgzk7nwnKVE2HJl/wm/J2WK7CLhHUPIhl9NuQQBxW7u1u6z0vzmq0iQsXOLCgKXebSLMBjoGQ3lNQ5S/+ta2t4CdWnJwNFR6gHb6BMstGTxpOq5pufurKR9ZSPAI0IXp1TwVJk4ot7EBHfR9iHB3zRrDlnhHhnEDPk17NppmTGtqQ5uX6zbsGmuv8JiwFiFB/ih0ikXNcJFGryX83ihtRThHki3ZVJzkaK49hyZ1mavVoai4CGO2J2KH+BVQnDQv3pntIywlsNHEj/FCZhm01eiwlH26C3FW8AUtr/eYtDElet RixbCy2Q MY56HYrSkh64TiDmEPirAFZOaTCLkitMcFekqeeQy/X4znCLbA5bFp/kqA9LiDJsZaSkGRq/eJL2tURma05gjlPwL3LJXq4RZRm26tn8q2pFx3CQ6V2kmvzcAEZuuvws2AqHV3Jg/m6nPbhgFHVudo0bVBEO5kGYOD+16Ovqsh+b5onI+wD54w1gP5xyVIFOBLF1O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000749, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.01.23 16:10, Екатерина Есина wrote: > Sorry, I've noticed that I'd sent the patch without description and sent > version 2. > Function find_vma may return NULL, that's why its return value is > usually checked for NULL. In this case vma and its fields also should be > checked before dereferencing to avoid NULL pointer dereference Thanks, but again What are the symptoms? How exactly does this BUG manifest? For example, does the kernel crash, and if so, how can it be triggered? -- Thanks, David / dhildenb