From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081FBC6FD18 for ; Wed, 29 Mar 2023 23:29:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C6936B0072; Wed, 29 Mar 2023 19:29:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 376B26B0074; Wed, 29 Mar 2023 19:29:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23E436B0075; Wed, 29 Mar 2023 19:29:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 14A186B0072 for ; Wed, 29 Mar 2023 19:29:27 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BB66DAC6C4 for ; Wed, 29 Mar 2023 23:29:26 +0000 (UTC) X-FDA: 80623529532.10.5FD91C2 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 09EC818000C for ; Wed, 29 Mar 2023 23:29:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=CqPjbnwB; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=ey2f3kk1; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf16.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BKGKUWWqulihARUFgnZfMKk27i10XHve0IMeGojBml4=; b=0CpS3rGEwPsBF6xLySMlNE0NzIYqOXf5B+TEVtcMt4V/UQFny6+4TWib6mci/qjyvnQBkq 9oIUrsaLIXkM95e745v3Ra8FGwml5SoVsrF6N2xKSIgB1DI2ZK+EcNQXkum50zdnQloYDd k+lm7eaL/7TM7zolZBsX418euIYKveA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=CqPjbnwB; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=ey2f3kk1; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf16.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132564; a=rsa-sha256; cv=none; b=zuhvTPPbIAWcQP7J0eoHm8jQr/W46LC4401hH5xyr3vTM+TBVdN5y15xIhWz28fIjdhyvC czu6CW6TdVnMnQAwyY6E+TeKXq6kylEtrwenn/yA0ugR3CLez/IH01Bg1p8FphFmavCtor ERjI1fCuy+uDLwnjtqt4cqHFW6GgILY= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132563; x=1711668563; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=a+NVpLO2XQBp6iZs+ex8RERrDcsLfBZuQOxHVIXweuE=; b=CqPjbnwB07nrbPfHTXv0LfyHLjmBe41AH10YxIg533mUXJ7Cj5gV1yYp 3RgxWvVQHM19Z29oRpaSpZZP353815IPSMzb9Z3mr+H4xA2jW4FYS0/kk JJjKTCE10oSDvX6ejO5CpxznLsLK76w2hFTGBl0YW2LyChj2yoYk5+0IF HvJtz/xbT6tbWa+hzl92pzJvs1pN0akqzDnIz7zH28vu7bxwRGRIuLV+I 8FAW6rrLx8C9xHQ1HUVC6jNj32RFc34f1gcu0zz65SqI3+DnHVcMq+qKK 6Kta8N7VWDtIq7nZwwYrdose/XhVd+wJvA1QFTw6VWVT3lzT9Y9/S3lHh w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225113324" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:29:20 +0800 IronPort-SDR: UyYpWaQB24QIH/UEPD2c9q6Xg6YjLH1zZlY6hGbGqjjTGxSi3AAoyh+7iHchsfwndoCGEIGes9 DTG3nAuI678tAa4JMb+tazdCgEC+kKwiOtc05bsGS+fTkyMm1lDnXXJdgsfdBNCsvq/oiR1woR 2KKxry324mDyKgb7YIeQvpMulxVa8ybinnjINv4ZbxTerIYKmYnBEGX/QoYNhf4NjM7gBxyl1R 8aVRP5FG61Q/bj5nRZISlrfVJQu6zBKHYCrveBvugHAQrjOVz6T11yA/4/p24H1CNmGwml4CM1 XFo= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:45:29 -0700 IronPort-SDR: /uRXeujAN5M1+SmE+TYh+wDq4FKpGC2hcK1V73rP8XNZpu9bhue/Xkexu6AhG/XyXQfkIVgNzt 3oeE9XXDrJep/8hVvacTVYsfAnSRtgUnO3IUrgxrnKob8ijOQPRdyW7AGYD+/JbCf/brMUBRTf 6vpA8CPv6pYLputdK2H3O2t6IXrwlV9AhQ68gIGyvefXOlp/ftd7nwzwW7455g1HKFvuhreXtz TeDtS2RyV4NjBA8VXmSCcVIXsfj/UA1eOXQnsEqe/HT+PDUbnHSIYb6wrU95MDKrwhRcM9O+tV Yp0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:29:21 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2nX3PPPz1RtVp for ; Wed, 29 Mar 2023 16:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132559; x=1682724560; bh=a+NVpLO2XQBp6iZs+ex8RERrDcsLfBZuQOx HVIXweuE=; b=ey2f3kk11MiZ8fW2lBsVE6iqLCNprO9dciEEFxTXxN+atK95JFm GeL4fdna7sGh5OA3GyhTl6dDgM1awPXCw/oh0ur/h+S4H1cvx8Kq82Mw1Vc30qtY Nl4miDGl6PutBI7w7Ra2ULynQ0KRR2jk5wsVgu1BGOTa2pU2ZCzd8135B1HLnAHe bwtsBUtPmdPVK5BZusnYQ0LO/k1J1+NHVVOZRXZOFswL4vtTAlv9VzJwO/o1EGqz GHmTvBtmOh6QS/VJ7nCVRUApfB8c0Gn/ArE3TTpQ9cCBP794K0T3HJ8VeF0pNwdv NXyennxT++lsXIsW0TYKGI/+C0BsoiTHPVQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VGIQNuDYS3rR for ; Wed, 29 Mar 2023 16:29:19 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2nR75BJz1RtVm; Wed, 29 Mar 2023 16:29:15 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:29:14 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 01/19] swap: use __bio_add_page to add page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <7849b142e073b20f033e5124a39080f59e5f19d2.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <7849b142e073b20f033e5124a39080f59e5f19d2.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 09EC818000C X-Stat-Signature: nukixcudq5wsjz1b41g884saao8w38ed X-HE-Tag: 1680132563-336751 X-HE-Meta: U2FsdGVkX1/tLD9M/+YQK4rZCRysd0WO303SlpGCvRKUAHLaTEaZdApzuC+mJO/xt495Men6ZaYTOW/72fpiQJJDdyEvzhKjuSpCZjWOu1XZCQn8pHp9Ttu3wMW3kRC6L258+ZMa+mZR31b39Jo5JbfRPBmCK3AjsTw6ZgM0FwfW7uGZNGFd2RKIODTfK5i32qRx9UOx10qHYr87FJDsVmmp9QhYslkLeXiWqnCchppIT+0m8BEZj3By1gHBXrTjcdh1LJ4JdIDhG3lBshlOwbtFJZN4w/8fy/HF6ebpOzFtvtevuG+uWGtqIBbmJUpCqH97JwksuTfILf3YhtYim53C87hjBrEr4a2KDOVTk0//kw/B2hXIxqtOKo9H++N+Ic7puyF3E78hIQ9RF2Tik7ebD3rwky+ZYj2YB3bn4zaOe6OYf5SGwESvqOO+DCHUAv7ZYyUInDhws8TZr88wMQo03G2yaRHQjPvR1ZN2L6vfSJeExb6fR49e9f8cklTd4VEGCFV1wdqkCccnU+bMp3x6AJ6lXcVSEbCtLtUy0N9Jy99K8RHwNkPkT+HNjPIAsnW7DpX2xzff84ttBxBiWnmeJvhdYVtpFyCX/dz7YNMVgpV+UdAyMZJQ7glHUMl26Fs7+N21vrXeAj97ZrBes1v4z7TDYB1BtkKKfiD0Arcm1Vsyi7wSBrK6In3hNicySu6AKYoFyXMMOXfYStZqti72Leti3JlHv2TUhsOWggIQBTWF1hIrncwtZjfV03S7gcqCxMa+GhMO9/0vGFnyxvZ7DOWbA6rBLhuX1EmBqTy/m0jXy2UYfvUvYeXH8YritKJ+LDyf5SMZgFoPasbhS3ZvtPFtQllwi8WCBOhF770NZldseRaVjrvog53NmdXC1+a87UQD/Syc1frRWCMnHpbSZKLvw0dz1O0+5FAsDfd8A1WS3gid2j53m0w1MLpUO6/HJjnxStDAUxhlrqm Ys9wWQxl tMvtcszVdz4rFErvgwSx+rcTH7d2MIhZJ0sPONRk1OiVR+VGbAG/IzyCenKHapGbnCSC9FQPq71juDLFBWW60fr+h5DrXA6J2UjnmlESWRqHOvgMjNfmvPRrNee4n1UzLhTW2I7nNY+micjzQVF/JhPnTTccBcnJeMrFY58J80uwoVy/Ek1RdXWlMT1mhKdLgnLTiMHzEFQgJqYB9NpQarkaLQYEOtMrKPwn7qLz0CCsg15JdUfxYLm5Y4JuVFXd1WfKsIvOHqajwo8QyjQsJRgnbRME3HDJ8zf+gxsdrYDF0FBQFMkDAlcqx79RNUA4rtJOdND7qf0nqgUwfupZwT3LChSXsYrjJhSB9CpgzoTkaV+NJfSHR3rHWOT3DKoerzq2sVrwXnixFigY9o+wJSBQHgp+bwZVWqfWjKV6eixTbuQourRdvBGE/uBQuCmAK/WiKSrCqQSXqECI8peM5I0Q6D3LVf4nEud0Bmk00oShPXrOp4tPxg1rOWAll9Ro3ubRFwxRBOuarqqgofCTTd5Jwy/i0kanvWISy9UgtdyYdnVgAM29KQPwJor6D6c5GFllZhE/g/crNbuUOih9MiMX2IaXrgyqRb9++XMYzHeG2J8ZKR4q8FvezCfqbpy6ag7yJCfrPf2UDtxIWI4Nl06TdQc3ZAJWOT1x7/5WveM6K/SDYKXB7yefAJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The swap code only adds a single page to a newly created bio. So use > __bio_add_page() to add the page which is guaranteed to succeed in this > case. > > This brings us closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research