From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16815C3DA7F for ; Mon, 5 Aug 2024 01:33:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DD2D6B0085; Sun, 4 Aug 2024 21:33:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D486B0088; Sun, 4 Aug 2024 21:33:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 755086B0089; Sun, 4 Aug 2024 21:33:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 585C26B0085 for ; Sun, 4 Aug 2024 21:33:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DA31A41B31 for ; Mon, 5 Aug 2024 01:33:25 +0000 (UTC) X-FDA: 82416469170.04.74588F1 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf14.hostedemail.com (Postfix) with ESMTP id 3CE36100008 for ; Mon, 5 Aug 2024 01:33:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722821573; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wgr58nwnY0Mco7kjux8ii6T4Q4O2jfEhsYqBxsD9YpI=; b=Qu5LCGpS/Ns3rlRH+eJetFlsnDbT2EdCXPPOq3dld8CKvQwG/9Z5esxGcNWnM+kQqoa5mZ kgy5ZojYHAgWzF0NbF0cQKEX+aNH5CyRKWGMiVXHBfCR2Zg2VRXO3mJ6yB1UQ7eODb0mwe y764EV11iZfrzsHMfuHk7uaUkIWiukA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722821573; a=rsa-sha256; cv=none; b=NueC8u3P+IR+sMWN7NsJna3DypRq6bZGJQbVTCQn6tAOjQJARfrpv+1m/QHDBmAtQLj16A Ws5ao6ZYnNXO6i2TOulkoNZf10GPieMGR8GXjVeC/b+YPiWXnKnsunQtTr+TfwgHvqbMyB tYxOzqyZ6+o6gBnos17o1LM0m6I0tnE= Received: from [2601:18c:9101:a8b6:6e0b:84ff:fee2:98bb] (helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1samao-000000000mQ-42LS; Sun, 04 Aug 2024 21:32:58 -0400 Message-ID: Subject: Re: [PATCH 0/6] mm: split underutilized THPs From: Rik van Riel To: Yu Zhao , David Hildenbrand Cc: Usama Arif , akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, roman.gushchin@linux.dev, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com Date: Sun, 04 Aug 2024 21:32:57 -0400 In-Reply-To: References: <20240730125346.1580150-1-usamaarif642@gmail.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33Aeo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdYdIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gUmllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986ogEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHVWjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE+BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTeg4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9 Fuy/FD/j ddPxKRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/NefO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0MmG1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tPokBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznnekoTE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44NcQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhIomYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0IpQrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkEc4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 3CE36100008 X-Stat-Signature: xgbgexankrqmd6en8egogoeo8dpwua1r X-HE-Tag: 1722821603-455727 X-HE-Meta: U2FsdGVkX191uxC8DPO8of375xPVVtzHcnmOmFffgKNmJxYR/M4s9axW5vv4sNF8rCc75WUXsQx6eTld/9jcDX5BQpSqsdcu1GjnpSxOls7nfAkyWH9Gw96ZYE2dNPto518axiN0V3hAcM+O0vwCppXTylbp1FdkxAOPV9QxrYYbM2GgSQrbbWR/7K/ve4nQPavQqttRZfna99AKOs0BaT8i9q6Esnkqq7DR5v4SaW7/iaP4Ycu9dRPxDOf1DnMy2DQA7BiCsgycAlknFaoX6dUKMagHms5CjQaSzkEzzZRblerNbeQRSnKEWd06PiPCBCh/3dsZhVEjNzsedtUxseKdDVbTu3MvgppDMRBITehFdjE5aZKjJFJ+72J0Od265GGZ9ijsd/5O4Dg5esR1Q3bsnlncpZI+CUfysv8QHjdx2bCPONxeItNNsIBLf980xHoVjklET9qKsD5a+2apNOgEAWpVNguTMTkaXpAQIyZXbBCwdQJoxKg5soZ2aBS2/5+iAWuQGChB7GkNlBk2hPVHIkjUkUH/GoZ8hpCUSpRqxym1aLNu1GM67XA8KO6C5Tn15AVOCmR+2EGUlAgb8MAUfxrb/gDVqsyZhpS0Pd8olTnnxVSGf4pdqtZmXnrgRwDBlF0C0GL3xB+T+rFTZD+hA4/98PUzRlPPMC0rNMkC+5Q/DVBFUuMvHGaSZCS651zyFMc47g4ao9Fr4HssqWY02dNdX/uoXgrB456YQIfL+4K15K4WRmf7F3D5LWyKjEubknFFY4cwI48TLK4vBhQGTxqnADEUYznR1sZ2LFp/mx5ftDCvKLqxiVhOi943gOofALcf8x/K86Kutrm7fQBqB0v3Z1gsP6fnhVJLWNCbUva1VugHdkh+B+EkwpRGu5TLU4N0nfw1NP0xFVAeBjbJAwLAQGbR1SrZbNE4JkGClsIXv599XswwsKzlSg5ieN0LJZCJcLvbBpWXpf9 5EtZNylx NlojjT+301MM+FVuXSZYEQ1BrsIL1+t7lr8yXKS0N2ZbLXX+rFIQszJQs1CJ2O25SOc+ANUyevznAQUxrAxd7KTfxRiaGpxsxhkLgzEo8/yxcyxXHa6Xn5f5nP3D7kytKimNqiXWIxWLEpqxZmlkyslOhKt2Xxeg8km14pWLgMW/aq2D9Jlr5vpwD7wUdtxioRNxIIactZVzy3fZQ95Tqv1sLijoHegRLSYUMNh4e8WIA1KqiLo7JJfRHfV6WSrl9STZ6VD8kWxACCysmpevf3ggG8yWpRVJfTOvpZZh3jJJW8TN3GlHQA96+0aRiyUz3da8fpUH2Cc4m3WhXgyYMy4F0bR0pEhrAZTv2rJPcGN7nd+OC6PAEYBvOd9Y+Upe8YUqtkgDpK7kAR7HEVI4goX+OcOL1SztdFDGRd5ri0NvlhumQZrfW2iEWHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 2024-08-04 at 15:54 -0600, Yu Zhao wrote: > On Thu, Aug 1, 2024 at 9:47=E2=80=AFAM David Hildenbrand > wrote: > >=20 > > On 01.08.24 08:09, Yu Zhao wrote: > > >=20 > > > =C2=A0 I would recommend shatter [1] instead of splitting so that > > > 1) whoever underutilized their THPs get punished for the > > > overhead; > > > 2) underutilized THPs are kept intact and can be reused by > > > others. > > >=20 > > > [1] > > > https://lore.kernel.org/20240229183436.4110845-3-yuzhao@google.com/ > > >=20 > >=20 > > Do you have any plans to upstream the shattering also during > > "ordinary" > > deferred splitting? >=20 > Yes, once we finish verifying it in our production. >=20 Shattering does seem like a nice improvement to the THP shrinker! However, given that the shattering code is still being verified, and the THP shrinker policy will no doubt need some tuning once more real world workloads get thrown at it, would it make sense to do those two things in parallel? We could move forward with the THP shrinker as-is today, and use the increased exposure it gets to fine tune the shrinking policy, and then move it over to using the shattering code once that is ready. Is there any good reason to serialize these two things? --=20 All Rights Reversed.