From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1184E77188 for ; Tue, 31 Dec 2024 04:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFC196B007B; Mon, 30 Dec 2024 23:13:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA8A26B0082; Mon, 30 Dec 2024 23:13:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997936B0083; Mon, 30 Dec 2024 23:13:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 798CE6B007B for ; Mon, 30 Dec 2024 23:13:40 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EE87AAF419 for ; Tue, 31 Dec 2024 04:13:39 +0000 (UTC) X-FDA: 82953933006.01.3A57C6F Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf05.hostedemail.com (Postfix) with ESMTP id 24C8A10000F for ; Tue, 31 Dec 2024 04:12:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735618362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=90nFi3ygZkgyzK2rK+4MuadQ4V2eeHLMNCEnHNM1cVU=; b=t327aRpBWYan4/QX7HEAPhIWbLkzGxpve0iRFuOumuLw15S1X8h6q4njfFgcWLz36JF325 s04rG9ilfKCW91CoIUT8nxGL7STjehAS3L0VWNMW3eP7SkT2MbA+gpQ2LoiKcjGt3T1OQI ahHKfMhyP6fKFPLTVBEMlCVsMSxbGQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735618362; a=rsa-sha256; cv=none; b=qrOc9kiR+GBbD3ITDvg9w/1s6WZv+F5FwJ+pAXH/3GJwvK5QFI2s791hELyqTeF+nOJEt+ +kt6xASDg2fQJjKYLEZ9F1Q9Ft6G45FHSvl1tB/G4gu/FCDvhfyEY7zR26rdYp7jFDJ6mI JVzbKsb9a47tuCHtnIJ2qQQ3U7s9kIU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp Received: from www262.sakura.ne.jp (localhost [127.0.0.1]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 4BV4D6t1018377; Tue, 31 Dec 2024 13:13:06 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 4BV4D60O018374 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Tue, 31 Dec 2024 13:13:06 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Tue, 31 Dec 2024 13:13:06 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/util: make memdup_user_nul() similar to memdup_user() From: Tetsuo Handa To: Andrew Morton Cc: linux-mm , LKML , Al Viro , Denis Efremov , Julia Lawall , Michal Hocko , Kees Cook , Vlastimil Babka References: <014cd694-cc27-4a07-a34a-2ae95d744515@I-love.SAKURA.ne.jp> <20241223172552.133f4e293f1dfbb6aa86b5ef@linux-foundation.org> <6ac4cb00-4841-4deb-a3f9-7948a1ba5389@I-love.SAKURA.ne.jp> Content-Language: en-US In-Reply-To: <6ac4cb00-4841-4deb-a3f9-7948a1ba5389@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Anti-Virus-Server: fsav404.rs.sakura.ne.jp X-Virus-Status: clean X-Rspamd-Queue-Id: 24C8A10000F X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 8n4jc67dpimefg4zw4jh51mr95u44gts X-HE-Tag: 1735618325-843147 X-HE-Meta: U2FsdGVkX18jjEGw5K0ChM/uW3ACcMCMfuzjT8muDx9ciKHUIlRyJZZfazVrHNQFVqxWY9cOOSnfMDT+HsJjnPGRmf0RkRaunGEe2BNYqihPIbWs4jTirbU58lmvtSEiHREr1N62Gh620H7KucgY2WdhoWHRabNSWLjJyuNNyS1TRC9K3t893XVeJANr1ntmrLZFcbHEtzoZsa9pz5EQ6XSYyVlQoKVl4BqDy2C0PxqR4QGOdIOdxPs7kan7OqsO8H3TQ0gdng7uWX6ThyrawhYLxKK5rEdtEGbZGa1W1t2fJhHl4iA3uksqfQ+zltlmVtAE1Ko6gsIY1qyYQD0BJ/KLDa82v+HLwEOuAO7EZ2L/py+t5c2/9f0OF4ftg5IktQ3lI0M1wVSZFKfp+LsmfZ0MBKBn6sJyi4MjCRKZO13xy12YTHbrULk3Wxi7eG+GNm0TUx5h9HDaiRxkjBiRlwE6PmhOpkKsn7PO7Su88uzLeiNbcmoelufZbKtyL2aoeSrPfTJqj+zJ3gf2OrxA4fp8f6kckvWP7y3UGsUwgMj5847gWm4TD2wWhTgIlh5df4cbE0b5RIVdZj0Ch6ZDGuceVOcMpO0wZ3B2f5wAR0I2NfE/2U8SORXACFCn1e2WB3KwQ/DOowVKpyAbeSNL0Yl4AlJiX4gn850RV5wSVE4kbYRp7HhwqB2pIsmcCfkXNZHN1JcMKlXTBZa3T3WsRprsm2H8fR0rJqS13qcZc5Vs6+1CDfS4Ird63OvyXTlQ5xksLvWjR1ZkH3HRn8NW7lrlrPCD/N3P7KIhkceiig+iVDFfP51JKJCetyBwlg2OIY87eRYTj0MYoc1S1V1+oGvcMy86p3Oe+Lr7ZBdTjHcQeSl8LQcC1XqZ73PdGhsg3zmhZ03ngdEYUTBp3GjCGG430fKmvJBmR1H3ouTeWp6qO4wtPHUXUMA4R17x65ZcFstPhUWn/xWQ9WjC/jA QS1fnw+3 fIk/oQAmFNKjNSMUb0iwjm3Ggh2JXP1wRJTe+lf9fvNWEVKqnNd393h9hQKoHm/H+9kq7ZlujOKjj061iQpYp7fDISeUoaBGMpC/IfJllpF1wOtgcJpvX5QBzP67UG8d5wcDpd87AxBrsOlSR6nuXluChxPryxRbE9SL4MfLGg6MF8LdzVVKwuqH8AbDBBjWCIbR5alvWJj2FrE97RoVtrckmRra7d1xXnazq5KHJ1RYh18V/56rx2CvjroxutQ/GYEThzUCXukI/yZeX952ARUDAn6X+TTvsdRep6n+95/Ik5Ka1OKxb3mkFDcQ8sWo5SWPaax0j8BPHK3D2KO2ksiZLHLZpO663zKVUniAJrtfluQtxxbMNc4erCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Would you prefer updating the description to something like below? The only difference between memdup_user_nul() and memdup_user() should be that the former appends trailing nul byte. Apply three changes in the latter to the former. commit 6c2c97a24f09 ("memdup_user(): switch to GFP_USER") commit 6c8fcc096be9 ("mm: don't let userspace spam allocations warnings") commit d73778e4b867 ("mm/util: Use dedicated slab buckets for memdup_user()")