From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 672BFC25B78 for ; Wed, 22 May 2024 07:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB746B00A1; Wed, 22 May 2024 03:48:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6D906B00A2; Wed, 22 May 2024 03:48:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4456B00A3; Wed, 22 May 2024 03:48:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B1DC26B00A1 for ; Wed, 22 May 2024 03:48:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6DB6E4017F for ; Wed, 22 May 2024 07:48:59 +0000 (UTC) X-FDA: 82145255598.04.74A93E6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 2AE9D16000B for ; Wed, 22 May 2024 07:48:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IjriuPmk; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716364137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=phV0a9Yi5QmyXuhVqbX1nibkB5NQY4qscA3tdGeagZo=; b=Px6xvrVJ2m2HnbNpl0DMgNfBx6LUC2Xn9GEAQ5lGcmTOj/HmRc8H+l8UuDucTjWvbHT02G Em187CKRFKctFrn80SA/9M2Z7FQHkqqUU0JXSJrxgquvPM2IwRZ2eFhaA38mYE0zRBPvJe W+y/0R/l4Xbd/5UVu5KOFoU1tKVuHQE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IjriuPmk; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716364137; a=rsa-sha256; cv=none; b=WnP8Mi8XOP1GkJpERFK/IHQp/OwR6mcgDjvTVEo8j6Zf1ceQWHUcQIEWNLbLDEjL1HiJR5 kAeTvdJp8AlAu9ancvhLoSpIogoC95bTJL+WEeL1uOzMW8pJgnqEgfu7aRRJitPpQt9iGG 4I+Wd61tNqy6X+BcPARgDTCbEcs1W+w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716364136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=phV0a9Yi5QmyXuhVqbX1nibkB5NQY4qscA3tdGeagZo=; b=IjriuPmkJV5BEDpBC3a4l2kIhvKVLkOlEesnfpmg08Hejq07ouVzgeX4H5KFPtKFGIEgb0 4h53TKVwCwCBuwTVLB951lCsODNpOArtsKAVlKPlp4aBnz7CIyss2O3QS5J1oVjsbAf0d0 z/UeDmr1q33WZyCBKRuwD3+GwxhFiHM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-icy3KVODOySEOLZHcPuh2Q-1; Wed, 22 May 2024 03:48:54 -0400 X-MC-Unique: icy3KVODOySEOLZHcPuh2Q-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-34dc34c758fso7982270f8f.0 for ; Wed, 22 May 2024 00:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716364133; x=1716968933; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=phV0a9Yi5QmyXuhVqbX1nibkB5NQY4qscA3tdGeagZo=; b=WgRDYoopeSkzzbRuHfO2IQcGlds7IhLcZa4eNY6AGqUzrSkFl/m6PCu63kWdnSEmY6 Lu1F70R66WzhtI0YSnTsqgD1GccQk9qy2FIRplOhNhv34O7DeZq4uIDqQwiMeoXM0dTP PcnLmo0jeKAHQOMCUnaDsR1K7q018f4+9byMtw2KVPf+vyuMSgHBJ301UJVF8h1e8K9+ /6YM775TSHnTTohwoIwpky35dsJBOI8koZQWuZh6K1Jv39OU2UccDOt3BaVLbofEF1W6 DCwwGoX+gfKGK0HhT9Rs6LyMXqs7rxOsyDhpd2Qp47HNYEFUSX7VjYVBw8VLhXhHc+aH BU3g== X-Forwarded-Encrypted: i=1; AJvYcCWg4r2IJaPS5zi1xgomLipeVsFF7SESgF8/DlH9svEAa3pt6jhW1BiOsj181R9q1ysH4uLjlHIDlYRD4M1O95S8ge0= X-Gm-Message-State: AOJu0YxutiSs89/PFb3YIiaVWq5LFF5ck0wECrcZGWfppQM6siKgUmdo gzDkinHTiu7Uuz8/4MPzgVT1wLOz2hDtmrbZiI6oO/fffHZ+7ZwceesyLFnqSBT8pj20vzf5R6A kc36ydHxR2IUuqz47M65jr19ehMkYLCSRarp79lkbkcNMNjUs X-Received: by 2002:a5d:69c7:0:b0:354:f16a:3b1a with SMTP id ffacd0b85a97d-354f16a3d80mr179827f8f.39.1716364133122; Wed, 22 May 2024 00:48:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/i8LxpSaeeGUAgY1y0rGEESeV3Xdj0J8pTf+jaNoxxM4TqxHTlKSWivb1a38H13XeqPDaeQ== X-Received: by 2002:a5d:69c7:0:b0:354:f16a:3b1a with SMTP id ffacd0b85a97d-354f16a3d80mr179803f8f.39.1716364132604; Wed, 22 May 2024 00:48:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:d500:4044:6d4c:f060:f677? (p200300cbc709d50040446d4cf060f677.dip0.t-ipconnect.de. [2003:cb:c709:d500:4044:6d4c:f060:f677]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-354df9b51f7sm622003f8f.59.2024.05.22.00.48.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 00:48:52 -0700 (PDT) Message-ID: Date: Wed, 22 May 2024 09:48:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: 6.10/bisected/regression - commit 8430557fc584 cause warning at mm/page_table_check.c:198 __page_table_check_ptes_set+0x306 To: Peter Xu , Mikhail Gavrilov Cc: Pavel Tatashin , axelrasmussen@google.com, nadav.amit@gmail.com, Andrew Morton , Linux Memory Management List , Linux List Kernel Mailing References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2AE9D16000B X-Stat-Signature: dbqrjpkhx3q9u9ahwdw8ri13a5quxa6n X-Rspam-User: X-HE-Tag: 1716364136-252138 X-HE-Meta: U2FsdGVkX1/fqoQq4knqNr55sFQirxbvWNbuUf0rLrOMTDzEr3ZiIy6XVb19uY9V1X/i7PqDm2ZfCO32/F4Hz2nuEKme4DOwi/KyKpdzUL3wNWpGb2EQtTbA0B2+zFXntT8LY8yymHtF8G+5QptYAfLcRMfeBMTfCcKQoGvPYsPH1f22kgrRGXcSeZXXDrUqqXQ1AW9qc+oQM+UH/7bTkPSeJT3iXM2ksCF4r01jml5zCe10ZaHDZe6QfIOK/40PyTnueuANko3CZNiCYNQ45iV/gEOlQrSZ1LemGjmOGclRp1H6aC+/W62p7cQsV5+M7GRMuXI5PgR0duc0ULuGo7g06Ebauy38OzcaPDPJvjoC1HeIwvTTxMBzQJkTIKaISKvGW6G3TT6E52/psonYX+3MniaPLja/vk90t27QUx1bZ5pvw150G0LvDmOZnsEvEZqwu13wbk5UwCOQVKii/KKPD5lhv06DZkMFStUFa2YB8t5iwZ5WHcZNJQBb1og5/72krF8Qpk7bdwHiW1jG3/BBH04h/rab3U7NPEg0+NLJObCU7yz6uBOYyHcZGshqJ4X6zBl7D+t8K9wjsW4s0f7nnEV+nDRTEbOQeiXGWzB36Y6IHzR+ykBQbu1Skr0FE1MOjPyGJMhj7rZgxsLroaHlLgk/rju4ECSONcX7C3L+wTooFAembx+UMxAD1jqizObm3kBLvvlcx87XI0ci/l4vYs0yPqQqs9f03xLvxP4GTwpFwYyrHQjdQbxFGH/I8UX5SbkZS/Qdg+V+SqHAs/A37ra5arZNM/VKtm8lchQq9iQWB2Hl1u4Nphz2eQ17SbaqxCtsE8lhu/fpVnAfVESSdWGpMFJ2avEa+VlMD5DfLmoUTuCMCveD1dDNbs2jKz1/j+wbAVgqmkIGTJ/l/tGFVKRtEKtx/CY4/CGckf86mwLp/K1FC9OAIBfTKewgYb/4OsHR7YKZN9ksSGP 0Znv61wC 6OgTHwirWo6pmAMt9S94yvm0dymoeYHOTdWpwifXjhMJj/tiuzlUEcEfDEtLvJmF9Chx3EFCovwsTO63Fl+PclRGzTW0zR8xTQgae/Cc9K7kgwfsmh5vHg+UeTiqnrvXNMbIeYkLNHPVVjpXH9bSsYX6lGbhbkYI1B6PzTfFxln/b4FR+wlN3Hq9n08L8d7XyyHne4DXhnRcL0TOqKWqCRSfjHlImeTr3x4UNKXf55BiVk95TH4EItYS/ZejCjpSs400cgyDeGXVUTO+M+0yrqrJ2+WPyh3Qb0WZCgv2L+R9TUpbtWusbqHNfi3UZuMM/gZTGxUlJUR3IqiDUI26htp9uKmGYW7YOqZTYdHjJtkBKbBam1E5iO9TuPP5y8cBomTfa7h1d++rliQ4cBWndgBfcKOuuL9cfVuZoH+1UKotrXlboxmGEM6M9ZptUC0BZZLKGGQIfwrZPCRxOuBtNCCUpmYWjVgedHkOhEyZkmBFhTi2DtQXD31qFQaZHHdLDv/oNDSjxOYHX8mZOVhSlE3s6a0P7nDaY6e7CXlaes8wr7i+kAYOj5tCJ6dey3v0Fa4AR14Q09Iopapcx89Nt8MgrW85jREYxkJySNo452S58i+iH3rG3d++AyMw/HR1zgUga X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.05.24 00:36, Peter Xu wrote: > On Wed, May 22, 2024 at 03:21:04AM +0500, Mikhail Gavrilov wrote: >> On Wed, May 22, 2024 at 2:37 AM Peter Xu wrote: >>> Hmm I still cannot reproduce. Weird. >>> >>> Would it be possible for you to identify which line in debug_vm_pgtable.c >>> triggered that issue? >>> >>> I think it should be some set_pte_at() but I'm not sure, as there aren't a >>> lot and all of them look benign so far. It could be that I missed >>> something important. >> >> I hope it's helps: > > Thanks for offering this, it's just that it doesn't look coherent with what > was reported for some reason. > >> >>> sh /usr/src/kernels/(uname -r)/scripts/faddr2line /lib/debug/lib/modules/(uname -r)/vmlinux debug_vm_pgtable+0x1c04 >> debug_vm_pgtable+0x1c04/0x3360: >> native_ptep_get_and_clear at arch/x86/include/asm/pgtable_64.h:94 >> (inlined by) ptep_get_and_clear at arch/x86/include/asm/pgtable.h:1262 >> (inlined by) ptep_clear at include/linux/pgtable.h:509 > > This is a pte_clear(), and pte_clear() shouldn't even do the set() checks, > and shouldn't stumble over what I added. > > IOW, it doesn't match with the real stack dump previously: > > [ 5.581003] ? __page_table_check_ptes_set+0x306/0x3c0 > [ 5.581274] ? __pfx___page_table_check_ptes_set+0x10/0x10 > [ 5.581544] ? __pfx_check_pgprot+0x10/0x10 > [ 5.581806] set_ptes.constprop.0+0x66/0xd0 > [ 5.582072] ? __pfx_set_ptes.constprop.0+0x10/0x10 > [ 5.582333] ? __pfx_pte_val+0x10/0x10 > [ 5.582595] debug_vm_pgtable+0x1c04/0x3360 > Staring at pte_clear_tests(): #ifndef CONFIG_RISCV pte = __pte(pte_val(pte) | RANDOM_ORVALUE); #endif set_pte_at(args->mm, args->vaddr, args->ptep, pte); So we set random PTE bits, probably setting the present, uffd and write bit at the same time. That doesn't make too much sense when we want to perform that such combinations cannot exist. In pmd_clear_tests() and friends we use WRITE_ONCE() instead, so there we don't run into trouble. -- Cheers, David / dhildenb