From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB8AC54E41 for ; Wed, 28 Feb 2024 06:49:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C286B02A6; Wed, 28 Feb 2024 01:49:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CB756B02A7; Wed, 28 Feb 2024 01:49:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BA506B02A8; Wed, 28 Feb 2024 01:49:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A79E6B02A6 for ; Wed, 28 Feb 2024 01:49:24 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4264CA0E86 for ; Wed, 28 Feb 2024 06:49:23 +0000 (UTC) X-FDA: 81840286206.24.6BEC5AE Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf02.hostedemail.com (Postfix) with ESMTP id 798C980002 for ; Wed, 28 Feb 2024 06:49:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CMsio4B4; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709102961; a=rsa-sha256; cv=none; b=w78P0rH83LoObsWdHuuLeBhzyfRQDPO5gzLMMjB0NGj/xVNPzhPZLeXmQYdiT3FA3ZyfkF tVzuZSyvv9IJpfxKAuDMlUm6BYsO1xzwaX8vErTdbsAknmWtNLIGRhRN9GQGTU5aXy5pil Mh9V/WpWJbirOyYjKIKvw2zMJpI9IH0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CMsio4B4; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709102961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6S3YME2pgLHPYQU3lBfvV94TvsKe/nmiEavd1qVEYLk=; b=zvcW59kIz0VmDi7u2QM3ow8Yo0O90JJ5l7zuWJ7a1qtgpZD+j2+Rt3GrXRZxtHtJ0JH3HM 6nBVt3aUi2XgNg42Dj5TbMwbz8oXdlB/4VOJAWJvzI05yCStwzF7fml6XT6MZHMNJb3fTS HSaH24EgsRCFuWSt063LTd4Otu4xfKQ= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709102957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6S3YME2pgLHPYQU3lBfvV94TvsKe/nmiEavd1qVEYLk=; b=CMsio4B4CD/lJBJgZVox0kRhNO08fsp634BgnlQYADsLOBK70SxK874YnDqebGx3mVqGxd tYTRXTfBnUaUmG2G3iCbM4okoyM3/d0uIxyFPTdpHVWpe+5fngTF0nIOp8l2UU5WfllGgi y8KESOTMZgiUD225b3xoD8vMA+ZAF8A= Date: Wed, 28 Feb 2024 14:49:10 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/2] mm/zsmalloc: don't hold locks of all pages when free_zspage() Content-Language: en-US To: Sergey Senozhatsky Cc: yosryahmed@google.com, hannes@cmpxchg.org, nphamcs@gmail.com, Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240226-zsmalloc-zspage-rcu-v1-0-456b0ef1a89d@bytedance.com> <20240226-zsmalloc-zspage-rcu-v1-1-456b0ef1a89d@bytedance.com> <20240228061400.GL11972@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240228061400.GL11972@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 798C980002 X-Stat-Signature: 59x7bmr1jipfsxhy6cys5weq9dpzwd5p X-HE-Tag: 1709102961-379308 X-HE-Meta: U2FsdGVkX1+LHCa4YixyyTqlbKkQux1aqYKFur98o2aqATWmbyGc6vg1jh9/lGbinTfda/HeTFS+TTWAgIX2YMUbmvS4TeuF73sOoeUQzyzAtRxWfhfoBYNixVp4MWJNlbT30whDZOA7XzySLsrCxRWbmGxbfljjusyhJME6+9CBEJrkoQb8w3i95O2HiXqRgxhzcpia1vAWIPGLMMCNwaDY/KPhizvwshB2gCc0f8ho6gcH1qwGtzDQOoj1dvEKxW6bH6Q5h1vXkEphMqhh5F1pE3y/9TF74uWTYYsGuu2ETzNnd1NKj8gBwwv+z8CjdwrZzvs7pRzu8AnprkH0730KUmCIZcYmpYlVoDAZby2cjhOZ1epbAeOf/NUZZKPTULLrJK7NHdrRyCfuV1wgEEpdr4GYEpWHw6pDgYBAAgzhHSULD30fTCkqRKWN0dc17nyLTt0jvXocoUuVwmbnaGP6tCf1AIkoVmOIwxZmpo37o1gAfcW+xJxx4zq/RbPgdYgiEJO1aLldUikpT4hba8YhbYMf+QVq8gFYFGaWIEFaHcHiet89b+IESrMM//H+YJrCBV015N9mwNcLBWhkrj1aVWX8xwgBSwCoAqB3lH57HlKlS3hK1VRbkk3fPpTyixyfn+iurvBoWDsuoZxiPf+BItlOUDJ1WYZ7N2yGazgK1CWBGu3jEFd9wcmU2pg3zgHqFxHSNk0/gvytq8SewM/Zcq+mdoJR06rSVH1xMDMhTfJX5n9RXMSWNdtlwE1uqmaZbhsIR+Z71z15PojJyB7J/AuT/CpaU2+0eDBLWN4PDeiI7wqSriSbaJQ8+ywzPxRb7eltx+84muaA7fWaIdSEfaIejIHy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/28 14:14, Sergey Senozhatsky wrote: > On (24/02/27 03:02), Chengming Zhou wrote: >> @@ -834,13 +841,12 @@ static void __free_zspage(struct zs_pool *pool, struct size_class *class, >> VM_BUG_ON_PAGE(!PageLocked(page), page); >> next = get_next_page(page); >> reset_page(page); > > reset_page()->__ClearPageMovable()->PageMovable() expects page to be > locked. This seems to make the patch doesn't work anymore... will think about it. Thanks! > >> - unlock_page(page); >> dec_zone_page_state(page, NR_ZSPAGES); >> put_page(page); >> page = next; >> } while (page != NULL);