From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45559C27C53 for ; Wed, 12 Jun 2024 07:32:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3A348D0008; Wed, 12 Jun 2024 03:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE9458D0001; Wed, 12 Jun 2024 03:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3C318D0008; Wed, 12 Jun 2024 03:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 877368D0001 for ; Wed, 12 Jun 2024 03:32:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1EE014124B for ; Wed, 12 Jun 2024 07:32:08 +0000 (UTC) X-FDA: 82221417936.24.9FCB4AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id B1B6E160019 for ; Wed, 12 Jun 2024 07:32:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZN2ccBc5; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718177526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ed7eSdV4iPKjNeuFNhzZoVLSasdUP/mWopJUg7P2wX0=; b=cfb4fj1FahaOXQ0HRg7OActEBCLXfdY8TER5iBDTaFg8+FRenbdEa3nOAmA0/N8FXxjlvD 2jG1HFBbIWohQulXATfNUQHobvU7pt6yMOLSn2cZ4VDv3/Ib7tx94O32yE5aeNPz06CeUE /2Xb1ZTGME3quVtjZ8FRwLHxy2BVhYg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZN2ccBc5; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718177526; a=rsa-sha256; cv=none; b=kc1zd1vR0vE1+XUVSFJSkmFEgL5cHTmoocIwfNmSsL9yJ68MQlSUSinJNSDsM5LuXhTL9e 77Hr73r/bBb1oZDCVW62YeOIxSzpdn/kLfZluTwUJQylmXwkyE9sb/0wqHiWLyO8MTUz9e HrWIM80kbAFMXkpU0vqhZCQX9KBG6D0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718177526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ed7eSdV4iPKjNeuFNhzZoVLSasdUP/mWopJUg7P2wX0=; b=ZN2ccBc5AGXacSJr66F6CLiT7PlnJtZzfIQa+0bxXWo2dAiEZnFU8YRDLRCuNs1lGARRca cw64YJmND6HMrG1KATfB/7uO/zIE+ZAE+pWHoj5mZjf9W29Mke4FpriGLn+XkH588caMc8 1WTGOKseMOlGPTbf1gspnkq4GQTvkGY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-shrwnU7sOIiwxYZdx2eAZQ-1; Wed, 12 Jun 2024 03:32:04 -0400 X-MC-Unique: shrwnU7sOIiwxYZdx2eAZQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2eb6f6b1b2dso32106071fa.0 for ; Wed, 12 Jun 2024 00:32:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718177522; x=1718782322; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ed7eSdV4iPKjNeuFNhzZoVLSasdUP/mWopJUg7P2wX0=; b=KHjMIbybZw1KJ8ks87K/eXsrDOr/HODf5H0GItGq5kOgaJsZrr703fsH+YoMqiQ6V2 cATqE4Q2Y06O+Qv/8Evacu880iGE6hJsWcSMn+q2siLtXRrVDy+zu9fREKs6cjS+q1BS V1QBHXtYl+Cd28U0RuH/v7bX6YAowsJPreZQWVNE5NDXFJe281zeGNigrG2BqRNO0U53 yzpTZAUW1/sYuwjgwgETF7xPT2ZMy8QJU0B9vd4qWnpQ+02DFPStXtjyJXvCb64soqjz pJY4joroEj6tP/RpRaygPV9L4w85r7Dj8QM7ZOj1GmyyqTvct1jixq0x8i0o6t4vVnyx Pd/w== X-Forwarded-Encrypted: i=1; AJvYcCXbJQ119HKf84xO4iKs/AV35Ex2u2ODQG977goFn/LRRDT0iLRK/orQvk3mD6U0nd2qCBpRFTnAaI8yxos+gls5duQ= X-Gm-Message-State: AOJu0YzSBGsO2ukOu5fVryOUxBu8obPPxDK85qD2qiO6byu2hwbqX8A5 HtlqvTXI6aOI4OAJeACEqEO1Vt7LH5NePmLvFIckjey6UR4SOzHZjcGULYBeS1swxp36sEGnrkb hgpG63fq3DbC3DU+rhkPbk+kavtf4Ntu5V94R1YGVdqyaRTWC X-Received: by 2002:a2e:8782:0:b0:2eb:e1fa:4f55 with SMTP id 38308e7fff4ca-2ebfc9c9d53mr6178221fa.12.1718177522768; Wed, 12 Jun 2024 00:32:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFL9VZICmq3wWOxmHMEaOi+ZW4Z541K9OLPwP60b1PrajV5I7ETP42j2tXyTBW7CzSOFlntOw== X-Received: by 2002:a2e:8782:0:b0:2eb:e1fa:4f55 with SMTP id 38308e7fff4ca-2ebfc9c9d53mr6178041fa.12.1718177522363; Wed, 12 Jun 2024 00:32:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:bf00:abf6:cc3a:24d6:fa55? (p200300cbc702bf00abf6cc3a24d6fa55.dip0.t-ipconnect.de. [2003:cb:c702:bf00:abf6:cc3a:24d6:fa55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422870f0d9dsm14491555e9.29.2024.06.12.00.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 00:32:01 -0700 (PDT) Message-ID: Date: Wed, 12 Jun 2024 09:32:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: yangge1116 , Matthew Wilcox Cc: Baolin Wang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn References: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> <776de760-e817-43b2-bd00-8ce96f4e37a8@redhat.com> <7063920f-963a-4b3e-a3f3-c5cc227bc877@redhat.com> <48150a28-ed48-49ff-9432-9cd30cda4da4@linux.alibaba.com> <11ef3deb-d1e3-46d5-97ed-9ba3c1fbbba9@redhat.com> <697a9bc2-a655-4035-aa5e-7d3acb23e79d@redhat.com> <3a368e38-a4cb-413e-a6d9-41c6b3dbd5ae@redhat.com> <48fb0e58-16d1-7956-cf35-74741826617a@126.com> <617f9e36-9334-4630-a6b9-473f2dd570d4@redhat.com> <8351052a-5c21-c383-544b-3166e883587c@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8351052a-5c21-c383-544b-3166e883587c@126.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B1B6E160019 X-Stat-Signature: asn64yrenmtt7c1rrqx73im911g99pdj X-HE-Tag: 1718177526-321420 X-HE-Meta: U2FsdGVkX18FXZCGdFQwHV9JTqfXGHUgOZesVV8IsNkaPsh++DBmZl5/skXVVrmFzUnjhEzlJDG3sYShVCQmVP1BrVboYaAuwavVcuB5xpHXdMFaGsNF2Yp8zYNEGcZMJx4iFfvIv5vOKUfdDyM5sA1I8ryQlVpfB3bSKo2t5j0prc0jn1QDC8RRNU9n1QRsp5WgK7AdFU9AretNIrcuZ6z2trNom4YPxi1fm92OtGPinoVt4lgTKvnLbCdg0CoinklmV1px51x405jULB+YOCSOnQekY/XfNWcI8HpbdjOrn2oHbs0rHOQhsE/h6OmnE6Pr5McgdymKKkR2XQKOrGS7EFoRhFNQM9MpOUa0Jkjrue8qlI2anuCMnEknTLSjN31MN3oUfOWI+cXykOOk5BboI/uWgMJjXc2NRpqZ8MxAHWW6ie4BYD1P05OWGJkKFhMQcPQE4bca79mRQI3RGIu7KXdrbcz2GRHbt5Y7dXqJv0LVs/iomOIedl8KHR2Do4tfNKi89PrT4zqainB657dONaCEgtZtWe8YIVKTohUSUyCGS6iiTGxDX7nTdXV6IdQmu/l1G3lwOqU6Swo8hghkkhuJlJ1eUFx9c4xBdR5cTX+KddwfxkJgBSIO1McgS6AmknT9hvjhY69F5WFZ4uTj09wawOUKrYbnHrtt/5cEYdDTb9ykdo0GRT3udSRU0gM+MBeW/qSXh01HrV/2wLK5sAGcHsQb5epfOcdXnI5ADsrgKBvEfhYDqjiRlsKuux+Uv1RSUlbin53Owl6g7i6SiPOyRjHEFGpDjXZxCSiaMXwdQJpA9y/ISbh/8Jd2S1S1bukpyi0k2S0mmiIbO+1agAXWniM7KjJr3kIA7PrIXw7+dEVpdws87G9vXPFjLfXkAcH3GVeipJbUkxJdCEg4kHUEfsYtGb7LQ+WZw3v1e+s92rQs4nWBV8CHodE53lB6vlwTTQFExplxlNr bP+5lnFI rgi+GqdrF2Zw0cd96uni6AQBSo+hWRBFB/OaEbfb2OR90PGWm8FBi+3TIj90CsO4sSfFbpV9nE4ZEq06kUXmDJ4PzfP2GtL6y6EBZIBriLLWGqGNW+65kaB/eU5Odc40t8J9H3TrjdxtRpUgMggNc9PnC2pfs5jhB1RekpihuVCeeLbYiRljfQBZqUZeIdZSHES9/cbGmkjgXv/ANhYg+PNO8tFFCFSPiLw9jarmjlLXVmb60o37RnwHD3IiUa28PW1fhMjtSOgNssdRYZpBXmB2OaXoPP/ja9DyfiVBJv8/53Iefr86f8xyDVueqDnh6AnhXIytkEWvPeuffdxxzTmPDVlDEtfjPn7NufTSctttwAzNd7mt+OWhxcg3nnExMg/vY/tljccZSWCM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 13:20, yangge1116 wrote: > > > 在 2024/6/9 上午12:03, David Hildenbrand 写道: >> On 08.06.24 17:15, Matthew Wilcox wrote: >>> On Sat, Jun 08, 2024 at 12:38:49PM +0800, yangge1116 wrote: >>>> Can we add a PG_lru_batch flag to determine whether a page is in lru >>>> batch? >>>> If we can, seems this problem will be easier. >>> >>> Page flags are in short supply.  You'd need a really good justification. >>> >> >> A flag would not be able to handle the "part of multiple LRU batches" >> that should currently possible (when to clear the flag?). Well, if we >> have to keep supporting that. If we only to be part in a single LRU >> batch, a new flag could work and we could still allow isolating a folio >> from LRU while in some LRU batch. > > Yes, before adding a folio to LRU batch, check whether the folio has > been added. Add the folio to LRU batch only if the folio has not been > added. > >> >> If we could handle it using the existing flags, that would of course be >> better (wondering if we could store more information in the existing >> flags by using a different encoding for the different states). > > If a folio contains more than one page, the folio will not be added to > LRU batch. Can we use folio_test_large(folio) to filter? > > if (!folio_test_large(folio) && drain_allow) { > lru_add_drain_all(); > drain_allow = false; > } I think we should do better than this, and not do arbitrary lru_add_drain_all() calls. -- Cheers, David / dhildenb