From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBD2C2BD09 for ; Tue, 9 Jul 2024 11:09:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 089496B0099; Tue, 9 Jul 2024 07:09:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0131B6B009B; Tue, 9 Jul 2024 07:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA6D36B009C; Tue, 9 Jul 2024 07:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B91C36B0099 for ; Tue, 9 Jul 2024 07:09:55 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 316B21A15B5 for ; Tue, 9 Jul 2024 11:09:55 +0000 (UTC) X-FDA: 82319944350.22.E31B367 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id C422440017 for ; Tue, 9 Jul 2024 11:09:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mXUT3SqW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DieAd5o6; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="zFUF/L94"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RViQhDkZ; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720523369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8fJE3nCOXYNp2LxWcHSy59jmf7yc5spRvIy/bBKZFmQ=; b=kd6kKOvreAFzcyMZfm+TgWTlXbE/BmAzUUQEVUOk7klQT8fWX/IdxW7qm1F5KTh+IZAy2Q kguUMh5nuJ/MXYpYOVrnBRXRnwPJePJkEWtXdtmKnIlOFvdJ3g6Fimf9ZPltnCvgr8tfK6 rs03HtuiVh6U+s1e/FFeMZ3lKaJteoY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mXUT3SqW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DieAd5o6; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="zFUF/L94"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RViQhDkZ; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720523369; a=rsa-sha256; cv=none; b=hW2auf2XW6+ITN1pB24Yh9pq9wGqHg3AOD+P1h1KFEPkZtT48KTLHnIMA9A/XfiEOziWkN xhvJ7l3+H1T6nLy5NLDAsSp6NPlzVE2ldu6Q6JoSjHE0RCEv+OJuZ9/rPpKcZeWt3rrUJC I12vaRcqMoxW0wa8ygJVym3fbdLnR30= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E900521111; Tue, 9 Jul 2024 11:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720523391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8fJE3nCOXYNp2LxWcHSy59jmf7yc5spRvIy/bBKZFmQ=; b=mXUT3SqWiCGk/kl3JoKNy1rGiRyLBgazptOYhdBWfoAiFa1voA1kX3GUJE+M3P5jdO8dR4 BAsvgfNJd3RVMMk0Of0MmShR3suc3b2a0IBXwtAk/qocZ2Q4rYZ66q/lCnQUsOcGP5/iAC XVU5IxIBCyl2zuu546MMiS+32UP9uME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720523391; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8fJE3nCOXYNp2LxWcHSy59jmf7yc5spRvIy/bBKZFmQ=; b=DieAd5o6HbiAyA+NZxLMPKAKoO3/S/kZ57fBudyRsSx6B7kvCQgwmXUkbQ6HeVGqbQz68+ 5wpGttewTOJUasBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720523390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8fJE3nCOXYNp2LxWcHSy59jmf7yc5spRvIy/bBKZFmQ=; b=zFUF/L94Eb7cp+IqsLKl/5cAA6kj0p1S1bdOJR+AqRqTMVY7X6PsLBEuF+TCAP05YX0L8g S9P6cuGQfzd/ongojic6egAL89qO6bPLUvuV64iEj5Ugdw/oBzGaamw991z34J5zo2Wcim QR0M3O3zoekapbTjtxCkyf6nsxCLIXk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720523390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8fJE3nCOXYNp2LxWcHSy59jmf7yc5spRvIy/bBKZFmQ=; b=RViQhDkZlUO/SPA1uYl536OGdx4ZtwgFgoOD4VjGwlk28MTzWn4EtTrv22EcmUlH7SaIRC lck4NHCWpqAh93CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C345C1396E; Tue, 9 Jul 2024 11:09:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id djQkL34ajWYSXAAAD6G6ig (envelope-from ); Tue, 09 Jul 2024 11:09:50 +0000 Message-ID: Date: Tue, 9 Jul 2024 13:09:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] mm: move internal core VMA manipulation functions to own file Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Liam R . Howlett" , Matthew Wilcox , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Suren Baghdasaryan , SeongJae Park , Shuah Khan , Brendan Higgins , David Gow , Rae Moar References: <8622e12013139411ad44eca5813839c34574974e.1720121068.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <8622e12013139411ad44eca5813839c34574974e.1720121068.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: g4nkh7jwxy6f3pb6zd7a39zy8uhm9t9x X-Rspam-User: X-Rspamd-Queue-Id: C422440017 X-Rspamd-Server: rspam02 X-HE-Tag: 1720523392-363132 X-HE-Meta: U2FsdGVkX1+QkV/4kO0ZA6CJtYPH3NY/3L9A2jfjr0WOKJpBfFbVo0nKSMxburtegh5nbPczzoSink79eQH7wLn1BOmG7GkJ6I4Wb2kwpC+fzew6RwtPyy/K8Rc9lt0D8hDNGT3vVT7LZNHTUTgbVl9xI7/kf1neQQ/wINIw77h8wuZTH0dsLr24EWi7o9XIaU482Lw/lfkqBgg8cQFauIGDxyFtGga3iX5i/v6KlJjP+ri/G6Sa3WN6RtNOr+HAjfLr1jy1B2mRsc9V9qu6VZHenACM4/JohcBxcwo3R5XvHpURSahd1/5SwYTJWlig1HamNYTsAx5OtkZlRNE1D2ppX+W41WTPpDgMNhodoRGPvUAucdOHCWfVdUNVJJ77U61RgiWwt4EovdkBFDSnhrhqd5tsN/lorUzycdrMsmaINqNQtEpwXrTZQT+ZVQEmCH4SuEB6Xq2cK/+j8LL0fqAjxLxPlUe80Q9KuPRK6xL9T6T7iOQt2ye6fXVSqCU6H2Y7vFr3t+4GsisAexj8NK7WO+v7esirXJMDSCqD5tK/CDN4ytvzWiVCeg2GiTIftQe/V1dT2oXltBTMgOR4teHvCP76CGaCfr9T93u2pYEEB+lPQAFnpiPBlhW9seUlEuOY4OcbN2RMTq8wItuRnNL+FZJ52n89JURgyA2Qh1aUO6cN7rKGF8W/P3jH/yqCUgIFTT3x9CmjGFOVhPf+L8H8xQ9uKf5O7Nir5xJd9aSZTIHo/RGz95uvpd4+9uHM+fV5pFEx6n3Vc0dZ+4D3wQyihs/kbV/U403bsio1tbnfqNbSqtiYLBE69vDK4rW5v/osq05uKHljjzqtix2OQWsqEmkk8OUkuqBs4hsk9sJ8vpy2haVcqlQBm54wvr2GO4Oeb8HsIqNn0IykdDWFwPjhrYS//XymXUuKIxGg2iW3CBTG1HQ97AZkjoRQzZvdG5bNZu2R11Y6ltkNoRj Gg9eZeDI RdUBamC+MuSZ1sPflw614mtpmp9YyNsQUNb3QRBPdtE2OLzrXm1rGlo/jsywN7IHDeI+BdgjJ6iD5x5x5/pJ4LaxK2UIUWOuZOKuDNotdrSC3gclnUvcYxJzzwBxvyrezmiKFMNWxQzi+rd6CF1Tj8uHY7flXDd+akHDk1QRslRmeYivgw47aFNILS7wvEV9kh83pb2dj+OYlwoIVRYhTX3YWbFTWcv+m4qnMFrRF039LO6sl5UD1X0ONg1kyTG2xIPIn7a960OMiYCgAAHLXZt66tdJrTvVo5g3C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/4/24 9:27 PM, Lorenzo Stoakes wrote: > This patch introduces vma.c and moves internal core VMA manipulation > functions to this file from mmap.c. > > This allows us to isolate VMA functionality in a single place such that we > can create userspace testing code that invokes this functionality in an > environment where we can implement simple unit tests of core functionality. > > This patch ensures that core VMA functionality is explicitly marked as such > by its presence in mm/vma.h. > > It also places the header includes required by vma.c in vma_internal.h, > which is simply imported by vma.c. This makes the VMA functionality > testable, as userland testing code can simply stub out functionality > as required. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka blessed be git show --color-moved=dimmed-zebra