From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B66EC54E71 for ; Fri, 22 Mar 2024 10:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04C1E6B0093; Fri, 22 Mar 2024 06:28:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3E7D6B0095; Fri, 22 Mar 2024 06:28:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E065B6B0096; Fri, 22 Mar 2024 06:28:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D245A6B0093 for ; Fri, 22 Mar 2024 06:28:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8CA9C120B76 for ; Fri, 22 Mar 2024 10:28:30 +0000 (UTC) X-FDA: 81924300780.10.85376B1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 17147A0011 for ; Fri, 22 Mar 2024 10:28:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQts33LF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tRfumdP1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQts33LF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tRfumdP1; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711103308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=czIUYvOjO/iSkEz5wFLR8GnkJx6RwMigJ7+M+2CV8HE=; b=Y1U6vDmP7bqqc15u05CfzwWiCdLM5OahYnhaKY8WWnpeAMQagnFYdjo/jN9RIWy0crHIQU PQQq20hRk+SnGrtRVPmZS9VxiVTqXXwMY7KpIEDjixsa4YGbiPke55X7xsnCafqqyaMots Frv79tAKyWAhQMT4yU9J/Q5v7qGrwaA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQts33LF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tRfumdP1; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQts33LF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tRfumdP1; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711103308; a=rsa-sha256; cv=none; b=Yq5TbO8Ptjpw0qJYcxyoMvQpYiBoFjFgGeP526FBCz+H5Mj/I7kLtsOip1NvgKmFcGNAhx +P0qjyotUwIr+Rhljmjq3qd1w1pAtdwpESJ6MuzBIPVMhVtjv+MVcBnNU7+ZLR9IrHFA4x xFk93S9vqHCbTygOUCuzukTHHrjlc7A= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4B56A383DD; Fri, 22 Mar 2024 10:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711103306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czIUYvOjO/iSkEz5wFLR8GnkJx6RwMigJ7+M+2CV8HE=; b=mQts33LFbPSeeey/k/WOds+VMlsUaw3Se/WrW+DOSC5PAr4/+T+T3NHx4AJXgxQ46xCLZD +PHi8J8pfjlNvxt7vBT8KXBdIgB2HvaN+XMB8AaZFnIaJ+RV4cfhgLjAxZagI5eb3FJIrj fVLB3ebzUq7VIVpGvU3ePWGflv+KAQs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711103306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czIUYvOjO/iSkEz5wFLR8GnkJx6RwMigJ7+M+2CV8HE=; b=tRfumdP15X36nJLY0Tshihc2M60KrAH0IE7VlgRo5bfq10HrReXOJ/+bnkkWIaVXewoYmR tTJkidRAl8DGEpBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711103306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czIUYvOjO/iSkEz5wFLR8GnkJx6RwMigJ7+M+2CV8HE=; b=mQts33LFbPSeeey/k/WOds+VMlsUaw3Se/WrW+DOSC5PAr4/+T+T3NHx4AJXgxQ46xCLZD +PHi8J8pfjlNvxt7vBT8KXBdIgB2HvaN+XMB8AaZFnIaJ+RV4cfhgLjAxZagI5eb3FJIrj fVLB3ebzUq7VIVpGvU3ePWGflv+KAQs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711103306; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czIUYvOjO/iSkEz5wFLR8GnkJx6RwMigJ7+M+2CV8HE=; b=tRfumdP15X36nJLY0Tshihc2M60KrAH0IE7VlgRo5bfq10HrReXOJ/+bnkkWIaVXewoYmR tTJkidRAl8DGEpBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EE57513688; Fri, 22 Mar 2024 10:28:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VndHN0ld/WV+WgAAD6G6ig (envelope-from ); Fri, 22 Mar 2024 10:28:25 +0000 Message-ID: Date: Fri, 22 Mar 2024 11:28:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/9] mm: Remove a call to compound_head() from is_page_hwpoison() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand , Miaohe Lin , Muchun Song , Oscar Salvador References: <20240321142448.1645400-1-willy@infradead.org> <20240321142448.1645400-7-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20240321142448.1645400-7-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 17147A0011 X-Stat-Signature: 4hqxge9ijooujaynkh7rbay1nb8xwisa X-Rspam-User: X-HE-Tag: 1711103307-211811 X-HE-Meta: U2FsdGVkX1/ZtH3yRMTN5jzxSpuiN8JnCnRNyQFHowXYW8H8iY2rkjRSE5pfc/GxkAU2T9xo0NoJnUf+mQkp4/bzp9X/9/OOIQisuph53ZEICUDmrzSDtpcM9+0fo6RgBaiCC7uP9Qn4Tu9aGjYgv8hYNQ1eN+NEjTf8Cu6ARdXHWayfPslK/rk1svDt0VP4hXMeMsk9W7PCLfqHoDAdzzsN0bj/ftu6gqIYnOPmLXEiFwWu7nETaU75UxAzNF5qHsfXeFfo7nWbd/wxpDRKfEwa2KWeSU5UaUK/+wDHzH457sHshM1MFa76RFtieabWx27cIp6382GblUOVS28zJmp9W/SQEjVkSxYPdH6eWrQPt8zhMzYIfkRpgj3G+hY88ok/hZ5oZYx4NtiDsTZy01oV6x4XM+IfhTTO188ttBUO+1kXweuwMzNU/v7OElMIkLTr4WJj0c1vKUctk3++vsTn6bAwfHlbNP3YfRKuXemNtR0L2N59K3dKICGJSPMGnE2T5PWR9qqiul+oRrI303SbW+mOykb8EVfMR3JvffDdi7t7poQcsM6al+zH6FPYVC1eMO/FgFbcLc94pNmnRNQAxi+czyN5Y2grscAsqSU/mBOCXDbjYud/5eszQpD+UAXgRWrv3IzqVw2BJWiRmUbBu+m58CrXxHzGgzVGLrcS4EEJdCt1ZvY3upO0Q3Syuurel6/LTuv6OmQWY1LFE30py5n52Xvick4fpZI2eXYxNRQDW6+nRKnCvAybrZAb5N1mXg/n/Pra+suUjSOh1jdeQgbTbl2DLTgoW9s9Ya4T0aRsFzDh3hZ6nQ1mfU67knBog4ccfkQXnZR5XXe6ILxs1DKuLdSKYWZefoy36OYOAozgiL+p0LlgySUWubUiB8NiSMRgriZ+Twvctt44GthavWhvROQbcqXY8h6b1Q5im58YD6Ll60kn2XgqQ/p7gwPqownsNyfv0sQwjdI u0gUd3GW NjaFGWX8sHsbMmQy1MbgUlQYej+2GmqwvRoiNOQZnBolSTiZzoI6S3Nq1sivV+EJ6s4yemxyag8ZiCnAT78KBYrqaJmRDbfQSY9RCQylysgYM7OoeddTcvJXQxaZpVGQ+d2f9oNg5ENKMnekVCJFyD7xbJ0dRCiPx8AYLuAh6/+qKx0DpsNN7spsEWqtfp7nwL+vIsCGj+Nv6K7H5TVITINVY3Nzt/BZ2OG+oxcmqEsHoJtCnVoNXEfjF0V89arOtXb8/i/zfJmz8goFzv6s0JARdeM4rsgMxMsD5nS2iLxHr31ifnIa9EWN4vzIdDjilJAypm+GVifeK1gZ4QM4NK3p07OVNUqjKZ5z70Fwi9Ki2rekwV7eX2KyX992qN/ULRT5oyGjWuTkTFO3SqllysfdxhyM7hysibb2P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/24 15:24, Matthew Wilcox (Oracle) wrote: > We can call it only once instead of twice. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: David Hildenbrand > Reviewed-by: Miaohe Lin Acked-by: Vlastimil Babka > --- > include/linux/page-flags.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 6fb3cd42ee59..94eb8a11a321 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -1065,11 +1065,14 @@ static inline bool PageHuge(const struct page *page) > * best effort only and inherently racy: there is no way to synchronize with > * failing hardware. > */ > -static inline bool is_page_hwpoison(struct page *page) > +static inline bool is_page_hwpoison(const struct page *page) > { > + const struct folio *folio; > + > if (PageHWPoison(page)) > return true; > - return PageHuge(page) && PageHWPoison(compound_head(page)); > + folio = page_folio(page); > + return folio_test_hugetlb(folio) && PageHWPoison(&folio->page); > } > > extern bool is_free_buddy_page(struct page *page);