From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8042E77188 for ; Tue, 14 Jan 2025 20:41:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BF8E6B009E; Tue, 14 Jan 2025 15:41:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46E436B009F; Tue, 14 Jan 2025 15:41:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C09A280003; Tue, 14 Jan 2025 15:41:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0D8A86B009E for ; Tue, 14 Jan 2025 15:41:59 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ABC20140D2A for ; Tue, 14 Jan 2025 20:41:58 +0000 (UTC) X-FDA: 83007229116.30.FE11EA5 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 5263F12000E for ; Tue, 14 Jan 2025 20:41:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="emU5/VjE"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=J6XVWv1d; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736887315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6fftlLj/+7O3eNaKOQ7MrbAGnNf8vQvemWX8GtxE0zQ=; b=wctSMyZdljESpzQGJNNWhrGeldtdgPBi0Sukms2uwfQDsO5p4w5w+uOnh/qrovKUDY04WD XSvpWWz61fJYvCb+cs032WuvpN03CTj61bSgJMjMfpBojiUMVCQUjHQAaY8S3xYF7nJrzs 2/9IuIxL+icjsSxdcEVQiQxX/GiU8Mk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736887315; a=rsa-sha256; cv=pass; b=xeBM38MLGZo4hyYNDl/XJe07MPGOBIt57rTbGr37xbq5K8U/Z7+HWvcTpIrHBmU1QTLNWw RztXfZwW5jXC6F+SHcsCu5kJBLmLDLayTwKebrg8hy71jiNPehRiJ0berJhGfG/z8jEBK/ ZaEdmFd8XdSCZnoi6HenQGQ8bS/G+4E= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="emU5/VjE"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=J6XVWv1d; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50EIXpGt032524; Tue, 14 Jan 2025 20:41:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=6fftlLj/+7O3eNaKOQ 7MrbAGnNf8vQvemWX8GtxE0zQ=; b=emU5/VjE9B1iblHn19Br8fAyj8TkX2x+tj P1IBuzQjj9V+yRwuzMoz+ZwP+kTUXZSPk9S++tqQFPbiD7G0LtWJWeMEAj2QAtz1 7I/9D/0tyh2ezxM0j14ErSYQCPnVQWNof7LJZVzJIe3BhMZGaaprhE5fRwJsZtJv wxYdlziYF4VxAz1yEAEQ1/QARiUguDhR3vmqhiMN3O2Zf2hmxKtw1RuTfM9tdtZk IdBJRzRsm2eshfCMzA4/0e0BsIwrkQq/eV9ygr5SKW2cpytLPgqvk96GCILL2juI CroE143cXhx9+T8VW/Wi8zH741j+RiZDJdew6dimAU1z2a54tCJg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443f7y6jx4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 20:41:47 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50EJWAWa030053; Tue, 14 Jan 2025 20:41:47 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 443f38maeq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 20:41:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aBwtSBx9xY4rfuIL5rxLXXOl/eLSFcz3tFVA4CJn3GrUlaAXHiqz3nId8iLhzPhBI1dYK2KyAcdxYSibtg8pGyF9OinLfdtKSSr6XE6sp19xta9Tj5CKZLmwI9FxCXJHrU3oYGckK/DIInwl6igst4mmNxMAhDyJTPfyZfJXRKaBkwUpfo/zYJ3VX4OuNpx78OBQpUXjycATqUTw0StIffzfW//kRYEQVT2vDXWKLd7M5eZTsYcXEfu7LRGpNTpjjx2g0EjfoqxxoqPdnk145L//jndBNex7Q0fqW5XlDA1B0O1W9BTWNoPNnfIyQcEXx8dKXJPJ9/fDOmF6Idwfvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6fftlLj/+7O3eNaKOQ7MrbAGnNf8vQvemWX8GtxE0zQ=; b=QSGlwo4FYn2e2GGLkyH26sSJq7Y/83E8wKMjvEwbkiPTvLi5ZBrEB6510CeHNYTDW22uL0P4APflNN/WfexAg/cbKRNtyLo7pGk8MTgwtqcuw6vxtpLebOtdqdk6qzK7Op/IH+7jg5ZqI/ZIgNbCpWPpvInv83WujdTG7rEDghciv/aF/wl1OZrqB8HawcOtxtNfSTHwoaKmDsVYvmB8ymsvy4NEgwWkNecwldp0RvN2mWaiRPrRWo+YqNtl+UFDibEtftz+sOQYxtZTRqL1HVrbLJL/ABvmXXxwhu7NneJWhLh2N5nTkqkVJTbhno2SOkeznFQVThIqMwDoLcWhdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6fftlLj/+7O3eNaKOQ7MrbAGnNf8vQvemWX8GtxE0zQ=; b=J6XVWv1dvZKcgZU5chM4hXGV0rJPAN+KpR6YDX5k3tuJmTdIZuOz8iscoBF3DsFgCdnAInCxJhUj4L+uozhl94rbXBl0tBcAHxgo0HL3haJ01qVrQBPvHeeQ/mILVPtBOg1A+oPGvgDSLuHK4pDwYIJhWwzQHeKcg0g/mAGLn7s= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by SJ0PR10MB5616.namprd10.prod.outlook.com (2603:10b6:a03:3dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Tue, 14 Jan 2025 20:41:44 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8335.017; Tue, 14 Jan 2025 20:41:44 +0000 Date: Tue, 14 Jan 2025 20:41:41 +0000 From: Lorenzo Stoakes To: "Liam R. Howlett" , dave.hansen@linux.intel.com, kirill.shutemov@linux.intel.com, Shakeel Butt , SeongJae Park , David Hildenbrand , Vlastimil Babka , Andrew Morton , Jens Axboe , Pavel Begunkov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ryan Roberts Subject: Re: untagged_addr_remote() in do_madvise() Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0275.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::23) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|SJ0PR10MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ebd6466-0e66-4344-2d21-08dd34dbdb98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SooaOsLjuAjw0ozCIVhqIatVgh8tgxAdDw7zjiO0C5UVAXvTuxLp/+F0oCW+?= =?us-ascii?Q?y3OPC0fi/vje8MeuC1xfCv2P0dHBCNA9hUa2BoLw6Rve+cAwSP5eVi9RezN+?= =?us-ascii?Q?9BMGDn5sYk2Z+NA/jfx225TuPrYotDdAqMaroWdTd6abypL6dS3Z7gDBGVOi?= =?us-ascii?Q?nzXog/dTf34c1r2ncB4fnPR21VBv6hjWoxF7WXZE2f6c+H3fnAEZGubWLu42?= =?us-ascii?Q?x8jvFuWeTuq4fL0HUAut8ilqDVlmiK4ujZ9ePqWQ9s8eX7H6fvrvjPPqe9IS?= =?us-ascii?Q?r1IPfEcf7NoMKqQQ+22gWx9ufC8crsIIvHV7RivIbYZ54x5EbiXKdSgKGaBN?= =?us-ascii?Q?vZXvYa5zAN0LW9Hx8ChGWOG9i9O1tRBssrYRdW5Dw/kA/LFSTiHVn7N3VPSm?= =?us-ascii?Q?A7/z/tGgxU4v9tQ4UfvuOeE51ekmIWZASW680pMvs/9/AzPgdsFEFLibAq8F?= =?us-ascii?Q?1AqWKoV9iKlTKF/6lhC3tAft9FFuXni5FC6BUHo1b0zoRK1XVWfFi7AnJFKE?= =?us-ascii?Q?Fe4yB+SfyMRHb6qN4Iyws9+pKlvFVzlrnbNjfl8/4IKc0rNSFO5Jl6KVEojg?= =?us-ascii?Q?fuASWqYqriIs0MiW9YrvpwtSoXcJSukMOcwnlGm3nO0BH/wTsm/+jEu8T0iY?= =?us-ascii?Q?lBzLMm3Snc1IJYtlQ/ok9ZsXLG5PU+7NlCzmut+rRoEvIv4ZK+soZBdv1mgg?= =?us-ascii?Q?LxeOWk5nmygyVzq4fkHIFj0YY7lKZj4ItpMyxNpKrTEc5wPkYrdb5T6TTG6m?= =?us-ascii?Q?zKlbnmII4GLUfLjEoEQ3u5AmTtxxz9vk/zjxP5TRvWehfqUWxcLwwUqqjR2l?= =?us-ascii?Q?W103IJ/dw2pVS/ljz/dTCoQqEmqyjd/VNqYIbUTUGAgc+Bd8klb4Pn3o07Lc?= =?us-ascii?Q?c1CaLSZsuvLo0mg0GIbYR/tYgkoEhlDH3ywQPaBLkbfX3UkhypIB0thdWhOs?= =?us-ascii?Q?rtgC7gnx9mSQ3sW3+6E1NSP4FL1+3G44LCmy/V7e1DOrEPEXaszKPN2nMJqC?= =?us-ascii?Q?Bt7S6WzgPt7pzDr/Pt1Uq59na3NzBomI+kaaCTS0GHTeMxTF4NTXw0PeP18p?= =?us-ascii?Q?W5qaIcrW2cVsmWq9FhtN5s1BlmlHioX8GXW5UGZm8hhkL4qEMIlQwd4yzgtN?= =?us-ascii?Q?gMtn2J4Z4sy2s3grgHASrbntN/qMhPqK7kzKCztCK2DDtaS7pv3EDB/wT8+s?= =?us-ascii?Q?cyoU6zWUcjc25QlyfObwQIyIDT/Dt2b3bccYuHXPDQDquWQHYyJS7zPPALul?= =?us-ascii?Q?7i1PwFM/hN+xiTWwQ14qsrjeOhpFbbBLpSf22xAN7+qfuSZk2wDkzqzQBNXZ?= =?us-ascii?Q?rZaxd26KuNdKRgWVLDctvvO8dEjVSbdI6ol9UhSA3dL18619Lw77Di3tbx9i?= =?us-ascii?Q?saGD6bw/v5mcc7TF1nE0r4MFJmXVfJ/4P+z3RBc/2TWXN9creQj8SYq9VKNo?= =?us-ascii?Q?rZMMZ/+n977YZkR5RyOF9zKYHdLT92Nb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TEckBTn6cxdxiKAk8FqNz8+2BXVrZ0rC9Per8DY7u/Ae1OjjKjo79d0JCPhK?= =?us-ascii?Q?mbTMOGwx7SQV+XDDG22CsiYUatk1xjLx+AlmmbDDvDFpklIrpNP67RbZm6Ie?= =?us-ascii?Q?vIGtkqapZmi8NTerV8jqq0U+8cojDjsmEJGMki0T0jrBfM95zCpUczRi3lkH?= =?us-ascii?Q?dn0RiqWqwLfjQtnzz90rV76awpqUCfOTaKnONn92KhUjgU6rhA0/ZkrEJyTT?= =?us-ascii?Q?IhYSHCSdnzLQ4ryDTrwxNJ9w2Uz2ALseGvBTXOG/pXHuCJ9hmLZhnNJ7N0Io?= =?us-ascii?Q?lkghG+bxYUoDYbp66XOjHajzA+2VESZAoSyevxFDUbis6VH4bBJFaN2+Q0eW?= =?us-ascii?Q?ZhRwb8iX1WGEAGmQi3OgjiYc8M2P4QeCDxcI8LRXOoz01y7Ib4OkX7ndD0UZ?= =?us-ascii?Q?ydFihzUgUTE5rwltuMOR1iLQBFcVRSYaURXvV9AMO3qJs3LuDDr3mbIF15HZ?= =?us-ascii?Q?JfCkFs4nOaqdz3TFHNPRQvZcZD1PDsRR1ABnkU/KAxKhGru6V4wm77Rppe/k?= =?us-ascii?Q?4yillfsFWbs0RlgaI6825bQkmocnaBB29Dd3rM/h64+EPiCk8vzXq9rt3GM3?= =?us-ascii?Q?/NF49KQBut7v5NTOWjQmHtEHcEkqqcn5vE2Gn1c7wC48OaNgkF2TIvNKY3wD?= =?us-ascii?Q?GMAnjJM8BeGOh4XsUyqTtrHPChJhQvua1MEYrIQiqCyxgNMW3c6zPRiU74i6?= =?us-ascii?Q?Hf7nYr5D89Sw8P4JhmfZOffZbhHF+4LiEXdm1r068FZ7neOm7sPzfQBHOpNx?= =?us-ascii?Q?I1J63KsDgAoJ/ghGFzBn8cfCe1Ls7cmP3oMVaBASY9VJr9eEkbMKRKInq2wE?= =?us-ascii?Q?Rzrl2/BZFDUYfCoZ2LOAxTtLQJ1XKq6y5auvs0wywucyEsOR9g7boj5je3EP?= =?us-ascii?Q?hhUjAmKgXVLTnGTNQMCY3o3YZG7iwpc7qVKL7pqydeHRSea1DCgxBW6SpKtN?= =?us-ascii?Q?YUc0maD0PBfq+9+OqA+9Ap6MDFki6XUd9l0k37UeeV0WMQg4lHwxuOlpaFvY?= =?us-ascii?Q?J2PU1hpRCtHKW4kAPfCM2GJXLzF/MzHxWOq12NNIX6sCpB7uhc9wIRoZ5miw?= =?us-ascii?Q?hbIs2F8m5Gzitcg2VcNpkZHbtAXY3R6+TzO5qD4Lhqr3X9JVT5xTxacXhP4U?= =?us-ascii?Q?1Gread/g+SvaowGQzgc83N3XPI2Gw3ooytHT2VQkIDPuOdw9moy0mbGECUhI?= =?us-ascii?Q?jQ5J/GK9DvQP5UJlbmLex2+xha2Q9TtXdyqe1ioo/g93EXBrEgMyxCZD2FJT?= =?us-ascii?Q?PO4gD4jB6O3gJMQ0sCq6pIDwZODD/7I+rAzvoijL9Ay2+dvvTpR64OFpXOiI?= =?us-ascii?Q?hLuu2HDWFp3U33AHrvJFGu9lOdYJvNRtB4Cur2kvwOQHaK711buwqVeSA1t5?= =?us-ascii?Q?7Itzut7ETvZsXnLe25CFOGOHBGo8tN4lUU2QQLBKz4GX/K5NrquDT34JdAY+?= =?us-ascii?Q?1xbYGCx2wr7jcSUf+yjwictdsI5qBVLFaBRcfpe/CzPFV/c/U+DDfPiUQ+hk?= =?us-ascii?Q?lDRg90R+ONGRFdifBOjA1rrpsmIrz5xAa39Lfca41GeT42M6w/cXtXI34PKt?= =?us-ascii?Q?RCQTt1Gf6ZzoXOvR+RUAnujmlM06XxhxvDv73iU51KfimhuJ/lHw/s3RLa9u?= =?us-ascii?Q?Tw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: t4TgdNVPOrEnVkLfzVZMLcqJBYHKvm2jMbdgSvBAADOwUOLxM1GX0v8pHkL1K6gmx7hiJGHv6o9GLBT7PPIHHS8ULHqMHvfuxYebBGAwo5CJ4/Wvl0rvbbA52k9xkzo4+syf4IU5dXEcwkjEUu+Z9L51G6d5PhXHbx7KPRROAzpSvRKsT81UQ0FqUL5eJfuk37zPeOPOVVHRj8U3WwQQ3WTddFL7ZGyBPc+0dL7+jx+Mo9WLX0qKrkwH7bQFB9ttoqCtfIitX4afwtsK0tZZ7wcrWLwrW/5m/cpOuC1nHB67lNbdtV9MIatbZZnSlq5qR6wguDHDI6oKAHWKhk/OtMPMgO2K8cffvhH8Yl0b4BM4fZtUvJz4fqrjrjg+Oi4LHmI8g4tv93WeFS6H3IL/fpoQwnHMxs63c1EfrJy9qwUGjvWRWCTfESvyndaV0u0I9vywlAeRGmJTTzTEshBWFh4Y5yaRjWMHU7a/JbcgujhsdnW8kiVznm5cvGitzvKgGEuKN0rbQnx2qrhzelnLNBUtKYBoJAJ2u8SyZxK2vmGFGJ/hI0gBlsXxAvZFJS7Fbwm8TvDUrYgHPRZzH4UHcBfJv9kOcW7tmXRurOayaPg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ebd6466-0e66-4344-2d21-08dd34dbdb98 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2025 20:41:44.5557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eDn08YOvATPM9yd3lm9NhTOIz93v/1OoEps+QbdSZrTbgsh+stI+tzhN9fDhFyVpDLFldLimTVdDcWg9ssIfTHnhkqtoykRRa7WxCEavBTA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5616 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-14_07,2025-01-13_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501140157 X-Proofpoint-ORIG-GUID: rsXiQttPxESK1W4MWElTMQEJrTn9w3cC X-Proofpoint-GUID: rsXiQttPxESK1W4MWElTMQEJrTn9w3cC X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5263F12000E X-Stat-Signature: dqrzx3j7hggaufiqrkjbjag7h37ut6kq X-Rspam-User: X-HE-Tag: 1736887315-188400 X-HE-Meta: U2FsdGVkX1/lQfjg9fY3mtHwmlD3nakTjldprZ16KwSinOTwH+wlIABWZ9v3nQLAHNObSHE4+0xgpgWLtwGvjnCTVS4wkyBu1vuzpM/VtVVbjIUnu8LkDSBWWxY802x/AKSRCCwpC2wnKu6OtTYXWoGTEWlbU9BQwDfTHHYvU06cXyNVm7MdTk45xoY0Lqgt3X5ALRJi4leJtxSTlSD8kepY8wdgiGZIq+wBIsSNMooOBuonCs4h9KoXigNEcVHoRq8I1LL4LcFkxtMIFlJAos1H9WgRtHMb/rCxZFo7lhipIuwvIW7T6Hf9m3g8zVdByTA5tPmSuLotmNqjPglZVWGlUgnwhrpBeXMGoj6UrfEYxr9sGmXlmELAD2qRE38jTL2F3xDKfeR5WwnTH+wWh8JO+gi5tDB4GJugAEtk8kg/KCnhzsZxkNbsQtovfp1HcgmlnCQgfmyHZRPKNKccp8xS6rD/EEBbvByIH/XX9EQCINB4yH8DaNzylbulZfgAw7yHfdk0zkschVmOMddOXjntsrI8f6/7tjFCaxHgxwGfQna67Byp8/Y5Jg3O46eGfl+kNbQcaewdNpjn43Wgb7rKm7i+k8vj7/nSwdm6ZcqSNG2jkqOXrGczillNaLHJ488Pq3DDNV8nh/XjsfoI0i+zznomCBDBv5udYqMtzesuDu+nW72sAFyRy0EBYfDH8UMr3hNsMR/Oxib5B7glGYA9EuaRh13Y/kwUHrK5e/x39onAdBj/b1IyOKVHHJdjYrlD+xivxs7mXdvaxu8Z28lKEA4IzGus+ynX8XE63WThzTnfyjyNj9TWKTyKvTMM0kqc3vr4Ep/M7elrAW11hqG4vTmB4bzD8/Hez9XlExXLANrVFcDSOK7E1m3Zgvs3BXqOZ0PzMYa3gLDsx3s3ItKq7ofCQ3/OaEyOPNO4abpkzVh8nstuWQeXhQF791XxCg0dQrMdeATmjTgwIh+ R0A4zQKE nS0OjAXGiQ8w/FB1mZ7VOWv90n+/4v2lMNPLhwa91Fe+SliGOA4RjJ5DBBKAyRVr01ayq/CzPpCItPOsX2EesBqJepCvMub2ApxoD3mZ8rByxX3oQajXDNjTu/E1wH2ZI5/smfBNOT8ttEn2fSxm/tavrNtwIg3SzOt7upMIbe6P2XvQZ5z4k8ipgK1C5Pjbt2tlAypMRtxE7JEHinGjkjjamgg+CxIDG8UHqBJXOe1J+P25fUEsevSuXVj5ZsyV/d6kxX6aPO8It/d4rSz/nrzFAgKxTCIyFNFPrxoZrOxNRA6d2tZuk3Mu3SMem53AwLITNgPdkRkYmjugazu38NSjYEycQAdkwbZy0g1VcOWsZdQ9LL/svnjfITUj61nl0ZmMmkMv9awZUA+8y4Lz5onY/QNSosa2Z87CrLTaJS3q8VNOCQcjz4KH+melmQ+QXZA76/JOab/bbf07KTGjXtildH+YThPRyerJIkhaD10qLE35g0snwYcu9vo4U4QIcYe1g/DO3kCOiXAeBrmoa24akFlLcb5L2rXgptJUvZZ6EIbWylMjd0i7YUe6CvdniHbGWEtD59fgI4MLwFw8u/CRTSykSj4OBHrr7oMZNAlYyoaenmTz5FvVpRvnJfs3yfPpCkt8u1ftlmrR4krHXZoMp0uFc8NqUla77NechY8hDoTrHA7dPWyJHwa9z5U+J3NsxG9hs2RdQeHc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +cc Kirill for commit On Tue, Jan 14, 2025 at 02:43:17PM -0500, Liam R. Howlett wrote: > Hello, > > I noticed that mm/madivse.c:do_madvise() calls untagged_addr_remote() > after validating start. > > Looking through git blame shows that this line was moved in > 428e106ae1ad4 ("mm: Introduce untagged_addr_remote()") [1], with the > reason being: > > The new helper untagged_addr_remote() has to be used when the address > targets remote process. It requires the mmap lock for target mm to be > taken. > > Although this may be needed, we cannot move the untagging below > validating the start/end because we have not validated the start/end > that will be used for the operation, or at least, isn't clear why it's > okay? > > Can anyone tell me why the code today is correct? That is, how can we > trust the validation of start/end is still okay after we change the > start/end by untagging the start? > > I think we have to move the locking and the untagging above the > validation for this to work as expected? > > [1] https://lore.kernel.org/all/20230312112612.31869-6-kirill.shutemov@linux.intel.com/ > > Thanks, > Liam To avoid losing context from IRC discussion, seems to me the only check that needs to be potentially moved is: end = start + len; if (end < start) return -EINVAL; However, MADV_HWPOISON, MADV_SOFT_OFFLINE seems fundamentally broken for tagged addresses: #ifdef CONFIG_MEMORY_FAILURE if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE) return madvise_inject_error(behavior, start, start + len_in); #endif ^ this is invoked before untagged_addr_remote() is called (as no mmap lock is acquired) and so no attempt at untagging happens at all...! We do need to fix this... unless CONFIG_MEMORY_FAILURE somehow automagically disallows address tagging... Perhaps need in that case to detect if the address is tagged and do some horror-show hack, maybe acquire lock and untag and drop lock in that case... Or maybe make it arch-dependent since it seems only x86 needs to actually hold the lock for untagging? Other than this case I think we are good to just put: end = start + len; if (end < start) return -EINVAL; Below the untagged_addr_remote() invocation?