From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC499C83F1A for ; Mon, 14 Jul 2025 13:40:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61FC36B00A7; Mon, 14 Jul 2025 09:40:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0506B00A8; Mon, 14 Jul 2025 09:40:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BFA86B00A9; Mon, 14 Jul 2025 09:40:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 38D5C6B00A7 for ; Mon, 14 Jul 2025 09:40:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D7772C017B for ; Mon, 14 Jul 2025 13:40:08 +0000 (UTC) X-FDA: 83662978896.14.E137B98 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf13.hostedemail.com (Postfix) with ESMTP id 11BA520005 for ; Mon, 14 Jul 2025 13:40:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZzRZpbkK; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752500407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hLhOpP+M7fPAL0TZ14egchh8HzpI8mjwvlMXJK82SCo=; b=AJQGY0TrdnDMO7eYZpPzHyJBgqcExnWwPAy3illHXJaKVW6/04T1fSvridjwDPCI6kqZaJ qbFKM/zLrZYNJnWig4QLgXo00r1Edp1WBfrR4gT7j8qTSt9KUW59J2Iyq6npuB2i+4ImDt CGUgUf00QSv9Viyn6d7A7KW4J09l+WY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZzRZpbkK; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752500407; a=rsa-sha256; cv=none; b=BuEkJMCGDx0imLoiusR/J3rlP3ekHJDqon/UDQriQEb0F6ddeRhdNnGhjc/QJ2bDZWj1ug 4DYlMY/eaMp2r/ZBaQYjHUIjpBG7n3zkW2qyoi/4qh2o0ewdt2Em68w9Y1UyATP3WgLM9+ qQ5goxHF8XK05n5R0Vp/B8ZKybFADUY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7187861447; Mon, 14 Jul 2025 13:40:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEC95C4CEF0; Mon, 14 Jul 2025 13:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752500406; bh=dea+tmBeWqB+yG7LfH3kFCnhPvkRqdYPOZzN+qCQA0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZzRZpbkKdoqDZrBghSEyLjO9qVHKNo6Wd/vTIR8iVb2lN7OpSGdF6MEb3TLCP5e2j qrROrJTszTtnTK1zEFwadxRxsKC0sHs1STpX2X+7+5v/6eFyMsGlxM0k+UZFkwMYvj b+HURDsF8P56gmOTGVMx+2oSelH9yFH6RV8p6l+ztH7iGdi1jTeA7L4KPLAmdHubvQ fdduTknny41l+OXITL0S9xIxtWzxE1zrNEk/YTEsvqiVpqycFnad7s4wKj443opYRL Fy+eTneiV1RXey/ZaNnLc983NULzhz2KfsdRyCPCS30frne2vq73Ow/F9yuPC0bJs4 Di9FGjsmOgqlw== Date: Mon, 14 Jul 2025 14:39:59 +0100 From: Mark Brown To: wang lian Cc: Andrew Morton , David Hildenbrand , SeongJae Park , Lorenzo Stoakes , Zi Yan , linux-kernel@vger.kernel.org, Christian Brauner , Jann Horn , Liam Howlett , Shuah Khan , Vlastimil Babka , gkwang , p1ucky0923 , ryncsn , "zijing . zhang" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard_region Message-ID: References: <20250714130009.14581-1-lianux.mm@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mG9YY/Tnfrcf5Rq7" Content-Disposition: inline In-Reply-To: <20250714130009.14581-1-lianux.mm@gmail.com> X-Cookie: Non-sequiturs make me eat lampshades. X-Rspamd-Queue-Id: 11BA520005 X-Stat-Signature: jpc4qsbyecesqpo3ew1dosh1tqkwbqfz X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1752500406-970104 X-HE-Meta: U2FsdGVkX1/pzIXUtpRN4plaP8Eh1gA2HIomJWGKZ6kVDEpPZCr63PgYMawHJsJ0lqXFXc1g3eKSifv8dEIFBKZlZAr2U4k0Vm4hxmm0JbTcQaCtbaOxtQ5ZEj8OEJd7MNLeZM7n7l204O1JdXhHfsTYNYtrKhwmQJ+alxV49zICB/e65g0zIyMK550o1xC/XNQtU+htxWn/IcIFh6Hku5nq3MVQMBdsOqLYlgyqX26s9aaebQhdYrf5H4jUkO5pQBE6t7Sx1CDNYXRXPxZ7LTDLqNX5kIsXNycWkSTtXdAUrURFFGfgE0kWOpJ9zH0xoO82d2bmDXQj9mQeYdK1Y0hnd7z1mag0mac2G2fBuOsJJiG4KOnceZRk0TmRbSuy7dz059dZy6MDWE1EYb405xJcRNlya22yuWxp3lo6p/dvW9PAyu+n6z7+gI20ZGHw7g2/XjN8n6Il9F+0UxDuBL9uzIGE4tZKm2JdgxIWl40/fIk0QHkbF5zOsputL18ogoQA2l4DhVN+zCmQF/7KLlFjlin8GC8bkD1jC0p7wjYfWrt2J++fWEJRgMB79I3P+Q0DIU5zwwuY68wwiQ0ICl1kd2kOPofp+Uipg3cODdeJ6+3jdsMlUJzqYSXr+LTWCmO884oUEjm16P70P4TXUyJM7m8Yi/lrkp4petXdYwBxm0iDWWxRTBnJnR2OaSOmfbDtHgOpVLLFLj3ejV5/IbSg2mduSsRh3Zvo0pOa0xcXVuHFAvMQTKuv7+F8ETklV0jEJy65s/H0Sx9HPZhWaLbxIvMNMVd4H4xlx16mG8nehSCjNY4AaNOckNVzKqlYEmzyEmzIwwA0Fb9gGU65OfxCXj6Y/144fvddNe8Lto+MH4boawS2SzM+9gZ7kwiWIkORY0bc102TIPsrSc5cP9yshQ6qlhrcFXy2z1H5OX0F56eABRR0y8EA1Q9XCGR5Ki9a0lO+TI8EHI1ytfm Zx9+srMd sLMk+olMOtIsep6Dj/RZOK5rEevJCIRITlMwxJW720ZOkr21BBD6PTjzMB56EVf7xVjTeFwzJ6aupm98Z8L99Ze74Owe24qosLNuAMPiXJ62zfVFAR4NG7DLCSUEoIic+UtSRHrNrPoRJs7jdVg8PlichMGJ0rskpTr4Yoxc1daGiq/g98cI1wDNnXYVguBSieV42+k2qpLF7qJRV3FxeANju2rYvtZoXCW0l9o0ciGiui8ufIBGUf12/I71IlsvB5qe078dkjJUSpvY6HWEbgiQK++2ofRQA1I4WOOvJo6ZPtx1v3b8dKgIxc0lpl9SK1Rd2HTZYSQz/Njl6y1Zuw9sqFFcmnKC74h5KR1qaKIZ58mdYstg8xviWPDDtfLJVVqNt0zP2o8k+t59WZuwA8zTmBXtFA8q4jXgFi9oAurIwwOp4mY/havDj2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --mG9YY/Tnfrcf5Rq7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote: > Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared > `vm_util.h` header to promote code reuse. >=20 > In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro > to ensure only the current test is skipped on permission failure, instead > of terminating the entire test binary. These two changes look fine but they're not really related so should be separate patches. Looking briefly at guard-regions.c I see a bunch more use of ksft_exit_ functions that ought to be fixed as well, but your fix is good. --mG9YY/Tnfrcf5Rq7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmh1CK8ACgkQJNaLcl1U h9Bffgf/e6P7d065l3tVXplIfDmfI6m7r7Q+rxjsoMJt/PqR/EClhsrfnTC5ZSv/ XpnWdUv4e8cz/8J65Xi7aHZVgU4TcaFzC3y9sTTBpzpk/54SaTwZERILkA/Em795 f7OuLDasvYV+IRubq8StUNtzE6qgeDjckqstXsZzidvgAKuWT1DZCFlg+c+diNsI nieqQaAi4PXwYtvHfFzsyn8Kg9p35KswyN509wXmtWzcDyRwhKh9PcqDGKuIxho3 k6pLEmdGVvfN+AZa528BXRMds0ia8ayI+/Rx043G+UbA8mUXBcWYsTv73sTCp051 alrl49LiqM1Kw1WO6QDNiKjr8Yckbg== =lgx0 -----END PGP SIGNATURE----- --mG9YY/Tnfrcf5Rq7--