From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADB0C54E58 for ; Mon, 25 Mar 2024 08:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 864B26B008A; Mon, 25 Mar 2024 04:37:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 814B66B008C; Mon, 25 Mar 2024 04:37:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5806B0092; Mon, 25 Mar 2024 04:37:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5B8836B008A for ; Mon, 25 Mar 2024 04:37:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 02B97120A14 for ; Mon, 25 Mar 2024 08:37:25 +0000 (UTC) X-FDA: 81934907292.06.964279B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 765FD40004 for ; Mon, 25 Mar 2024 08:37:23 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=miKh7Uc9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vyi52dy2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=miKh7Uc9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vyi52dy2; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711355844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WFQLPMdnm6Vb5R5hL3AhD23eFZIrDhtHvEGc7c8NawQ=; b=qU3Up6SpoUajuoAYIzIPkxfqAMV0k3vkq9HbT+8gX6/18W5Sj7OlRtceaCz0xoSr5YbOu4 rs1k6dBmdpiRHLPlIUAqaDZFIZPedv+ZN5K05mQ9sielBWgg9g2WjmzEu2B3aHDU3uPnUg 7JXJeIf6C54km+EkIeie1xnrYeV42N0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=miKh7Uc9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vyi52dy2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=miKh7Uc9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vyi52dy2; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711355844; a=rsa-sha256; cv=none; b=yBiP08BsD9bNwotWOkEwaTj6gyZ8Fi6Qs0vvOy8jrDOySaY2+0bH6dMv85xOG6LwBcuJT4 P/usy9/YOusSNgOm1xJuEd+cHk0/O6tV7mz6ekiJlghR2pw7kA2PjC+rIL4hD1rqNk/DIT oMaqxTTcB3pD6m359USKfuJZkE8stQI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D09CF20ACD; Mon, 25 Mar 2024 08:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711355841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFQLPMdnm6Vb5R5hL3AhD23eFZIrDhtHvEGc7c8NawQ=; b=miKh7Uc9Go2lsd+lz6z5odw8nBqRC9SMVAgYW7Mm9Ie6Wjli4cWp8XYQzuoXfPu3T5eErF T7B/igWffe6Xj1iy4g8tuL+m9lM6wzTqPa954PvDjOEDuW7cCi+TEuWQCNhHKUP7fUjh2E +smQQzbC96K7v0LlFXFbkw9U5mwXynA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711355841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFQLPMdnm6Vb5R5hL3AhD23eFZIrDhtHvEGc7c8NawQ=; b=vyi52dy2jR9n1ZjsDFypwWY5JKlHtTsfDXNVZaTGvO/5mJ3r4DUAcOxb7CgCNSeeVxNoKp /sWqbPTAoJRPPRAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711355841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFQLPMdnm6Vb5R5hL3AhD23eFZIrDhtHvEGc7c8NawQ=; b=miKh7Uc9Go2lsd+lz6z5odw8nBqRC9SMVAgYW7Mm9Ie6Wjli4cWp8XYQzuoXfPu3T5eErF T7B/igWffe6Xj1iy4g8tuL+m9lM6wzTqPa954PvDjOEDuW7cCi+TEuWQCNhHKUP7fUjh2E +smQQzbC96K7v0LlFXFbkw9U5mwXynA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711355841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFQLPMdnm6Vb5R5hL3AhD23eFZIrDhtHvEGc7c8NawQ=; b=vyi52dy2jR9n1ZjsDFypwWY5JKlHtTsfDXNVZaTGvO/5mJ3r4DUAcOxb7CgCNSeeVxNoKp /sWqbPTAoJRPPRAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9DFA013503; Mon, 25 Mar 2024 08:37:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pK42JsE3AWaxIgAAD6G6ig (envelope-from ); Mon, 25 Mar 2024 08:37:21 +0000 Message-ID: Date: Mon, 25 Mar 2024 09:37:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 -next] mm/slub: remove dummy slabinfo functions To: Xiu Jianfeng , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiujianfeng@huawei.com References: <20240321131733.268615-1-xiujianfeng@huaweicloud.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20240321131733.268615-1-xiujianfeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 765FD40004 X-Rspam-User: X-Stat-Signature: 1d5cd8jn31ucta7o5meiznhtowr7gfaj X-Rspamd-Server: rspam01 X-HE-Tag: 1711355843-382065 X-HE-Meta: U2FsdGVkX1+6Xt/Vmoh8DrHc3Gci7MObmj2w3e2YdhNn2EZnI+eTYyKFNe6EXfxN3z6ZC0p8HsFYI4QDnZ9EfZXv/vpNT9BlEUZyUv6oMR9ox4+M5HVd/ugH60UVGK0ktytqUHVbQ7TFf5iLEsDf4ML6IzVBF8NgB2bIHN/j1pH8XPr+3XCW9Km8ZhqH95idzfDrgco6aakf4MbvD/uAEFYsyPyEFO7OR9ZT+sif/UROUw3eCUyK+9HEotiIkNCuEumjoT9WPLdM79SrmiF2RfCx98O5IF2ahUkEyR4S+a3R6oLSmImyzc44qihA22waa3UAAxquNE0OzQKy5wWGJM6oAAsINXYBnP1/w3f3AEbSM1JTY0QTzH4haug4zqq7y5q0bebDwHZf1FiKHFZ2Ox31uKh1BNjLrnzRuY2IBuFeobTITmDkBr0OfT2lZYN9Z02NE4F14Zf24vCOPJDoeWk96iGWLoeW9hGpmQZV4JUvGO88GopySokByl581DC+5u/5VEKFjIxIyLOYSThexOooMohtbWdQxK+0DXRu9WmGy4xsZhqBmLHt4IGGHL9NEKhVaHpbGDAqUyxt6JVHYg2o5CwMsVKRgEo6ZF+2kbR6b0hsorlfrT6YyLImM5p/imlD+E/t8gHUbzRtAAWXRf/BJIlbtkFGn7+s6KxYwTzOD6wgLqbivAq4Iueak8cSYzPkacuCjhCLYTJmE9xN1t47fnH9qtUawlAaGbtDTMVgLPx/4VKOtZF8/JNhRpbGc29ZuzgngN6/mz3NnUyMNmvjCug8A2jc1BpC6skov2en14+mlRnKy6dhcj1ulXmYhGYcU9PuObPX+icQ/4he310m5cWINT9DYnqWLwhqY98hAJBluVOxArg/8FAN3r0d1J19SMjhRCvUhStfDJsxZXIH+KpehdVcqQuDJTTF4jhA/W04VJRvjYecAPwberyo5ZsYfvWBnRaAdho+N4Y 9SOVv1FQ 9bfgBFC9l1FLaTtVUOdbmxzyUeQBpq6Z8spj4qSzGhyLOAlw7blNP9KQKV7DvwmFcUF8UWp6nrfiQaP7iUlGbx/BrwmgiSzHFiLOIxGLzmzkzLHIDFmpO4k5mJrdH652/DHhzDVRQ1YChL1aTXJyTchmNgESkzOVcXn4vNkIQsJy0DlL5SJfw5Cm0Xn8tGj6WBDHm7Nn9MqC6Sa0tL2dNm5UaO9UUuq/sLIRwNLxdsYDXCadCtlv3ivBis0g7WR3xZ7+upzF2aD88hUVszBo7aetpDXIKGYLzTH4Upi8sYtf2xfMned5kZSr9GumCHGDDe4oUfiyQxKx52q5vnuQuQYWk1kIr1oCoVX5tNMDipr4MQXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/24 2:17 PM, Xiu Jianfeng wrote: > From: Xiu Jianfeng > > The SLAB implementation has been removed since 6.8, so there is no > other version of slabinfo_show_stats() and slabinfo_write(), then we > can remove these two dummy functions. > > Signed-off-by: Xiu Jianfeng Thanks, added to slab/for-6.10/cleanup > --- > v2: correct removed version > --- > mm/slab.h | 3 --- > mm/slab_common.c | 2 -- > mm/slub.c | 10 ---------- > 3 files changed, 15 deletions(-) > > diff --git a/mm/slab.h b/mm/slab.h > index d2bc9b191222..78e205b46e19 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -496,9 +496,6 @@ struct slabinfo { > }; > > void get_slabinfo(struct kmem_cache *s, struct slabinfo *sinfo); > -void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s); > -ssize_t slabinfo_write(struct file *file, const char __user *buffer, > - size_t count, loff_t *ppos); > > #ifdef CONFIG_SLUB_DEBUG > #ifdef CONFIG_SLUB_DEBUG_ON > diff --git a/mm/slab_common.c b/mm/slab_common.c > index f5234672f03c..67c03d6bd26c 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1078,7 +1078,6 @@ static void cache_show(struct kmem_cache *s, struct seq_file *m) > sinfo.limit, sinfo.batchcount, sinfo.shared); > seq_printf(m, " : slabdata %6lu %6lu %6lu", > sinfo.active_slabs, sinfo.num_slabs, sinfo.shared_avail); > - slabinfo_show_stats(m, s); > seq_putc(m, '\n'); > } > > @@ -1155,7 +1154,6 @@ static const struct proc_ops slabinfo_proc_ops = { > .proc_flags = PROC_ENTRY_PERMANENT, > .proc_open = slabinfo_open, > .proc_read = seq_read, > - .proc_write = slabinfo_write, > .proc_lseek = seq_lseek, > .proc_release = seq_release, > }; > diff --git a/mm/slub.c b/mm/slub.c > index 1bb2a93cf7b6..cc7e68fbdbba 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -7099,14 +7099,4 @@ void get_slabinfo(struct kmem_cache *s, struct slabinfo *sinfo) > sinfo->objects_per_slab = oo_objects(s->oo); > sinfo->cache_order = oo_order(s->oo); > } > - > -void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s) > -{ > -} > - > -ssize_t slabinfo_write(struct file *file, const char __user *buffer, > - size_t count, loff_t *ppos) > -{ > - return -EIO; > -} > #endif /* CONFIG_SLUB_DEBUG */