From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDE5C02198 for ; Fri, 14 Feb 2025 23:45:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003EB280003; Fri, 14 Feb 2025 18:45:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF545280001; Fri, 14 Feb 2025 18:45:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D95F5280003; Fri, 14 Feb 2025 18:45:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE1C9280001 for ; Fri, 14 Feb 2025 18:45:16 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 71D404B07A for ; Fri, 14 Feb 2025 23:45:16 +0000 (UTC) X-FDA: 83120183832.29.5ACEE4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 29F641C0010 for ; Fri, 14 Feb 2025 23:45:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y9Mjj4jI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739576714; a=rsa-sha256; cv=none; b=HbmeDDYFVuFX7QWOKTHqiHJEK55yQj0HBbUdULcV3p2PzdVFpAiieke85HFNQESCmuopuy aqvVNrvIdtOs1Dg2eXNczCiyLanAvJpejiQvLQoYhyKdysVyo7f0AjA1earw1IOGSYLOAX yGiLVI5TLTIhArm7oqBlyDD3K+nySqU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y9Mjj4jI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739576714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2uueQUErYPXOogibQt2DkpBHVR/rr0cRQbTOjQ83kAU=; b=Mklzn8qO76noq1Ebo93uEGK0xK9HfpDPFhN13yKtF2i+U5r/Fs6Le+E0njC+6j1BJ8a1aI YqpaIMVU9/hlIH0LMtROn3WAwWzjjwdHfGQ7U1s7iTlD/pmnoN69H2vhFcydbs8R59wwsC OznJUO2JYikNxsRl2PxCFhxkrubz7lo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739576713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2uueQUErYPXOogibQt2DkpBHVR/rr0cRQbTOjQ83kAU=; b=Y9Mjj4jIPBq++RiPuZAgAsY+qHG+OYzWOJcx8/wLWGmiaQwu6bEuidUZfAby/Y9AvU9VrZ wYdjUGAKoIq6l3EGohqud7jNsBVWxS1ctiJh70rRorL+xnDOef3pLa78s3vzblv1kzcUEq r6mX2cMOhKzB3Gm5+ZYbHh83FCOzUwU= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-S_CMOaykNpyVvcSa9Gc9_g-1; Fri, 14 Feb 2025 18:45:12 -0500 X-MC-Unique: S_CMOaykNpyVvcSa9Gc9_g-1 X-Mimecast-MFC-AGG-ID: S_CMOaykNpyVvcSa9Gc9_g_1739576711 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-220cb5924a4so83222535ad.2 for ; Fri, 14 Feb 2025 15:45:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739576711; x=1740181511; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2uueQUErYPXOogibQt2DkpBHVR/rr0cRQbTOjQ83kAU=; b=YvEL3pUYVYrgKpyE6jdPA1XtqGR1Z6AP84OBxF3vY5DtiUoFCS23G/xwO5sl89QgLK rPXsVRt8QgVKdFvOW2KFZt8nrBUG8tHYkzTnpPMGlvaTwVHPGb1D86x7lFOQszFQ15MC ykmG8uqpVb3yI9x0ugtgQwseRkUAXEDQdhosNZaOKWEhvE5J3CqkpA6zwp6QYNcXFsmp qFUk11IWyrzEoGvBc0MpqHQCUhiJ67VKdPgo06XtRAE7HQl2H6kk+tkV9PlJc5RUtsHx 9N6sv2mvVTXWC1gt/D9Fc6m1keZN+GBPY1VEZpW/HQHhiI30N32z9jvgRKy9jann2SGJ ydOA== X-Gm-Message-State: AOJu0YzRODBcLU9LY4pzyKstBfwtHuHJtVp5CuwtjfbnD7ArOKmCwGFY RK6XN45515o9pIO2JX1JDsf51FBVfTAGSyvilV7E12Iw2ZOzmtYM765U3kexzgLF+hWUjYz7XLP 6xXkJqfqo8cCmwyigyfUgEHDzC/mIKNX4+gbLvbcZWHwlFI/e X-Gm-Gg: ASbGncvuLq4Y6Vjvi5ymDu0mf085BVfp83bq5dfHMIF6hFK4DCuXDwnm1ipZqHYqrV5 Avd7/IkWlngQHeGPtoargrUl6c3Wg3iCTSZfOESH7IMyl8V+9/KOryL3KjJyDRZeRqtpUUZrM/S +1klEbKZmK90V/ya+cE7zb150zdYt6qXg4U27nCKqAUspef5cKQ6xxXdxm762oz1l4t5DLAk/lR t3rPQtRlTpQzm5AFC72aehVHM/z9cSvTZx4bVAEk/2LZLe6LeoxyVgpN675kcLlNPYNXpEXGUnJ Fzjh5A== X-Received: by 2002:a17:903:1cc:b0:220:d81d:f521 with SMTP id d9443c01a7336-221040c2513mr17359125ad.51.1739576711357; Fri, 14 Feb 2025 15:45:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1/UBEwliKz41Ij24ofXhRsnSPElyjOlGb6aP2vhhmo5j5L3SZcrvye5FgNNOK2T5S+zGO1g== X-Received: by 2002:a17:903:1cc:b0:220:d81d:f521 with SMTP id d9443c01a7336-221040c2513mr17358795ad.51.1739576711018; Fri, 14 Feb 2025 15:45:11 -0800 (PST) Received: from [192.168.68.55] ([180.233.125.64]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fc13b913easm3576649a91.39.2025.02.14.15.45.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2025 15:45:10 -0800 (PST) Message-ID: Date: Sat, 15 Feb 2025 09:45:05 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drivers/base/memory: Simplify add_boot_memory_block() To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org References: <20250214063504.617906-1-gshan@redhat.com> <20250214063504.617906-2-gshan@redhat.com> <20250214145725.708746506f5937acc96783be@linux-foundation.org> From: Gavin Shan In-Reply-To: <20250214145725.708746506f5937acc96783be@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5n2_U098_WL7F58u1adqd-PjSmm2ClOHo5JYRhW39zU_1739576711 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 29F641C0010 X-Rspamd-Server: rspam12 X-Stat-Signature: feqrtko1qrab8c7sojeitahtm8rzpj3t X-HE-Tag: 1739576713-214447 X-HE-Meta: U2FsdGVkX1/IS8+SUn1V17IYFzfUlGLS4ZbRcWZaGnaJo6n2kV41MnJDPrpeS/m0RmQTwO42sNctO3xnvP1DdbTP71Y2PpH7DeifLwEUOft6jLZytyij0xAhgjy6FOIOQRg3AvOGq5/pf0HLe4EE5ofTbChBXlRYTq/suB14d6QYSVnmuDtF2UXT9t3DMFve1sG5GUrRWTBX+CSDOwUkYUOBjcjngef6aDhts/PA6VSxq+4yJL6wsnRMtPi5cH3LeMqyNZU3IHjaRsYh28TwGEVYNNP1IGicfgVtvWDfQPzg4IdPcEBer7W3OAHJKxai6vNyi8AFh48x3m2QlgD6ZEcpvKCX6E7Nsl8TMuBeAxwzqe0YfFM7v7q9jrU56Cj3r6psBga/BkeWpjodLMhDuunp/eX7shgGHIsn21fuHqMNbXec+qdfCFqA6rolCM5JOpr4h1iMilPXXPWNRkec60FK+lAKM//ih+TZ2Ryak/xyzT98Gg+J/IclP5oox5vTM2S/BSvqjVJkq4bky3NuJRhm4T7mER5sFs4vtbt4kf69TSFDE5VorFeKDZEhWvhDYOfwq6c59TvzqW06jkCHHWZF2TT/0GnpROEfyjrNvbRtWMDidOp6igXrgnCqB3dybr2N8DVe66BCfp31usDZlMPCW1HrblITNxARt2WdFw9uO7H2bqAvkDbg75gM/WOhlTXbr6ZT80ZBKuamnsDjeunC17gnCnEMtyCS6ljRNk07PCsfwQHgELNr/3/kmmXIohOSyVVhERj9R7CQn7JN2OJsNaow7SMexcvzgINKA3QBoQGZdff6N5vPZTFcafzV/xo7BDVQNmtfYKlNaW+R9eQYfVEpdy7ew+HinpmSZUdC4UMwPryPiHukJJ/n8V6zmzKqFVBFi8upEQL6NmBaydL9oXW7zLBK+c2FNiN3x4mWj0VP/k1mO2X3XDP12P/evV4wxe9K7ddm8I2wTy2 2yWULVVW 4yUWkkJgXNU6GBbKDKUX0P6Kge5Z5cJuXW0RVI6UbVbyYWQVYzWuZjSmYha6YM1arOHvMEV9M/kDf/nbkQq8cD9XrVoiQ1eBNw0WCD5qSKZIyfNOJkmNbATGssPs+xyKzcSPn281UzP1MTLy/8bPcXx4B1CJsrxhWhoOsx0WGmVQoIV7S8SY5Iu2/2KVkc7TbZHsRT91yu3aQRbEj6sXdsS4KDXMw3rfwlMYkEAxFnBhep+ly4/9n52Q0AqSuk/K7ZC1rHafVo7Gdkf4BEspOLp04tUjRaPDNPskcfCvlfUp1GunlQzi5Q111djXYRUqn8o1YupnxH7CJOtQfuC0nQQjCDAskUuHGNN3K38y7TG+KxfJpcKZeOe10FDtn3uEu83uBj05JVcePuFytAelR/j1f76ciQHihw4n7uI/ALlAejaPq2kstEzB7N2PaASTSX7Hb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/15/25 8:57 AM, Andrew Morton wrote: > On Fri, 14 Feb 2025 16:35:03 +1000 Gavin Shan wrote: > >> It's unnecessary to keep the variable @section_count in the function >> because the device for the specific memory block will be added if >> any of its memory section is present. The variable @section_count >> records the number of present memory sections in the specific memory >> block, which isn't needed. >> >> Simplify the function by dropping the variable @section_count. No >> functional change intended. >> >> ... >> >> static int __init add_boot_memory_block(unsigned long base_section_nr) >> { >> - int section_count = 0; >> unsigned long nr; >> >> for (nr = base_section_nr; nr < base_section_nr + sections_per_block; > > mm/sparse.c has a for_each_present_section_nr() - is that usable here? > It should be fine to use it. I will add one preparatory patch to expose for_each_present_section_nr(). With it, the nested if statements can also be avoided, Something like below. for_each_present_section_nr(base_section_nr - 1, nr) { if (nr >= base_section_nr + sections_per_block) break; return add_memory_block(memory_block_id(nr), MEM_ONLINE, NULL, NULL); } return 0; >> - nr++) >> - if (present_section_nr(nr)) >> - section_count++; >> + nr++) { >> + if (present_section_nr(nr)) { >> + return add_memory_block(memory_block_id(base_section_nr), >> + MEM_ONLINE, NULL, NULL); >> + } >> + } >> Thanks, Gavin