From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD28BC36014 for ; Thu, 3 Apr 2025 20:59:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFA9A280003; Thu, 3 Apr 2025 16:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA890280001; Thu, 3 Apr 2025 16:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBBF280003; Thu, 3 Apr 2025 16:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6776C280001 for ; Thu, 3 Apr 2025 16:59:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 77892C11BD for ; Thu, 3 Apr 2025 20:59:21 +0000 (UTC) X-FDA: 83293948122.18.E2F4025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C78E1100008 for ; Thu, 3 Apr 2025 20:59:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b2ntmmI3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743713959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=okPcXkwc0pba7YOQSP6Wfu/C299mxzOOCAmFdcpAZ/U=; b=iu62OF53OUsW6T4DALF5YXb7D+NXJGOLBtbv3eDVAiGwoLB7cUQ2Q89OVJki2MIBQR7I16 4Bqy4m26Z8196hIzedSnu35wv0VEVnDUC+wSPjeW6L6tbqdvr6WF2vDH/E69L6EUXYdw4I mdvwhT4a3wE7/DJsnaRO2PWWGkSjlq4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b2ntmmI3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743713959; a=rsa-sha256; cv=none; b=W8hxsVPvI+lJ78M8S9GC4ycfbb+vbb3VNFNXAMn5pGHdCVRz4GHDkeb/olixqsp/+Wi81N JlUyf8inNWStccXBsiqsCouJtg+tFyHQvvpLKl8wmem9vajRTep+GnU8e20iKRyocjsbDz 2QAyRq/uWD7QshrCR0geX72u+T6Hw8Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743713958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=okPcXkwc0pba7YOQSP6Wfu/C299mxzOOCAmFdcpAZ/U=; b=b2ntmmI3fdaKUB36B451DLVA9JR+jjzR1UXpy6u4tOzIx0TqWQacTXQfWVh9E2/o1efqK0 mJcsidubYkvF6/eixJU/4Bjvo5PgM7KN5HBNL/HLqySQhVNj/7MlFqJL+rj57URUsXgs6s 6GyzqZ6VZ6obmMXcy/Io3rTAAsiS1qU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-1F1jKdh9P-SZ7a58MCRcDw-1; Thu, 03 Apr 2025 16:59:16 -0400 X-MC-Unique: 1F1jKdh9P-SZ7a58MCRcDw-1 X-Mimecast-MFC-AGG-ID: 1F1jKdh9P-SZ7a58MCRcDw_1743713955 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43947a0919aso9912085e9.0 for ; Thu, 03 Apr 2025 13:59:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743713955; x=1744318755; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=okPcXkwc0pba7YOQSP6Wfu/C299mxzOOCAmFdcpAZ/U=; b=GoYVPsNlDhu3ZkIiSDbDKHIKiY/eRM0yqHrnaaFNRng10POgQ0gZrtcXx3vREHnlKG RgjYzUY0twVIa11YCY0P74CzbTGVeuLc8sw8J/qZDKmqESbWAtwHHbq8Lbyzp7vuXDe0 jLxh5+kfT8DtQvMDkYcqw0wQwVOeUC4sCGjNOxnjZOALwTv8TkBU4Y1haat3sxggceNB 1D9zfADoXwNvvEO+8wFD9e54j7uWt7yz8Jihv8I/gjhrJ9qp7xFbVSsj+AX2bGLuaVND 99oYgkhybxjuoQI2i2GnKfPcvjIIksnA20ZyuuxKobEMPkByFRiB9452p9d2wS1xrDk2 mLpw== X-Forwarded-Encrypted: i=1; AJvYcCUDAKwhYlQsiGrDaA+aE+nCN+PGH/NZyvAYZCwCJqZW+kJvn3rZ2hMMD554SRyVpyiOCvQmhgBMrQ==@kvack.org X-Gm-Message-State: AOJu0YxLCSFIec1dYOFwElmBUjKzSE5+8AEgZpHaYyeQZ7rO0utqK4lU 3+hIWcrr+H1V81DiJ/4f67cCw7fX0JnWYfm4iZH0pa/9eHs0gFHLwVX5UIjLLJ0SfgI777CHoUk 4XVJefRGwoKwvw8ev8BlfDL5BZOa4Yf3Vbfj45foEYB6dwVoM/zGadiV7fG4= X-Gm-Gg: ASbGncsVXKOzzJPRNkVHMHWjRQ6MN8HTmCdP/cGiulqphz5m7l6SalT9TB6R/Avl/Eh blCPEqXKkuBrGURGecK0d+MIDha4vftEWgKV0cGvQWL1QqHXtNSCZYgx34uHvpOjm46pJ//OjfA rTiAWMH8hUzJSuZKkK2F5M6Po0eUlPu5MO2AlS7KokxBpkqWSVZOeDxZpK8zccCQCuMYid3RnEz kbVzXRQpI55tIKWOKjM9QhvENSjIzatIagaGaJyFIXGk5GE+oSNJBEJPIkHuKXZdD1JJrNptyWR XQPxKXk3aUzNxmLeYPYmlFH9x6Zl/WVADnDGHJMzOMlXC5nly69JgsxjDj6IxUSPGnxPRGunLEr P7VrL4bnRrdwkTBy1dHv4S7eUGyqeoltMnmAyVXy4Bpw= X-Received: by 2002:a05:6000:23c2:b0:390:e1e0:1300 with SMTP id ffacd0b85a97d-39cba93cff3mr433662f8f.33.1743713954843; Thu, 03 Apr 2025 13:59:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsWOY+2shD/NONc8uSSm4VliRSdcVCeRxk5qB7v8EplW3KLanR1fhTMZTqT4/Mlb1KdWPuEw== X-Received: by 2002:a05:6000:23c2:b0:390:e1e0:1300 with SMTP id ffacd0b85a97d-39cba93cff3mr433646f8f.33.1743713954396; Thu, 03 Apr 2025 13:59:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:7b00:54a7:eb96:63bc:ccf4? (p200300cbc70a7b0054a7eb9663bcccf4.dip0.t-ipconnect.de. [2003:cb:c70a:7b00:54a7:eb96:63bc:ccf4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301a7586sm2752181f8f.38.2025.04.03.13.59.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Apr 2025 13:59:13 -0700 (PDT) Message-ID: Date: Thu, 3 Apr 2025 22:59:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] x86/mm/pat: Fix VM_PAT handling when fork() fails in copy_page_range() To: Dan Carpenter , Lorenzo Stoakes Cc: kernel test robot , oe-kbuild@lists.linux.dev, Dan Carpenter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Liam R. Howlett" , x86@kernel.org References: <94c35e89-f915-4122-b1a0-436893201373@stanley.mountain> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <94c35e89-f915-4122-b1a0-436893201373@stanley.mountain> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Gk7uGXjZQuVg_lfInxLkQI-3Ki75et5vIkluZqkiPow_1743713955 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C78E1100008 X-Stat-Signature: sng83yjhkdifh1pzo7sburcuihdnbf7g X-Rspam-User: X-HE-Tag: 1743713958-538850 X-HE-Meta: U2FsdGVkX1+YLByJkgSdtkaGRlVYvkI8RYpxZ0/9sqyPkBBlvjmD9Wl4HFBD8PSxx1FyQbHKJ9Hzv3BeqEhm6QrXjz0YY0WH0vnJzQVLxh3+vry7h8ja9ZY9nIrB7g3+0ggepKvIsmkgvsRwsqHCXLoqA7rvq0zVa/sjDwhxfFaPh15b0WvQradAViS5VxLfHg0mLiJCUdUIGVUexifOuJHRRD7WFqWWoAXIZQSc9NSqY0wd4Y2fjRe9OiXeN9G8vm6zd6hyG6uDOvG1r2o3awtX3y2VsQ7sMEbfCPvly7oxaW1Z9b0nKJJeWOTbW5TcrK7zclNas8LtXuH4yzY0oWc6UiGzgat6QNc8iTMuW6pwYEG+S/Wg6sPYbvCktIa4/As5aNZRtDLXVwv004VaKw0aIh/04GPe0IRrX61PqhYhr8/xVrTilKNMRYBKIe4H8uYI+PShINpdGs4XBmOJq6PstoWQ5ZL0QSCjiWMLHN0oD9XGN0JbHzekKH0TSFD0RpVj9ygFPvFbWazyT3V7EmMyNpYz84KgLhE50ayaV3ZnU3pK8PaWJ9ARi1kCyeS5/9moCrE8ms0ZX8IkwS6xCuGu07jPnL01JkA6wJbXCMxMMl8Yx7m/eQoxqU9Y6UNJk2BJ+5L4xSjsQwW+PgokqQGhDln0Q3xLQOEYnnjYHwiOIp6NbQpYqwA7GnR6fvfuOJzmyuwAhCjdxGnOnPNzoYIGflgd3UjlpjlSAcQAIxioMrULXv4P+YXlzRXoLoN74WpEfIgOvV3a6uByHJ3+mU0Mgeup2Dlo7BrbyRXZxya04ye5DQWsb0M5fxdqszyHKon5YrCDbWVEe74kiWOqwpnm6WSTSV7UuXknXI1Lf502N58K/cVZwXPPy2cHCD60fHwGyY31ChBvZ0q0nGowXo3HqIx6SGiURGOKVVYCN1AY8L2Uh5xRDYlDZTp//rub5kOOmNPsu4cIHTbR1Wv xk28Yq3O 9aRh9LeiOFOC0AkN03ZNNFvYS9IB1q3E7D5uNfecgLu44kbtHJ0uxPHBzYTkUwKQfxZeTEFJb1QwPm4Eki9fmd3uDyxLcpCYuKMMQCF1Mb0mXCmBwycl0Zpx7xo5UJZ6gUEmz8Xg77BmUSYlGyJV9KW6/MITk4RAK+nPWDX5JH5oXWujCjPZGbI2+/vWKE5qGp9Pza2++ZC3cVwf1/1QW8l31+yLq6FPfYiJFJCeEFddrTuabGQhfTVNbwkg7p4b6SeCQRde+Ezhb/FLNM32OxRpFgPgN9PgQd45N+gqwW9F2fqZjL0/wx66H21aKYPC14EvRbdD7eKN8BqzPVhofGnXUfGZ5FjRTy9EkVXfUl9glRO8M72dm+wk6iBVwwxwn0vJieRGyK3OAbFHxcSQ8EbMvw4Caxp1GolA526q9Q0U5VDnJf06K4p60VRzWdqQmSeEf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.04.25 17:14, Dan Carpenter wrote: > Sorry, I've been having trouble with my email recently... I replied > earlier but my email got eaten on the way out. > > What happened here is that the zero day bot emails go to me first and > then I review them or forward them depending on if they're a real > issue or not. > > Here it's a false postive because it's set and used if the > (src_vma->vm_flags & VM_PFNMAP) flag is set. Smatch doesn't parse > this correctly. I've been meaning to fix this in Smatch for a > while. There is a slight complication (on top of the VM_PFNMAP checks): If "src_vma->vm_flags & VM_PAT" we * set pfn * set dst_vma->vm_flags |= VM_PFNMAP Then, we only consume the pfn if "dst_vma->vm_flags & VM_PFNMAP" While we won't be using the uninitialized pfn (good), we'd still pass an uninitialized pfn, which IIRC is UB; likely nothing happens on GCC clang, but we better handle it. So that should better be changed; I'll send a fix. Thanks! -- Cheers, David / dhildenb