From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED737C47DD9 for ; Wed, 28 Feb 2024 09:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 779176B009D; Wed, 28 Feb 2024 04:31:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 728586B009E; Wed, 28 Feb 2024 04:31:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EFD76B00A0; Wed, 28 Feb 2024 04:31:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 511086B009D for ; Wed, 28 Feb 2024 04:31:21 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 991FF120EA9 for ; Wed, 28 Feb 2024 09:31:20 +0000 (UTC) X-FDA: 81840694320.17.5ABC512 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf10.hostedemail.com (Postfix) with ESMTP id ACFD0C0012 for ; Wed, 28 Feb 2024 09:31:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FxkUMgHo; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709112679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kmyL/BrWdx5wm+hWvNvDksX7lVp1tOfJaEY5Dk9iJ0w=; b=mzoigbb9JyaPNE5g93L86RHEfOOP5Kbw1TmvBUsFF6NsbLSNq9OINCSjIkMMz9eO5+T/p1 HJbn3lABF44lvKEg2l5xaWLrZDGR/JzrHOnlh31sJ3uLtqlgNfJffGWNdzzT6OcVGzVM4w 9v6ltatoCKsd871k/JckzcXpLq8pfeU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709112679; a=rsa-sha256; cv=none; b=eBFmfczIRninQug/UoyWcByz7Uu6maaJSMZfqgthGt/AOnAFAhyuTSUqdiyrFkHWqGiQtM mdNQfI6He4r7DOqq0m6JX0OsbfPwMYs+Q5KZ/CGln9kN9cLtPHJdtSNneeFVSWU/6hJ2xT v9tjBYOfGlxxEdwEI0WY3s8G+ZL92zU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FxkUMgHo; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709112676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmyL/BrWdx5wm+hWvNvDksX7lVp1tOfJaEY5Dk9iJ0w=; b=FxkUMgHoZ8vP94baYaMWYAKTYOvHCcfPNQOLWsscKf6JV6oUu2rmY/Gae2+2Ktpv5sOrxl aKR1CyClv8PF3fBMdO9dbk249uKOv8/dOeWCZMXP6LuJTWCyD6nPQwI24LshbKBxrjvRPf w9mpzeiZd30A7jC7MU1uyfZboJ8N1OY= Date: Wed, 28 Feb 2024 17:31:06 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm/slab: Fix a kmemleak in kmem_cache_destroy() Content-Language: en-US To: Xiaolei Wang , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240228030408.2740647-1-xiaolei.wang@windriver.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240228030408.2740647-1-xiaolei.wang@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: ACFD0C0012 X-Rspam-User: X-Stat-Signature: 9rhtfyrg8zezzsjc1p7s1wxipxmtf6p5 X-Rspamd-Server: rspam03 X-HE-Tag: 1709112678-406984 X-HE-Meta: U2FsdGVkX18LDzJ839bi4Ngw087SGNIcvlF44kk1vFsRzWNb6CRlJ5SrGdRjmSzP6xotlciBvAfYOLKBPx2O0V6UliqrOa0VvZvx1fThEU1UtTmYT7oedr4BkAJ2Ot72boELKvf6FjKEoShCB1EsYu6E93E8ipSbBuscvX4qqOnPBpqybvIFJbng27fIQAjE2o6ZpVKIF1nMmsLFMUSekGXCkGsJS2mwjtmjenKhalme6OjjzCIwODK5mD/UzShmQuuU7Km53moHI9a/+1tXaUV31fARUAQF3C+jC0/yFqGcNoCxAvw8x5IZG6dKbfGsa1YzXuoktawhEP5U1RIsvdG41reBWTWIdiA0GuUXviX4FJqsH5LAUQ7enbBy1qAY7McAQ7xkqbkcfrZ9BUlGYVj8CnHT+T8edFoIK2rvut/2zSN8h7VE4kiVw4Ml6q1nUimPgqt88bMTragJY5pHNE1jUfLgD1JHRDa1qC8wpzSM9NhKrApy20eIxO/gmxGVgiLQqKMOFhxnDj8wiF/H/hMRdVKHlzMRsdLvzZpowVF599pXu8fGqEsyzDG/dDBlUN9tM2I/bOVtE2PR/CGlOA1DSyW6cOJ/nbF1xSchr1ruVFTD2x69R1J9TXOWS/KxyYPvFtLRbVSIP9QIwbb2OXf1ww6Vfnkih93gooDm2Y6IA/wNCnnmxBJygdLExuFP8CkYvXgczX4QwYlUM0ogVkEsPXXu3QMkl53mGFz73mYGwi5RbHTNAkJjPbfopvl4VpUP5SL+4JVRdTnlsnE3/fb00FkivfO4BYl/Q6JmKY04qrwydHigxwPiaCDSgT7iEUzNVefeTYTqAVZzh8WpJWtOqHWYt4vxP7RS21ok3ZAfkpras/cimFZ/hcmActGBcNNh3nz0AmJgWWJikID6DLtN2yCPjAlAViQvSsbSqfM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/28 11:04, Xiaolei Wang wrote: > For earlier kmem cache creation, slab_sysfs_init() has not been called. > Consequently, kmem_cache_destroy() cannot utilize kobj_type::release to > release the kmem_cache structure. Therefore, tweak kmem_cache_release() > to use slab_kmem_cache_release() for releasing kmem_cache when slab_state > isn't FULL. This will fixes the memory leaks like following: > > unreferenced object 0xffff0000c2d87080 (size 128): > comm "swapper/0", pid 1, jiffies 4294893428 > hex dump (first 32 bytes): > 00 00 00 00 ad 4e ad de ff ff ff ff 6b 6b 6b 6b .....N......kkkk > ff ff ff ff ff ff ff ff b8 ab 48 89 00 80 ff ff.....H..... > backtrace (crc 8819d0f6): > [] kmemleak_alloc+0xb0/0xc4 > [] kmem_cache_alloc_node+0x288/0x3a8 > [] __kmem_cache_create+0x1e4/0x64c > [] kmem_cache_create_usercopy+0x1c4/0x2cc > [] kmem_cache_create+0x1c/0x28 > [] arm_v7s_alloc_pgtable+0x1c0/0x6d4 > [] alloc_io_pgtable_ops+0xe8/0x2d0 > [] arm_v7s_do_selftests+0xe0/0x73c > [] do_one_initcall+0x11c/0x7ac > [] kernel_init_freeable+0x53c/0xbb8 > [] kernel_init+0x24/0x144 > [] ret_from_fork+0x10/0x20 > > Signed-off-by: Xiaolei Wang Looks good to me. And I notice the PARTIAL_NODE state of slab_state is also useless since SLAB removed. Reviewed-by: Chengming Zhou Thanks. > --- > mm/slab_common.c | 8 ++++++-- > mm/slub.c | 6 ++---- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 238293b1dbe1..b6b35bcdd196 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -404,8 +404,12 @@ EXPORT_SYMBOL(kmem_cache_create); > */ > static void kmem_cache_release(struct kmem_cache *s) > { > - sysfs_slab_unlink(s); > - sysfs_slab_release(s); > + if (slab_state >= FULL) { > + sysfs_slab_unlink(s); > + sysfs_slab_release(s); > + } else { > + slab_kmem_cache_release(s); > + } > } > #else > static void kmem_cache_release(struct kmem_cache *s) > diff --git a/mm/slub.c b/mm/slub.c > index 2ef88bbf56a3..9ba59d064b6d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -6792,14 +6792,12 @@ static int sysfs_slab_add(struct kmem_cache *s) > > void sysfs_slab_unlink(struct kmem_cache *s) > { > - if (slab_state >= FULL) > - kobject_del(&s->kobj); > + kobject_del(&s->kobj); > } > > void sysfs_slab_release(struct kmem_cache *s) > { > - if (slab_state >= FULL) > - kobject_put(&s->kobj); > + kobject_put(&s->kobj); > } > > /*