From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BB3C4829E for ; Thu, 15 Feb 2024 09:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA3CF6B0089; Thu, 15 Feb 2024 04:30:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E45DF8D0001; Thu, 15 Feb 2024 04:30:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0616B008C; Thu, 15 Feb 2024 04:30:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B63C66B0089 for ; Thu, 15 Feb 2024 04:30:27 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7DA1EC0F6B for ; Thu, 15 Feb 2024 09:30:27 +0000 (UTC) X-FDA: 81793517694.18.E9ACD81 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 57D87180003 for ; Thu, 15 Feb 2024 09:30:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="nW+x/sC/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a0QZXljE; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="nW+x/sC/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a0QZXljE; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707989425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ItpbHQ3bDK2Ms6tbFLF9ssZWlzu3EH1B6fIwNh9aF2g=; b=yEgBRMirCHw1Eoiu/Fkc5Ude8iewM5yMMlejA7qoP/URpUSiUYcqbOG7GRb4m6xdkjn8FQ b0LWmo8Xxw5zhbwEA16zYm0XL7y3NkODZSZRq8LmDcoHoZda7/p9s98QULxoy4Hiwdy+8E xcOsF/0UdJA0ns3tdDRWXuS+VgzmlU0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707989425; a=rsa-sha256; cv=none; b=ZT3+UsnMG0efQj6AcCIicHa3cdjeIv+0fgcV0sxRnzawU/eogkBFR1vkAhLqm+bz7wmSSl hJriI8P3Z/LFJvKcfgScRHjCIaQ6rq1yYoEWICHvsMCAMfbZEAKKGL/omfAweymbTdqjUp 3MU6TiFCFE6u1WNP3f3Oq1dC0IbMp84= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="nW+x/sC/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a0QZXljE; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="nW+x/sC/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a0QZXljE; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 71D2321E6F; Thu, 15 Feb 2024 09:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707989423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItpbHQ3bDK2Ms6tbFLF9ssZWlzu3EH1B6fIwNh9aF2g=; b=nW+x/sC/btYdct1t+azeY4/OpFnHWcucp0cgCJ2BLeUqzyr8hp0XmcLLB4ICd8idTcZF8S lN9ro9mvNHm6mB/F09T5I/WtxRdtRCGh9AzG5105vs3BEU5xdimOCY7sr0LXCDsYgtKtA/ KsJUoE0CDxvZOkGBP+UUpQGPvI4qitA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707989423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItpbHQ3bDK2Ms6tbFLF9ssZWlzu3EH1B6fIwNh9aF2g=; b=a0QZXljEiEzIKftYOPfeA0eKZuqWdDB8QuQmlg/PREAHzYbs/k+HNi9VLqLj5quCxNGJTe A9VAUoFRXnXb+xBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707989423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItpbHQ3bDK2Ms6tbFLF9ssZWlzu3EH1B6fIwNh9aF2g=; b=nW+x/sC/btYdct1t+azeY4/OpFnHWcucp0cgCJ2BLeUqzyr8hp0XmcLLB4ICd8idTcZF8S lN9ro9mvNHm6mB/F09T5I/WtxRdtRCGh9AzG5105vs3BEU5xdimOCY7sr0LXCDsYgtKtA/ KsJUoE0CDxvZOkGBP+UUpQGPvI4qitA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707989423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItpbHQ3bDK2Ms6tbFLF9ssZWlzu3EH1B6fIwNh9aF2g=; b=a0QZXljEiEzIKftYOPfeA0eKZuqWdDB8QuQmlg/PREAHzYbs/k+HNi9VLqLj5quCxNGJTe A9VAUoFRXnXb+xBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5D7DB13A82; Thu, 15 Feb 2024 09:30:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Y8SAFq/ZzWUxGwAAD6G6ig (envelope-from ); Thu, 15 Feb 2024 09:30:23 +0000 Message-ID: Date: Thu, 15 Feb 2024 10:30:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/7] lib/stackdepot: Move stack_record struct definition into the header To: Marco Elver , Oscar Salvador Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrey Konovalov , Alexander Potapenko References: <20240214170157.17530-1-osalvador@suse.de> <20240214170157.17530-3-osalvador@suse.de> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 6ogqfd44yon5meh13bth8eg41x93fnxx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 57D87180003 X-Rspam-User: X-HE-Tag: 1707989425-700156 X-HE-Meta: U2FsdGVkX1/rY1CBu6s5V5cBTlkRvcZidu5vQ6pSJ/Fg2FDOc1cjihJC5js5f0JeKmWS5n1yybzmZA0ixO3aL5E6EKRsL6XPsXLmikF9YNHzxxNIDy7mXTBgSQx+crhv4rUC4mbta/G/+n3e0zY4A2bTxPK726h6a9vyYA0blo7BYTecNjdFohi2BIolncF0IsfL0gmuRZlMTPtNqiFG+ese4yekMtxb3uZcukStGp+FXRQjv9nstszIFphsOtR0lwzpD6lrX0xrdo21U+tfE0knAAeMbeQf7UYfkk3oyu7eOGzjDpbzdZuJs0IffwMHC60yj57wv3j/rcE3hBHInGsW52BYEvpQJ6IliTJLYDur/jEWtHx3/up3rQXcCfhufPPnQDFpZLSbk4vWPe1ZRt3v/41PWfxZTEEMzTEMVBdLrMIUqH5o6HcgWx+6hV14o3C7qHkvsDrrzUTwH+//JB4O51HqmMrxQOLVCzlhYKiVVBwd2y74EzD6SwrrRH2nO683fZ+umNnOfVJ5OWJOyPxoabmRz6XUY3FVaRiMAITcSJLlQw8gXnQjYRvMCKzMKfjVT8c91D5hlYz2klr/4QnlJxuulcPTRwGp+NoYlE2hhLQkmNFwmrGR7FvqlDN8PtnKsOxXs5Fj0LWNPZMsQFbB+UQqS9SmVubsRPFnyimiw9yFsmZ46IwmmfuFwcpEY3ygykUD8vd74LawK79UhMraADXEX6Ebp9fdcSt/5tPMeWwk+xt40XdKxy7XvZ9qmmlTyOsyNzlYmd+9Iitva1N2r9n9s/cXiJEUK42X5vDLhP+ikzOknzwJrbtxsxuhBGgrwg+2axtM22TgpAyaSIGsIjD9D512VydDscTIjv32aiWZod0GyPzSfpCVwHngOdKl0Zuu9wS/n0wEo1DHCPFLeAkENaSr3PGjZwDJlibT818zQ/aLSypMvTZB49dzr0JNLcX6hlovSHu6yLY s7b1RRK3 CXYZNuU8yUwuDbzI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/15/24 09:16, Marco Elver wrote: > On Wed, 14 Feb 2024 at 18:00, Oscar Salvador wrote: >> >> In order to move the heavy lifting into page_owner code, this one >> needs to have access to the stack_record structure, which right now >> sits in lib/stackdepot.c. >> Move it to the stackdepot.h header so page_owner can access >> stack_record's struct fields. >> >> Signed-off-by: Oscar Salvador >> Reviewed-by: Marco Elver >> Reviewed-by: Vlastimil Babka >> --- >> #define DEPOT_POOLS_CAP 8192 >> -/* The pool_index is offset by 1 so the first record does not have a 0 handle. */ >> +/* The pool_index is offset by 1 so the first record does not have a 0 handle */ > > Why this comment change? We lost the '.' -- for future reference, it'd > be good to ensure unnecessary changes don't creep into the diff. This > is just nitpicking, Agree with this part. > and I've already reviewed this change, so no need > to send a v+1. But confused by this remark. There is a number of nontrivial changes in the series from v8, and IIRC v8 was dropped from mm/ meanwhile, so a v+1 of the whole series is expected and not fixups. Which means including patches that were already reviewed. That's the usual process.