From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0283CC28B2E for ; Mon, 10 Mar 2025 10:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 119F3280004; Mon, 10 Mar 2025 06:34:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CA9C280002; Mon, 10 Mar 2025 06:34:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EADE8280004; Mon, 10 Mar 2025 06:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CBC2C280002 for ; Mon, 10 Mar 2025 06:34:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0CA75A942E for ; Mon, 10 Mar 2025 10:34:56 +0000 (UTC) X-FDA: 83205283392.06.CB813F0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 9A7B0C0005 for ; Mon, 10 Mar 2025 10:34:53 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZMTtmDnt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Gbicgfoi; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZMTtmDnt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Gbicgfoi; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741602894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OL2Jtr+IMvqvjb/CMqGeFxXeoZIVlzRqDlmMZHJ67DU=; b=UQUQmXrk12nVXePp9EdlpKJj2sJWKhmFwbvbgem17HmTy0ueWrrUz6ueey2Wb4AtzYts06 9am9ADsYqF+sl9EYhwg+eUOCYqBG78btzwI4Uj3fLfIBhSocgV/agalKzt+LKlNxfNoI+K mS0h//6xEI0/f4UUgakab3LkmPI965w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZMTtmDnt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Gbicgfoi; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZMTtmDnt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Gbicgfoi; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741602894; a=rsa-sha256; cv=none; b=oPHZQobX2P/MoR9PVPjUffDywfeUz+9MdZbA92Eg3ogO9nrJv4SS9jWdJY3pVqhTOUSQ4w J3a1YI7slcmEnyaAELy2eEStI4SrwZ76Qu2H5XB4oUTzMkJa6wxQKyXsnokE9MkVMR8Dwh 4GFxI0zeZATDe/oRY9vDVA1OIa1wk6w= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 019A71F445; Mon, 10 Mar 2025 10:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741602892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OL2Jtr+IMvqvjb/CMqGeFxXeoZIVlzRqDlmMZHJ67DU=; b=ZMTtmDntJKGla57oONxZ0+Pdq+lZoSe5Rf0lth9XsjwkfhXf6zw+548dfazGD/LuGiAxxV Dl5d3qOVtvNdepm26CCudlOQ9RAo8WtEq3QhW36j+1hg/uQlWKEC+Y4AVMRGCwHddXBB0L aGvo5V/tlfWzq+dl7BraKaAuMdOd89I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741602892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OL2Jtr+IMvqvjb/CMqGeFxXeoZIVlzRqDlmMZHJ67DU=; b=Gbicgfoig8XzczVnYMHuER/2RSfIILVvVlLhPndHz9LPIUswyLLSETTsrH7Phei9aXTDHC +bjCDJQCc9zq1iDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741602892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OL2Jtr+IMvqvjb/CMqGeFxXeoZIVlzRqDlmMZHJ67DU=; b=ZMTtmDntJKGla57oONxZ0+Pdq+lZoSe5Rf0lth9XsjwkfhXf6zw+548dfazGD/LuGiAxxV Dl5d3qOVtvNdepm26CCudlOQ9RAo8WtEq3QhW36j+1hg/uQlWKEC+Y4AVMRGCwHddXBB0L aGvo5V/tlfWzq+dl7BraKaAuMdOd89I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741602892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OL2Jtr+IMvqvjb/CMqGeFxXeoZIVlzRqDlmMZHJ67DU=; b=Gbicgfoig8XzczVnYMHuER/2RSfIILVvVlLhPndHz9LPIUswyLLSETTsrH7Phei9aXTDHC +bjCDJQCc9zq1iDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E20C6139E7; Mon, 10 Mar 2025 10:34:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rfXcNkvAzmczawAAD6G6ig (envelope-from ); Mon, 10 Mar 2025 10:34:51 +0000 Message-ID: Date: Mon, 10 Mar 2025 11:34:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [memcg] 01d37228d3: netperf.Throughput_Mbps 37.9% regression Content-Language: en-US To: Alexei Starovoitov Cc: kernel test robot , Alexei Starovoitov , oe-lkp@lists.linux.dev, kbuild test robot , Michal Hocko , Shakeel Butt , "open list:CONTROL GROUP (CGROUP)" , linux-mm References: <202503101254.cfd454df-lkp@intel.com> <7c41d8d7-7d5a-4c3d-97b3-23642e376ff9@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9A7B0C0005 X-Rspamd-Server: rspam03 X-Stat-Signature: kmiptono9mo6pfoer7wtotp6975zhj4p X-HE-Tag: 1741602893-873022 X-HE-Meta: U2FsdGVkX1+DjL0lFGzOFH+GTziOK1DnW2djNqmi5dE76g8KWfAyr9ZpvPcBveo5diKdY29IZgrwvMpLEqsNnBtkLfFYOMUT+3w3UDrpOolIsNOLk9bWncsU8hRN6cnaD9wMTpC1W2dkv8ESdKC9kuKj1lrAyxvKwlCDAbxm2vZFEWk6zXfdkDfMhuSgxWGOUvvF2LFWlR4UE3Xgq4ekS+rqRRJSxvbA3GLzn+/7izIBI2rujNtNcHwf7sCyj8gh7j6+MiD80v7EMHSatT4VogO1gP85c7y6TMPRzfRXRU6mGR3NSOrZ9LJI55Vi3fmVWyYwGCJcFvSi5xyv+86DomA6rtJx1FVrLOFrnwOs79QERLc3Ms9wnvFjGqSV9HTQyRtBVOZgZKVH/aSXXmNCAqXUxuHfAWUiCq4IZ/MmM1BBdnSbgFqrGsfcclxZ1jdNwH0xboxKUrZp5XPaBoe62HiETzczqzD4v15TXbZhWQcSHLR1iVpPqSI/5dsWHmHWpokfs/HVV6BJC82cAbDTsf8xoQlt45jDnw4XN2htSFtQBfTeIKdvkYTcjugtCi6YkobGTFdFp5SmKuPs/KhtaSo2RMrkaq+xzokPy5Q8WFxEwtJTyNvprKKORSoXfHT2NVU8IO2MktEOcHaK/HT4WT1+esZy9TDYFscaQVYeCY0j7VbW/EUHgtIvHckLO0sFLAnLl3lDVWA8I5YWeUer1VDoWzqMjdTHbGr6Tm6GUdGYgphQ8GWnnc4vWOfvBblLMGe5wRXiuhm8KZCrFixR0Bcq11krukciAeoi3YzqTW++Y3L0f1GhCX2TAQfVUEOdj73XSDraKaSz946b80jTEdUR8FOsZ4rL+xWl0LT/N1EVaXA/bGIDVl0wMCjy6eubOEwjH6AYIVRoxxZ+Dw7lpuFetElYnO4+7ITQA7pt4Oo3PNur5eF2hdGmy/TEJ2YPNV94YVsGNCYT5JHMjqM 31OYnMmv Z4W/bMprQnHQp3WRAt4mqPUMms7rYybHwqx2kOREKEGvALPomaQ5dMkAojPgZAzKDdy3xeZTMQ7G3te+40DLlCNNxzXKDRF29LE4/yZChn+jtnn5YB24bkuKXmFRY6du8Tq+umvXk4FPTzJvIHe1QLGUbVdEjWlw7mtj69VWBduCyZZ3rat3xDODy3IDZBDwm68vFDmorSqscnQ5NjFdHlKcOfi7gn98X2uOlWWUTJ7SeuSmGX4aYDbjNn3aGqMQAJ4/DK18Xtf6fJUjpalkPeJFulLlEO71eYLzTpIKA/QEBXCl1I95HhaWUA9YfvzO6gS3T6nhalGvkvVgwxZsy48dGxsINhYdK2OEmc0NCgpgpPDgeGCw1XD3j60eT8sPCe2V/pZacB+W8fnxnC4LSSbwF9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/10/25 11:18, Alexei Starovoitov wrote: >> because this will affect the refill even if consume_stock() fails not due to >> a trylock failure (which should not be happening), but also just because the >> stock was of a wrong memcg or depleted. So in the nowait context we deny the >> refill even if we have the memory. Attached patch could be used to see if it >> if fixes things. I'm not sure about the testcases where it doesn't look like >> nowait context would be used though, let's see. > > Not quite. > GFP_NOWAIT includes __GFP_KSWAPD_RECLAIM, > so gfpflags_allow_spinning() will return true. Uh right, it's the new gfpflags_allow_spinning(), not the gfpflags_allow_blocking() I'm used to and implicitly assumed, sorry. But then it's very simple because it has a bug: gfpflags_allow_spinning() does return !(gfp_flags & __GFP_RECLAIM); should be !!