From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEB9C4332F for ; Wed, 14 Dec 2022 14:27:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53A138E0003; Wed, 14 Dec 2022 09:27:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E9F48E0002; Wed, 14 Dec 2022 09:27:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B2458E0003; Wed, 14 Dec 2022 09:27:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2B4568E0002 for ; Wed, 14 Dec 2022 09:27:55 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB2D61A0F25 for ; Wed, 14 Dec 2022 14:27:54 +0000 (UTC) X-FDA: 80241140868.10.C405C05 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id E516A80002 for ; Wed, 14 Dec 2022 14:27:51 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fQwuf/P3"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671028072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PUOCPLsMlvmgNvxqq+xl+qmXFp8RWQPctNaQzKj5Za8=; b=2xP2PwbOcjrOUFYjCFsou42O9gtQq6+jk5DL4a20/CnofWBsbqedKNRV/JCA7pe6nJpWVL YDDX2XErp+4RZpxrIXHQ2ODFMBPUYJ2BK3ip/+OjXN2OxOJaqbsyUitVxZ1ChYzWAEHj9H OASgTe0NEif2FtVvmCPaDrlrJ3HjZMw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fQwuf/P3"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671028072; a=rsa-sha256; cv=none; b=D5cfSNate+dLXhpSsT+9CQlpG9ZMMh5nIl470tBdaE5fKkKPlVYs2P/HAwXgt56DeuaOyu Td5U5M9WBwSqVCjr5OzZ/DS4KOlvamaKQYIxqSeSgqZMi01LOmQALtxI2YL23BSvb3qdzl xhgxjkyckAO8p1Aeu/kLooaAqWMj0GE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671028071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PUOCPLsMlvmgNvxqq+xl+qmXFp8RWQPctNaQzKj5Za8=; b=fQwuf/P3/WyJ2+Q6lkafpaJTPjyTDBlJPlykfMNFl/RwOlRs10fEOESzaA9nKUiuLKZOtc SbFAFk2RScvXll6vy6exTOvKZ0EM9pG7UkOPvfUWE0T6hmcNjMw2jK5pKFGXzGlSNLHqFS LkpzBbtGudg46ePPzeBCAqyn4THgWvQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-187-v8-MHaBsOSaNEoWtQmtoRQ-1; Wed, 14 Dec 2022 09:27:46 -0500 X-MC-Unique: v8-MHaBsOSaNEoWtQmtoRQ-1 Received: by mail-wm1-f69.google.com with SMTP id g9-20020a7bc4c9000000b003d214cffa4eso4249765wmk.5 for ; Wed, 14 Dec 2022 06:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PUOCPLsMlvmgNvxqq+xl+qmXFp8RWQPctNaQzKj5Za8=; b=vSr7HCTk/HoxrRexJC42lugnvqBYkWvcwFk0DPzn+pwe/b7eQFXxvi7bxHZklOKbhL LEKyStXKMi0sKEhnLZwhPYbblMUfn94rT4gfokTrHsk+YGF69gWMoV8Ss4aoJs+f+S1G ahRkNqmeHdBUk5K+0aJDHIJJ44aWWDicZMIINSTQbBIjYQJ9bhG14eqf3OYzJb7R9em+ Lc4+gZQzOFZuD5LoiDBJvkYQ0MTO7YuU6O87zq/8OwPX2UkmMqg955xUXT5G81L11THd Z4RocNlzDBIpY1ejKQNEA8842tjxmKY9mxGf+eVHCSs70f5ywzNderVm7Wie/6bX0m+N iUHQ== X-Gm-Message-State: ANoB5pkSYPSJzulSLNK6P0WUovCOFyG8s9OifQyAWfFLRzU12hCz+1Ct m/u9AJHRmnf09seF+vSTcEO7mzJ8bot8cSH3lhkYvmxhrmb9C1Kw6rJhfZl5vnXYnPmgHWZIwQL u6fTkRZ7ktwE= X-Received: by 2002:a05:6000:10a:b0:242:3b08:51ee with SMTP id o10-20020a056000010a00b002423b0851eemr14250623wrx.61.1671028065479; Wed, 14 Dec 2022 06:27:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6D+MsUcEs1FOJY6loDHWSlpVg1Lbs8KDbj30T68FfG0OAE5mfaDnky52VFD3wc9G8R+3zSUQ== X-Received: by 2002:a05:6000:10a:b0:242:3b08:51ee with SMTP id o10-20020a056000010a00b002423b0851eemr14250609wrx.61.1671028065130; Wed, 14 Dec 2022 06:27:45 -0800 (PST) Received: from ?IPV6:2003:cb:c703:7700:dd7c:92f8:481f:b96b? (p200300cbc7037700dd7c92f8481fb96b.dip0.t-ipconnect.de. [2003:cb:c703:7700:dd7c:92f8:481f:b96b]) by smtp.gmail.com with ESMTPSA id h8-20020adff4c8000000b00241f029e672sm2914089wrp.107.2022.12.14.06.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 06:27:44 -0800 (PST) Message-ID: Date: Wed, 14 Dec 2022 15:27:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm/uffd: Always wr-protect pte in pte|pmd_mkuffd_wp() To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Nadav Amit , Hugh Dickins , Ives van Hoorne , Mike Kravetz , Andrew Morton References: <20221208194628.766316-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: innja5sj9k97nb3ey69rn3fd4sjb1thm X-Rspam-User: X-Rspamd-Queue-Id: E516A80002 X-Rspamd-Server: rspam06 X-HE-Tag: 1671028071-400340 X-HE-Meta: U2FsdGVkX18Tcu2Dw9MVEHcCc2okZCG0gHlPCzKsgJIaWMS71g5PeudVqN5iekJ3V6HMPnPuZAvY0ZQsdkM2Phvdsi9q0hxx7Nb1JNLNbkPya+QzgLUeU/DDM89ZBjuSnoqebcgk0VDwl3ixJ5r+do47OQAVrSY//QIHO88hlExEqWevcC1ULjO0Z0IeHTxtBEQjgMj5xlKTrCxCthkoJarpJiefEc2/tycAZW2yymKAEm7O11XEnES0pCL766W2rEe7AxOQFLy06ozmYDkkbKUKONRW21+Oh41SjDAhrWWmaZ/+8b5UPq6IZ+hwyfdXNGJk7upgAVZtm9WNNkiqhyRo7cyiK1i+UnLGXNqH+/CQkLt180X+g5qO7+rhRJeeiGBogGAdeK/cBz9UcLZw+CJZXtZ30U9ucQQ/ebiFHeCAEvYEIMvA6rOwlW4tw6jZmveqXIq10X7tHUB/KHi/7mII8CWHnoaOQwOYk5c3eGg+OPH/z+ygr44xDD8uXzCeUHquaQeGHHjnTlaKPEJeydYynveDUktamnkqFwPnWKodEcAQyVTAD2xFI7CnNODYSabL3QIF56IK+2fBbd6vPEK2D5bPMlMUjFXtHJ85Bf10y3LQY1RD81iAtS58hnW0zwk0WoWCZxXrl1nK0/3idZgu2y5otM1XPwK7UJNY5He2MwHZGNA/M45WIX7BYBgzeVlIi+f9/Kbv3QsErv5D5s7ymoOe6Bocn/XkTgif6WSWF8oE0sycO7vZkiotqGlalbVNLfCE9Uy/S7S7vStIWbQKzviC/49ee3AsvI0Fc4DIj86HqTqnVaGxHuic8YbictUp4i9hXaPijWiIejQIiWinX7WiF9wNWZLHEiTgLr1kt+V26BjFHdjblYAI0cC/r695R6pqs9WczNDgzPXWQBl8hVSxCr1pmiGwx4zta0+Iq22U1/RHPKPcEYrDshyMuLLsSxD/P1TZtgVlAH2 e/qpNdbo 1VbFMcvrrXpAPDhyZ1mwilNr0oP9suKIXPHP6PTd5xWCom2CU2h1AN6HXM8n3NRt1WxPzqYBT3tcg/gusgrUFjr66L+yZjhdd14XgMNUavdh5YxW0x3KAX3EMEbL/DhwOoGIY0LvNrk/fesN2hQLzCZ/DXrIofIK7dtN6lpgl9BV8/70pna+lZFNbTaw9vZEcJ/HnVfd8Zo0Ki0r6s/8FNSX5q+yfcOcHDfUT3qBJRUiwAyMsHtlObLQuRFG9bUxAItne X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.12.22 15:26, Peter Xu wrote: > On Wed, Dec 14, 2022 at 11:59:35AM +0100, David Hildenbrand wrote: >> On 08.12.22 20:46, Peter Xu wrote: >>> This patch is a cleanup to always wr-protect pte/pmd in mkuffd_wp paths. >>> >>> The reasons I still think this patch is worthwhile, are: >>> >>> (1) It is a cleanup already; diffstat tells. >>> >>> (2) It just feels natural after I thought about this, if the pte is uffd >>> protected, let's remove the write bit no matter what it was. >>> >>> (2) Since x86 is the only arch that supports uffd-wp, it also redefines >>> pte|pmd_mkuffd_wp() in that it should always contain removals of >>> write bits. It means any future arch that want to implement uffd-wp >>> should naturally follow this rule too. It's good to make it a >>> default, even if with vm_page_prot changes on VM_UFFD_WP. >>> >>> (3) It covers more than vm_page_prot. So no chance of any potential >>> future "accident" (like pte_mkdirty() sparc64 or loongarch, even >>> though it just got its pte_mkdirty fixed <1 month ago). It'll be >>> fairly clear when reading the code too that we don't worry anything >>> before a pte_mkuffd_wp() on uncertainty of the write bit. >> >> Don't necessarily agree with (3). If you'd have a broken pte_mkdirty() and >> do the pte_mkdirty() after pte_mkuffd_wp() it would still be broken. Because >> sparc64 and loongarch are simply broken. > > That's why I mentioned on the order of operations matters. > >> >>> >>> We may call pte_wrprotect() one more time in some paths (e.g. thp split), >>> but that should be fully local bitop instruction so the overhead should be >>> negligible. >>> >>> Although this patch should logically also fix all the known issues on >>> uffd-wp too recently on either page migration or numa balancing, but this >>> is not the plan for that fix. So no fixes, and stable doesn't need this. >> >> I don't see how this would fix do_numa_page(), where we only do a >> pte_modify(). > > Yes, this patch won't, because it's a pure cleanup. Otherwise we need > another line of wr-protect in numa recover path. > > I can remove that sentence in v2 commit log. Feel free to add my Acked-by: David Hildenbrand Nothing jumped at me. -- Thanks, David / dhildenb