From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5482BC3ABC9 for ; Fri, 16 May 2025 10:12:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 824FB6B0130; Fri, 16 May 2025 06:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6016B0132; Fri, 16 May 2025 06:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650636B0133; Fri, 16 May 2025 06:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 491B06B0130 for ; Fri, 16 May 2025 06:12:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3850E121D8F for ; Fri, 16 May 2025 10:12:36 +0000 (UTC) X-FDA: 83448356712.26.0FD2DB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id CE81F40003 for ; Fri, 16 May 2025 10:12:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QrgCNNxm; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747390354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EkasRa5Pu2fO21jkuVHfz8uIAEIKEfNxMoCN0WluX4Q=; b=HRbsXjWeZE9WqS6NdP6yXxrcQw7K1yMEGJZKtDWn/i0czxHnV5DwyvfWtx3XQO4xdN/4Wh +RtqoXjZxlWnVdUlTKIzk9AQ3nWolaoPXJ1tYs2WrlX9Sp8M1C2ZrrrwJ0GyKuBZA2cPws xptsSMcPVGi33GMeXEDVTDX8KDRu9Jg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QrgCNNxm; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747390354; a=rsa-sha256; cv=none; b=s8WAh5+xILy6eX/tY02T8S9tGJvrsUhPmZUlYijzOaO4iRMzsVNw718lTuQv4KSWWoEIUc qbDeBdvnk2BZ/IHjZ3QbzhPIbNcvE7tuQLg86wFDScdN/YrHXpyRR+WJljFY8tHOmMB46C J+SM4IJhVsWT3JqtjIzbSSUfxJ4Wxqk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747390353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EkasRa5Pu2fO21jkuVHfz8uIAEIKEfNxMoCN0WluX4Q=; b=QrgCNNxmu8xo2LEaJWJIG7FcTF7KpNS1lvyZsmN0QXg7PqBwSdrRoQrW1Mz+Yn2PeKHURG A0jQ7tYCULTKPki7h4EaXDxcpbOoCuVvjXqvEJJ/KZssKN+jch0n8lkjGnpgUZoz3Q/OWg psmfgL6DyYvbzQID3bjnfzm3WzzgSpY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-559Q7c_EM5WtnbA13fZCxQ-1; Fri, 16 May 2025 06:12:30 -0400 X-MC-Unique: 559Q7c_EM5WtnbA13fZCxQ-1 X-Mimecast-MFC-AGG-ID: 559Q7c_EM5WtnbA13fZCxQ_1747390349 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ea256f039so15565415e9.0 for ; Fri, 16 May 2025 03:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747390349; x=1747995149; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EkasRa5Pu2fO21jkuVHfz8uIAEIKEfNxMoCN0WluX4Q=; b=bl5Z+Lmp6ZZxYbz5iQBAc0Aj/XTxw9aebX/lurM3/G3jLfsY3w0Vt9Hnpl11nnTyun fwBZHs66csM2hSsOdmBrLGVG/GZZYTc918tVKBnKR8DTZ/Z4SNahtAGs+v4QK/SLZs/+ Wyi6lHHXhayvZddmW3wE1EgXzgnfEaD6wWJsrF7MZNTsHl/W5qSumWyxiXHjfbPNolcX lhPsj1Sgf3hSmuMDLUrTCaSqS5d0xaJlynz3UkxN5QzjWcDaWxTgdw0J8k5U7eOWNlfT V7dqAfgfy8OWJh3BDWmQfv77rayH2YP3GokxwNNZV7n8n4sg00de22vBZCD8NtEQy2z0 cCSQ== X-Forwarded-Encrypted: i=1; AJvYcCX2KAJnnZ0BZpQKCRB90GkCQlxf8hmTfFf9OSvWfJdPyVsqqwLmwNwcrdPi128IDflpCzneOdJrlQ==@kvack.org X-Gm-Message-State: AOJu0YzFxBccqZke2olewZ4xPopOZyhlGsI/tcKw1Xea8rTNEcIGTqvE Kif0hkGDT/7IdhOBbAkDmu7+oiMUt2rRutJiQq6fsJ52K+apnZmyvNWIcOb3wE9+YAn1by9cSO/ BXcV5fEVjkqMLCU8PcWwp6jgMkTVUqTaovTO6SKXK5+kKyKpYZt7j X-Gm-Gg: ASbGncsAX8DluW6+JtVvdeDjIEfp26zACaUUHa8QEjbV+0eJA9NVgL/uY5BPiMFZuws DJ/9BhvElkQwfHXsIAa3TkxVFkYB/2m1uqFLBKUIMfjODEGasPNb86NV2PWuT+zb7pBO/VOgQEo 4W1DRCGRNPgJhG5MKtlBSJAK9IcTF8e0IP+owDUgeCClCkeP/WJmMDlj7IMzY2BRdbSsJH5jev0 HypylCYsJpGfpOCZ7sizxfyvEI1sZAiAx+lFfH0ied9MUjNy45A2Vkf7riNU1JFRYUPzH2WtJuP pxRIsp6GZ1x4JsrOoSFwHykh4RMfE7vD5bbBrDk0Asr1OJ5oCziU0Rct1yeW85Q6dy0ISFwagFI RuIWePJRz6dBlAbKR9rzd4mx2J22v4jxCh6v5/H0= X-Received: by 2002:a05:600c:3c9b:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-442fd5a1e4cmr27903685e9.0.1747390348886; Fri, 16 May 2025 03:12:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwZCQ9dC6f81oGCBZ3ShcxdI7vy1GL2bgYoSUOa/epYKuujCLoPaBY8jcJSKZsbz7z8M7I/Q== X-Received: by 2002:a05:600c:3c9b:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-442fd5a1e4cmr27903295e9.0.1747390348445; Fri, 16 May 2025 03:12:28 -0700 (PDT) Received: from ?IPV6:2003:d8:2f47:4700:e6f9:f453:9ece:7602? (p200300d82f474700e6f9f4539ece7602.dip0.t-ipconnect.de. [2003:d8:2f47:4700:e6f9:f453:9ece:7602]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d310sm2400207f8f.17.2025.05.16.03.12.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 03:12:27 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 12:12:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] driver/base: Optimize memory block registration to reduce boot time To: Mike Rapoport Cc: Donet Tom , Andrew Morton , Oscar Salvador , Zi Yan , Ritesh Harjani , rafael@kernel.org, Danilo Krummrich , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang References: <56cb2494-56ba-4895-9dd1-23243c2eecdb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wq71MY6fyZNNvocBRI5W_Din8SVkf-ozd3-hZh93BRE_1747390349 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: i6r4e17wtm3dg7wzu35e9tyb7o1nahue X-Rspamd-Queue-Id: CE81F40003 X-Rspam-User: X-HE-Tag: 1747390353-984739 X-HE-Meta: U2FsdGVkX18SIpqV9qlLVXvNBC3dDi96auUiP8m1TsVGsV+j2LxPB9DNmxLPzCnm1rSRUPXWRpEfNsi/8wWtDxsTttu7TSVOf1RioEjwOr8xBnV8mQxvUF/NMODy2BPRVYcKfzRf6l7fCPV5UfrYofKZNE7Jz2Z3z0tZIVcc6lt4p1buLLCZc69P1V7XBfMEpkJXBz/GXcy27K061m9hZGw+y1+AZcChOeD/7YNMzVNilo3UB6QtcX0WKcGnQScfhxjCloGLewTQRmbYKMZdEJhnrkqOoHr1J8nQGxLTwtMOoR7gcwGcqSi2FwbfNSrSXjEYLaTPjjzl1zsnVeh26xmlbDZFLX8ansSBE0/NI0xQcrCS3Idcxef8BlkamyAkL/Z0wPGq6A4+oLuzUjYKZ0EYE+cYcrs9ZHhW/+HWjyBhDLIGacgHm+d+FnhMcbDgBcEPx4sO8dOZRmmoHoz7G3sos3ulnC4Bo97jNez1m5wGw3BXyoxzbBdyxz7auC3bT41QtxrRSRlK4YliKIkZCJT7hhT8V+Fqmkzaak/JElGptN0LAOvS9gC303Sz+GAKlxe78gm9BvPt8jM1jx16tiBi2ukzjAEMWMV3IYlFsuDsyV4svVz7+NfP0K5sGfXb0V8Fd74qes6vJncikz7uokmIujA9M2IMrJDz7+lt+i8HkovKDVZVDTY6COYmVv+DmzLI1tskaxYMZ18tiowl31NvPDyXB+KKi5pduTr+uHcbywCC//xpqvEhpRGhwEUQfiUnOnYtNunsgT5sjSCVz5132Dkf4Za3ajkkKm2P/KrKwm64NYauHhmyDeDN09LwfSo7igoALZS7Xqsu73zD+BjkYyXfLzj+NitRWVFCYUmeFDcqaHwhdcSpriiE+4JpZW7EPSDQPcoG26yLfMZYmuwQ2qpow/P/ExgTRQ08xq2YkXc4+szR1EU71uQpTjchWtpgVcnT0RCG9BAye5U 4i8H7Vbo 3S5Jv05NEZHcEyPqVd+8yWVyKiP6TV8y5nNC3VLf6q9r4SjnxsoVHDOxHW8fXSvptiOxNmGtZylELaaO/NmSVQjPpCkGaVBLp1A+jz6d1tiHpq0RwKC93WRyYmPz26lRUEUxM5/MdXOMGP557JK85DJ9klg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> We'd have to be smart about memory blocks that fall into multiple regions, >> but it should be a corner case and doable. > > This is a corner case that should be handled regardless of the loop order. > And I don't think it's handled today at all. > > If we have a block that crosses node boundaries, current implementation of > register_mem_block_under_node_early() will register it under the first > node. At least upstream behavior should be that it would be linked under all nodes. At least that's what I remember :) > >> OTOH, we usually don't expect having a lot of regions, so iterating over >> them is probably not a big bottleneck? Anyhow, just wanted to raise it. > > There would be at least a region per node and having > > for_each_online_node() > for_each_mem_region() > > makes the loop O(n²) for no good reason. Yes, that's why I mentioned it. If we have many nodes it might definitely be relevant. -- Cheers, David / dhildenb