From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06902CD4F4E for ; Thu, 5 Sep 2024 03:35:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766F96B026C; Wed, 4 Sep 2024 23:35:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716406B026E; Wed, 4 Sep 2024 23:35:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B65F6B026F; Wed, 4 Sep 2024 23:35:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3E8E46B026C for ; Wed, 4 Sep 2024 23:35:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B9655C1626 for ; Thu, 5 Sep 2024 03:35:30 +0000 (UTC) X-FDA: 82529269620.18.96ED48B Received: from slategray.cherry.relay.mailchannels.net (slategray.cherry.relay.mailchannels.net [23.83.223.169]) by imf10.hostedemail.com (Postfix) with ESMTP id 4869BC0003 for ; Thu, 5 Sep 2024 03:35:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=UsDe89tB; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf10.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.169 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725507233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sqv0e0qkAp5wHmZcV7cPBzn1r7u2Pw6TA23Yco90OIs=; b=4G9LD7fwz1JD9xrLdrc6uoE5ATSLIPDz0Uj9aUPrBQWrVbBzPFxSobj5TcuDF3FsPh8QxI ANcn7Z28xRFOvnm8v8UBeVUskFq1+uolIoy69uvLqPn53+Nisl//OKrRVe/uO5n2yMqC32 NdAe2LzWh3DHRkQoSi0chOOOZDRCZP8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725507233; a=rsa-sha256; cv=pass; b=t+XeDwXCEV6ee7uJ6ebMNeVBOAG5CCfX3gitgkobr9eyk+s+N6H9OcF/xWUY5Qt2ZRIzcD HM1CC2TY7HWTDJezVmsPF3aJOJg696o6iFL7LG4ijVowIcGzRR1X0j7o26kz/wY+onQc2C 1QkjqiOvnAMHIQmjBg13bpT1dfmh0+8= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=UsDe89tB; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf10.hostedemail.com: domain of dave@stgolabs.net designates 23.83.223.169 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D6EB72C6F27; Thu, 5 Sep 2024 03:35:26 +0000 (UTC) Received: from pdx1-sub0-mail-a262.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6C4692C6DA2; Thu, 5 Sep 2024 03:35:26 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1725507326; a=rsa-sha256; cv=none; b=Trz7bC3h4Yky6kz33kOgYl0pzPL911I87IwVZNyUReddSV0yENtO3PIVnKfAFMiZTcRnK8 ocEJONF5dM1tB5Nh7zZnr8RbtV00/ScB5GbklLJfsFYHv+3zV6xCfkgSfqtpWdsb3p3hdF UDPx/8iAMMIV1punbZTXLLdQlmuaUCcbiGl7s6U+UXLxau8MNhCLlhi6jYV2wjJF0V75Vt pkJ+bsPiSu+obEPBo2la0cruFxNvEmMQqXHhm/I3PW1r4nakxfLT8InGqUdUWNzix1o4Z3 ac8O+q/vok/S/jzOFUZXsZsaInr0Pxx66sRjXrOjZyNQl+oRI+6xJVIB9vagEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1725507326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sqv0e0qkAp5wHmZcV7cPBzn1r7u2Pw6TA23Yco90OIs=; b=SjdMY07rbVcTZbkGMdqY6lhcJLUPcJ+q5BWwhvEBHddL+Q34T/7PLRe3HVWQu8uOg5/FQV fSpdP/z1gDbQxRWoArRwz5GFI8o2HX/+m5qh/IOj3dOA+1AfrrrxwnyWxuo5M7XZZF44ZI rQOgAic6MV3kd35/A4npPBmqL3G58xBqseegVo8DOPTg+MtmKU1V4akjMspvJ9wGBdHsvV YG9BgDblT+ggBOn2YSoJiszBqquW/SVrtLP6z3pN3TQfbZWiU6SCxa9vlcGkvWoaEvzOI8 D4iEHFn2ZjLpTiQg71XiB/JwIpj9htjJX/zT/PQrWFI3LJfIAMY2pgTi5ahwkQ== ARC-Authentication-Results: i=1; rspamd-6bf87dd45-4wmp5; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Rock-Reaction: 5bd992fb6fd8a490_1725507326763_2866573522 X-MC-Loop-Signature: 1725507326763:1884108718 X-MC-Ingress-Time: 1725507326763 Received: from pdx1-sub0-mail-a262.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.23.7 (trex/7.0.2); Thu, 05 Sep 2024 03:35:26 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a262.dreamhost.com (Postfix) with ESMTPSA id 4WzlP94QRXz75; Wed, 4 Sep 2024 20:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1725507326; bh=sqv0e0qkAp5wHmZcV7cPBzn1r7u2Pw6TA23Yco90OIs=; h=Date:From:To:Cc:Subject:Content-Type; b=UsDe89tBIYADnq175TNv41WyX2G/T2Tg4gDQM8Q6VMskZGZjnPVj1NkelevY+11CY WbuuCVctBRH1fypGmYzaPjRIpR51dJn0g2DjRzfQB0na89FYF8jEgwc6GC0MThG+Kc i0wm4gwrj5JABnhoumT3MgXet4lvFpGV4xgklSjiVCXbZ0gik8jpL4Ekk2rl87bwHV SZcN1Ljsi1PrMyJUzpdEpIovYJJZOoxMRGUskb/o3zA1NOtDI7+GdLoMKarK9SluW8 kR3sUURMqZbRrp0fNCp2YRtL2ay865jt3piUcW3DWPmI9zh6Hca1x5H1bmBrW36RW5 M8eSpFAp4XJDg== Date: Wed, 4 Sep 2024 20:35:22 -0700 From: Davidlohr Bueso To: Andrew Morton Cc: linux-mm@kvack.org, mhocko@kernel.org, rientjes@google.com, yosryahmed@google.com, hannes@cmpxchg.org, almasrymina@google.com, roman.gushchin@linux.dev, gthelen@google.com, dseo3@uci.edu, a.manzanares@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm: introduce per-node proactive reclaim interface Message-ID: Mail-Followup-To: Andrew Morton , linux-mm@kvack.org, mhocko@kernel.org, rientjes@google.com, yosryahmed@google.com, hannes@cmpxchg.org, almasrymina@google.com, roman.gushchin@linux.dev, gthelen@google.com, dseo3@uci.edu, a.manzanares@samsung.com, linux-kernel@vger.kernel.org References: <20240904162740.1043168-1-dave@stgolabs.net> <20240904131811.234e005307f249ef07670c20@linux-foundation.org> <20240904181543.02de2242490cf233c7879697@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240904181543.02de2242490cf233c7879697@linux-foundation.org> User-Agent: NeoMutt/20240425 X-Rspamd-Queue-Id: 4869BC0003 X-Stat-Signature: unbqeitta97aust9z8gqze3axf8bw331 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725507328-58433 X-HE-Meta: U2FsdGVkX18hteIuYg12pOj3USaAZ7lS3ymNRGAtTOGqXd5nv0C3X4UET998ajAswuLW+FKoWYWFjczaxQtlfpZtdoxiIYrBkpfMBY1B/LxtqHjtI4Rbb6RtoX3PLLAws71/rBYpkAPY+U7CfIHq/FwSpqRptS+97U3WX81WppRlcG8dW4Jf5AxLixZfkAQtatEPpgq9rLCXo2xzzNk5Sq+lw0yh8QrdDpS32Xtm43DzcVk5+RU4BJ5+Wk9HIkzD7avFZTtl364I4Gw+cEUHVfqLrir6ePc5Crx/6XZnQ2d2LNuOMUtTyag5l36cCGROxLr3TL+cQYH0Hy2ERVg6+h6wZz66sgjMN0OVgaFJe9zMOML0eKMtSoilMQstyivXdlmfwmEFgaG+wx+TWLoM8fFAfE3mWH00LedV6JfBrVX3wLkYQBbdxQgXWWvnsx2zlDmWI3J7HyDpQsNaGCIBfigaerXnzlGOk0lgplMiZA9Bjw4Lp2ZIPEbSWs/G+dwu2OI5MMuENMKHuNm2AmRxGdKHTusuJb3RVUHPjVCXnsVDufF7npzTrhgxqkmqooic0TcEjEtARBWGOgSkTF9FChRbzR6s827R4p4iozEomTZKlQS94XN5sBjpqwqFWG1O8FVS7GXd0Mu8kIpIJzTWgXEbmweg6DewjxBDoDDfZWAOMkrMrAcBpNjndOSgLSONswtWqGn9g5cXswSvjPGI6hXE5uw8AGa/t9b0Icf4o99vMkzM0vISnNwJi1tqw6MBR0wwobH1P1kAZpIOC29T5gfQWmrBVicZSK0L/DtxQp7m8ig0uwCZPC/Qyxhq2VeRMttEKDLbMO5UjdZKvNIYbtwsqG6l/Tfwsr/qGBA4mAJ+HbF8AIEWTTU+CrVGsrAAfvrAjrRKUPo/b1v5Gdd4SXWAo3ushGCPggjBM4XLtghBn32hqgOsznE+jzjiOlusX1E6l3+LW1eHEGE1yAr B2xQxTJD 2KFESfrpHHZZiSDKUJNdzJXwMTCKiYUsJETrILwd/39MhPg1ohSNvQ5RDwp/i9BobxE68DsfGbWHNRo6/icZroGgZZASaTj1pDRewOP77Y4rFRoTo5zZVNz/8+JHyJ/DHhoa2lbPiINmWCGkHhMsAhIUsLghi6+FG7qZRUQT1vpw18jd3UxTesHvAIxun4kG/Py4xYO7kIRRDuzNOkMp1fy3H8rC8nb8mpP88DIz3hCjL5MtfCyX6rxmoBbhWCRdoo0yWHGp9p1tJuxyiEAqw2qDlAcKkFWbCEkCvT0lmaXijI4q5HF87VKQo4DI+zApGdCGob9GHMq+G/sbRPiLitwBpj3TKpazsqI3t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 04 Sep 2024, Andrew Morton wrote:\n >On Wed, 4 Sep 2024 18:08:05 -0700 Davidlohr Bueso wrote: > >> On Wed, 04 Sep 2024, Andrew Morton wrote:\n >> >On Wed, 4 Sep 2024 09:27:40 -0700 Davidlohr Bueso wrote: >> > >> >> This adds support for allowing proactive reclaim in general on a >> >> NUMA system. A per-node interface extends support for beyond a >> >> memcg-specific interface, respecting the current semantics of >> >> memory.reclaim: respecting aging LRU and not supporting >> >> artificially triggering eviction on nodes belonging to non-bottom >> >> tiers. >> >> >> >> This patch allows userspace to do: >> >> >> >> echo 512M swappiness=10 > /sys/devices/system/node/nodeX/reclaim >> > >> >One value per sysfs file is a rule. >> >> I wasn't aware of it as a rule - is this documented somewhere? > >Documentation/filesystems/sysfs.rst, line 62. Also lots of gregkh >grumpygrams :) > >> I ask because I see some others are using space-separated parameters, ie: >> >> /sys/bus/usb/drivers/foo/new_id >> >> ... or colons. What would be acceptable? echo "512M:10" > ... ? > >Kinda cheating. But the rule gets violated a lot. The only other alternative I can think of is to have a separate file for swappiness, which of course sucks. So I will go with the colon approach unless somebody shouts - I still prefer it as is in this patch, if we are going to violate the rule altogether...