From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC784C2D0CD for ; Fri, 16 May 2025 00:22:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB4E26B0098; Thu, 15 May 2025 20:22:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A64146B0099; Thu, 15 May 2025 20:22:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 905FD6B009A; Thu, 15 May 2025 20:22:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E9A56B0098 for ; Thu, 15 May 2025 20:22:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4E0CA1208AE for ; Fri, 16 May 2025 00:22:28 +0000 (UTC) X-FDA: 83446869576.15.6783755 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf13.hostedemail.com (Postfix) with ESMTP id 80F5920006 for ; Fri, 16 May 2025 00:22:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IAKRCfcO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3QIUmaAsKCC0JLTNaUNhcWPPXXPUN.LXVURWdg-VVTeJLT.XaP@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3QIUmaAsKCC0JLTNaUNhcWPPXXPUN.LXVURWdg-VVTeJLT.XaP@flex--ackerleytng.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747354946; a=rsa-sha256; cv=none; b=babohLBMlpjC7mIh6+BEAlWt/toduXL25H5if6IAAgQrTif+8AgKSI3wM9UoHs67OAVXM5 x5Eeba0r0rev3K5kRpUyWmJIYoZZDGu8y9NdJySbXTUk4x8A1eGXYCiJk+ZQ0qFCyWO7gA 5Wg9SeQSUSERY4Y8nzNo24ulq2p1uX8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=IAKRCfcO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3QIUmaAsKCC0JLTNaUNhcWPPXXPUN.LXVURWdg-VVTeJLT.XaP@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3QIUmaAsKCC0JLTNaUNhcWPPXXPUN.LXVURWdg-VVTeJLT.XaP@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747354946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U2sAkeu7MGicRsmk1eQ6Ys1LarlK/EQzO2qqYVap+q8=; b=OsTjsb+9l8T5dBblnVLGgOsMOrDoNRttkrdchyc30Y4fMO+niB2cCQq0ZbBXzaQSR55jEH u5+r6t1GUKResMcFAG9O4G8jog9jvrDBwuXMSogj8Jjvdvnbu1eDPZcTrEc9HfhtaDDlsY jgp9Ne/ORiAp7snaEZ1FjxeSDY9mKsQ= Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-742512d307bso2732558b3a.3 for ; Thu, 15 May 2025 17:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747354945; x=1747959745; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=U2sAkeu7MGicRsmk1eQ6Ys1LarlK/EQzO2qqYVap+q8=; b=IAKRCfcO1VIytDLlOw4DNOmu2OTBttpN9wRH+XiukXf7pf79HyAnGP1zn5pXsLTr0K Wit+KR2UXi9tnBsibUYsnad/Bd1ktBVACRQZqI2Puh72OrTgs00AMrp7/fxznvz6V/gn AiC1M/Y8snBmhv/JVGNjzuI15iYQAQc49X3o/ttUAe+cslLQfOz8MttM2sYtQraE2vgs KG23MUuBobrtMnO6Ru25heKw+9JslhlPZ2kxwvK/usdvmlCVEfSqBtets9JzfKM8lpqS isgNEJGMhBERl/VT1br7j6LUSbWEAs+JzFnAfjHonw1/pS4YoSmW5GWNqOE6t0DJDIRJ uqOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747354945; x=1747959745; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U2sAkeu7MGicRsmk1eQ6Ys1LarlK/EQzO2qqYVap+q8=; b=M7cOF5TldqHYsujz6Fc8hTQwuzqG/yKqh5+RCbUvPLcTgoKT2cwyg0K+wK7Bo0Y6P8 66CGgsdBCp5ms0hdAOvJXv9uCslgsvgebBcTh4Rr8sgWr8lLKSkL6EdfAr58ZFNznbSa dPn7y9VShzFp3rRwt5DUwa7DHFommOJHq4eLrPLwz+m0TOQhZHHkVbsX34+dmO9cwc6A AI0tfFkKskuG+2hjgPu7wo+ttSzX/73sby7CWlHldPGvRs3prtbZLy+8MZi0WHaC6VES p+IJaxuhns8HDOpGIdFg77LAnKqWqEXlHfNJDam1alqde6zYgPj/3VQVWPHA+TxKXHnD pErw== X-Forwarded-Encrypted: i=1; AJvYcCVm0tYqTk2Qj5Kj/mf69T0y1S6wBoZ3IVh52ni+PJPFlZE9UhwaPXsPKYc2+8XKfCRTyTOSI3253g==@kvack.org X-Gm-Message-State: AOJu0YzMLEkwtaXFWjLiv76McFftcKDFaVVCiEj3UhYFoWcbSnv9fyLO 7uGJH597aTkROLENnZfwvtIfN2vEZWq29G4RDuYlg07sgEr16l5gS7g4o1Dchr/nDOc4fSfl93d dMhEBEJ/NVsIEjYgZlNfKliCJjQ== X-Google-Smtp-Source: AGHT+IE6+aZ6pB0+4YWi/bOE+1/FrllyYKfVOjrPP4jF0YyDdqPgCbM1S1tbN8ddfEjmhOfVoPvdJc2p2g7nYFoIDA== X-Received: from pfbmb27.prod.google.com ([2002:a05:6a00:761b:b0:736:b063:5038]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4fc2:b0:73e:598:7e5b with SMTP id d2e1a72fcca58-742acc906ccmr622342b3a.1.1747354944946; Thu, 15 May 2025 17:22:24 -0700 (PDT) Date: Thu, 15 May 2025 17:22:21 -0700 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1101.gccaa498523-goog Message-ID: Subject: [RFC PATCH v2 51/51] KVM: selftests: Test guest_memfd for accuracy of st_blocks From: Ackerley Tng To: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org Cc: ackerleytng@google.com, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 80F5920006 X-Stat-Signature: xphbd1gxixd16ip38bhaoxbidmi6df9b X-HE-Tag: 1747354946-739321 X-HE-Meta: U2FsdGVkX19ksAw6h5errV7fOGKGAotMvG82zno5W32o7Mkb1hroZFuiyqBCE9ihEXwN/Ax7p6thS3fn6x0n9JMQ2zjBrvMsshiwtg+ofU8k5zPk01GvQxu+vQ21fHavC1ymBnNSKdTvP7Byku1WpNx2gHa4mbuKEnhqqugL7r2yAgxL0nVvQPONAsjguolQe/QpuO4T5GqKxQdoT2mONyvH/4Lu9mFi68eTJzHUHNRlucqPS62wovBp5aEC6XldJnxbEN81YAkMjIGAHFqV7VBJBVm7JDpQ3dZ7/Qz/MPc81+6mOeFFYq0Qaq/eEkoDsfS5wPOTndgHBMkNaILRqpu+2HMbI7Dnp5KrAbDw878cZ+e7SU4mVmkdl1ODL9s9ampSGPIihelyi6f3t7WhOsK32fuA5CDWC7BP96xQnI7f8BuDuLTxYP4CTb8QpUIyJ0YQVUuoIAo28oNasTPcjhPTtNDKOXJYh7Sypu4xvLyHVj2bhPnbBd7gwSMiuTELv58CzupJABHATkVhfFMHVytrmRKo8q/ruUmJFhFBdW9gOCNElpabyyWsxlp9jHrO5UNC1FBHah6sphXeW+GnagSeuz1P827FEYML8h5k7uDfj2WhnbRm/49DjUpGqW2Y1nUwthux4/Hy2N82iS2lGOH+u/KhXE3V9Hv7MjBkFSuc5f5T9wJWOFWgC/tyEHPQuMu100CdcZJ7sbM/HkDlNIj46VEZazDuyvGGrdTGABFkyr5GcTX83IGOu4X+2HWANbt4UHAfqmshuVXJw/Sd8U/HK/PuW5B5FDHYYoFAAnyVBJ+ilJ7iGIexaZYQjhDB1K55+iLjXGSx3nvbE3co06/ZO9Wpnty9tbXKcHfmiqYseayRlXCCcqtucsjRdzgtQCRwBXvI6RkGVw5W/6bRVDq1TdPIwCTuj2oYoT5j3fbjYukj+lCGhxY4osOvA9WH4tJwubWkEeaQEdkz6aV M2WBa7eh D3GeOZV2lwjAVlFua3SHb7ag4EAbToI4IuMXr9opLGiZ9uTmEDSw9pRf7Tzjb7K/k1wbFTiYxvyB5PW69aB8ukApHLZTSt/eBh/VB64bMewC08CMVV3bNEErxBKbc3xfHI5f2fpz6StyIJwovtH2SZtsUwWUxG8x3tKXzN4Q0simuhyYmG5YXPCzA/XPSxq44q04Apsbj7c8H8+SwkH6StlTsN9TIINBvkFlI2mYsXDBG05M3eFiRrT66Ij4Si1sMYC6mvPSuKrvq3k4fj6Dw27JnrWpfr/zO6pEUM7FVJftura3vhFRsO/b1kOknlG39xaBsKTBCoipHRnakJOdXgKsmuGO7Fjs+nTGIW5fQg1ja91klFINP6vNvvd2oSiQ3SF2w8Ebs9x1UYOddng9eSng3CIRXT4nUtb1CuPnLz7OTcp1MKcZ7oBIBKvrkuVIs67nio/eg8ZSt6WXQ6JUQc/AclL5iWgYdWltCGo8gl2EoswLjRLL+ndjR0Mc0RMC5/t0/X26+xVuKb9N7Wf7wO/pD0qTaTQa6dj/4IGNmm0+LTYhkd/L9zEdyIYoIDPY/IKWJjcBCQckXzNXL8ddhkhcHsMR42NIQQfKrRK3wH1I8cJqkMPqrCIPTvcF5Zzpk2x8BRbjzjqWxvMQ0rCDiq4w5/rdpmYUHIEmvDTWsFkGFQa+/h/v5lcOsgXneoPc3WlCv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Test that st_blocks in struct stat (inode->i_blocks) is updated. Change-Id: I67d814f130671b6b64b575e6a25fd17b1994c640 Signed-off-by: Ackerley Tng --- .../testing/selftests/kvm/guest_memfd_test.c | 55 ++++++++++++++++--- 1 file changed, 46 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index c8acccaa9e1d..f51cd876d7dc 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -142,41 +142,78 @@ static void test_file_size(int fd, size_t page_size, size_t total_size) TEST_ASSERT_EQ(sb.st_blksize, page_size); } -static void test_fallocate(int fd, size_t page_size, size_t total_size) +static void assert_st_blocks_equals_size(int fd, size_t page_size, size_t expected_size) { + struct stat sb; + int ret; + + /* TODO: st_blocks is not updated for 4K-page guest_memfd. */ + if (page_size == getpagesize()) + return; + + ret = fstat(fd, &sb); + TEST_ASSERT(!ret, "fstat should succeed"); + TEST_ASSERT_EQ(sb.st_blocks, expected_size / 512); +} + +static void test_fallocate(int fd, size_t test_page_size, size_t total_size) +{ + size_t page_size; int ret; ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, 0, total_size); TEST_ASSERT(!ret, "fallocate with aligned offset and size should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, - page_size - 1, page_size); + test_page_size - 1, test_page_size); TEST_ASSERT(ret, "fallocate with unaligned offset should fail"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); - ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, total_size, page_size); + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, total_size, test_page_size); TEST_ASSERT(ret, "fallocate beginning at total_size should fail"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); - ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, total_size + page_size, page_size); + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, total_size + test_page_size, test_page_size); TEST_ASSERT(ret, "fallocate beginning after total_size should fail"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, - total_size, page_size); + total_size, test_page_size); TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) at total_size should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, - total_size + page_size, page_size); + total_size + test_page_size, test_page_size); TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) after total_size should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, - page_size, page_size - 1); + test_page_size, test_page_size - 1); TEST_ASSERT(ret, "fallocate with unaligned size should fail"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, - page_size, page_size); + test_page_size, test_page_size); TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) with aligned offset and size should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size - test_page_size); - ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, page_size, page_size); + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, + test_page_size, test_page_size); + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) in a hole should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size - test_page_size); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE, test_page_size, test_page_size); TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); + + page_size = getpagesize(); + if (test_page_size == page_size) { + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, + test_page_size + page_size, page_size); + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) of a subfolio should succeed"); + assert_st_blocks_equals_size(fd, test_page_size, total_size); + } } static void test_invalid_punch_hole(int fd, size_t page_size, size_t total_size) -- 2.49.0.1045.g170613ef41-goog