From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E2AC2BA18 for ; Fri, 21 Jun 2024 02:34:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BE606B036D; Thu, 20 Jun 2024 22:34:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26EAF6B036E; Thu, 20 Jun 2024 22:34:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E8676B036F; Thu, 20 Jun 2024 22:34:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DEAB66B036D for ; Thu, 20 Jun 2024 22:34:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 95FB0A079A for ; Fri, 21 Jun 2024 02:34:12 +0000 (UTC) X-FDA: 82253326344.04.3DBEA00 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 8B194A0011 for ; Fri, 21 Jun 2024 02:34:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jKCEOD27; spf=pass (imf25.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718937245; a=rsa-sha256; cv=none; b=wRZTMMNyQeKVp/4EWmqycUGQVyh1FyrZRbm+zSCQjFD4Da9Ol9iPbPG1pB7Wo65OPpRfQb 1VbkrKexkI6FSKm/s31gh1Hl26EiSTOP3NNG8w5B0Dsa5zi5axEj6HHEhwIjc+UrdI4rG7 i2Kz5U13Lrfc5EFEj8/qZBGZqlzTTNA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jKCEOD27; spf=pass (imf25.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718937245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xOSvEcBvsy+ngNco/Y74YnnM9ZOkN9kg32lW2fgmxos=; b=VlX4EQAfgkI1CY1gSc95ESJPsxpJ3rIZUXFiZDY8lumZXcQZmVJB6/qzyEg1hu1Kc8qyeU lRVjLuA9iil831BtqPwi5g+yRrJGiFOWAory3FYHz9hwvy0TJgNJ9pAYM0welxnQEuB1O6 FZIJRfkjPajdkgi3uBL0mQjGjX7WoGk= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1f9cd92b146so11322425ad.3 for ; Thu, 20 Jun 2024 19:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718937249; x=1719542049; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=xOSvEcBvsy+ngNco/Y74YnnM9ZOkN9kg32lW2fgmxos=; b=jKCEOD27lMZPCg/Srj562+uC+GhEZyzb4/EwFsriqtV0hIoQsgfi+ldtbA7EhdRKa5 LkSnv9YkyZ1b2o+PifvpmjgWdlzt5W9yG7KSomdoRvUZ577vc1tNfkTCmoAya7+hT0UT PPEf2hjJVdMWk0bKwad7rKX+STLhWX/25LakYxCtjGF9h4YCWNxKWwW0sLdmvVTqBdnl 4iX8sbRg7wQ1gwS2djmh5zzM84G/Bv3TtyXPYRqz7vr/WgbWAeTF8gRiJm5ztOTdkF1y fw+TZAm0QIezwan9Pey8xqWo/INCUL9+vfznllGjIjMCyJJnDUBLJ45EFAimDhXDX0Ud 3gKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718937249; x=1719542049; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xOSvEcBvsy+ngNco/Y74YnnM9ZOkN9kg32lW2fgmxos=; b=bKk7+ZduMPcdy5C8oG3FSg5BD1cZfW28wuiJ9m1MgXzx5ABKaLLKmWQKaMgaray5fH Sw6Xb37W306yQM7e4I7gS+A6iKrmRnRkaoUS9MyvT8u2TpTZp71ABeYuznDWXX6vnQrO sjLP7Yja/xU9QRTtSL0KpkEtcdwYfw3PyseuTGeMBqpZPqC37J1jLeYxxmSd4IUXAn7T X2VGJJ/RDwOR/+faBOTeSS5dkCYClzjLcoK16acqJ4aQtLIBy2oxcjBZRuBRI7WzeKKf sjf8h0PSBTjMOoj3S4mLRp5XaLrVRcrPm9qmUPhCm9sj3vv0rX5WXuRy5qU8uOwdZ8sP in1g== X-Forwarded-Encrypted: i=1; AJvYcCWksgvWOONj3U/gv6Unh6exZCmdd8Fhdwr5ZBnzo0tH4QnPjjYSzR0qYlQROL3IVeuHeqlKLKJCqTdEHJzPST7P2Zk= X-Gm-Message-State: AOJu0YwCy8QFjJpBo+Kev384Crjsj4p9LG2byWmVVCeKSfV4yL7qNDMv 1ADr8GIYh3DyhX003ZSx7IOWQ6332ArRSwgmKru3fZFTX5Id5XsE X-Google-Smtp-Source: AGHT+IEkQd3WF/jsdK3ArKdymc5kN9oI6GfUyT3wmR8NURh+vRJqB7HbuLdN0Efqc2QS8uG8MHuGvQ== X-Received: by 2002:a17:903:2311:b0:1f9:b1a4:d43e with SMTP id d9443c01a7336-1f9b1a4d7bemr64819325ad.20.1718937249298; Thu, 20 Jun 2024 19:34:09 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb323982sm3292505ad.91.2024.06.20.19.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 19:34:08 -0700 (PDT) Message-ID: Date: Thu, 20 Jun 2024 19:34:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch v3] mm/memblock: remove empty dummy entry To: Wei Yang Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, Paul Mackerras , Tejun Heo References: <20240405015821.13411-1-richard.weiyang@gmail.com> <8d6205d4-18fb-4e98-97e6-db226dcf48f3@roeck-us.net> <20240621010713.cyai3pkucbp7v7r5@master> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20240621010713.cyai3pkucbp7v7r5@master> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: bg3xafkn3t34345y7zhiwewyd1o4gi8n X-Rspamd-Queue-Id: 8B194A0011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718937250-12480 X-HE-Meta: U2FsdGVkX1+1eUgL9Mymr3AQOheT7FeHR7BwplRjzmO55U1Pb1J+638DxVa5wa6WyEWzoUlAu4f5vEU6MEv3X1sy3zGX1ElkGztRo8I6/X4pSZlo4/wqDgv5UU8vX3g02Vb+SB69AuyMhaxFEZL4WILTlH0/vxYUcEGGl9+RbkNYnEZD7rQi2MJJ4OkVJJnctKDmP0W7ZW/qmmUdC0Ixg0qarzitK3fCilpGrF7a/KVRHgvst+WoXksLTNPv6O7SnJ3xApGtIoH07NUKQLGqIb17l475/3DMXEJP4wZn71a/fZH5wevKIJQfkYKpypMN0BYnFDzXIpy+7/avpDQe4Fz7ysPZrgkiNfCKYaRke6jtKqw4iyzuW1rofU4J1gotBjcET+sTWur48L0dTcUQ4qP2x3sqc1qO/3VvLDZknPZrCAQP4A+EuszXaXOKGGh7MpvTJWPGVwNnJMVoR75DA6/lxi4kFGAFpzEhLlFfEwWTQdErmWi2hQBxVz1rULdT6AsljG8bRwot73lC9KOMjvTnQfXRwXd5avqQU+NeM/hPFAPUzKpH789q4slfV/6MYoasvc8jvQ/uUT8Pzxj2vl/g3DDlT1qIVTeYnOYnL8qDBhstUjlYwm1FiQVTzT6A4gsRZiV3eJMd3deQNqm+Ra6QvG7RGaf4taA9vRhoD0SNDoPi/Z8698lPRh5JfL/kpM1XyYvxjgdbPZj8Zxoj8lkUddr1AfDpfc8KhJNVOGivid9LCsXI71eyjKdFyT/wAQD4pO9elHP6KmEn+qr+lGTr/ZPFGk3/7pLY57sSGYK7MEVe1z/VxwcRt+jKEnhNzjyHwbSzbflkZrOQL8SHIec85N9wOqEO658VoECsC9qnNwK4ped40/4NlJft0ykP+QST6OdEM+wu03ZII+tZgF+GkdfpYYFSniC1CyFc9OovDfeX5/V+3T/cugzGHyiCK/lK4aqjVklfTPE9VLA v1vJL9Hj OkPL58pOzNP0fXbXuzYx8LhqX/BGujiL/oBHe1fqv+8NK9K+X4egZWMC8F1oQzcJH3D5olubISdZ4gL991J2uQJ1jSwXQ8qmVtR+4VZUaugiFLTiluZBpWrl8e+xy8NTcib098LNdwoq25eSrfr35QB5QHKQToMYWZr1l15RQS/acvWrdEDVfpVYhW2YrE3WdNPqDtCDk1xtJyaI3KSBmD9WMSoVs1d48Vh13b57w17iYgVjJ0ZSQqsqUs+veYoWPi6AuEp+JQoJHVrDXAZTZVcaOLBEgILHIzltxeGoe1wM4YWGOQVV1f3iO6OYaV6si3DdH3hUR1IpJcmVtvl4mRgPef511NZVasfE77Y1NrAq5Y+tc8XPEoFPkkWZweYX/GL+eD3QRWwckAgMarC2lyjT5ZbSU9U9TnJojWZ+lCSl+Zkpq6srfC2gl07HkbgKDVWNN06AdJUcYGzNgml+Z4i+5UeAYogW07tIphemjx80ZgcUJ5t3/6EQjGVc8IPf7iLnml/g9U79KRZZp3FdFuCP5D30/SN8byl57kaJDEMqFr2aDgvtAJQdnmK3LjjmO8YBQpgbvyj3GH949eAdYSD/p3xZXdC93m4lagEZMfn6UNtAFy0znyBQpn2OmhdrMrBPvuKtXpgc7HFp0vHYLJitjPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/24 18:07, Wei Yang wrote: > On Thu, Jun 20, 2024 at 02:58:17PM -0700, Guenter Roeck wrote: >> Hi, >> >> On Fri, Apr 05, 2024 at 01:58:21AM +0000, Wei Yang wrote: >>> The dummy entry is introduced in the initial implementation of lmb in >>> commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization >>> use it."). >>> >>> As the comment says the empty dummy entry is to simplify the code. >>> >>> /* Create a dummy zero size LMB which will get coalesced away later. >>> * This simplifies the lmb_add() code below... >>> */ >>> >>> While current code is reimplemented by Tejun in commit 784656f9c680 >>> ("memblock: Reimplement memblock_add_region()"). This empty dummy entry >>> seems not benefit the code any more. >>> >>> Let's remove it. >>> >>> Signed-off-by: Wei Yang >>> CC: Paul Mackerras >>> CC: Tejun Heo >>> CC: Mike Rapoport >>> >> >> With this patch in linux-next, all microblaze qemu images fail to boot. Reverting it >> fixes the problem. >> >> Bisect log is attached for reference. >> > > Thanks for the reporting. > > Would you mind running the test to take a look? > > It is in tools/testing/memblock. Simply make and ./main. > This is a silent failure. There is no console output, so the image crashes before it gets to that point. Building microblaze:petalogix-s3adsp1800:initrd ... running ................R............. failed (silent) ------------ qemu log: qemu-system-microblaze: terminating on signal 15 from pid 2343410 (/bin/bash) Guenter