From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AEFC021B2 for ; Sat, 22 Feb 2025 10:52:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279356B007B; Sat, 22 Feb 2025 05:52:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2299A6B0083; Sat, 22 Feb 2025 05:52:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CA006B0085; Sat, 22 Feb 2025 05:52:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DCB3E6B007B for ; Sat, 22 Feb 2025 05:52:06 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8C429B2307 for ; Sat, 22 Feb 2025 10:52:06 +0000 (UTC) X-FDA: 83147265852.29.CE4B18B Received: from pv50p00im-ztdg10011301.me.com (pv50p00im-ztdg10011301.me.com [17.58.6.40]) by imf08.hostedemail.com (Postfix) with ESMTP id 98B67160005 for ; Sat, 22 Feb 2025 10:52:04 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=Ao4p1n4T; spf=pass (imf08.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.40 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740221524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rgvQfOLC7f+M02f6hvzxNZIZUkpYeai7A7dWzk8uoIo=; b=z3n22uJTtZC3JNNPeXIb7niDARk1zEs+rTDDGFGmw5LqMwdTatlD1MdwIv4I8e2Usteo29 7QMVP6ADruUKIf2QeXzEGGS/cMgT8ijmm8GnCmql1E0SBbmlzNSGqOBLigYeUz88G9Xib2 uUrLt8DuHZZ61fxuTWC151e2VsEvkak= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=Ao4p1n4T; spf=pass (imf08.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.40 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740221524; a=rsa-sha256; cv=none; b=aV9c3FTA/WqHxATCu/cB6Xqru4eakJ9zlAoWFIPpUzDLfYTpNySf1/kIgpVHmilbRDLtSt BF7SryTXEYCm3Sp6f7qvem2v06XZUdbR+eyAWNFzpV7+hc4ERUl6+1IEzAeNXvDpcOXvLA WrRqUuTvuoJTTxbUn+dQJwyl/N9HiGQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=rgvQfOLC7f+M02f6hvzxNZIZUkpYeai7A7dWzk8uoIo=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:x-icloud-hme; b=Ao4p1n4TrSRRxXxkSH05UqzT/HgGCVsxu62sY49QJR1PuEtvfkjoljG6DYIsPV1Jo Uoed4vqcpZcyby4LnXmShg/OPtqYjLumfWHHUDlYfNqQ6dQN22Ftnqmx6O36rZw4pn Zow40fUE1JPdJ6sCCjY/WYjE+FPhsJ3Qn3uALPQJvHkyeXkgHkQYcEmil8PulKL+fJ fUkhds+oHSvwMCTYtsOSOPQcBSN/J5AwXkpjyTyw6eT8WOu4oEaeNQASEoQIT4MOfi C0yQ4S9F9AXSKb3ZkHgdSRi1KtFKXciIEp5TNHrDn78nvw5GkDRlcaWTiJS2gmJ4GI tcmo7WXp+ddNA== Received: from [192.168.1.26] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10011301.me.com (Postfix) with ESMTPSA id 56304180100; Sat, 22 Feb 2025 10:51:42 +0000 (UTC) Message-ID: Date: Sat, 22 Feb 2025 18:51:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs To: Johannes Berg , Stephen Hemminger , Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221110042.2ec3c276@hermes.local> <9af9413b7ab41c6b2db5f862d0fa50e9de279d67.camel@sipsolutions.net> Content-Language: en-US From: Zijun Hu In-Reply-To: <9af9413b7ab41c6b2db5f862d0fa50e9de279d67.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: f652v4ma64Vm3Io7f6-KRKFfH-wFIu9m X-Proofpoint-GUID: f652v4ma64Vm3Io7f6-KRKFfH-wFIu9m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-22_04,2025-02-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0 clxscore=1011 bulkscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2502220087 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 98B67160005 X-Stat-Signature: 61pqukxuyobiu3qfqskyzupsrdddm3tz X-HE-Tag: 1740221524-565781 X-HE-Meta: U2FsdGVkX1+jlOD0bmSD61WIw4mayK+NTSdThsXexfQ3jtIk2giugWl9BoPmiJbIW0COSs4a1R3xP/9XUV2z8jbPFGIO03hTtv8aD8gpt0spMyPukijFVLC2K0SULsP5JsmyJj3vIJ2xqvmPUEyd0ii3GtRcnvB4w/XXlbPwLvEG0GIYRIrEv/x8hYH6IxQbEmkA8XZXQUt3xcSsBZVxXUUMjyR1tWzA0hdEoec6CXiUshccWum5+SGPB2J9xmYBbRo6JM2lSSe+OS3ZSq7KJ0Xy44ceNEBeLR+LbGSBbjykHPNMrnhVi/Kd7NNgFtJF6rrMaTY85K/v2y6cAkF+B4znwM/sw63A9W1XAhRfOCRN8i3uKRusTz9VsWdf42Llw7DGMjqiS9j9swuuc7UYtD61tU6T57AT+hCMyHDFUIRLf53mz2gSH9XpExgaLfPzL6WsrS3DF+HkI4Xh/K7NfTSwlZ6W9BinmzF40zXKApGTXUVyDML3CFsC90uAuv+LYrVFKjs6l++RFdsY1U9C17bUMB6989jkKeHgZZwZ4kj39nk/rzCOhlsxJ1u21t+gRFpXJK1kLpelxZtqh8cPjUZUC57AW5mtsM27CkqvRacfqQt4n60RxPduB9aLkMSDbcNn2hwM+9jd/GyqAy6aDQ25GY+0QXtua/HnMy5dgC3OV0j8NcemefAEeI8lwv8+1MdbNbbbFMkUc7mf+1lZ9Excf6rWFvZf2w5Lc91uq8+oGe0B0QAIu9sFzmjMfqtdlNorlxflqo1Ud/4vpil74R5qXmC7N0tmD+KwdBBhgOLg8pysOebbY3cp5EtuKRogKBXTM2PkcPk7+BYTe7PuY3B5MhKRbADm/CiXKu3lgrwtERQKg5lovNB5TkLexVnx2acCgmwoXjDESEOJdFYh01iY3oYyEXCi24kO6YakM6aqaCXDyua0qQ8FOQgCa2lI12WgDdaDnevKvxObYeQ czevvAHh nPGY4mLu+DNglaZhBx8zuMo4Ju5hTn/id29aRVUTyBIcjO7pzmNm52nnyNmzXHZpAyoZOc5nq1+03fSPE1zbDDeIJxRvQhsk0pvcHii7hBFzvx0+9O4J4o5WKSnG+cbDshJmcATkskkW3ICl9CYEwO4/FjMGTrSBtKj8uA36NA9anKOnqF6UtDKRLjfXcCy96Zz2q+GuRio7tFtE/+rJhwGvXhYdoP6GIR8MpjJA6hJZe2G4TZgJ7UIUbN4Pp0PcP/PgzpNo+UpOYi7RWhq8Ff0Y9ZMXzScZiqMv4RkB/slEHUYH1ZPeET/ImDcXPQ0aGx78WWXd1XS+5uOlwhaPvULCm91DmeUiY5sMrwJr2V9Nr8pPBiaFz/YHoWMuGwgHopJbwvExQfFYGkJ3NXEc0Es4dy4rTwEpUltAwC1rx2/oRDR5jClNuzlxCcooN56b7yK0sdj59whdrPmA0JkE0Afd1hluywJ8rjdidIgM0Hfa5onk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/22 03:36, Johannes Berg wrote: > On Fri, 2025-02-21 at 11:00 -0800, Stephen Hemminger wrote: >> Is this something that could be done with a coccinelle script? >> > Almost enough to do this: > > @@ > identifier fn; > expression E; > @@ > void fn(...) > { > ... > -return > E; > } > > > It takes a long time to run though, and does some wrong things as well: > if the return is in the middle of the function, it still matches and > removes it erroneously. if return is in the middle, we may need to convert the return statement in to two statement as [PATCH 18/18] does: https://lore.kernel.org/all/20250221-rmv_return-v1-18-cc8dff275827@quicinc.com/ namely, Convert "return func(...);" to "func(...); return;" C spec such as C17 have this description about return statement: 6.8.6.4: A return statement with an expression shall not appear in a function whose return type is void. A return statement without an expression shall only appear in a function whose return type is void. so, do we need to treat "return void function in void function" as bad code style and make coccinelle script check this bad usage?