From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EECAC19F32 for ; Wed, 5 Mar 2025 03:26:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACBF9280002; Tue, 4 Mar 2025 22:26:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C59280001; Tue, 4 Mar 2025 22:26:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96B08280002; Tue, 4 Mar 2025 22:26:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 75392280001 for ; Tue, 4 Mar 2025 22:26:52 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DC1F1140A74 for ; Wed, 5 Mar 2025 03:26:51 +0000 (UTC) X-FDA: 83186060622.26.1D45686 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 59E4940006 for ; Wed, 5 Mar 2025 03:26:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=aZEEGkea; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741145210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yKFINBa+Q1e4WG77Sg/agAnuGFQablMbFUvpvYj4kDs=; b=CWrDwFGoNUup7/LSMB0JWtGonrZMWJMsM7oq9qvy/U3pK9AZejt+gPeRMzOjL5WDUJS8ct Kp//inByShGmQ62QvM6K3LneeVxcv/mIZcHdT1quuSHRJeht6GI8Opr15lc7ykuoAWYUa0 Kx3FCDbITIqlnAvxuYFWUvQgIDlI0BE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=aZEEGkea; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741145210; a=rsa-sha256; cv=none; b=F4pqMiV8y+svm/WofuKwzIa32pxbfRsEmPhG0f033+fNo1li8BbfXtjTMmzN0eeN9RGLxO VIsZJQTULdbQkA92MFl5nOsrjML373EwYjTT2/RQ0KriDZPZeZ4q/aKA7pm/Gc/j49ZAu7 6oDcqpCH8I9wd/swLMS/OhyXzgWLGc0= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2f42992f608so10103800a91.0 for ; Tue, 04 Mar 2025 19:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1741145208; x=1741750008; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=yKFINBa+Q1e4WG77Sg/agAnuGFQablMbFUvpvYj4kDs=; b=aZEEGkeaCsDB0QEPp9NPM4pGWm8CgXmvnhuBIugS0l+jZuFJJzG//YHuEPgMi8vZQ9 mx7YCpjTJWMjM8sjVCxVjaCRd7iJUh/avao4l2aaRj75UodNSS3XGCJJhQaMkEETeO2F +lRUrDnIeLGDlGhM2J8hmeK3JpDiWTC0l3NERSXFR3bobmVD/DCj5ZfGkzkRre7gQ/ji WKTWWJ2cL4K+UqpTeUQKLBLHvkwfA6xsCFZRoJvymEj8bcmlVFYIV6xZYUwWFp2DfWgj +iSHIqGVvoksYRY54aUgVERmjZ2n+sv83FaqCe5A78MOsU7HwgUsov4K2qCo8GH8fZmq FNGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741145208; x=1741750008; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yKFINBa+Q1e4WG77Sg/agAnuGFQablMbFUvpvYj4kDs=; b=ufVJJ45T7c8oDjjgWV9fir5E36rD8OynagZbHwZ+4yk92XZ7yH4Lym0oYoiqw4zq6H fsCN3/yF2bnGyucrYJcmElyNSkNibRgrouRZtrVnyGMfFPSvtLgS8oQKOppS4UzKkIam coAI9+xC6hVHh4Fs4oTXepiXAgq31Z+gCcbcXcnrH/YM7zhTG7MVv6/EKC0JJxTyWzh5 Vv6+4MdRGbzqjDJ9Wdut9IkGYDEytLebRj1CTtGOXSpPxnn7oS5U8BQVcFQ43kowt/dW I2RL2Bae80NQ+U9GjJU5sMa9khejtQAmdQw5+lnfTrDZTbm+dCouHy9eEHlwo0Q+qe4p yCPg== X-Forwarded-Encrypted: i=1; AJvYcCVlzxaMvsqnMjpH1VnVzCB+VoCX4AyVaSr192PA2KiIwFszOhQZA+f1rOnWWZ1ebJY7ZZgAOdSsvA==@kvack.org X-Gm-Message-State: AOJu0Yx1OY233mB/TWIQr/vinfAZeV/qnU/5g652OpmWirlUMRXCC90m +AkfbnF0xSCxTnQ4gUeKuGyikPOw6ZqXNWuvz7uFO46aQQS6TPjBoQYfvfkSgHw= X-Gm-Gg: ASbGncvDU8jaLdmhNazDzbzDPtDhFDLR3sPYAkeDKT8RpU/x04XWahbczFlnrCa7fus OTZEsrjxAFAefPkVbD4duGYwXOqbLMvHGL89RUyoIu7No5U4sXfWEAgqOHvyaFxPcPWO9EmQj4n 830yKDhrch+ph5IG/C5YKTOisOnmjBp6/N+HLwEb3Kw+QcvDjmCmAT7vJCa7ZeGLq5SZyJ0KN5U eCjutYxZh0E49agegYhVfRuh9oSU4bAeAz4B66ayhJA/sZ/vKNQU5N0OZJWuzL8twD3NfexC7Ym q+TQNt5EM7lTJTyr/WcRx6QJYSVtKmj9y/kjR2D2Y4i3RK5+7RVuAZjf6D6HESAgfUK0Sw== X-Google-Smtp-Source: AGHT+IGBGORdCLvFd42QG25wNcfjd3DkQHwAlOsYf+nq4bbOhvYPNGfhM8vZksdKWT1yBD7TzeaJwA== X-Received: by 2002:a05:6a20:244c:b0:1f1:235:a358 with SMTP id adf61e73a8af0-1f349449723mr2570710637.6.1741145207973; Tue, 04 Mar 2025 19:26:47 -0800 (PST) Received: from [10.68.122.90] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-734a003e28fsm11741707b3a.127.2025.03.04.19.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 19:26:47 -0800 (PST) Message-ID: Date: Wed, 5 Mar 2025 11:26:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/shrinker_debug: Fix possible memory leak in shrinker_debugfs_rename function. To: Muchun Song , Liu Ye Cc: akpm@linux-foundation.org, david@fromorbit.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250305020123.605496-1-liuye@kylinos.cn> <99A7645C-B8FB-4F28-B4B8-D5372F4C001E@linux.dev> From: Qi Zheng In-Reply-To: <99A7645C-B8FB-4F28-B4B8-D5372F4C001E@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 59E4940006 X-Rspamd-Server: rspam09 X-Stat-Signature: 335w8mucm6az1pwtpd3fi9fjqt4pas3e X-HE-Tag: 1741145209-402879 X-HE-Meta: U2FsdGVkX18fIIZ3IyYWEcY9PP7tmboQ6s6ow0WRgHjXx86AI8JPUOJZPHlUN2jsmRlnv7Is7fV9fp32RE9JtJ0+vV+ZvkgQpD7XqEAnCNoes5tCPRYaedhqhq7zR+OIevzSIwmr/KmgaFScl1o1zoYAZs4EnOkp+TX8dRK25otJV9JaHtMK7HY8UsiAJB7zFZI9VV7y5BaXVAW5FCYZH++ky/NKiSBFSRtRRARk3dnMmrRGp/cKc/TJZ7yUl748Q7D/Til1XRPiLpyTNxmfapNwefQyegv9QR/C/gaRKEy5laHjCwKGLCJm/bKV7goFo8U5O7PGe1KFjn1ACMx4VBY9xFIhYbuUDRV8YXrM+A839HQkDudOTUlJp7z+a7LtB7kc9kP+oWgvwxXczBYYglJI+MemJjh0Oii3z7KUaUWaV2GIprA1cOjjKbcsrA7IZsZ7C98G48kRd0cEmnvsUCopI/9Wn6dRr8GAGETqgoFpbRA7/ML7q2ZL6yVeBB3MCA9Kn8YHb5+5x8GWCZqZomsPeRojHo19a0/agocYkFclow/39dJipymiudztBbUbvfIcQ9Vn2nXL43omeEZmRAF14a4GoM8CNaS7cdhvsy84eCs9hoBmmd54KQKmzl96OFkT6fkBb9W/9wbwVvbIxVOGct3AurraXBLBGWBpJviI5qsyGIzJ0aitDZTq0+mkhpwU0pyM/rHmvw2zOslJQJZpN4oOU3Lj9Ai6EkPiWf81wa8QM89GEjUYFFqGBLfQHL9fw+L7qMf3fyxVbS0g5NDqBlxYHr8OW7I8yDzqxy3VmmVCu3ppzhb2aRLlPdYQhqyVYdpz+UmoEzJD0XRbrV44Z006CG0gbSbuBMz3pxXMn+qGOmnTHMIF5SXZo7/N333RvYenVl0tjD0JrONYme4jcM7Prsu6Llacz40tO45Ifz/g4SwsvExPVV/x9Q3NLttzMT2nsG0bbk16yEO arqP3U/r WptcvZp6I2Py98Ap+z3AZb7sFWAcdP3vs1CiTA3GknZEgc6b0hz9YGVc3cBpj1lS6fQJtLocqb816AUQTcQKL6PHFkKF1xBNM0DvdgjXt+lELeTqk1S6vZeiGI0sPNAEuceNNegx5zbpxZ2kZKOulplZViI9UwHO6J/+sfomFyFWci00AyUXpemf/hV8WHNDgc+gC1RuXGLA4uRjiExhaDHDU60btIlAhG0c+5HpqwTIB9tZomt21xA1x5ARczJe41k3iRFCBcBigRL6fpkGeIPSY3USngl+gQA07E2KGkSIlcO2HI76f02PFzrVSvADr93TUGlRshJ/VT3seTVB0SkLCsU9H23KjuGsDCuMbg4bGYbTfV8+AqKme7ksyZKI/33gD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/5/25 11:17 AM, Muchun Song wrote: > > >> On Mar 5, 2025, at 10:01, Liu Ye wrote: >> >> After calling debugfs_change_name function, the return value should be >> checked and the old name restored. If debugfs_change_name fails, the new >> name memory should be freed. > > Seems it is not a big problem, no memory leak at least. The effect is that > the shrinker->name is not consistent with the name displayed in debugfs. > Right? But the improvement LGTM. So: Right, so the subject needs to be changed. Maybe: mm: shrinker: fix name consistency issue in shrinker_debugfs_rename() ? BTW, it seems that the callers of shrinker_debugfs_rename() did not process the return value of the function? > > Reviewed-by: Muchun Song > > Thanks. > >> >> Signed-off-by: Liu Ye >> --- >> mm/shrinker_debug.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c >> index 794bd433cce0..20eaee3e97f7 100644 >> --- a/mm/shrinker_debug.c >> +++ b/mm/shrinker_debug.c >> @@ -214,10 +214,14 @@ int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) >> ret = debugfs_change_name(shrinker->debugfs_entry, "%s-%d", >> shrinker->name, shrinker->debugfs_id); >> >> + if (ret) { >> + shrinker->name = old; >> + kfree_const(new); >> + } else { >> + kfree_const(old); >> + } >> mutex_unlock(&shrinker_mutex); >> >> - kfree_const(old); >> - >> return ret; >> } >> EXPORT_SYMBOL(shrinker_debugfs_rename); >> -- >> 2.25.1 >> >