From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063EAEB64DA for ; Fri, 16 Jun 2023 07:16:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFF638E0002; Fri, 16 Jun 2023 03:16:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D87748E0001; Fri, 16 Jun 2023 03:16:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28ED8E0002; Fri, 16 Jun 2023 03:16:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AE5268E0001 for ; Fri, 16 Jun 2023 03:16:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8B49540A3D for ; Fri, 16 Jun 2023 07:16:07 +0000 (UTC) X-FDA: 80907751974.28.B51B362 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by imf11.hostedemail.com (Postfix) with ESMTP id 958A740003 for ; Fri, 16 Jun 2023 07:16:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf11.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686899765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/x+Pi0LaZgjVbE1wQTNRdmLGQjT/cogtakG4otiSUg=; b=J3pc2SEQ5439JJ6I84p9aKut3AET02JLHMlonF6BZoBdCwsEcupq+ZQ75e++rvoz4k3HT0 fTS62ILWdN+R4gVjNQJmgxsVsi/weoPivdMdXA+IkLaXhq7DijIXZH6GZijUm3/7PIFsYs aCAvM/W09x+5RdoNiJvjuuoXo5Lqmt8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf11.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686899765; a=rsa-sha256; cv=none; b=OewxfKWudt1vL/WqCaveC2bPmhIdmBCfayTrx7p9AIV0DeZinrJucS+WM24Hxf1GCdH6tX TrOIobKEx8tigGtAF9rdupZAoZnl2fHxTfnXjtpo91gpMaT3He7D7A+cA2VHFv+R3J8vCP PCVlg8J4JIBCJiCzD8uYDDQwc+Xg568= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R931e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VlEyKMk_1686899756; Received: from 30.240.112.107(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VlEyKMk_1686899756) by smtp.aliyun-inc.com; Fri, 16 Jun 2023 15:15:58 +0800 Message-ID: Date: Fri, 16 Jun 2023 15:15:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [RESEND PATCH v7 0/2] ACPI: APEI: handle synchronous exceptions with proper si_code Content-Language: en-US To: rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, justin.he@arm.com, akpm@linux-foundation.org, ardb@kernel.org, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, cuibixuan@linux.alibaba.com, dave.hansen@linux.intel.com, james.morse@arm.com, jarkko@kernel.org, lenb@kernel.org, linmiaohe@huawei.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20230606074238.97166-1-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: <20230606074238.97166-1-xueshuai@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 958A740003 X-Stat-Signature: 7y7wryyguq7w1m3eoc7trfu8ugku7uiq X-Rspam-User: X-HE-Tag: 1686899764-874234 X-HE-Meta: U2FsdGVkX1+8XeQ0E/Fs/0RfRTUiLiKJM2aPbzb1ELMkjesTLWrV0ZE1xa+Z8DT/BfLvlFkNiVx7ipOIFssPuEvNwS9hSYSbscJWjMLabYgTg1R3YknV8048498sraiB2CbtqUp69gjTGfcNQQf1APEOW4de9ReP7GzyQC/OKOp81fQm+JpySTDRX5QtAuEmXy7hHG2iXKIL7xlbQwUpymfRQTgDu0iB5t7OYzvhXbskHL09uXg/gGCRfpyyJ5eTTSGirkPVNDON8W1xJyGkFG5inH3RIODc6se4Ea3fVf6LJNOMZO6pCmqmPLfYAlIdswf4/BNswLImCE2bjTZx5H8QGs0J8nMTOwaO7ZjJllEgMX41kWZgqpcQ0WGoxUsG2xbar0/rTkd1O70el4QDpOyNxHz4vObF2OLqNJ8csuUOmSY0bfBlkamNgYFO8biG6cbVnAfgHSQfDzKvX0jOt+WWw7UcUznfjP0V2Kel0Miusz5k3ETglNu34qB8evOplgDxQWcDb43jWBpE8jqn14GiXNIdzQm21oYhf871mFXkaJD635GKw16Sn6hHJxq65L6XDXye4VAKpSRmI9xaqAfL77sZE3mhkPOYAjcSS4CT/3qJWUIo8PqnAqkOrz4u+1LFWvmIzfF+2BuNPPaoi2JGYivRBEVwlgd4o1kTblK0JpIhhItPY84N/xxLiULqf5aYge/llCLhaf1j0ckNTf5nVQOGuU4BXV7pGqCee0iVJRdVT8jVC11aA0yxVQQSX2L5WOXrSQFsao3VQofl1JEyaYj4noOgLAM/cB4gGUSpe02BLLrz5QuRTMPgtL4+gAUpvzcx4VTVND0fqTVx5d4IQIoHoTr8cw2jbkJCGps4fB3vLyADa6QZr4esSIE3y52QjRgO32zTD3nBnzPLPszxIj0paZs/PArEqhteAsVPx3xJYkVa2SNX6G/ub0gIiaKILa/VcIprKifgnMW 6U3ZsDjk YLqsTMjKLIprnfFfhjAp6AreZ+6Glhi2Qnw4iKNYiq9cYA3HhufbPMlvaHfPnH8+Q71NzvBjLtTFVit6c3eTLu6YvgpXOsDRv6gThMKaCJAeUu47RdIQUkU9vJKbEmRYa6+wcgwTkVWOf2E6BKegqe0YGTElQcp758vqKObM9mBWCBtDpruebJTMF35iKPxFYvF7McVW9cDsyZbiaeKidMAMl4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/6 15:42, Shuai Xue wrote: > changes since v6: > - add more explicty error message suggested by Xiaofei > - pick up reviewed-by tag from Xiaofei > - pick up internal reviewed-by tag from Baolin > > changes since v5 by addressing comments from Kefeng: > - document return value of memory_failure() > - drop redundant comments in call site of memory_failure() > - make ghes_do_proc void and handle abnormal case within it > - pick up reviewed-by tag from Kefeng Wang > > changes since v4 by addressing comments from Xiaofei: > - do a force kill only for abnormal sync errors > > changes since v3 by addressing comments from Xiaofei: > - do a force kill for abnormal memory failure error such as invalid PA, > unexpected severity, OOM, etc > - pcik up tested-by tag from Ma Wupeng > > changes since v2 by addressing comments from Naoya: > - rename mce_task_work to sync_task_work > - drop ACPI_HEST_NOTIFY_MCE case in is_hest_sync_notify() > - add steps to reproduce this problem in cover letter > > changes since v1: > - synchronous events by notify type > - Link: https://lore.kernel.org/lkml/20221206153354.92394-3-xueshuai@linux.alibaba.com/ > > > Shuai Xue (2): > ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on > synchronous events > ACPI: APEI: handle synchronous exceptions in task work > > arch/x86/kernel/cpu/mce/core.c | 9 +-- > drivers/acpi/apei/ghes.c | 113 ++++++++++++++++++++++----------- > include/acpi/ghes.h | 3 - > mm/memory-failure.c | 17 +---- > 4 files changed, 79 insertions(+), 63 deletions(-) > Hi, Rafael, Gentle ping. Are you happy to queue this patch set or anything I can do to improve it? As @Kefeng said, this issue is met in Alibaba and Huawei products, we hope it could be fixed ASAP. Thank you. Best Regards, Shuai