From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518AAE6B24C for ; Fri, 1 Nov 2024 12:05:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB1B66B008A; Fri, 1 Nov 2024 08:05:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A616E6B008C; Fri, 1 Nov 2024 08:05:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 929A26B0092; Fri, 1 Nov 2024 08:05:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 73F7B6B008A for ; Fri, 1 Nov 2024 08:05:15 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2C36C1A019F for ; Fri, 1 Nov 2024 12:05:15 +0000 (UTC) X-FDA: 82737393858.17.7435084 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf04.hostedemail.com (Postfix) with ESMTP id 3CAB140018 for ; Fri, 1 Nov 2024 12:04:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=HBWA42gI; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf04.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1730462593; a=rsa-sha256; cv=pass; b=AzDwKC5SmhNwOxYLAyXeWloPZm4kK7ents1F0eARmbD9eeCyqu/nTkHe+b/Scuu+QdAy3L LOWQkePwcEK0A4t8q4/yX9uvwN81KGdkvYQsI3YWn+xCOAtz/Ae44ZmIX9wMXo+qqU3NPB eZ1fHuh5XLOM5iuovAUcExvzHrnC+Po= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=HBWA42gI; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf04.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730462593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/NMi3pGigRmlDzj0TOeS5jZ0ve4nP+ZwL2yz0+HO+fQ=; b=Yh2kwXzPWv9u1ZDGCDMld85yTCh+2iWGkSiaNIGQh8obuwvrCX7nq7ICXkv3ZCsr/CcLtV b00e1qLYIGz6LWISDQxvqUDgD/BNTgmhTw1IhHlVWkd2oie8H3XfZVIgfUt3uRhVPpBBQV yhtiPhUb8m/Ub1L+LYmDtON0ydoMtJM= ARC-Seal: i=1; a=rsa-sha256; t=1730462681; cv=none; d=zohomail.com; s=zohoarc; b=EK3LpHZfnTpGyfXurU1xjh1Z2ukDCE/4TYlfbRj3jelnAcwy1yPeaTL16fUIPqoNzwTwjuvcYhAAoc/sI2Qo4QsTbHsEJkUytoYz6aYwwVFhh1SQOhGNkYTL80Z2rgMVdZ0yZnECAYtnCXtYUZK0GtQz2Uu2hxCtj4zkHN2fQMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730462681; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=/NMi3pGigRmlDzj0TOeS5jZ0ve4nP+ZwL2yz0+HO+fQ=; b=HnQY1B8nKe8laGMa+/u4t5ms0w1FequDIDXiPhhPdWCG8zXI3pKqITck3MCcm/Ih20Xeq1KYa1I/U+x6P5EsXmCIxC4Bhs0SU2G/5kesX5N3HBxSfRDtlqKkPeMpaRaub2foZuyDAQsq6KlzojbRTiC7/ldvDKouMF3vJJvOzoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1730462681; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=/NMi3pGigRmlDzj0TOeS5jZ0ve4nP+ZwL2yz0+HO+fQ=; b=HBWA42gISrcL6C+foXidrBwRXThCQcXWGJBbL92XEK2DsW9Z+eAqKCvMVcl+n/O7 i3mIjx5aav4uABK+8HAElYvSnhjhtpXPVMlXxr12rcw+HSyAIZofpXYQG0itAsvVIAD oEgo6pDHf7ulXUQBuQQ7F1KDZZeMFtoGau8t9AcU= Received: by mx.zohomail.com with SMTPS id 173046267927518.196252159989967; Fri, 1 Nov 2024 05:04:39 -0700 (PDT) Message-ID: Date: Fri, 1 Nov 2024 17:04:25 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Shuah Khan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v1 1/2] selftests/x86/syscall: fix coccinelle WARNING recommending the use of ARRAY_SIZE() To: Mirsad Todorovac , Andrew Morton , Suren Baghdasaryan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241101111523.1293193-2-mtodorovac69@gmail.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20241101111523.1293193-2-mtodorovac69@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Rspamd-Queue-Id: 3CAB140018 X-Stat-Signature: kebykdr563ikcupfgtqd6ez66b4fn8c9 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1730462677-841110 X-HE-Meta: U2FsdGVkX18tYD3wuvBL4mvgN9vRUlHpb9wVcY4M4GhpcK5T9GNSFTAs+yNcRzmsZlHeA1mF9QuILDwH5qEyuRbkaMwc5/OlDP011ylrQdLJa8yNtoQuIjF2XW7pG5ieinnlCGi2sP0oZetu5xXJ6pWf1ldgumv9Z+gs3RMsbPQdhKHAJVB3Sveym3P36DqlR/pXSfQLrcYDVRr0vQCIUmA7sxAxef3RzIn0KgPxKwMa9hZvP93N0Rk7JXa/dVi6KMmkzg36GcoUnz3SzN/JIOcbOKAW6qJyx2VUt/rKwI/X6U6WN6vEwVtY16RNCKfyNHbJGaCa341O1a+XmjWKLqE2wzgVckX1OeB+mRbbMxqOH6ziE0FYUTXeWipNtFEArc75Q6yvAOwOOx4IE+f84F2SB7dF71INQXJSa5IOsA+ygNNvKM3sdnoD7LeAfabxhBot4o0zskGwze8pzGTgIjJSFuAQ8MSmjUo964Mg/CFng30igbwj3bCpMjVwBlbpK/k7HcdCsOCCwnMGY8oPZ+3/UgFOhCz92+Cl82K17aWSRpFXmgXXXY5e5jfWFy71rekYd+lEglrwNw1R4F/cbTsNv/K4dcpjqzDciSn+uW+UqmVP0nbEanvHXASWnldbqYXvjMCe98I1P3OntqnjlLYTt0ddlxwJdNHG9FI602ryeMP2FjCW/L3usgFE3rC6H0loTcN3feG+G/aIBUdmchPEXktPthG1Qo7GGCsp8YjNYzlFCLo9lPJWaxxg18FBosql7VvjGMa1aSU4qFaT7j1x2ltcKcq0xwArhDqGB1k2JFoU24ELogtCsJy9fMAHrpafK6GWP5czMi0LwIjEwYv8fHh4W0pDlMZtc1Kz98gOuiAH2Z7UecWSRQGBtN7uvJL6SMiv/6S2GeGttTnHBOMoHsFXeiojSDzF4jjRdGhf4FZFZEbrR0ahuAHuN1fKVNSeO2ggXcSmNZvxo70 l1TcE5/4 ghgvegWuWZy5E9vUTtkc8GHqIzewt2ckClfu1lYyoAbA3Wik8tudcVHZtLPix3ZZ7KOgUWM0cER53Z4iEhzwl4lY9DQPECtx65NX9qgJctCFK6IbPM+hNYMM0+LsoZmNqmn5Jn6FpXc/mboYzlZCvWYiEHJ9kmQQSDcT0jV6WpZB+iwZ5oZ8No5uOBr4azD7i0IZE/LWbFlqs7ZptWGuJWDMORXGQJTbWdd6pyYuytEm/0WkpV6lJwE8AiKYlZNSfTxVZFAzjVw09YVBzTbUh3FJ9XTgzr3DvmS7JVTtwMvWluqblEiNLhX78XSejY0SEnXCnAQsmiHypZDzQ28kxy3nP1N2YFrQ936//m5uDv2evXIyfHjzkAiPCBhw/un9P31Ju1B0nk4+aGMXezP2D4+NSrEdAduj0l3Y498iEZcKGjavNAGCwOjNbanKjc5o0y66n+xkpcZQOf01iVhSGe5LNPxwpg+N4nsJOTg+IXdxZvdx9YYfh30ubE856XlOWtzDP6ixzqQZq6yhCJAtjYx3nzVLEkPIaKTdCT1HBQ/lIhSDztk3g6DHjNoFPiXXyS6u4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/1/24 4:15 PM, Mirsad Todorovac wrote: > Coccinelle gives WARNING recommending the use of ARRAY_SIZE() macro definition > to improve the code readability: > > ./tools/testing/selftests/x86/syscall_numbering.c:316:35-36: WARNING: Use ARRAY_SIZE > > Fixes: 15c82d98a0f78 ("selftests/x86/syscall: Update and extend syscall_numbering_64") > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: Shuah Khan > Cc: linux-kernel@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Mirsad Todorovac Reviewed-by: Muhammad Usama Anjum > --- > v1: initial version. > > tools/testing/selftests/x86/syscall_numbering.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/x86/syscall_numbering.c b/tools/testing/selftests/x86/syscall_numbering.c > index 991591718bb0..41c42b7b54a6 100644 > --- a/tools/testing/selftests/x86/syscall_numbering.c > +++ b/tools/testing/selftests/x86/syscall_numbering.c > @@ -25,6 +25,7 @@ > #include > > #include > +#include "../kselftest.h" > > /* Common system call numbers */ > #define SYS_READ 0 > @@ -313,7 +314,7 @@ static void test_syscall_numbering(void) > * The MSB is supposed to be ignored, so we loop over a few > * to test that out. > */ > - for (size_t i = 0; i < sizeof(msbs)/sizeof(msbs[0]); i++) { > + for (size_t i = 0; i < ARRAY_SIZE(msbs); i++) { > int msb = msbs[i]; > run("Checking system calls with msb = %d (0x%x)\n", > msb, msb); -- BR, Muhammad Usama Anjum