From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EC9C83030 for ; Mon, 7 Jul 2025 04:01:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AB118D0003; Mon, 7 Jul 2025 00:01:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25B768D0002; Mon, 7 Jul 2025 00:01:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14A9B8D0003; Mon, 7 Jul 2025 00:01:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F3D4B8D0002 for ; Mon, 7 Jul 2025 00:01:56 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9CC51C033F for ; Mon, 7 Jul 2025 04:01:56 +0000 (UTC) X-FDA: 83636120232.27.4104D72 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf12.hostedemail.com (Postfix) with ESMTP id EC2E840002 for ; Mon, 7 Jul 2025 04:01:53 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=fHxNYfTj; spf=pass (imf12.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=fHxNYfTj; spf=pass (imf12.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751860914; a=rsa-sha256; cv=none; b=u9itxBP6r3Q4Sg3P/HKDi4DSe4ZYkc5dPd/HsG9v+/pmXfaWXviQpbsZOlh2zj+LHc+M3p QFyg5+VyDUcEZZ1ukhyWQ9J1etwG3HrIUvXxcnv2FEZGBlASknAv9QvPKehIKIzT1QFMxB WWW403xcLMUjsKAryHAZtGZhFTXnOEY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751860914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0jkCC5vc1Ep0d2o1MPjj/UHlIophWUPzN/EEy1rjq/k=; b=Pns2j4UkfdkQpmr0P5pp7WPfpgsPP6vzF2BWnJ/0AFQY6Pk7seo2F13cM6cwJu0I/NoHzp cHjfkTTWGCm1Tc1SkdOZW/lLcHhmJvYJ5M24G4FtM5mnBKCZjC87by0ukp2OVYWEMh9dQV JykIiI2Huajs6ipjDaHEv/IvxH3UB5A= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 566JwjU6029879; Mon, 7 Jul 2025 04:01:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=0jkCC5 vc1Ep0d2o1MPjj/UHlIophWUPzN/EEy1rjq/k=; b=fHxNYfTjNk4f63if41FpVY wEKMMdAkDa3NU0N3UXXnz0DcEY3wcPmM4hyNABiA7dz8D3MhZUiewRg8REpodjtZ JA04PHkL9e/h8Fzow5tOuw2P2Qee1mz1rY9FIW9zFCQjmsfnpF8ew/9GPkxEwrLO e706dyY4z83Nsniaew1LLnSgJAbbiN08sLDL+FIgkHL4H1A9DtNkJdwgrdXUkg4L 3kXWUI8DzxXMVPWFgmVjnmk6BpXl1crSMO9APO/IFGJX6gcG7p+B0b51ekrsGzD9 Bja3PGrtv/tDKCtbEeCVOyUPxAQcfu9gh4rUxhktZvThsJb80BFlHsfFVtZPawMw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47puqmxv8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Jul 2025 04:01:34 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 5673uQPv028836; Mon, 7 Jul 2025 04:01:33 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 47puqmxv87-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Jul 2025 04:01:33 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 566NF7cX025593; Mon, 7 Jul 2025 04:01:32 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47qfcnvaar-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Jul 2025 04:01:32 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 56741Wlj31457964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Jul 2025 04:01:32 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5761258059; Mon, 7 Jul 2025 04:01:32 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65A5158043; Mon, 7 Jul 2025 04:01:26 +0000 (GMT) Received: from [9.124.213.32] (unknown [9.124.213.32]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 7 Jul 2025 04:01:25 +0000 (GMT) Message-ID: Date: Mon, 7 Jul 2025 09:31:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/base/node: Handle error properly in register_one_node() To: David Hildenbrand , Oscar Salvador Cc: Andrew Morton , Zi Yan , Greg Kroah-Hartman , Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , KAMEZAWA Hiroyuki References: <20250702112856.295176-1-donettom@linux.ibm.com> <83012fcc-36ca-41fe-8e2e-949f1ba8adf3@linux.ibm.com> <0e36647a-414a-4f53-9159-1ae3ac836d11@redhat.com> Content-Language: en-US From: Donet Tom In-Reply-To: <0e36647a-414a-4f53-9159-1ae3ac836d11@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=FZ43xI+6 c=1 sm=1 tr=0 ts=686b469e cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VnNF1IyMAAAA:8 a=eGJtRLdNXFAazgnYVQgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: u8pCr4j-iRa8n9x-TKBFqYalk5oRF-eX X-Proofpoint-ORIG-GUID: I4i8XC_HrXgeBu9D82e_LmQrrzMfAerP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA3MDAyMCBTYWx0ZWRfX20WKFnqSSuV1 wXBnKIFbDo8f69GxVzjYnIJNQNqJqHrS+qnAMwKQ2ZKcPxEwlIfJ4LfoOcPpsND8Qnpl5qds986 4qc3EqsEeXYdFnosd50kbdUlZZH31URReJ6YJqN89et4g339wc0qIvb/ZBNh5NCTZWBGTc7Nl17 KDqlA154lCBQvuOYgNPJ/viev+pOKBX/J4uVsh1pgaSsOmSFTmrtwi6kFFvdAAMPGhv+ygMWZFu nQi65lfE8S+KT3AIWVWGvRnfEnDAIx0rKG7r0reg1djTBdOnVJQy9LJ5DS1w0gJVkcXdYeDWe1O GlF1Fnk+NSzCIT7YlJpkLzvkGjqt7d7E/+A9vhwZ65esPjveU7cVIqAPhchVXT9x+gYk8+zhsyp qsd2wlL1UBE5am0EsdUeMpTihKzsKnElR1yAUOS86h5iKXyLFP5qKm0bkqMm3bxwMahOAcbA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-04_07,2025-07-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=927 clxscore=1015 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507070020 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EC2E840002 X-Stat-Signature: 3ya1qmms44h4q73sfennkairkhptyjx8 X-Rspam-User: X-HE-Tag: 1751860913-588365 X-HE-Meta: U2FsdGVkX1+UqA75EQqKN/parRfbniP6xj1VmbesYMIWxmoYIuJ3z1zADPU69Pri5P6C3sRsyS+AKZXXgOaVs0fKhFPt3xhNYalrXzBKRizbDYN1pOqiQID9uCR3E/9Y1sMzljRFXhtMOqlaVylRDqC4hMWtFNOtOsQZS+iwTWkLK4k4Ev6pUae/ede8WqBAMDAWK8aOsrcmwvzb/mE1YNZS2RTxclLatvpzoRwXURw3SLVkATuv1c7mmGE43+1aquSqX4eM4ZBzp46Z2avppMQhkUDng2G2ZquEnKB0stT4dSxw+Ayoqm+3aHEFF/fKZA8aVzELm1GaGyhyn98yLvjSDzCf61TzgimIFcfwagHmak0t71OEB3jRva9dt1+l6DITdn3miJosW1lDFcXYoPRuQNeIbmBeYCK2/YXA2Cjthfiq7K/yoRtPK6uFYCxS/d8VTYKbSlv2hlVsLLzeITZ0BUJhC7ck+v/SeF/bYv6lZTAYoVhkWVw+pzXzApK1iM+KvFwTlws8uJRNv53TaBfzt85jjk1MA5jcvo+oxCtq7812BKmVSaL1TSVtANQ5MjX2ecPlLtcnMc4JTytP82e29xTAKl4io9FJTasorXErLfQgDI+wEPFEY7+m9J+dsQ8u9/2M+2RlvfJwrKgBj01nuCQGgcv516ucu4m+F9+9207EYDK8VZ39jf7OoJMBEflXlJpGRgrDkS1sEayOiOhEZNvR95Z0kjRBaVHRdoPId/Np5NoKIud7V2T3QssjTwTy2gMhea1CmiJsv0iU+KuwMYOQguw18HZtZ3G167Dhk7yaLoZjsOJ9au8u/za8lGfSvMs8rSeigndj201d88Un7YmUfieYAVeWFQXeHki9294BKJ8Na4RyMKExyBDPKolpt+JF2BjmLAI91Mhyfq3MXZNEWRRe7JutZc3y5UbGRQpwNh6a27NN6qHzwmiYiiXSYk544eq4yIZfUVP lRN2bQCe 9iyONru/ZNa+DNc7NgGbljBFiQlzpE0tgrSnBVRW2m4MlQrQp0APrD3AsTPGxrZSOi8TcRFtx4Rq6wbB93CUQ+pWA+DzJXOaRS18+ah1mDXtJv16x6vaPS8DY1O8CB+xKJxrt97FeHD3TeN843gSVtZYji60Xb5NkvuH7jTlJMEoAiIGqGKBlK0EeNQvYcaowtLLMCPITagZY7rYabANO+xoICEoTWdVA+sq55MILK9z6I4zgxVxsHMzGFPTJ8sUXjG1q61MIoOQXAAqXcMVjwoyfuXIbrHURD20DLA7BjFpwW6KbGwkhylbStwwWeNTgBY2a6sznymJCE1Dk4criV7e4cXu9DgB0eMNhGEO6fxDUfpF2HGQwbbRAgFjy3x39SPvJQfy0X1mmMEgc/F4EkwHMP/6frqsB5/iUpPh3MiqVEWkJsEqlUz0UZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/4/25 5:59 PM, David Hildenbrand wrote: > On 02.07.25 14:59, Donet Tom wrote: >> >> On 7/2/25 6:16 PM, Oscar Salvador wrote: >>> On Wed, Jul 02, 2025 at 06:28:56AM -0500, Donet Tom wrote: >>>> If register_node() returns an error, it is not handled correctly. >>>> The function will proceed further and try to register CPUs under the >>>> node, which is not correct. >>>> >>>> So, in this patch, if register_node() returns an error, we return >>>> immediately from the function. >>>> >>>> Signed-off-by: Donet Tom >>>> --- >>>> >>> ... >>>> diff --git a/drivers/base/node.c b/drivers/base/node.c >>>> index bef84f01712f..aec991b4c0b2 100644 >>>> --- a/drivers/base/node.c >>>> +++ b/drivers/base/node.c >>>> @@ -885,6 +885,8 @@ int register_one_node(int nid) >>>>        node_devices[nid] = node; >>>>           error = register_node(node_devices[nid], nid); >>>> +    if (error) >>>> +        return error; >>> Ok, all current callers (based on mm-unstable) panic or BUG() if >>> this fails, >>> but powerpc, in init_phb_dynamic(), which keeps on going. >>> Unless it panics somewhere down the road as well. >>> >>> So I think we need to: >>> >>>    node_devices[nid] = NULL >>>    kfree(node) >>> >>>    ? >> >> >> Yes, I will add this too. >> >> But one question: if register_node() fails, is it okay to continue, or >> should we panic? >> >> What is the correct way to handle this? > > panic() or BUG() is not the answer :) > > Try to recover ... Got it, thank you very much, David.