From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B4BC2B9F8 for ; Tue, 25 May 2021 15:40:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB4D161360 for ; Tue, 25 May 2021 15:40:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB4D161360 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CF596B006E; Tue, 25 May 2021 11:40:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857236B0070; Tue, 25 May 2021 11:40:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70C056B0071; Tue, 25 May 2021 11:40:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 3AA926B006E for ; Tue, 25 May 2021 11:40:23 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C62B5181AEF3C for ; Tue, 25 May 2021 15:40:22 +0000 (UTC) X-FDA: 78180165084.17.A4F726F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 3792040F8C0B for ; Tue, 25 May 2021 15:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=aMZe4A2zQzMI+uelvnbHSyD41P+lsnLT3sV78aXUP9o=; b=JtRs3QWWxwpDcCdH1Y5q8NByB1 87wgkFxd3Z/DlsEEN49VItEPC4BgccoIGEkmDDRgaSDpshupSQM9Rc9XziE8br/SfUfs23C9Nzni+ hmsyIb8xs/vIDZDcQ+bKEDcBSD6BUME50uOG0JjkCuDe1AcTwrZSj0hFTmccMMWonUqwfHvO5FFy+ kGZM8LZZrnti7Ou/ZahyjjGJHXuYIcWpeU0AWbRObNY92tjvNgnSBpsmq5efCOcjcxEpmWdfIdIOX JehuA4YjwPwdM5gu/u97NqVKUmoFC+cYZE0/eWO5SNyZGQHzVj7oY0xj3bLwlLRDcsU/mFM53Tn4H UedYbDhg==; Received: from [2601:1c0:6280:3f0::7376] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1llZAD-0064rZ-AI; Tue, 25 May 2021 15:40:13 +0000 Subject: Re: [PATCH -next] riscv: TRANSPARENT_HUGEPAGE: depends on MMU To: Mike Rapoport Cc: linux-mm@kvack.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, Andrew Morton , Nanyong Sun References: <20210525001302.27779-1-rdunlap@infradead.org> From: Randy Dunlap Message-ID: Date: Tue, 25 May 2021 08:40:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JtRs3QWW; dmarc=none; spf=none (imf10.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org X-Stat-Signature: 614ke4j1ukth6bq6jef5gxd5c36h6prn X-Rspamd-Queue-Id: 3792040F8C0B X-Rspamd-Server: rspam02 X-HE-Tag: 1621957215-139474 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/21 3:33 AM, Mike Rapoport wrote: > On Mon, May 24, 2021 at 05:13:02PM -0700, Randy Dunlap wrote: >> Fix a Kconfig warning and many build errors: >> >> WARNING: unmet direct dependencies detected for COMPACTION >> Depends on [n]: MMU [=n] >> Selected by [y]: >> - TRANSPARENT_HUGEPAGE [=y] && HAVE_ARCH_TRANSPARENT_HUGEPAGE [=y] >> >> and the subseqent thousands of build errors and warnings. >> >> Fixes: e88b333142e4 ("riscv: mm: add THP support on 64-bit") >> Signed-off-by: Randy Dunlap >> Cc: Paul Walmsley >> Cc: Palmer Dabbelt >> Cc: Albert Ou >> Cc: linux-riscv@lists.infradead.org >> Cc: Andrew Morton >> Cc: Nanyong Sun > > Acked-by: Mike Rapoport > >> --- >> I really think that mm/Kconfig should have "depends on MMU" for >> TRANSPARENT_HUGEPAGE, but commit 15626062f4a9 from 2012 >> ("thp, x86: introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE") thought >> differently. I.e., mm/Kconfig should be protecting all arches >> against this Kconfig problem. > > We could > > diff --git a/mm/Kconfig b/mm/Kconfig > index 02d44e3420f5..85bc8bf32e7b 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -403,7 +403,7 @@ config NOMMU_INITIAL_TRIM_EXCESS > > config TRANSPARENT_HUGEPAGE > bool "Transparent Hugepage Support" > - depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE > + depends on MMU && HAVE_ARCH_TRANSPARENT_HUGEPAGE > select COMPACTION > select XARRAY_MULTI > help > > but in a sense HAVE_ARCH_TRANSPARENT_HUGEPAGE should imply that MMU is > selected :) Yes, I had this patch before the one that I sent but decided against it based on history. >> arch/riscv/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20210524.orig/arch/riscv/Kconfig >> +++ linux-next-20210524/arch/riscv/Kconfig >> @@ -106,7 +106,7 @@ config RISCV >> select SYSCTL_EXCEPTION_TRACE >> select THREAD_INFO_IN_TASK >> select UACCESS_MEMCPY if !MMU >> - select HAVE_ARCH_TRANSPARENT_HUGEPAGE if 64BIT >> + select HAVE_ARCH_TRANSPARENT_HUGEPAGE if 64BIT && MMU >> >> config ARCH_MMAP_RND_BITS_MIN >> default 18 if 64BIT >> > thanks. -- ~Randy