From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7B3C3DA41 for ; Tue, 9 Jul 2024 11:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 611AF6B009E; Tue, 9 Jul 2024 07:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C0C36B00A0; Tue, 9 Jul 2024 07:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 439BB6B00A1; Tue, 9 Jul 2024 07:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 201386B009E for ; Tue, 9 Jul 2024 07:20:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BDF24C1849 for ; Tue, 9 Jul 2024 11:20:04 +0000 (UTC) X-FDA: 82319969928.14.17ED4A4 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2084.outbound.protection.outlook.com [40.107.244.84]) by imf21.hostedemail.com (Postfix) with ESMTP id A3D4D1C0010 for ; Tue, 9 Jul 2024 11:20:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=5Gc3I1VH; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf21.hostedemail.com: domain of shivankg@amd.com designates 40.107.244.84 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720523971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L1Wv5o3Od3x/l0VjADH+DmZIneoEKnSdALB99+xxZVk=; b=RUrZewocaO6gNrFVdIIlv0nNpC0xlJ+ohZsDUsCltveGnAFNy8HGXA+LhcFLGZ2Mp9nNN3 kFiP/L0CQujrkAqy3bm5WyIvnQuoY3ZK6TGI/yN62h8KqTcOJF+fsyfNXbkX9BfrQmsV/M cWzO2zQHu4dws4krR6ZcO0Yz/AtJ7Cw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720523971; a=rsa-sha256; cv=pass; b=YoZ6zYlchM67tanaOCrdekkw4vJmjQd+Sgw32f8EMYPRwqY+LQ1swLBKCbPa0muyWj0wiM KyTP4qcXXuwtwjvyjWX6o/eF3jwGC40bX1A6Ss86ke6r/Oocy53rHsSlACN1f7JTrrkQ1A cETJEmRvqz76HqGQW6kUW1SHEEnAx7o= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=5Gc3I1VH; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf21.hostedemail.com: domain of shivankg@amd.com designates 40.107.244.84 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TeYiVOLe7JfXMotBL0eAEd4gNprLGg+0ZvcVEbfX+1ZOhhM2pfsvodLcZSDvXC0sSYMXGJUTWYsfgdtMzTKK1Zo3UWLmZl45GV9AcH1bd7+8CE6trdxMzJ5qwzcu4wJqsn5ooNKPW48lXVKc4lndMrj1EmRhm/l9/ztHH3CsOnggL0qXv3BhxNQ2qohQnKsMjF+52Q6RAYrALPl3mKeVMEp+6cqqROFdwVZ+Vr8cOu0ELT6o9gQJ98aCHtpKyMRz4r4sCPSZeQAgp9KsaUWIrDckDaiKWxYL0m/QZgP9tNjusYp+wsRNYgIoD1mPUmS8dbEd008ajw1ZNP+ashdugA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L1Wv5o3Od3x/l0VjADH+DmZIneoEKnSdALB99+xxZVk=; b=lX/xDvxSo73RiZjf9Q6ueSHJ+d943Pf5IRxyA3g3r9nRGkgBE0jlLJcsCmLFLfIQfAYkATCz+XcMWLqvNxtgqcaThbPvzojteBSk0/2Qr4RpUzZIb9llJ76xffTBV6r6LuPUSQSrOx31cTIgE9M+H5aemgSzms8eDfd7jfBQjAjyePDaUIpuSDb34HotGxeZAUTIuLvC8K7D/e2uIfVx6HP1MWyOvuHURIvDcfaoDzfhQ43FePo/wZ5h/c+CRnbqinglLpfYrL9ChQOCmWgcwdRGc7PAHagNi8bv34AzQP2/QPH/k7nm9nftFentTCMB3dFV1l8p0t6HiX6pGKTpYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L1Wv5o3Od3x/l0VjADH+DmZIneoEKnSdALB99+xxZVk=; b=5Gc3I1VHRzIX73oM1rGqQkoUfvcfGKVlOOBIOGb/VTIK8PkB0q88hoKoNuXMgDunfy9Rc4xgKSQn52ztrxuSHMy64HbiLeME5PYoqadbqZ86favgwliYKK01eGfjIvJvMwD99Kkv5Vg6ZHfejJLspepoYypxdD0eGsh2nZk0bT4= Received: from CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) by IA1PR12MB8190.namprd12.prod.outlook.com (2603:10b6:208:3f2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.19; Tue, 9 Jul 2024 11:19:57 +0000 Received: from CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870]) by CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870%6]) with mapi id 15.20.7741.033; Tue, 9 Jul 2024 11:19:56 +0000 Message-ID: Date: Tue, 9 Jul 2024 16:49:47 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: use zonelist_zone() to get zone To: Wei Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, Mike Rapoport , David Hildenbrand References: <20240709031953.22217-1-richard.weiyang@gmail.com> Content-Language: en-US From: "Garg, Shivank" In-Reply-To: <20240709031953.22217-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA0PR01CA0114.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:11d::12) To CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4262:EE_|IA1PR12MB8190:EE_ X-MS-Office365-Filtering-Correlation-Id: 25a4fc2d-3700-4612-0ae4-08dca0090fb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cFQ0QnZINGY2Y0dJZHdkOWN1eVhWeVVpKzV0cXJEVW1FZzlEbEdiTm9YL0VT?= =?utf-8?B?Mk5aTGp2SU5MdG8xbmVjNXMrU1I4TjhQRGN6QlhCSUJFS0huS28zdm9YVlYw?= =?utf-8?B?VEJ6a3dhL2NKWHhGRC8vMDhtM2loUTRNWGdlcWRnRmIvL2N2UlM1Mzk1Uk45?= =?utf-8?B?eWc3VVI3c01sMWM2Y0UyN2RXdzN0dmdCRndrZE1NWkhuK3hHWlQwaHRrTFZ3?= =?utf-8?B?WGtzSW9VK1NMUmFabG1GbnBvQWpUNHEzK2M5VFk2aXQzRmxxL2pweWJxdWp3?= =?utf-8?B?RGp3MjZSbUlPL2d0c2N6Nkp6aCtGWE5OVXQrKy9sTUZiVmkrQnFnNkNoNjhW?= =?utf-8?B?VzNucXdHWk1rbE54Q2txSXFyclUydzlOZVVlbnA0NVVXTU13TU9Pc0hxc25C?= =?utf-8?B?eWp5T0RKZGhCL3k4MGhYcUNMUzh3cE9hRThtN0F1NEtpWGRQcDFMb2l6Y09l?= =?utf-8?B?UklHcnYxOUF2c0k2aSttY2x6dWJNV3ltZEFFSXdzazdIam54aTFhMXZpRFRJ?= =?utf-8?B?NjhVeEVNTm5sNlM4bC9aUmd3bCtpNW1RcmtnY0JwSHJaV0RDbXB6ZEhuVTdm?= =?utf-8?B?VXRzbnpDbkdsMjN0STR5amhLSHA3c215bUlwQ1gzVVczV1FBejkxSHFPU3VO?= =?utf-8?B?SFFIU2o2Tk5CZUthYUl6dzhkSittSll2Z0l5RzFwWThqZmh4Lzh3YnRHNGI2?= =?utf-8?B?ZEZoOVltWWdub0VLcXBaOHJ0R3NVM2dXR0FJOExEVE9sU3lFSVl2bDdLY05S?= =?utf-8?B?SUZuL3pJbXJ5dkQrOWJTQWFIczJRVElTMU8xRjE5NWZsTU1OWFNaeTBsQmxn?= =?utf-8?B?cVgxNE82NStOR1FRMmdyQldwdHNnSkRWVjZUWlc2aVk3K1lyaGdWcDBJeEwx?= =?utf-8?B?SE5uOFJrSHh6ZHBrdU1vTFRiTmkrSGRIeXBvMkdLcGJPSndBbHh4SXgzK2ti?= =?utf-8?B?bDFzL3FjRXhrYUJiLzBxT2FCUmpJSjdqUE14UVB3a25LRHZLazhIdjN4NEgx?= =?utf-8?B?aU5KeFkxZHZRM09wMjVLalRMYjZLd1Y4d3ZEelVyVVpWbFAwMlFZVnV0OHI4?= =?utf-8?B?azdiSkF3WkhXK3N1QmNwSUpadVo3cE1Gd1g3QjVzQVNwWDgxQVdCbWVXRW5O?= =?utf-8?B?Umlpb28zNTc3WERqdEF2SmlWbVo0UDJWSDlXT2NrbnNreWV1WUJ6M0VtUTBh?= =?utf-8?B?cjR1NjRzamFFRXlkV24xeGhtRGRmcVlTby9xRFMxcU55RGVKSkZOSThlbGEx?= =?utf-8?B?L3hYeWFZTHgzbU1BeWhCWXdMVzRBNlMrNUowNE5RR1BwYXJ4UkdjaWV5a01V?= =?utf-8?B?L0EvRlBkdHUzTjVCL1RURzZiZVJaSHdCTkkwNFJDN1U3WTJsZWRXNXRnZmlp?= =?utf-8?B?YjFjcDAwOEw1akd2N1ZMZCtyeUVoNi8wZXg5d1VwbVBRbmVPNjgrb21DMTRw?= =?utf-8?B?d3ByNjdVbXdVRGNyOUczRDZWVDdIeUtmakpaRGxDdE96UWN2MU9zNlY0SnZm?= =?utf-8?B?UzE4dlRjYXhVbEx2ZThmV2tCdU4rSDhLSXpJMTZkT0RucWtuNHpxaVRmaStR?= =?utf-8?B?L0pyNGloZVA4ejNBQXdDZmFjdVhIQVNDajAvbDQ4eERkazM5eTc0eUpjMkh5?= =?utf-8?B?YXR1SXVMdHVRd3U3Ym52Z3BhS3F3MHZZelVLTlFyeCtSY3duRXdCWXNDTm13?= =?utf-8?B?Mjhqd0tyZ3d3ci9FZFFEVk1COEtldjJtZHd5RldmanpWSkVJbjR6dmJxUnNo?= =?utf-8?B?YloyenFEb1dYZHBuM3crbk00SUFCNHU1a0VpNXF6TTNXNnpFWVNuSHFJVHFv?= =?utf-8?B?bWR3eDdXN2QxSGFrMi9OZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB4262.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDRHV0xkUFBycTZjS0lVUWpzSzhQOWtibG5OVnF2SHlEU21Fa0psSlZ3T2c3?= =?utf-8?B?d1ZWTjUvQUV0aVRoZGtVWnczRHo3WUNJS2ZTUXpNZmltVWFkWlFWNzB5cVU3?= =?utf-8?B?SGYxYjEvRXVlcnhGQXBGRTl5UDM4M1RYMkR4RnNsWWRaMWFTSmlsaWxaMkhI?= =?utf-8?B?RzRMbUJSUkZsOHJzVkdYak5GUlRoVzFQYXA0eE9PazBYWEs4TURzYnA0V210?= =?utf-8?B?RWtMTklwNVJuR2ozREJRV2tVVGZQQXcvTENpd2lrbnpOYVkvR1ZpT0NaR1JV?= =?utf-8?B?aDZrUUJlTjVYL1ZvUm1iTUlLQWxJdGJZYjZHajgxOW1tcU13Z0V6NUdkNzRX?= =?utf-8?B?TStsaUo0YURqYTJDQkZoOFZvbE9IcyttcGFuS1hkOFh1Y2RFMFZzcS9FbDdv?= =?utf-8?B?Z0xBNU9XaTlTRURwclZQcCtIWkdpOTRnVlc2VmZZeUprdXdETmwvOHk5RjV5?= =?utf-8?B?cE5qdXVUSkY0OHZtd2V1cmFMeGRVWU1rSW11S2J4Q0xZRnVoc1lSU2NmVXB0?= =?utf-8?B?OERHS21Ma0M5K0NCSzlMS2k0cHZlQ1h4MklvN2Iyc1lIQmRZdENOeWRuMjFt?= =?utf-8?B?WlpBNmdIV2g0aVFORFZJNHRObTFOdExnK2FLZzhXakNyK2R6L0R5NmU5K2Ns?= =?utf-8?B?VXBGU0tESEZhM08xZHlnOFRUQUQzY1Q2UENWUmVZd1hwdXRVUkRkNVlZQWc2?= =?utf-8?B?MVlvRHA1Vzl2TVhxNFNGV2JtYmZ5RGRQR25XTlRzSkovcDFlM2h3cUNFVXZj?= =?utf-8?B?bWFRTk5yZ0M4MVpBOTlLSjIwa0dxbnZXZGRWRm1QWWVSUGVwWDIvbVRyOElX?= =?utf-8?B?WjRjUWcva0dUanc0N0VYNzhlcW1BSm9GOXFSTG53M2ZpVDZ3UjV4RXpUaGtu?= =?utf-8?B?M3RhVld5UElPT0RrcDZIVVhXQk85U1lMSVZWektxNi9LMnRTMWlCMXoxQkNI?= =?utf-8?B?UHZ6a05KS21QanpUcENDRnU4VjMrTFRtU3g5MXh3Y1haUFRrRmdqL1UrdEQv?= =?utf-8?B?aUdKRi9OQUVEdEdKam1HQXhPYmdLZWI4TFNkUnFnUjlDVlI4eUZUajNvdDVF?= =?utf-8?B?UUd4M29ZQzI5UXlua2NlUHhSTjczdk54KzJucUg0Q0tmKzhlb2w0aFVPTjVV?= =?utf-8?B?Rm9sOG81cnZUSXY5bmVQRGZpVmFNemltWTFMZWU3bkt3MUIwVnhvZi9tTkEx?= =?utf-8?B?czI0bm9wbXV6ZFNSOG9mVHBsaXlQUkJYM0NHSVMra1pBWEF1MTdrbGc5ZWRu?= =?utf-8?B?TU9KQm9HSm5zbmkzamloUjZCeHBGZ3BUOEYrMWxWTVplS3AzanV2ZGF4dVVw?= =?utf-8?B?T2ZHeGJZS3duQ3MwQUxwaHRvc2ViLzdXbUZxZndqSnJFQUN5UjA1ZXhxTWFt?= =?utf-8?B?RGEvLzMzTkR4VVo5dlVyV2dRM0REOVMzYmtTSjRncEREZUdzQkp1UEcrelRE?= =?utf-8?B?a3RudjdvcmkwRVNBVGFiNEJjaHdRNFh0dWtUem5uTllCM3VFeDBYcVFNMHlQ?= =?utf-8?B?UFpINjNiN3dSWitjT2xMRG4xazB4cmY3TnB1MkRXN2k3dHVKbXZGb2cvR3pT?= =?utf-8?B?QkFIazBod2VNeUZxQUtLbzdxaVM2M0hzMk1RZnZmaWV5ZWw5eGgyRnZGeEhz?= =?utf-8?B?aVpTRXMvbXRrM2xMaHN0RFp2WlVxN0NjUHdPZG9WQ2ZELzZERndiWCsyL2Vp?= =?utf-8?B?VUxSQU5zZW4vMWtKL3VSK2JUTFhkUnduZS9GSnVBcTd3NVVubU5QY2tHQ2pW?= =?utf-8?B?Sk9TRldUbm5jV2VTOG1tU0pGdWhmai9ySzBDcTNraTYzaFV5N0J6eFVaVW1o?= =?utf-8?B?aHpkSEhDbUNtdzUyVTJ0aUw3elNNQkIwMTd2NTQzY21VZEk4Zk90RmhJbkZU?= =?utf-8?B?RURVMWlrVUgxRVYzcjNQYkJWYUV2SFkrRVlPWjRhdUFEOEtSYVEwRjJkTGZj?= =?utf-8?B?T2pPM2p0NWpSMml3UHhHelFaMEhoT0kzZ0F1aG9xbEE5eE1lV2YzSGRDbFBK?= =?utf-8?B?ZTR5YW52a0h1cHRyZW9aN1R4Rmp2Z1ZVUDc1WDJnemYwdzdpYmJDWUZQNDZk?= =?utf-8?B?NnVJOGRrMWZpMGRJVzJCR2Z4MVhqazlZZXM3ZzJxNitnSGlZaFZVMFh6R2Jm?= =?utf-8?Q?90RXnUcAZbJvyUCcqoCVzGePq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25a4fc2d-3700-4612-0ae4-08dca0090fb3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4262.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2024 11:19:56.2064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u/nlGjHlRZqIfonJrWHi897YZ7auuKdxNZtIDFCMJS2NGPC4GINCZnfD2QA781RitGcK0MjQW9dPwxYdcAMBDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8190 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A3D4D1C0010 X-Stat-Signature: x1cuxtkeh8zfuojzjrnse6wcsh5utpw9 X-HE-Tag: 1720524001-316415 X-HE-Meta: U2FsdGVkX19pI1d5s7eFie0HgOOjsLwu/fzreONoiKOBRuPirZN0UecnnBpGWZfbyCoGDkUTeUVdgz5FVMCe0JTgNwYkrJstrDxYp1kN0RRiZkoNtQgQ9S+dwk2bJrE/PiLARycKJWto0oa8oGdB0zJ9TZ8f6p20uATlS0TjX3n3c80En64Cg+4m9CbTdT4CgymsiddABJMa7jICeuWezhh4oGe779pwzBGWHHw9KHVG6tz3P5hFoCYFowBzEPAHoj0PY6YMTkgwcjf0uA/2jdN80TXxaK+oSNYRVPEblfXof0IP24Dpgj4FStMr6kdzOqZj4AOFMdp2kdiMNlZ/mhA1XhQNiNTfHaOW6HYkO1YyIyT3KromaJxZeBIHqFfu04hvigoF70XtyT9MCKJF6ZaGn9kpZ82kX+T9wj97iaHDWhF+v5kc0XqGDpIIdKMjZlDXzPtcJfLwZEZhqV15VdLKWaC0WvHhH0B4I78hK8FL4UPcxxeIbkQWTRh8synNhzZdccj9540TwfXfEpAQDMkMZ2xUpkc0JJ/M4IQ0G86ivCtYuiOVGhNF7fscGyTIH4DIhDqiPj9niD4Te0FkQF/SfQDmeS9mmv2/uuN2D8MUrtOxkBRABm/edTy4TBVUnMCqF9kEx8q1f9ms8K0c90Yy+Uq7b2rIXB6Y2pK465xkfnMxuE9Rgj9E9I1YiDkp+4qTJ9RgKy9RcYs0b/w4UGBcPNQ1/rqaC2Cdt4AnO26BdNe+bm5eTgSlPB2ENH0pjA0zXA9ygxPc6arAD8J59GzwnOQOG90tGB5osrCeJu5D6/OqwfG20f5T1QY5houJ1AnBliWdYWl+y9HmLxk/csLE4eoh+Hhv1FwJ/B3fIc2D81WF/6XnFvD+gnmwI1mUzrAkgcqrFqcOeWXkPawBoUcVmcuztMYF9pBsVe8gtXqyho1C0fUGITJfMpC9YFbYxw43s+JpuWULFAQpnCZ F6k7u9Rp W5Qb9pYw385FP3C2LHHaHAsTXtsJdJYgHWlNohoVACiv47SOlNshRG5c9J9gvzicpSqthlMIA1AuhZTSvbIJQ6W9IUD5w5Z2n+IwvFpoPvDJm46KjJG+ARHRvv+oHX5jtCMw8qDywk7dn9wwto9BulNQd9+CG5+w/fahefhkYM5OgckSsshyXlYwgS1juQgqxKR3vNT+mG1rkPpc2Zu1fsWVJSbG0bwD4/ojVaKeGv+vTjbZDuhMyWU08RkG6MiPmZsnpwf8h7ixjDP2in9E4ruNnsJmLXOTwCCr/Z3fGtvISir8CZDSHn1V3JgcfOZpmqfLacYwN7AQy6qSlqmaLlp5IKUJ0YtCNScYCWWXlKYn3diGNBzVLQQvYrTRk8JaJMnciFKB4REjjv+sgPn7RSGviMUQwXoNDSor1PrEBrVrVBTAKJzCKJ3AA+m14CD5GFmmbxgrUUEJjJmHGg5SqqZawofFrzUkdMqIEDwpZUA3Zj8fRcZeFcPgBLvDMAJ4jIWhkCTb0sZkRYwTT4mvp1rgcbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/9/2024 8:49 AM, Wei Yang wrote: > Instead of accessing zoneref->zone directly, use zonelist_zone() like > other places for consistency. > > No functional change. > > Signed-off-by: Wei Yang > CC: Mike Rapoport (IBM) > CC: David Hildenbrand > CC: Garg Shivank > > --- > v2: cover more usage > --- > include/linux/mmzone.h | 4 ++-- > include/trace/events/oom.h | 2 +- > mm/mempolicy.c | 4 ++-- > mm/page_alloc.c | 14 +++++++------- > 4 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index cb7f265c2b96..51bce636373f 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1690,7 +1690,7 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist, > zone = zonelist_zone(z)) > > #define for_next_zone_zonelist_nodemask(zone, z, highidx, nodemask) \ > - for (zone = z->zone; \ > + for (zone = zonelist_zone(z); \ > zone; \ > z = next_zones_zonelist(++z, highidx, nodemask), \ > zone = zonelist_zone(z)) > @@ -1726,7 +1726,7 @@ static inline bool movable_only_nodes(nodemask_t *nodes) > nid = first_node(*nodes); > zonelist = &NODE_DATA(nid)->node_zonelists[ZONELIST_FALLBACK]; > z = first_zones_zonelist(zonelist, ZONE_NORMAL, nodes); > - return (!z->zone) ? true : false; > + return (!zonelist_zone(z)) ? true : false; > } > > > diff --git a/include/trace/events/oom.h b/include/trace/events/oom.h > index a42be4c8563b..fe6997886b77 100644 > --- a/include/trace/events/oom.h > +++ b/include/trace/events/oom.h > @@ -55,7 +55,7 @@ TRACE_EVENT(reclaim_retry_zone, > ), > > TP_fast_assign( > - __entry->node = zone_to_nid(zoneref->zone); > + __entry->node = zone_to_nid(zonelist_zone(zoneref)); > __entry->zone_idx = zoneref->zone_idx; > __entry->order = order; > __entry->reclaimable = reclaimable; > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index f73acb01ad45..83e26ded6278 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1951,7 +1951,7 @@ unsigned int mempolicy_slab_node(void) > zonelist = &NODE_DATA(node)->node_zonelists[ZONELIST_FALLBACK]; > z = first_zones_zonelist(zonelist, highest_zoneidx, > &policy->nodes); > - return z->zone ? zone_to_nid(z->zone) : node; > + return zonelist_zone(z) ? zone_to_nid(zonelist_zone(z)) : node; > } > case MPOL_LOCAL: > return node; > @@ -2806,7 +2806,7 @@ int mpol_misplaced(struct folio *folio, struct vm_fault *vmf, > node_zonelist(thisnid, GFP_HIGHUSER), > gfp_zone(GFP_HIGHUSER), > &pol->nodes); > - polnid = zone_to_nid(z->zone); > + polnid = zone_to_nid(zonelist_zone(z)); > break; > > default: > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 116ee33fd1ce..e2933885bb19 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4218,7 +4218,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > */ > ac->preferred_zoneref = first_zones_zonelist(ac->zonelist, > ac->highest_zoneidx, ac->nodemask); > - if (!ac->preferred_zoneref->zone) > + if (!zonelist_zone(ac->preferred_zoneref)) > goto nopage; > > /* > @@ -4230,7 +4230,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > struct zoneref *z = first_zones_zonelist(ac->zonelist, > ac->highest_zoneidx, > &cpuset_current_mems_allowed); > - if (!z->zone) > + if (!zonelist_zone(z)) > goto nopage; > } > > @@ -4587,8 +4587,8 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, > continue; > } > > - if (nr_online_nodes > 1 && zone != ac.preferred_zoneref->zone && > - zone_to_nid(zone) != zone_to_nid(ac.preferred_zoneref->zone)) { > + if (nr_online_nodes > 1 && zone != zonelist_zone(ac.preferred_zoneref) && > + zone_to_nid(zone) != zone_to_nid(zonelist_zone(ac.preferred_zoneref))) { > goto failed; > } > > @@ -4647,7 +4647,7 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, > pcp_trylock_finish(UP_flags); > > __count_zid_vm_events(PGALLOC, zone_idx(zone), nr_account); > - zone_statistics(ac.preferred_zoneref->zone, zone, nr_account); > + zone_statistics(zonelist_zone(ac.preferred_zoneref), zone, nr_account); > > out: > return nr_populated; > @@ -4705,7 +4705,7 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order, > * Forbid the first pass from falling back to types that fragment > * memory until all local zones are considered. > */ > - alloc_flags |= alloc_flags_nofragment(ac.preferred_zoneref->zone, gfp); > + alloc_flags |= alloc_flags_nofragment(zonelist_zone(ac.preferred_zoneref), gfp); > > /* First allocation attempt */ > page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac); > @@ -5310,7 +5310,7 @@ int local_memory_node(int node) > z = first_zones_zonelist(node_zonelist(node, GFP_KERNEL), > gfp_zone(GFP_KERNEL), > NULL); > - return zone_to_nid(z->zone); > + return zone_to_nid(zonelist_zone(z)); > } > #endif > Hi Wei, I identified some additional locations where using zonelist_zone and its related functions (zonelist_node_idx and zonelist_zone_idx) would improve code consistency. If it's alright with you, please append below changes to the patch with my tags. Co-Developed-by: Shivank Garg Signed-off-by: Shivank Garg I have also tested this patch. Thanks, Shivank --- include/trace/events/oom.h | 4 ++-- mm/mempolicy.c | 4 ++-- mm/mmzone.c | 2 +- mm/page_alloc.c | 12 ++++++------ 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/trace/events/oom.h b/include/trace/events/oom.h index fe6997886b77..9f0a5d1482c4 100644 --- a/include/trace/events/oom.h +++ b/include/trace/events/oom.h @@ -55,8 +55,8 @@ TRACE_EVENT(reclaim_retry_zone, ), TP_fast_assign( - __entry->node = zone_to_nid(zonelist_zone(zoneref)); - __entry->zone_idx = zoneref->zone_idx; + __entry->node = zonelist_node_idx(zoneref); + __entry->zone_idx = zonelist_zone_idx(zoneref); __entry->order = order; __entry->reclaimable = reclaimable; __entry->available = available; diff --git a/mm/mempolicy.c b/mm/mempolicy.c index e000f19b3852..ec84a11df1cc 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1953,7 +1953,7 @@ unsigned int mempolicy_slab_node(void) zonelist = &NODE_DATA(node)->node_zonelists[ZONELIST_FALLBACK]; z = first_zones_zonelist(zonelist, highest_zoneidx, &policy->nodes); - return zonelist_zone(z) ? zone_to_nid(zonelist_zone(z)) : node; + return zonelist_zone(z) ? zonelist_node_idx(z) : node; } case MPOL_LOCAL: return node; @@ -2802,7 +2802,7 @@ int mpol_misplaced(struct folio *folio, struct vm_fault *vmf, node_zonelist(thisnid, GFP_HIGHUSER), gfp_zone(GFP_HIGHUSER), &pol->nodes); - polnid = zone_to_nid(zonelist_zone(z)); + polnid = zonelist_node_idx(z); break; default: diff --git a/mm/mmzone.c b/mm/mmzone.c index c01896eca736..f9baa8882fbf 100644 --- a/mm/mmzone.c +++ b/mm/mmzone.c @@ -66,7 +66,7 @@ struct zoneref *__next_zones_zonelist(struct zoneref *z, z++; else while (zonelist_zone_idx(z) > highest_zoneidx || - (z->zone && !zref_in_nodemask(z, nodes))) + (zonelist_zone(z) && !zref_in_nodemask(z, nodes))) z++; return z; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d841905fa260..e998ff6cbbff 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3336,7 +3336,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, } if (no_fallback && nr_online_nodes > 1 && - zone != ac->preferred_zoneref->zone) { + zone != zonelist_zone(ac->preferred_zoneref)) { int local_nid; /* @@ -3344,7 +3344,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, * fragmenting fallbacks. Locality is more important * than fragmentation avoidance. */ - local_nid = zone_to_nid(ac->preferred_zoneref->zone); + local_nid = zonelist_node_idx(ac->preferred_zoneref); if (zone_to_nid(zone) != local_nid) { alloc_flags &= ~ALLOC_NOFRAGMENT; goto retry; @@ -3397,7 +3397,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, goto try_this_zone; if (!node_reclaim_enabled() || - !zone_allows_reclaim(ac->preferred_zoneref->zone, zone)) + !zone_allows_reclaim(zonelist_zone(ac->preferred_zoneref), zone)) continue; ret = node_reclaim(zone->zone_pgdat, gfp_mask, order); @@ -3419,7 +3419,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, } try_this_zone: - page = rmqueue(ac->preferred_zoneref->zone, zone, order, + page = rmqueue(zonelist_zone(ac->preferred_zoneref), zone, order, gfp_mask, alloc_flags, ac->migratetype); if (page) { prep_new_page(page, order, gfp_mask, alloc_flags); @@ -4560,7 +4560,7 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, } if (nr_online_nodes > 1 && zone != zonelist_zone(ac.preferred_zoneref) && - zone_to_nid(zone) != zone_to_nid(zonelist_zone(ac.preferred_zoneref))) { + zone_to_nid(zone) != zonelist_node_idx(ac.preferred_zoneref)) { goto failed; } @@ -5282,7 +5282,7 @@ int local_memory_node(int node) z = first_zones_zonelist(node_zonelist(node, GFP_KERNEL), gfp_zone(GFP_KERNEL), NULL); - return zone_to_nid(zonelist_zone(z)); + return zonelist_node_idx(z); } #endif -- 2.43.0