From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE5EC021A4 for ; Mon, 24 Feb 2025 14:46:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6632C6B0095; Mon, 24 Feb 2025 09:46:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 613816B009A; Mon, 24 Feb 2025 09:46:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DB9F6B009C; Mon, 24 Feb 2025 09:46:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3069A6B009A for ; Mon, 24 Feb 2025 09:46:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E24431CA8FB for ; Mon, 24 Feb 2025 14:46:13 +0000 (UTC) X-FDA: 83155113426.12.7AE7589 Received: from pv50p00im-ztdg10021801.me.com (pv50p00im-ztdg10021801.me.com [17.58.6.56]) by imf20.hostedemail.com (Postfix) with ESMTP id 367611C0006 for ; Mon, 24 Feb 2025 14:46:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=QlrLaWEd; spf=pass (imf20.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.56 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740408371; a=rsa-sha256; cv=none; b=Aidq/s3fo5okmvQsZN66yj0NrxmSWJ7w9R+pjHoGMeSZkKkUu7DjTcG7B/zvzKKzPXd7XY ZQVy/ZWIR/Hc72FliThMfYn1rL2JqfyxgCt5L1GX9wiElK9V334Tmkyaw2+kSdvtDQyiGi Eu++keN5OOOFP5pCvg1f664EtdqdJHE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=QlrLaWEd; spf=pass (imf20.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.56 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740408371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SxARc5+mPnL0BjR2iW5rWJ4TF8233iOHpKnJbbHiSqw=; b=2JFy51yKEUmARO0YWddj2bc5uH7Pgvegv718YVFSo2RTOpTsTCb8HX0iOrJBzkzzYcufCZ 5uQpsXuVvQVK6LVfyXR+rrpouKff5s3hKCzkxB4yfg+RFX4lP3VzL44/IJffsPX9yYs1fp rm94i6h2v8B8H8+uutPNnNEuFQaVlKo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=SxARc5+mPnL0BjR2iW5rWJ4TF8233iOHpKnJbbHiSqw=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:x-icloud-hme; b=QlrLaWEdYFkfsu8fuz6nbUdcj79Q8tJSmKk2HA1yeaCmsuHQSOTGqxvHL7yUmSH26 akU6WkcZrQNFnHq+BJaLeGPq0iB3wrn9quZ3+XX7TL6W2416KdFvIkp5eq2vQ9b1mC 1W3KDPpIj0DisqfGR5RfGhPUGajT30GJk6SpSRctraMh5Bn8xJKesYr+HLgu8FHVrW 5Dfwx7CMvdnY4JwcEN6gg2auvHgazI6WEAwJkihz3N6RwdjmSunhSudO5G6dDlNdEp B1QbwPUm6oUVtf0ONAKjCUdMnGgia+x/d6OTzrZdtjaV4ethm0Xnv3yRyjfFnT2Mpt tk5oRw9q9GBwg== Received: from [192.168.1.26] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10021801.me.com (Postfix) with ESMTPSA id 01FF82010282; Mon, 24 Feb 2025 14:45:49 +0000 (UTC) Message-ID: Date: Mon, 24 Feb 2025 22:45:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page() To: Peter Zijlstra Cc: Zijun Hu , Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> <20250221200137.GH7373@noisy.programming.kicks-ass.net> <8f36be7c-6052-4c5d-85ff-0eed27cf1456@icloud.com> <20250224132354.GC11590@noisy.programming.kicks-ass.net> Content-Language: en-US From: Zijun Hu In-Reply-To: <20250224132354.GC11590@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: rwcKYw_iCScrLPUxt294xX4BCs8xvrO1 X-Proofpoint-GUID: rwcKYw_iCScrLPUxt294xX4BCs8xvrO1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-24_06,2025-02-24_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=911 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2502240105 X-Stat-Signature: w3hb6ydm4jposro3dphue1j8g1awxoxe X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 367611C0006 X-Rspam-User: X-HE-Tag: 1740408371-492543 X-HE-Meta: U2FsdGVkX18XE8uVpr5/vGskUxrosEx9kxGTCAwPp6vAhE1EdOWmX4loYIXd0v8cC7u5byBkd5YxwMWhPOGBjSljSrpqCm3JcDC6HuzgE8ixZfbQ7mlGEIhRI7VFUbdbEKRpBX5h3FQlQ3d2ExzLn96LfcsDUXDiYU8mHCAbKTLVNwVCU8L9dWIFNUbK5SgZzkaQjZ9HPAlf2CDShTglSseGDY/bVuNNgLR+SXqWT7I/Q8xPQ5Ee5g68RXkV19BwTZcwUrkl2wv9r8Z236fzHWvPJiikTWUkNDo0Gumm9Qkh4y5KA8+6D7VlL5hFlB9eT1aB8VxLd41OqUUZkiG0QqntbIqRX3tIZqjkXil2XFsRJnZkBWBuMwpAxc7ue55QciEm9Rz1eRzTH+mLEXq1rimavcIcz+z9jXLWmT7zu0LxmJ/krgMeePDcakA3imOevIIoWUC10UWgA/EMTaVKFtIw+hiz+cecSf4f89p2qHjvU80SyiLwgfaVQJaYHq/oJXA8uoUAJzfllISosmI2SiaBOhnhvUvKs5lpdwA1grvPMbdyRey2JALmbp3254YE67Ikf5QnjHFAJOW14cA+2nAp5TCQBqa6Qn1WvxcyFn17gpDPrwlxG+6r+9t7pD8yvfHIlgvfiYknZEXMNTmfRt/SrAThIN4AEBOtdwPbuDZ84VI+7B6VMw+HaU3uW2fn3DodELub6y2Kz5RZs048xVPprqaaxbam4DphPkc4/6QFEvmOnxwSbRe7cYBFGvS0YzrYL3abLcr+LGzCkCpeP86dGacHQh1a0YlPZ7AE0Av9HOpQnUeZzbDvxFtU99xZVL7W97RTzwPquu3UnROJpz4YzVvbtSuzNB9Lcsb4ATjbQuHQUIQTLhXCiKEYTt37MfMkqy25Dw1lfmoZFkP7JfudIOUdDmeBqpNTXyBIsXvWST7pqpZ4cw2sH50u0nrhYyMaKATfm2qB0GGOfyf +tnna19m FsPw7ZngaiMEJRMz7l89gHFdkTFeJT2xKVmP75yPMoizNoGp9v/uYo2SNV9VYrDXjfOHO9OFrKm3irHOwjPuhsMbL71GnnNogC2xVG27sWwC0mEbX3N2kNZHaYkRsSm1cAXajBfRD0k9MDerQ9JSMX4R24oHWm97wpflhqGDcWASO9K9Ec2ww159VeBoUoKAT2zMU8CRgaeEoEjozJ3BqIK3/Fu2EAWvyDNR+UX4i1Aqe1bDl9wIO78BuQCHTvN/b0YDq6n1GipsIupFnNdaxNSrf+m1lHNrxkhpzJE+iQguz+/9xXyjozLVGIAVQa2Z+sYSv8EqOwXBEmUuIFi2XwsUk43dKBbUfq2lsv+SchEkhVdM229ODoUMEqFeSNKnjHBqDAGt82VNYKwvMVS1j4zTOZ+VUmcciZKt4V5SQsVQIpLXKmWQPUGunXANQJtDv12TizEWXXTDfKHg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/24 21:23, Peter Zijlstra wrote: > On Sat, Feb 22, 2025 at 07:00:28PM +0800, Zijun Hu wrote: >> On 2025/2/22 04:01, Peter Zijlstra wrote: >>>> */ >>>> static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) >>>> { >>>> - return tlb_remove_page_size(tlb, page, PAGE_SIZE); >>>> + tlb_remove_page_size(tlb, page, PAGE_SIZE); >>>> } >>> So I don't mind removing it, but note that that return enforces >>> tlb_remove_page_size() has void return type. >>> >> >> tlb_remove_page_size() is void function already. (^^) > > Yes, but if you were to change that, the above return would complain. > >>> It might not be your preferred coding style, but it is not completely >>> pointless. >> >> based on below C spec such as C17 description. i guess language C does >> not like this usage "return void function in void function"; > > This is GNU extension IIRC. Note kernel uses GNU11, not C11 any link to share about GNU11's description for this aspect ? (^^)