From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7B8C2BD09 for ; Mon, 24 Jun 2024 03:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DDC26B0082; Sun, 23 Jun 2024 23:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 566796B00AE; Sun, 23 Jun 2024 23:41:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 406AF6B00F4; Sun, 23 Jun 2024 23:41:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1EC546B0082 for ; Sun, 23 Jun 2024 23:41:40 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BFD1340A90 for ; Mon, 24 Jun 2024 03:41:39 +0000 (UTC) X-FDA: 82264382718.01.118D111 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 1C97CA000F for ; Mon, 24 Jun 2024 03:41:36 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719200491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DlIUhZFdK3I2fMGiJRy3RD4hYtdGnfDYm6suSZy04/g=; b=P18MHS9phkHEt2pP2ImHY3SAU4gGUSfdfm5N/RXySbOEZYZycGQV4PXt82UPwac0N9ftm4 J+Fl5AfUEyq06vno0tkJXg7esIezE/L1NjuV8AAPHuwo4dAx9IKqlTjl35YwP5T9qRDg7p nFUN1Ovb2Tef9Peromw9XH/cpVuOV3k= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719200491; a=rsa-sha256; cv=none; b=O16R8baABsP9KSW6C+WF9xXhKnazoIqJl13SrLXqja7xS4dDjAMVFUuvj6bbE5VKhSJNch C0HvR4mnnMqg7UJd4xzSPOwDeEvHEtHoNWJ+klwcRjOlW1Y+X5ZqxO+QhuOrNFcvD5e+UO 9JoLGvP7tZUe9a43YVidGVPCw5NAjkY= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4W6ttx1xcjzxT4Y; Mon, 24 Jun 2024 11:37:13 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 8BB311402E2; Mon, 24 Jun 2024 11:41:30 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 24 Jun 2024 11:41:29 +0800 Subject: Re: [PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages To: Jiaqi Yan CC: , , , , , , , , , , , , References: <20240620184856.600717-1-jiaqiyan@google.com> <20240620184856.600717-3-jiaqiyan@google.com> From: Miaohe Lin Message-ID: Date: Mon, 24 Jun 2024 11:41:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240620184856.600717-3-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 1C97CA000F X-Stat-Signature: mm7fpmrzaibbszqpf9rtpngbiyhz6uhb X-HE-Tag: 1719200496-628566 X-HE-Meta: U2FsdGVkX1+KL4cSoSoxvkyxNry1JZUrKTsPX7RVi6bz3gF/bx48RgEl+6rDYg8GAkEbijxBIwpJiNes/VtDdsmPRcRNAXUS1Z+7Dv4UEJCU4cngf4MS0c6obDS05e8TdclzlTv+1qmLPFeSfJ1sTmCgh2aRb8NAoK8yf5DRG+27Jdcg+2nTGSBE5FKZk/+NSqGCFKKIJoaaM23v76LzBwTHKdMakpH7vVVEwblti0EW4IubhVIBWtT/3f8Umx2L0G1e1Q4qCMBj8XP4xF8howNIBSl3gqkK0Gjlu9CC6EKYfxdRiwX8gr/4juXPZ+a+DTZbbrZY8M1yo3m0evpbsjErwXy4Md1vdiTJYTzn32qXr5+m2hku6GJ4itknz4LuPUPLjG51i9yX05j1eZ9YwU+0zLzM5GakRXZvQjRcTq8wJAV6uh/dpYDQhfuhJDxWSBpcpd5wVMJAqwYyvIrxGVHE6JfOoY4/aIlUXYNoRqjqkUxNThV+69Ha7UTijp6qpX2RMnsQpQX40kxwrZnMo2jqJk26ZSCo9ngPI9sxLiIturO6pgzWQOhS2cDZLRsY2Gn7YTkaMgbPTbgOZNZx0Ag64ON/OPPm75noZKIFRYIDlwXS5rUzvsKH+U8eryN1un11V+CgySaMVyYjXqsWWnr0gVcgkpug4esPlVMRuIDe13B65BeLXiMUK3gvhR9oUO6MyJlsKJ51X9D4iUmKTrd5M6lNFPRLlS6AXewHJIUcBddSIh8POujLd+fvpUktnb4pXaM9ecxfOirofXnczYgOqgV9f9XOhsVHWVWXlwoQoxp9ldwOH+GSz7IT0F3xDTwRDalIMBSOQ++jgX6UGZr6uSC+12hOpPp9E54HemGag+M7MQ0UmaYUHXGAdX2NchmtgR9z9X+rjZ4RLnPI8JqKjI6lovWcbJZW9Q7TDxzgzsCGY7azDzGIeI0ZKWRzJJeG+lITU5qopm++/FA ZcK1Pha4 D7B8AG54IAdEPK4pZ6zAifb4k6PfiLRQ/9s6m9wKLSCy2/oaJn2Gqv6Q1crWro64txNUOt+cMZ9yu+P2y2QjcbGuXIc+PecnEoixC5GzeESHgZETQxHvkXdpfJ6Zfuqi4oCkaaEaLh+oezsVT1JdkpKhEwZsJ3xWQbrGIqU58MPcwwVVnpCZGql7oWcmaEFBrlhv/1hI+yaqMgKS/d6YP8rRqzsUtUZ2izC8a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/21 2:48, Jiaqi Yan wrote: > Correctable memory errors are very common on servers with large ... > > /* > @@ -2749,8 +2760,9 @@ static int soft_offline_in_use_page(struct page *page) > * @pfn: pfn to soft-offline > * @flags: flags. Same as memory_failure(). > * > - * Returns 0 on success > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event > + * Returns 0 on success, > + * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > + * -EOPNOTSUPP if disabled by /proc/sys/vm/enable_soft_offline, No strong opinion, but it might be better to write as "or disabled by /proc/sys/vm/enable_soft_offline". Acked-by: Miaohe Lin Thanks. .