From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB7AC19F4F for ; Wed, 8 May 2024 13:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42F4E6B0088; Wed, 8 May 2024 09:44:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DFDA6B008C; Wed, 8 May 2024 09:44:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CF186B0092; Wed, 8 May 2024 09:44:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0F6546B0088 for ; Wed, 8 May 2024 09:44:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9286A1D8A for ; Wed, 8 May 2024 13:44:42 +0000 (UTC) X-FDA: 82095348804.01.7FE0098 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id EDF8C12000B for ; Wed, 8 May 2024 13:44:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715175881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WS0236DoHROEncp6FuUsx/DZXhHhaPaWTB4dbjbcuig=; b=FP+CS+JVjpYCzwtApKw33KhTIaPmjn5Hx8VGJ8NVI+0lZJD+LvMJYRbOkjicMQ6CjbDHqD twotTcBM3wflvNLoPaHA/9Pn3gD427CirvE9aQgPlT+zMqUFYcdmB/aA1vMA9k3NqGtDUr QABcnNnyKpBwP7VqPo0Ow9SuIO+jBYA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715175881; a=rsa-sha256; cv=none; b=Xak4lj0+/OYRmS7BWEOnSf7av7DtevJRdTf9iQg6zcnLjq4aSmhOOxGzPwAugCd5Z1iluK iasgA7dfa9BPiyxyNh1HQN/GdHykMJAQX2rP8QbOQiln6xcyGavWf5aIZ2MbJ5TIyC/v/d lfhkvgTyrxLGxp3FM3wQXOQZk6txPxM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AEE5B1007; Wed, 8 May 2024 06:45:05 -0700 (PDT) Received: from [10.57.67.194] (unknown [10.57.67.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42FDC3F6A8; Wed, 8 May 2024 06:44:38 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 14:44:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] mm: shmem: add multi-size THP sysfs interface for anonymous shmem Content-Language: en-GB To: David Hildenbrand , Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6b4afed1ef26dbd08ae9ec58449b329564dcef3e.1714978902.git.baolin.wang@linux.alibaba.com> <30329a82-45b9-4e78-8c48-bd56af113786@arm.com> <0b3735bc-2ad7-44f8-808b-37fc90d57199@linux.alibaba.com> <928c73de-76b0-40d6-a0c3-23d72270ac5c@redhat.com> <28f311ec-9b46-4f28-991c-ac74177acf32@redhat.com> <5c2c70fd-a291-4ca4-b229-dc54e92b3471@arm.com> <578e878b-259e-4944-99c2-9caf578e9642@arm.com> <6e412cee-be0c-4c94-b576-ebdd897e6e05@redhat.com> From: Ryan Roberts In-Reply-To: <6e412cee-be0c-4c94-b576-ebdd897e6e05@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EDF8C12000B X-Stat-Signature: die94w7nrrt5ezwd3k7893dpjzm735jd X-HE-Tag: 1715175880-905625 X-HE-Meta: U2FsdGVkX1//U61DXb4Gb2w/o+T1/1Lb+xAup+6DcQv5zqM3jzQHdv6d8EIsdMUDHn9eWU18rQQyjhI5mpetuPxOwIwVQTrGh2yYhNI4IqyTlVMsfEgv0oGVIavnqnSFSeUEHEYfKOH7YA+oGapgZoSwtJAubLV9TesTqalScT8ZLS5dkqGK+lI/2IdFE6c8iF3Iw9jfEknt1k5W0dNyNaas151p78oWwe5o+nO5wUqo1zfyn1gIqezLDqVpGeqKJBwCvfy3cWK7suG94h/zzotkwbGnY41Mhe0LHKVG8McY2M2YD+WLTSyLDMkYnhzP2Cd4bPD4d/i/gUCyyk8e525MtbP1eO3qytfCcBNU0rNdhctA7Eu9U9E3/41LzMrG9ciH8ok8KtdCN8817tVrRoHodcKiBL+T+tCYB0xqkHcZY8YEUaC0Yc4c1JuhR3+ea1jE04HnykY1TmEUwkfcOmuORfKHfCX4aovHd4sWnQjGCXXmEEysQGXbtwGOsnV4NENoNo3jFMSZuXWUYqHnZBpo1QWIEmk1uy6rs3xIk8GVFPTUny5/Isr5+d6rt8fhaLayqLlmxM4fTaYeSRrlIIKYFjKvh9CRgvuxGzuzenzUcM4uD9F0gj9gwRVLKV8yurLTw0VYjo4V0dpjvw046Zi0hTSykT8zaFe6ycBncXwmSdrZRvcSCuBVXXBw0COOWTT0uYjfZtWj/SzUFBlDnluVPH59+Jokbgm63eUqgZe4jTRBeHaf/aLWJ6ctxyie5Jicr6UICfwpTSG8WSqNeUp8HWeb+K6FBp8jyHUP5PQ9Fk3DyO0gf84bDOM9grkG/3/n28Sb4ZeCDNSoOz5CrKgsvTiMsXDFNiyXK4I635zdJYPKos6Y1hpklXPPl9PwIpSvVnYP7Ekng32zfUgQtjOzcQQyS/F9RlsTU9FoxMxBY421Dhtq4K7M0ML1Z8O6N50zFTsek/sCqRerCtD KAROi05P BRI97suICydAQEI8HL7jifVvmeTAOOX4gfJUMVZe/oa+d1Z2gNnvZIgjGokgWF4CrFLpi7dlB/IX/xRp13+57uIEkHc1qxH2nG9Qj0ywd7jaNzUvfmNGcB/BGVi3BN4E5CKUo+slrUPf25Nku4cFcEWWBlp/l/LA88eChglgrS1DXIROmEMIZNo/rv0nuwEeY60Z0GbKruTschnaicQo50ghb4PTZfkF0ol+tdbjYdGAXBnhu0XzyQxmRsp5VhUHYWKWe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/05/2024 14:07, David Hildenbrand wrote: > On 08.05.24 14:54, Ryan Roberts wrote: >> On 08/05/2024 13:45, David Hildenbrand wrote: >>> On 08.05.24 14:43, Ryan Roberts wrote: >>>> On 08/05/2024 13:10, David Hildenbrand wrote: >>>>> On 08.05.24 14:02, David Hildenbrand wrote: >>>>>> On 08.05.24 11:02, Ryan Roberts wrote: >>>>>>> On 08/05/2024 08:12, David Hildenbrand wrote: >>>>>>>> On 08.05.24 09:08, David Hildenbrand wrote: >>>>>>>>> On 08.05.24 06:45, Baolin Wang wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 2024/5/7 18:52, Ryan Roberts wrote: >>>>>>>>>>> On 06/05/2024 09:46, Baolin Wang wrote: >>>>>>>>>>>> To support the use of mTHP with anonymous shmem, add a new sysfs >>>>>>>>>>>> interface >>>>>>>>>>>> 'shmem_enabled' in the >>>>>>>>>>>> '/sys/kernel/mm/transparent_hugepage/hugepages-kB/' >>>>>>>>>>>> directory for each mTHP to control whether shmem is enabled for that >>>>>>>>>>>> mTHP, >>>>>>>>>>>> with a value similar to the top level 'shmem_enabled', which can be >>>>>>>>>>>> set to: >>>>>>>>>>>> "always", "inherit (to inherit the top level setting)", "within_size", >>>>>>>>>>>> "advise", >>>>>>>>>>>> "never", "deny", "force". These values follow the same semantics as >>>>>>>>>>>> the top >>>>>>>>>>>> level, except the 'deny' is equivalent to 'never', and 'force' is >>>>>>>>>>>> equivalent >>>>>>>>>>>> to 'always' to keep compatibility. >>>>>>>>>>> >>>>>>>>>>> We decided at [1] to not allow 'force' for non-PMD-sizes. >>>>>>>>>>> >>>>>>>>>>> [1] >>>>>>>>>>> https://lore.kernel.org/linux-mm/533f37e9-81bf-4fa2-9b72-12cdcb1edb3f@redhat.com/ >>>>>>>>>>> >>>>>>>>>>> However, thinking about this a bit more, I wonder if the decision we >>>>>>>>>>> made to >>>>>>>>>>> allow all hugepages-xxkB/enabled controls to take "inherit" was the >>>>>>>>>>> wrong >>>>>>>>>>> one. >>>>>>>>>>> Perhaps we should have only allowed the PMD-sized enable=inherit >>>>>>>>>>> (this is >>>>>>>>>>> just >>>>>>>>>>> for legacy back compat after all, I don't think there is any use case >>>>>>>>>>> where >>>>>>>>>>> changing multiple mTHP size controls atomically is actually useful). >>>>>>>>>>> Applying >>>>>>>>>> >>>>>>>>>> Agree. This is also our usage of 'inherit'. >>>>>>>> >>>>>>>> Missed that one: there might be use cases in the future once we would start >>>>>>>> defaulting to "inherit" for all knobs (a distro might default to that) and >>>>>>>> default-enable THP in the global knob. Then, it would be easy to disable >>>>>>>> any >>>>>>>> THP >>>>>>>> by disabling the global knob. (I think that's the future we're heading to, >>>>>>>> where >>>>>>>> we'd have an "auto" mode that can be set on the global toggle). >>>>>>>> >>>>>>>> But I am just making up use cases ;) I think it will be valuable and just >>>>>>>> doing >>>>>>>> it consistently now might be cleaner. >>>>>>> >>>>>>> I agree that consistency between enabled and shmem_enabled is top priority. >>>>>>> And >>>>>>> yes, I had forgotten about the glorious "auto" future. So probably >>>>>>> continuing >>>>>>> all sizes to select "inherit" is best. >>>>>>> >>>>>>> But for shmem_enabled, that means we need the following error checking: >>>>>>> >>>>>>>      - It is an error to set "force" for any size except PMD-size >>>>>>> >>>>>>>      - It is an error to set "force" for the global control if any size >>>>>>> except >>>>>>> PMD- >>>>>>>        size is set to "inherit" >>>>>>> >>>>>>>      - It is an error to set "inherit" for any size except PMD-size if the >>>>>>> global >>>>>>>        control is set to "force". >>>>>>> >>>>>>> Certainly not too difficult to code and prove to be correct, but not the >>>>>>> nicest >>>>>>> UX from the user's point of view when they start seeing errors. >>>>>>> >>>>>>> I think we previously said this would likely be temporary, and if/when tmpfs >>>>>>> gets mTHP support, we could simplify and allow all sizes to be set to >>>>>>> "force". >>>>>>> But I wonder if tmpfs would ever need explicit mTHP control? Maybe it >>>>>>> would be >>>>>>> more suited to the approach the page cache takes to transparently ramp up >>>>>>> the >>>>>>> folio size as it faults more in. (Just saying there is a chance that this >>>>>>> error >>>>>>> checking becomes permanent). >>>>>> >>>>>> Note that with shmem you're inherently facing the same memory waste >>>>>> issues etc as you would with anonymous memory. (sometimes even worse, if >>>>>> you're running shmem that's configured to be unswappable!). >>>>> >>>>> Also noting that memory waste is not really a problem when a write to a shmem >>>>> file allocates a large folio that stays within boundaries of that write; >>>>> issues >>>>> only pop up if you end up over-allocating, especially, during page faults >>>>> where >>>>> you have not that much clue about what to do (single address, no real range >>>>> provided). >>>>> >>>>> There is the other issue that wasting large chunks of contiguous memory on >>>>> stuff >>>>> that barely benefits from it. With memory that maybe never gets evicted, there >>>>> is no automatic "handing back" of that memory to the system to be used by >>>>> something else. With ordinary files, that's a bit different. But I did not >>>>> look >>>>> closer into that issue yet, it's one of the reasons MADV_HUGEPAGE was added >>>>> IIRC. >>>> >>>> OK understood. Although, with tmpfs you're not going to mmap it then randomly >>>> extend the file through page faults - mmap doesn't permit that, I don't think? >>>> So presumably the user must explicitly set the size of the file first? Are you >>>> suggesting there are a lot of use cases where a large tmpfs file is created, >>>> mmaped then only accessed sparsely? >>> >>> I don't know about "a lot of use cases", but for VMs that's certainly how it's >>> used. >> > > There are more details around that and the sparsity (memory ballooning, > virtio-mem, free page reporting), but it might distract here :) I'll note that > shmem+THP is known to be problematic with memory ballooning. > >> Gottya, thanks. And out of curiosity, what's the benefit of using tmpfs rather >> than private (or shared) anonymous memory for VMs? > > The primary use case I know of is sharing VM memory with other processes > (usually not child processes): DPDK/SPDK and other vhost-user variants (such as > virtiofs) mmap() all guest memory to access it directly (some sort of > multi-process hypervisors). They either use real-file-based shmem or memfd > (essentially the same without a named file) for that. > > Then, there is live-hypervisor upgrade, whereby you start a second hypervisor > process that will take over. People use shmem for that, so you can minimize > downtime by migrating guest memory simply by mmap'ing the shmem file into the > new hypervisor. > > Shared anonymous memory is basically never used (I only know of one corner case > in QEMU). > > I would assume that there are also DBs making use of rather sparse shmem? But no > expert on that. > That all makes sense - thanks for the lesson!