linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm: Don't fault around userfaultfd-registered regions on reads
Date: Fri, 27 Nov 2020 18:00:44 +0100	[thread overview]
Message-ID: <a240da04-1446-9282-c250-00507b745744@redhat.com> (raw)
In-Reply-To: <20201126222359.8120-1-peterx@redhat.com>

On 26.11.20 23:23, Peter Xu wrote:
> Faulting around for reads are in most cases helpful for the performance so that
> continuous memory accesses may avoid another trip of page fault.  However it
> may not always work as expected.
> 
> For example, userfaultfd registered regions may not be the best candidate for
> pre-faults around the reads.

Are we getting uffd faults even though no-one actually accessed it? So
in case I would track what some part of my program actually reads, I
would get wrong notifications?

-- 
Thanks,

David / dhildenb



  parent reply	other threads:[~2020-11-27 17:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 22:23 Peter Xu
2020-11-27  8:16 ` Mike Rapoport
2020-11-27 13:31   ` Peter Xu
2020-11-27 12:22 ` Matthew Wilcox
2020-11-27 13:51   ` Peter Xu
2020-11-28  0:33   ` Andrea Arcangeli
2020-11-28 15:29     ` Peter Xu
2020-12-01 19:08       ` Andrea Arcangeli
2020-12-01 21:31       ` Hugh Dickins
2020-12-01 23:42         ` Andrea Arcangeli
2020-11-27 17:00 ` David Hildenbrand [this message]
2020-11-27 18:28   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a240da04-1446-9282-c250-00507b745744@redhat.com \
    --to=david@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox