From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1035BC76195 for ; Tue, 28 Mar 2023 08:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D8216B0072; Tue, 28 Mar 2023 04:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 188DB6B0074; Tue, 28 Mar 2023 04:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04FF66B0075; Tue, 28 Mar 2023 04:56:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EA0736B0072 for ; Tue, 28 Mar 2023 04:56:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B9ADD120167 for ; Tue, 28 Mar 2023 08:56:57 +0000 (UTC) X-FDA: 80617702074.09.0AF2F0D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id C8BAC16000D for ; Tue, 28 Mar 2023 08:56:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t2sipxad; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZPtqPIHV; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679993815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nh59YKaOupZZpTW1uDmCRUQ1aAKohqr+w5EA7d7jR+o=; b=Dhx8+rs1+/e9oGxAltzDUgRhQSMqDpI9OuYvhe2GeORb0nNCNtMG9y2t3/K80A23JuWIYV XRuyRkYgeOqzlaeSMuLDHlHKc3mdDJ72N1u13Kee7G4KgZgIyMHY4JXxAIRwZ5gVCgK+3j aw2JJV/IQJll8VI0tyG5hlEyCcWr4eQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t2sipxad; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZPtqPIHV; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679993815; a=rsa-sha256; cv=none; b=7bidu/lTTU/hgYUaX6bi/86oOytr6X7q44HrrCRTccThXsl5KaF0izcQnyBlwSlWIyrNVM ef3Wsn10GZ5J8z7D2W5xl9jNlavNcY9IiSgcs/tNCiKCUNSmq1oE4FAY61hDvtO2LDZY9m 6Svy0L355mMhe7VZ2TTuv/dD4sUa2Js= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 34513219C2; Tue, 28 Mar 2023 08:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679993813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nh59YKaOupZZpTW1uDmCRUQ1aAKohqr+w5EA7d7jR+o=; b=t2sipxadwSudSlY5Uvh6MJVXEiPOV924bCkqtrbZIXG9TkRf6kcSA5opwqRVMm50tG08H7 NMLk4pWmyyRlCWYTkuMZVw823ynOk0+WT1aqAEdwyRdusV+U2XIC0M+4OU0xC8BpQJN3Zo aJAjx9sOTgpWEcZaBn/Z8VELsr7fE6M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679993813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nh59YKaOupZZpTW1uDmCRUQ1aAKohqr+w5EA7d7jR+o=; b=ZPtqPIHV2b/ncSH9qfDV+t916jW0VhX2ALCoE49wzX5TOKprWRiheCiQVk9+9cdvDibeyk WNOTkluVrkaC4+DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0BAEE1390B; Tue, 28 Mar 2023 08:56:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zhMtAtWrImRqNQAAMHmgww (envelope-from ); Tue, 28 Mar 2023 08:56:53 +0000 Message-ID: Date: Tue, 28 Mar 2023 10:56:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V8 1/2] mm: compaction: move compaction sysctl to its own file Content-Language: en-US To: ye.xingchen@zte.com.cn, mcgrof@kernel.org Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, chi.minghao@zte.com.cn, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <202303281446280457758@zte.com.cn> From: Vlastimil Babka In-Reply-To: <202303281446280457758@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C8BAC16000D X-Stat-Signature: pwjg96gdnbnr4wn7z9mr5shi8cwmpxck X-HE-Tag: 1679993814-979611 X-HE-Meta: U2FsdGVkX18k1XWSH18PD6ZoUc8o96XbKs7XvMhbLCiBhayYdDbwWMa7d7x7Po6C2LiLvTJwm0paOkXc9NNy9+R2iAwbNOyW67JfZ3Crc1Q0ccIPtwgdRUUOVFx0TqxQu/khsoBQeliguoTLShgiUFIzp4XDrJqWfq4IAkboeOL2/yln+/+E1csxo3dGW5re5YNRl+laaqQzDS4GFI0T33Rdzb1WvG60vj+R9LMpFPEnlb6BB7HYj4FJGiDsj6ePezdttrOHo+W7L9vYn5oXZNr9dF+U6jT1vX7+EuS5GwFfeBMPZ+Lm+Pb1ohECLyb4N2zeMHMOMfycoAFKVQj1qtuFvTBR/YZaa1dSCrI8W5Ipxeung/36MRMP7Qz9h6ZYOyQJuIUMRWPqjTj8pMWpFBG9V4shr7VTylT96+HKBvaq/pX9mcKfipJhZh5YMLeRRTbYU6Vpz2HX6voHyk2wu4s6luL4jcydKsbDBCcqkxKc54MChzWIMG2QNv4KzFlcSOPV1hlaT3aRUNYw8vNVLgHqOgh2OB+r0MoQ7d8P0u00KnwSUQQHS/zOHvobEFr4JCrSQXAkVBMaEGAjTrRMERhXoTwHfMDg11h+Vqf6HoHYMisr2uFuv4YTXvjX5S1SZB72sS8mzpUB8RF/TrH+yfJksxh0MRRBMLYbea7jePkHSs2ZfMRrLqwFZfWLR+8FqPI4jUfiT7fmgvj7HivGPP2tJUXYhFPti30UZNiRWGjqlq6a38+u5w+FiiB16tBekvqAcI81V7SSRdZMyIpnsFrxjx0ScPzmfFHPy5J/tuLsdRoP5gn6YNSWTqLPEINuexhTEyrkt1zctOLTZLaLKbpTUfAKK6cs6cOe9c6Nenr+T0oVJHGeMxN/+GMhlFXWm3IyFs32acfWGdREJdly0rhQFJJjHc/4rQ8IbV2qDnp3lXWkN2qmEFML61tEi8Au4TRy5oUHmhSnQDPvj3h r+JSc64W 78bga5MkthvQCD+PV+Bq/1C5Z97g0QwWKgtVaJ0euOHABRPpLeONb7PwgksCkfvGbhgqlCpUHwEL4q7qIzNqTS4utw5bK5Hjutmt9lTrGHEPyPUldSrhmXUm3YQjcgLRaabuzW0Oh5DXhakal4Q3Lw4nuH/GR9T03pZOAs6XbhF4CwueCC5AjKZ05hm8zoQ8tJTV1cSwV4QLQXSq2p6Fxa2jjETO5BjDNpAIqo4/vsgCdF2ywlTMnfB+5JrT73Ep50Zldo4vdlNVxdNSuTJ/yyuD7aO7BAgnvrNAmcpJUD9F2S7MXKlQzFBFziPdp6alwSi8SbavpT/eqBB8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/28/23 08:46, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > This moves all compaction sysctls to its own file. > > Move sysctl to where the functionality truly belongs to improve > readability, reduce merge conflicts, and facilitate maintenance. > > I use x86_defconfig and linux-next-20230327 branch > $ make defconfig;make all -jn > CONFIG_COMPACTION=y > > add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) > Function old new delta > vm_compaction - 320 +320 > kcompactd_init 180 210 +30 > vm_table 2112 1856 -256 > Total: Before=21119987, After=21120081, chg +0.00% > > Despite the addition of 94 bytes the patch still seems a worthwile > cleanup. > > Link: https://lore.kernel.org/lkml/067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz/ > Signed-off-by: Minghao Chi Acked-by: Vlastimil Babka Thanks.