From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8E8C41535 for ; Sat, 16 Dec 2023 19:35:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BEFC6B007B; Sat, 16 Dec 2023 14:35:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 949156B007E; Sat, 16 Dec 2023 14:35:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E9B16B0080; Sat, 16 Dec 2023 14:35:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C4BF6B007B for ; Sat, 16 Dec 2023 14:35:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 39C36160711 for ; Sat, 16 Dec 2023 19:35:11 +0000 (UTC) X-FDA: 81573684822.28.70C711F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 33927140013 for ; Sat, 16 Dec 2023 19:35:07 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iG82qlJJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of "SRS0=wfBN=H3=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=wfBN=H3=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702755308; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JWD/QkoBWyKUQsmiucB+B4G5EtURKqxgZCbXkFtWLUQ=; b=XTafOqh89JhtVyFCn1dkqr1SY576S7XphzcGer0PWTJT/Ve72QYfjRzqi1xqeCbA5JwXw4 ii3SkoiLbd66EtvjfSqUoZ6j/lTxlOjUceE6/7BzuT+POE4uhy6x6CUj28Xz+7DYvWM3bG zxfTyH/JuoTvO9yWUdNiUpa52mMMjr4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iG82qlJJ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of "SRS0=wfBN=H3=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=wfBN=H3=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702755308; a=rsa-sha256; cv=none; b=pFh0z7KsflcpI8e1YxME1DaMwPlR7FZIB20xSvD1ezVQHn0/guW0/NQwYfejmmni9rrOUM el612N8X32+rD/OqFLajYsh2aYnKFYeduDDj6VvZ15Y+I5+AC0z0oW8B5U0dOImee5n5O+ j8J2sLLghoPoWcjMMvJMMluvan1xBSw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 20D7EB80685; Sat, 16 Dec 2023 19:35:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1B57C433C8; Sat, 16 Dec 2023 19:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702755304; bh=UfbayCVz3R0ZIOss7ruExChm+cAdSZgFI69SFvbtnVE=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=iG82qlJJxrxPmgOppyb2c5/aYH3AUsa/8R8WAKqPPfFJGR4m5wEX6OAQClUlDPkfB kYOv4k7VZBW3x2e6HqHkXGcLulm0wwUY45F9gO2a0EW3/qDi2GfRBmuYtPAYiEjrB/ JpkoFYLoZhnTE751txj9qH0mLuSUkA4uVTDaGHFulwj6A1xYs3wyy05knjaiFp1iDZ S4s2ZVKNILO/MmUA81jPkbmKycmdQ6d94VZ2g5vDg881EoLVp5zI/+eV7o2UMamOy4 cWDi4K6XT3VZJNW/O93wxwnRShIekbIuuO44WVIk3uOtyvsS7QXS+1hJiCEK9//vit coQIP8AOoLrRw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 588AECE0965; Sat, 16 Dec 2023 11:35:04 -0800 (PST) Date: Sat, 16 Dec 2023 11:35:04 -0800 From: "Paul E. McKenney" To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 50/50] Kill sched.h dependency on rcupdate.h Message-ID: Reply-To: paulmck@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-7-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231216033552.3553579-7-kent.overstreet@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 33927140013 X-Stat-Signature: ag7t9u5i6rr6fbm4cbjg4ibwxobixcks X-HE-Tag: 1702755307-812062 X-HE-Meta: U2FsdGVkX1850SB5jyRthmgWlSWrDVWiJ0efi7VMMGzaPuO+TDYTCqKPgAuVlV1Lst+4+VnxLlsxvoxUcf3VPunTsooMIMl92Bz4aisJ+gUQcDvJg6buZrdtdp07ummWNZKthtCsyB2AKP+CfE7YGE0StL6rrrQlhchnJugjTsIYuMv6XfrXraE+LqF0BICtsNvP9x0XzdpNSuA/IhUmD1cyX8FW+T5MnVe7aPMFIh+yDknO+vnRkJ+MDfUSSg1vMzIcsXBU5pBbhcqpNc0LN/Clp0bvW5r3/SxGY+++4k3+T9cWnm6o6z+6y/NWkL5mn+bQdQRNY9KPmLZAxkKcy6h5PEUP+M+KlUrbuYD3NhRZpjcyDQmCdMIcEEoMENDx8RcPOzBMaiLUyLsROi6pNklFICcTWO03gbpab/Gs/BAeQBrsQOE90PEQL4QpupqQI2Nn+aOUR0f8gR2txXAP2FuEaNfjohbdCcQcwCo0oo8eO62I5sWlcyGWgUH1Z8sEkdRRaFNOhWLwT9WDwz8XpjjuwBC4bO0Or1ERQx49bf9s1tE1u/WrZ+pSlU9r5lkB0Fj83xVGlYZ3dRjxfDi+RHkobPCKigIdkYdndJH+j6896iq4CDXWxYq18KmOBfLqaip26zZmgdGCQco1+7Y44kh35Np8dOJk2JphZQe1hNImiIzMgGrZCzDjNtoCRYg0G4EZvN3bUeaqYZH2FBK6WGT5oqlMiahcP7fweaT3+pQU3zoOIyB1XB7rcwHL9F1YcN/HRZ70OMJz9sZ/h5mLplJU+eVY/0NkKgDq47oZtxlj4w4sev1bM869ZmeQdK+FRjA1SNdYUZ5J097lN5IFM9zIQ1K2JSY8n7ERHJivaglGzHRt1Ik6jfQ+UMA0Q0OC3JgIr14mUu1F3CSCFJE9GvpdoI+zfb+b2ZQnbwwD6CASr/vhGpwSa+Wl0+9MH6vSWdeAjVzoRO1AaFmImrv Hp2Sdurf +F65/yrOcrSE5lIFz8UyMAd1j4e3HkRfz6K+pfnDXD4WKpebosUWxuxM3i8wXo4ui88M1bNoU3Bld0eUHNPXGWcSzAA3Kq0CYATto14YhC61FAwsB9bL6/eXu3PbZf9l6yKNL+BWF0Oj/IiwnzOT1DF0+cPnffn8nLGMdKwlc/Nbk2AjdW5tumy4NtAz99NJQrbzyjslYgX5tk0PB+hn5sBYO8hrAYi/23Uxoxdfwba4SCMAH+vKgSaSjgSk6KFdhZT0jEm3jq9pF5E/aUYi0414NrhpOnObNgLzySeIvENMJyz4FHG+yIMI0PdISr3hMVsjqlOMY8dKYc6BqvkRnhc7HFW9wHMdIAVIOYBYyI3XZiPPI3NiLaun0vXLtpeM43F4Mns9ceLwxmceDNI7KgOLCGC8KdZAr6RIf86vDpLd042cnXwYgIn8Izp6awRAIFxvS9ZrgBQgUZEcUDoMHVnTpxGBfICIbK73TY/PU+pAqMmG5pGUdwuV8eDc5wt4D/hI4+e8z5vWZthDe6tszBmzU4CihjaNPXGI34QYqN9Nhq7EivOLxH8rQ5BueZwUqvIgfnlbkC/Bqpn7oegXBCk7/Bqd4XIS/MORMN2A1+Hr8PQc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 10:35:51PM -0500, Kent Overstreet wrote: > by moving cond_resched_rcu() to rcupdate.h, we can kill another big > sched.h dependency. > > Signed-off-by: Kent Overstreet Could you please instead move the cond_resched_rcu() function to include/linux/rcupdate_wait.h? This would avoid breaking Ingo's separation that makes it possible to include rcupdate.h without also pulling in sched.h. Thanx, Paul > --- > include/linux/rcupdate.h | 11 +++++++++++ > include/linux/sched.h | 13 +++---------- > 2 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h > index f7206b2623c9..8ebfa57e0164 100644 > --- a/include/linux/rcupdate.h > +++ b/include/linux/rcupdate.h > @@ -1058,4 +1058,15 @@ extern int rcu_normal; > > DEFINE_LOCK_GUARD_0(rcu, rcu_read_lock(), rcu_read_unlock()) > > +#if defined(CONFIG_DEBUG_ATOMIC_SLEEP) || !defined(CONFIG_PREEMPT_RCU) > +#define cond_resched_rcu() \ > +do { \ > + rcu_read_unlock(); \ > + cond_resched(); \ > + rcu_read_lock(); \ > +} while (0) > +#else > +#define cond_resched_rcu() > +#endif > + > #endif /* __LINUX_RCUPDATE_H */ > diff --git a/include/linux/sched.h b/include/linux/sched.h > index d528057c99e4..b781ac7e0a02 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -10,8 +10,11 @@ > #include > > #include > +#include > +#include > > #include > +#include > #include > #include > #include > @@ -22,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -2058,15 +2060,6 @@ extern int __cond_resched_rwlock_write(rwlock_t *lock); > __cond_resched_rwlock_write(lock); \ > }) > > -static inline void cond_resched_rcu(void) > -{ > -#if defined(CONFIG_DEBUG_ATOMIC_SLEEP) || !defined(CONFIG_PREEMPT_RCU) > - rcu_read_unlock(); > - cond_resched(); > - rcu_read_lock(); > -#endif > -} > - > #ifdef CONFIG_PREEMPT_DYNAMIC > > extern bool preempt_model_none(void); > -- > 2.43.0 >