From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04D5E784AC for ; Mon, 2 Oct 2023 11:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89DBA8D0019; Mon, 2 Oct 2023 07:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84BA78D0001; Mon, 2 Oct 2023 07:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714638D0019; Mon, 2 Oct 2023 07:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F98E8D0001 for ; Mon, 2 Oct 2023 07:00:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 29F7540228 for ; Mon, 2 Oct 2023 11:00:31 +0000 (UTC) X-FDA: 81300227862.18.05F16BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id C0177A0040 for ; Mon, 2 Oct 2023 11:00:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IuVHAjrx; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696244428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sE/fioVyndoiPfLD2q8BtFGyullYe2NKQu6+go3HzhA=; b=40vI+gM0Z9ZRgBbkJ/aOOcKIWmOWPRyLUqOEH4WlV8ravFW8ZQjuFfKkUMrjP1kcGGCdGg 9D9ylvmKNErpLTuNQXP59eCjSx70rXgSJUeTeqx2Vu0dnpqoMS3Bjk6ZUzHyDuSayBH3IC /3NZLEUAafqCs2P+yIlgKqqo1yRbyUo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696244428; a=rsa-sha256; cv=none; b=k8ua3eHmmspkAGXPjQE1P83OLt461o8RTg6PKKpRUeHIUCoB85EXgo0h4TIC8eaV5Cc0OW FrfgFDFkNnE+c2lMPu8C4JcL5O6gr0L363ran2tG3OVt8bEl6DLs0FlvFd5w0cgciZyNqO 7jYTNU2ajMN4zRw/U1dMtqStWgBH8a8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IuVHAjrx; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696244428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sE/fioVyndoiPfLD2q8BtFGyullYe2NKQu6+go3HzhA=; b=IuVHAjrxnQlnmOtwh5cRWK2czD4AMnp5obp/95vUwFNfmh0Alee06jv59NYBSQGCY6TtLq Fa9IrpCA7xAugjnkAf4LiFOoSUN/5BSHtka7g9hjUyId70Csy1sNQ2WTWAC5X0yROVfMCR En1Fm2jLZHTmB+7ArmnIWpC3GSXHpRs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-oLgDpTjdP9CIo-5NFpGADw-1; Mon, 02 Oct 2023 07:00:26 -0400 X-MC-Unique: oLgDpTjdP9CIo-5NFpGADw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fd0fa4d08cso134700715e9.1 for ; Mon, 02 Oct 2023 04:00:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696244425; x=1696849225; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sE/fioVyndoiPfLD2q8BtFGyullYe2NKQu6+go3HzhA=; b=Bj3snE/Di2xeTqVtZ7VjLGZ80WJ4js5fS/uYE2+AnniFrajDomy6EyKUGXmym1RCVQ jrFdbtlwHzt7ez7atwRV7oN+JUndh51aNnLNOOmTPHeX88SkFSx/0WodlWHGzIUqHmRu TZMGRFM2Ee+rYWjj6Ps1NnyzlCWGxR/wEEaTwZMNoJa/s63IvkZn9Hgp3QhEHUj73SEK zH9xTx7buXtWxNi1gYLUe/7B4B5HJPYwHbNABq3y8zys55XcrR7tRWsgDOICKq3neXNn RUsl/q6ESV9afEhryhCgLiXtXaFsdgnj8coVr3nAh3dcrBmEeYbbiMs9g8eduWYPolI0 eIRQ== X-Gm-Message-State: AOJu0YwMnFsteI3qatgMTbssf6rRzmfHB0C4KN50HzYQu82VUZ3m8zpB iifH0V33z6Va6vA7XpQKLlDv+tGfnkPB0bTC2xTEJYCznKuoU7Kko2lh7jBOUPsGxMvDa/hW22I U+OW/w76tSYo= X-Received: by 2002:a05:600c:520c:b0:406:7232:1431 with SMTP id fb12-20020a05600c520c00b0040672321431mr2380544wmb.33.1696244425570; Mon, 02 Oct 2023 04:00:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpz5EnA7VUhjf8bxBaFi8Q2J/OIhu65nFbWQC3K6Vf2VMyOLsEW2oCO85ItfFHZ33XdZIETQ== X-Received: by 2002:a05:600c:520c:b0:406:7232:1431 with SMTP id fb12-20020a05600c520c00b0040672321431mr2380515wmb.33.1696244425233; Mon, 02 Oct 2023 04:00:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:f200:cb49:cb8f:88fc:9446? (p200300cbc735f200cb49cb8f88fc9446.dip0.t-ipconnect.de. [2003:cb:c735:f200:cb49:cb8f:88fc:9446]) by smtp.gmail.com with ESMTPSA id 11-20020a05600c248b00b003fefe70ec9csm6996004wms.10.2023.10.02.04.00.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 04:00:24 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 13:00:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/4] mm/gup: explicitly define and check internal GUP flags, disallow FOLL_TOUCH To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann References: <5b20f3cda7cd841555c2626f98d23aa25a039828.1696174961.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <5b20f3cda7cd841555c2626f98d23aa25a039828.1696174961.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C0177A0040 X-Rspam-User: X-Stat-Signature: jqrqbtcu6ok3uyombkbiusj4398uz6aa X-Rspamd-Server: rspam03 X-HE-Tag: 1696244428-995857 X-HE-Meta: U2FsdGVkX1+eUcG/y1343tDdnXO6GCfz6rM3qlaVgXjY559WDFexFIdpXJ0Wxmi5GaQAn3RY08+WJcG9U7Rc4dG/n0SDj+GYC63rIzPMb+qSbGROmi0WHvwM4IuNokebdHtWGboiDZ49lO4ACYhWiBd2EJo9tugapAncYzv3B/sj3fmNmDZTRTockc2HrUPbzV94hK3uq7n+mnBBcIhDSbplMkc9RSP1C9uBzZttLy7knSlEkzCto0akMy7jS+o6MsvaMp4nYyBhJqieAe9Jqr8RHYC0AI7Td6h6uKOa8iM1a0URUNl8o1oN38029hXjxbYkMG0PcCqBwvOEUzcvuvuZ7sfSufYI8LsVx9zxVkHUZ2ZTjg/1fJawtiXxEmfkxSvvkMPBevw/EDJzgqqSvqXZvFFif3/5gj7VrTUxvEqGMNSiCPrOM2xVfTnVLVRtm2IQF2cOeRi9lfBu/ZBl/ElBd5VlyO/pCS5q6FEDrF+T4q4PQEEfS9iMOL9kVubkNDpguWhcm9sB+hQLmvlIgBPOSLLL4KAze9TRqxZdndro/wTSmjk/NQE5PlBajEL//vEeJNmToNp15GfDiBa/w2L9bfj6BHRMgQ5QZ0I+0OOTFdm1FD3s1rhS8hmb8J7FNVyxRy64dcGlwTaxOz43MPUK19gJzPm+uchC7FAkJs2iz1hF959hGs/ZuprPpQw2OeylS3MrOnPT5SY0ZgmIjXXxraGalMcRixRdtcrm2GQIHtW70Jrv3jRkEYjzT2SDX5x+0GhLabW1zUDzPkrJPdWngcGnWW0LXzOwqvOZS/XeUlSbRKl8l6enXhgEAKgPe2G0qzouVmD8DOOHnjrph2JKfFHs/GrB146OxBUbG7QkS8E8Cv+CcsC0X35mONzLPmTa6wIFa8cqd6/urSuW6Q2+wA9OV6z57U/tuU48p47134eY5Mw9+LtZH2dtsL5H9w3zh8nnXDaJDexpyiQ WXalTCDu yc+whwutGLZUt0Ca3t5aOGhxREd+DAP0sGHCRwB/fstETGDGJ5VJ9LFPSyywIkOkKIUyLqppbfe9sL4qYQbdwks3tSuGF15L9bSXZaDg3BGNNd8Wtc5wrFJUfQ3oK6AKStOVMNaWTxiyDJPAnKykociQ4mZeFmeET6GXbOuoPy6NUUXfrIIFWeyvbgh6hAGZJrv5oyrRZqaZ/yDE0dT0TkGtiFvrMMQgah6WGryyL9xSFeQXfk3Xq/aRN+xpzQKdc4PfytjoIPNb0ZnjgCFfe2XnuWLPHx/sMXcsz+oGGjyLHdSLEmHv4BYls7A3rRWEl77Q5llMhzOOlUFUXt/PkLSpgy743Sy+b3Y+QzdzG6CFSNaLGteveNEJQDPIgAkXcBq6ROrcUdjHckWn17UfV/uXCGfQfCI9oJ2WqqVHJLMpEvl7FI1t6VW5b6TrjuV7mkwXwDuT2ZFdo4/CkRS4MeeUPu/BxxRfKjs+T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.10.23 18:00, Lorenzo Stoakes wrote: > Rather than open-coding a list of internal GUP flags in > is_valid_gup_args(), define which ones are internal. > > In addition, we were not explicitly checking to see if the user passed in > FOLL_TOUCH somehow, this patch fixes that. > > Signed-off-by: Lorenzo Stoakes > --- > mm/gup.c | 5 ++--- > mm/internal.h | 3 +++ > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 2f8a2d89fde1..b21b33d1787e 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2227,12 +2227,11 @@ static bool is_valid_gup_args(struct page **pages, int *locked, > /* > * These flags not allowed to be specified externally to the gup > * interfaces: > - * - FOLL_PIN/FOLL_TRIED/FOLL_FAST_ONLY are internal only > + * - FOLL_TOUCH/FOLL_PIN/FOLL_TRIED/FOLL_FAST_ONLY are internal only > * - FOLL_REMOTE is internal only and used on follow_page() > * - FOLL_UNLOCKABLE is internal only and used if locked is !NULL > */ > - if (WARN_ON_ONCE(gup_flags & (FOLL_PIN | FOLL_TRIED | FOLL_UNLOCKABLE | > - FOLL_REMOTE | FOLL_FAST_ONLY))) > + if (WARN_ON_ONCE(gup_flags & INTERNAL_GUP_FLAGS)) > return false; > > gup_flags |= to_set; > diff --git a/mm/internal.h b/mm/internal.h > index 449891ad7fdb..499016c6b01d 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1018,6 +1018,9 @@ enum { > FOLL_UNLOCKABLE = 1 << 21, > }; > > +#define INTERNAL_GUP_FLAGS (FOLL_TOUCH | FOLL_TRIED | FOLL_REMOTE | FOLL_PIN | \ > + FOLL_FAST_ONLY | FOLL_UNLOCKABLE) > + > /* > * Indicates for which pages that are write-protected in the page table, > * whether GUP has to trigger unsharing via FAULT_FLAG_UNSHARE such that the Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb