From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164BDEE14C3 for ; Wed, 6 Sep 2023 20:04:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 579E38D001B; Wed, 6 Sep 2023 16:04:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5297F8D0005; Wed, 6 Sep 2023 16:04:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F2008D001B; Wed, 6 Sep 2023 16:04:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2D40A8D0005 for ; Wed, 6 Sep 2023 16:04:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 03130C0F41 for ; Wed, 6 Sep 2023 20:04:31 +0000 (UTC) X-FDA: 81207249984.05.48BEFA4 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf27.hostedemail.com (Postfix) with ESMTP id EECD74001D for ; Wed, 6 Sep 2023 20:04:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cPtMU4s0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694030670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bmMcIhh+Ry+itSHZvmgtEh+vsvBByJvKXB6RAM9pNGQ=; b=m2kgO+UinXKwioaxLRKYrJywXb54m0IcnmLK9FTD1DcF4aVf4wPNjKDYvMKlBihcNtp3qh 5gIF8HzX/RVhLXthRCchBpUch5/VSEZ3oFYN6e6834iV+HXO4ZNrnqb7GebqyCUtUwnpi5 9SBtF6Pcmwi2ui7JZrgcgWiurSshBiY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cPtMU4s0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694030670; a=rsa-sha256; cv=none; b=eYUkfx3OZgcLURPJJ4gPHAYrKr6Asupw8ZqKY0Ow/xluwZbvIe/Lkk0oIXs7BeTT29F3Xx YaTd7HKO3S0byB9n3eyFARWg3UBsnBNUF/fKSRCXXpBNH+fUAWRp4tfNjCZveUoaB8BKQT pbnhTf7byok2OpzxnQse5w9LJNqkT9o= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-401d80f4ef8so2791985e9.1 for ; Wed, 06 Sep 2023 13:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694030668; x=1694635468; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bmMcIhh+Ry+itSHZvmgtEh+vsvBByJvKXB6RAM9pNGQ=; b=cPtMU4s0VhkC14OyImZ/xQKebdwgDX4Dn/Ryr3u9S1deTId0rCHl1/cHhlCgWNXBrF 09amOf2oVzAnongs+KqAERtDgH/+zp1N2Geb8AJG+9AJlDYcw8RroOMTMVsQXLfS2inf jJSyUjiWxCLat3UU9CMDrac0XZYJVb7mySu0QvVifltBs9A/9NTtrY8JpP84dhptaOPs 7c3X9GPqZCGXazGujaZfD4D2WAmsS1M7TcOhhWiTJ00BZJ8dM3zjpPpZXnKjWQ00A/M0 3pnjGOaRqqylITy+tSrAWQxxOxNdQubetHkoQ1ojzFNyJmB2PELk+cjQF+Yq2B4FIEGy kNkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694030668; x=1694635468; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bmMcIhh+Ry+itSHZvmgtEh+vsvBByJvKXB6RAM9pNGQ=; b=jRUOGPRiGgURta72ybRsqsWD/64pSfJlkL4mnLv9+tOExavQs/0XwMZdr0Hs3vq982 opgS40/wQaptCOlGHBQuZAy6h8MNn+g2cOrYB1pF8z9fHWjpQ6Ey4YgrVb+nIm7OcOdF THo3OoOjUx8sEbQFttPzREVIU8tr/oBbfR8/VCvcq/x2B13wSKNYI9ETdw/la19rR2B3 6/Dk3RwI26P6czdEgHMquTFHfyt8mVjNmI+BqYDxKbO/wSbyy1HvbruFDrxEYFRJhf4n 2n1E86VY/Hk03H0bjv5b69kqn0Jzi+LFQodWKPKnHsk0EROwdXIKlpFi/rPWNbvMUF95 q6Dg== X-Gm-Message-State: AOJu0Yx4KAughZUENFFLRgO2QTwsOt9qBmcUVzXTZ8jPu89yqJLJ9PLg J+thnoaOT48pw/HhzMdMgYc= X-Google-Smtp-Source: AGHT+IED9e8NyKsYHfBWulB6kYls5zZxPwU85t53yVMQaP9ruOmWv6lEezcMNAM4Yy4mSlMFvVsKJQ== X-Received: by 2002:a7b:c3d0:0:b0:3fa:8db4:91ec with SMTP id t16-20020a7bc3d0000000b003fa8db491ecmr2959693wmj.10.1694030668261; Wed, 06 Sep 2023 13:04:28 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id x16-20020a05600c21d000b003fbca942499sm470054wmj.14.2023.09.06.13.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 13:04:27 -0700 (PDT) Date: Wed, 6 Sep 2023 21:04:26 +0100 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v2 0/9] Mitigate a vmap lock contention v2 Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829081142.3619-1-urezki@gmail.com> X-Rspamd-Queue-Id: EECD74001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: k5iam8ztc7hk1paayd1exx4441uh5gtu X-HE-Tag: 1694030669-806699 X-HE-Meta: U2FsdGVkX19PCdw9I7ZkBOJJEiaDnJnp/Y9NAC6C5CBhGejlJIkm9YiF4Pq2CDUULTagSJKGKKPo2IQoEoCfE99/eJ9BaelxywJOiwY/t0okZEoQlXMDytX+dZsVIYiZ45y0D3TX+QT+hQdCJpFsWODSrOskNTNhW3cf+mUJoOAKLlmkJhvIc2bTdDPf+cuOgfaf5cfkQESDygFNvfPpo8wQrcILYBstRfzU4JncdErLET75QvFwBRwyEGz+kPOyARYyxOu+uNkU9DYTLDhmVwbBLIhiR9npnBgfllzwAwZ7Pl+jakUU+w1IkqZ6LRDWveqFP4wS/3plHLiLuOTyto/arsAjrfB1ODDggsO3Krr8jCJY0Klt9csLpetbxWWr+GlQStVEDOl24LrtCTnWwqdEFxNQeG2eX8j9DlIhPrh92/pTLb3H7C9OUN8U+raG5v8V8DfKkXq1Tkddc4XyabUdoM4+83cXMH8vnQ48AZTa0rbNsaxheGRqfyI7xhV9Sg0gIRBDfk9Xb/PjpWN/uO6roE5UIG3JgOKADX3ZseHgWGgig21g0gmoztPUTCNJs1WIsCJqhD35CZCGVQdZhH6YJVzIEpMKTxW8Y4C/99rHNwBfu9cQDqPMWBiDZ2tsf73Q6o29gqiSDK5PzLDuzF+ba85l6FBxz+40JrqIXP8bUh8V5wEHadnL1VWhDSIpzW2+NPMecVQk0trXfeHbtNsKuViHFkNRKOPqChGQHZ1rVWn4ElnSIZAaikPoe7N53LLehnyqgeYxEmKo3KBo0+hjSGiZ5S1vcStq8w5tZS6pVGZ0cvsFJuyJNtq1xHXTDNmJ+IHjCantG8KUpoF/oGq6k4oeg0CyM+gHeCrPGNibQCQZfXGFEN+aAZN8rauzUSTbqXYM7d7sX/WWPaAxt64/YifnXCOFFZR9kCbY7mKqJNZOnb4bk5i/sKP98MleFECynTQIgZ/p5feC0GN PESd/iZ+ 8YgXFICRYaa1jOpKrsI/hZgcAB+f1g9qXNxvBNcgST5M01OXQIoNYXizj4tDa67IqthoFG+CajvuZAoWn60L4hk7Oha8/SxOBEZU28oLtjtfeNTWf+aFfhOy9kH7rzXe6I8PnM9peoU/lpjnU306e3tUnRQEwQJimyaLgz06w7YDqiR6g86gI8UthvEBemSdePa3jDChjNSgm8oEvaqMpeerh+HRkWJedrEG8FHRw5kyEFwLszvsQewUaqaa1iT6wfHXYjzLADtPqx0e+7iCDEgfAV4+NrYFZ2LqxEvppoJY7kv8hZZjOontvhzQ+NmXqPxZZIo7DKYq++K3Y1QQ68VetD3csrJ2zkhsTgqSdXQIDGeS75FTCGaG1H24EH4kGOBE4OdsIO2SNFKsDn8jAe+/YtLlQYebTZK2tSIYAJrXgUvSAN1KbtRa+3neRnf0t7MjBJy5w9JoNWDaS9T1RzWv0CCFhQl7ya0b4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 10:11:33AM +0200, Uladzislau Rezki (Sony) wrote: > Hello, folk! > > This is the v2, the series which tends to minimize the vmap > lock contention. It is based on the tag: v6.5-rc6. Here you > can find a documentation about it: Will take a look when I get a chance at v3 as I gather you're spinning another version :) Cheers! > > wget ftp://vps418301.ovh.net/incoming/Fix_a_vmalloc_lock_contention_in_SMP_env_v2.pdf > > even though it is a bit outdated(it follows v1), it still gives a > good overview on the problem and how it can be solved. On demand > and by request i can update it. > > The v1 is here: https://lore.kernel.org/linux-mm/ZIAqojPKjChJTssg@pc636/T/ > > Delta v1 -> v2: > - open coded locking; > - switch to array of nodes instead of per-cpu definition; > - density is 2 cores per one node(not equal to number of CPUs); > - VAs first go back(free path) to an owner node and later to > a global heap if a block is fully freed, nid is saved in va->flags; > - add helpers to drain lazily-freed areas faster, if high pressure; > - picked al Reviewed-by. > > Test on AMD Ryzen Threadripper 3970X 32-Core Processor: > sudo ./test_vmalloc.sh run_test_mask=127 nr_threads=64 > > > 94.17% 0.90% [kernel] [k] _raw_spin_lock > 93.27% 93.05% [kernel] [k] native_queued_spin_lock_slowpath > 74.69% 0.25% [kernel] [k] __vmalloc_node_range > 72.64% 0.01% [kernel] [k] __get_vm_area_node > 72.04% 0.89% [kernel] [k] alloc_vmap_area > 42.17% 0.00% [kernel] [k] vmalloc > 32.53% 0.00% [kernel] [k] __vmalloc_node > 24.91% 0.25% [kernel] [k] vfree > 24.32% 0.01% [kernel] [k] remove_vm_area > 22.63% 0.21% [kernel] [k] find_unlink_vmap_area > 15.51% 0.00% [unknown] [k] 0xffffffffc09a74ac > 14.35% 0.00% [kernel] [k] ret_from_fork_asm > 14.35% 0.00% [kernel] [k] ret_from_fork > 14.35% 0.00% [kernel] [k] kthread > > vs > > 74.32% 2.42% [kernel] [k] __vmalloc_node_range > 69.58% 0.01% [kernel] [k] vmalloc > 54.21% 1.17% [kernel] [k] __alloc_pages_bulk > 48.13% 47.91% [kernel] [k] clear_page_orig > 43.60% 0.01% [unknown] [k] 0xffffffffc082f16f > 32.06% 0.00% [kernel] [k] ret_from_fork_asm > 32.06% 0.00% [kernel] [k] ret_from_fork > 32.06% 0.00% [kernel] [k] kthread > 31.30% 0.00% [unknown] [k] 0xffffffffc082f889 > 22.98% 4.16% [kernel] [k] vfree > 14.36% 0.28% [kernel] [k] __get_vm_area_node > 13.43% 3.35% [kernel] [k] alloc_vmap_area > 10.86% 0.04% [kernel] [k] remove_vm_area > 8.89% 2.75% [kernel] [k] _raw_spin_lock > 7.19% 0.00% [unknown] [k] 0xffffffffc082fba3 > 6.65% 1.37% [kernel] [k] free_unref_page > 6.13% 6.11% [kernel] [k] native_queued_spin_lock_slowpath > > > On smaller systems, for example, 8xCPU Hikey960 board the > contention is not that high and is approximately ~16 percent. > > Uladzislau Rezki (Sony) (9): > mm: vmalloc: Add va_alloc() helper > mm: vmalloc: Rename adjust_va_to_fit_type() function > mm: vmalloc: Move vmap_init_free_space() down in vmalloc.c > mm: vmalloc: Remove global vmap_area_root rb-tree > mm: vmalloc: Remove global purge_vmap_area_root rb-tree > mm: vmalloc: Offload free_vmap_area_lock lock > mm: vmalloc: Support multiple nodes in vread_iter > mm: vmalloc: Support multiple nodes in vmallocinfo > mm: vmalloc: Set nr_nodes/node_size based on CPU-cores > > mm/vmalloc.c | 929 +++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 683 insertions(+), 246 deletions(-) > > -- > 2.30.2 >