From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74987C77B60 for ; Fri, 28 Apr 2023 06:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87AFD6B0071; Fri, 28 Apr 2023 02:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 805326B0072; Fri, 28 Apr 2023 02:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67D946B0074; Fri, 28 Apr 2023 02:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 514026B0071 for ; Fri, 28 Apr 2023 02:15:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1882F12026E for ; Fri, 28 Apr 2023 06:15:24 +0000 (UTC) X-FDA: 80729787768.02.48A21F2 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 27C3A40016 for ; Fri, 28 Apr 2023 06:15:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=jirislaby@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682662522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nKg0o2X3zUwk7C1FxgskinEP8Y3FsAVaj1+iPRtrTLM=; b=s0S37gtf608Rb4RpDtnuZJA6PDlckBQGaUH45+NjBHqk8g/TsNxFDItnxaejDnU+tViYsJ uc40BnEkyHl0ULRXArLecVwH6tr2qvbf0UEMKzMMI1mjZI73vQNHfPXpZylcl5KBSFBix6 78Kpgghr3yvfK/Obvl3yk3gyLSZWTQE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=jirislaby@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682662522; a=rsa-sha256; cv=none; b=wXubABe9+oNZUSFF3fIPAV0hxpHn9ZtmAp7DGp1YZIDXJe7gBK0SAAVVFuJSoJpGTCezH6 6282Wl7BIOhTtXfYnN1jYdroDUec222fySz+CcG+TP8YZqmKdvuiId+UyVAG7Ssbcxy4iz KOVSVqBszEnst9vriJ7/2F26QCB7kHA= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-504eac2f0b2so16342574a12.3 for ; Thu, 27 Apr 2023 23:15:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682662520; x=1685254520; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nKg0o2X3zUwk7C1FxgskinEP8Y3FsAVaj1+iPRtrTLM=; b=Ac0bqo11RT0CQ/OxtxxgGwDhjYvZViYu0trxB2zC6/8FdTqETUUN8iJ6NXYC8Od8pl yOHXOfuqahuKoZUCH/FaoBST/70UHegiQMjjt98AOmV1yeXOcNzXw2tCZTQM7+1N+xMR UXnmnBTX3noYHbiRoFayMj3Mnj3figRiZLUUf7XSYYc2Y7xhMpQgtU6i39jGWLHcPvts NUmrcYWFhoo7gqSmVM/P6Z55CTSvz0VYRB7eTkgLjNQGDeHPBdWmigoQa7UnLCpx0DXl P5oPc1B5jWenfDUKlQiKRabRYi1Eg4sUCnaJPE8802RzLw1EBaUzXAbfqCpzl9Jv6wuM eBHw== X-Gm-Message-State: AC+VfDz4zYXA/9IsQtFi+2tN+DqAxhkHIQHtGeDBebYS8a7ilYgqb1RU aI3Ay/bBzb6s8FwjLxn51QE= X-Google-Smtp-Source: ACHHUZ6EMvsXSqUHkSdrzd/E0ByCGNrcKMWu7/ohpHqyvp5f/plsxP+8DlyngVbdVoo0IoCjp1iLbg== X-Received: by 2002:a17:907:9347:b0:94e:ed5d:8777 with SMTP id bv7-20020a170907934700b0094eed5d8777mr4092020ejc.25.1682662520293; Thu, 27 Apr 2023 23:15:20 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id 26-20020a170906101a00b0095729352bf3sm9256078ejm.215.2023.04.27.23.15.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 23:15:19 -0700 (PDT) Message-ID: Date: Fri, 28 Apr 2023 08:15:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH for v6.3 regression] mm/mremap: fix vm_pgoff in vma_merge() case 3 Content-Language: en-US To: Greg KH , Vlastimil Babka Cc: Andrew Morton , Linus Torvalds , "Liam R. Howlett" , lstoakes@gmail.com, regressions@lists.linux.dev, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Fabian Vogt , stable@vger.kernel.org References: <20230427140959.27655-1-vbabka@suse.cz> <2023042719-stratus-pavestone-505e@gregkh> From: Jiri Slaby In-Reply-To: <2023042719-stratus-pavestone-505e@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: q6i4r5rey45qo6y3qo45zq6xii7nsco3 X-Rspamd-Queue-Id: 27C3A40016 X-HE-Tag: 1682662521-697304 X-HE-Meta: U2FsdGVkX1916bEZj4381oNfoHactg0/pHbj+7oGxwXMq5NPsKD/p/tkFYcMOEFBGcN0Qm4FTGUEFp411sogZw5V1ziawVH3/4cMFhi1O4UwlspYtdq+4XZIISr6IbLqZ9B3Dl6ECY2aTpY0c01oCHlpG2qHe7AZ0z3bgEyLhaGthGrgZzCDmGn9gf8MPSnDNdAAhIxMoCLg9ozzEtM/x6K+BAOnzsMRdOLRLdKBTSVf1YvGoH0AQ4sOvwRJ6vNhyVQbKjiTXAU/KuPDdXVThPzRvmWX7R8p6kJ72Ry4Eih4Qi9C0R3/iuJ/Qso62N+IWV37GZwV4ZidjrDYNc2wTR1M9a/J0o38Roi9hNkx1f2xYzOrxCwj57CfN4r1hoBU+JyOPWwO6QoXGyTUVJ7ybQ6SWVlnufHUGWMgTcQJToneZx3w843TlD43lOpdIcAMftt76nIqSJRGFj/4vg5i+ZFjQsP/QM08jAtSITHPxDeaOcqNZEIcSbxtYB1fh3iC+HDJAxbIw0kJIJ+R+Ck9Oz7BH9+dxBedTE8u0HiQxqYTfEc/ODsUmMmKSA6PImWHZa44VsIZdlAVRNSEd+/AS4pi3og+RWRUzFqNP2guYE/tziErMoZstnoA7+9NzfLOh5wuQwus2QKZZTjCR31VvfwURqxcONpLFJUOWLMJUguHldjtZKiizjcwIJL7w+Z+fKvjyaOBVKnUcZqDSHJUJDEhu6n4/otP0QJhc5AWc6zUAvZtOlICppmAsnHtM3rZu8BHU41aigqnFz8j84WnRGT2FehWYLfGxm0Et9WEJzmjRE1Q+tGKjSabekMxCM59TOwSvkFI+qtciOdOzq35NqLii4j3n2AXN1sqWGVPLnYrdotMPI6C3P1d9vXRpId8tocc+Z9sW1/MpBr9bZaIq2nuZjuFwn+auou0fhAdDWczqbNQM5yz1UXSQXBlxgpDTBK13VSW9uxEE5emo2Y u/jLGEPN 5+Vlv83iMDHqdWe/Ab2YuOppDsf+TJGHVUfly1N52u3y5fZ7htewguRChun+yKB6V3oLJKFj0Xwb/7w8P5Pxc5e23NhuJ94jLbkYXl1H/80G4gq1AEuNXhotSZgoLLX/BCL2IszGbmq0Imc/Yh7+h4cL+A244cvg7gRWKiaEcFnkz82xVQqY59uxIwpMnIW8Ex4/i9dWr/OZ+Nlm3K/82oQYQIiGuysjXqcpTiILCr7DOyfO9rIM8mZifyyK8zvEBiRO1iSbri0TQZ2vhLeUfMENYNAJ3mIFINZmB1TsAu57Vx7dIomPM+jANe4XEi+56m8RjZAaic1kC3kb9zGSEBtyQRQ+o24YoZlnSALvkadadujyOYYwiWz/RQpBrnPzv8B4N+4Cm04D5Pf+sdEnD5n60J6yf4osbXKJ+cyvxyHO8SUm8rVXVYI2i6fgJysvcMSPgEqIwtnqmuBlrcLzoBL6yOqtWrbnaAyAsEq+gfhJdr+dI1ectj0JMOAWbIEgAn4jXvRdE0g0m2OeKpl1/GA6MqDd1Oe4/yd5DxshehfzJF2g+WcA88ZgGgl0bY3cfhHE5eCWR+LFwF2qIvJvusAEKwsi34o2ewWGqRR8Kwx+gy1ef9LDSZu8cVzwGENxhgvYywfz5haPzd80= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27. 04. 23, 16:27, Greg KH wrote: > On Thu, Apr 27, 2023 at 04:09:59PM +0200, Vlastimil Babka wrote: >> After upgrading build guests to v6.3, rpm started segfaulting for >> specific packages, which was bisected to commit 0503ea8f5ba7 ("mm/mmap: >> remove __vma_adjust()"). rpm is doing many mremap() operations with file >> mappings of its db. The problem is that in vma_merge() case 3 (we merge >> with the next vma, expanding it downwards) vm_pgoff is not adjusted as >> it should when vm_start changes. As a result the rpm process most likely >> sees data from the wrong offset of the file. Fix the vm_pgoff >> calculation. >> >> For case 8 this is a non-functional change as the resulting vm_pgoff is >> the same. >> >> Reported-and-bisected-by: Jiri Slaby >> Reported-and-tested-by: Fabian Vogt >> Link: https://bugzilla.suse.com/show_bug.cgi?id=1210903 >> Fixes: 0503ea8f5ba7 ("mm/mmap: remove __vma_adjust()") >> Signed-off-by: Vlastimil Babka >> Cc: >> --- >> Hi, I'm sending this patch on top of v6.3 as I think it should be >> applied and backported to 6.3-stable rather sooner than later. >> This means there would be a small conflict when merging mm/mm-stable >> later. Alternatively it could be added to mm/mm-stable and upcoming 6.4 >> pull request, but then the stable backport would need adjustment. >> It's up to Linus and Andrew. > > That's not how the stable tree works, sorry, it needs to be in Linus's > tree _first_. In upstream as: commit 7e7757876f258d99266e7b3c559639289a2a45fe Author: Vlastimil Babka Date: Thu Apr 27 16:09:59 2023 +0200 mm/mremap: fix vm_pgoff in vma_merge() case 3 Please queue for 6.3.1. thanks, -- js suse labs