From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2558AC7115B for ; Thu, 19 Jun 2025 08:49:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C06E16B007B; Thu, 19 Jun 2025 04:49:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB79C6B0088; Thu, 19 Jun 2025 04:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30F76B0095; Thu, 19 Jun 2025 04:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8BF0B6B007B for ; Thu, 19 Jun 2025 04:49:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 30DBF1207F0 for ; Thu, 19 Jun 2025 08:49:58 +0000 (UTC) X-FDA: 83571527676.25.34EF3D5 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id D4BB980005 for ; Thu, 19 Jun 2025 08:49:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=H5kK8zTU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xx8zqzTB; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750322994; a=rsa-sha256; cv=pass; b=2StC3Dwy3lnPT8OITzeul/mk7ff185S8lIv54mzJtBXsr36WIgl7ckXkQ9lAZKvAeEDjVQ 6Dnit9tVsaITTlKtQxfoDGsXdwBWdB1IGyHJmafRCqXDBzM6YctTKJB7ttomqOfbwl6MpQ nNiP0O+C1y55y6ReClT3KqFEmXQ3m3Y= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=H5kK8zTU; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xx8zqzTB; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750322994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sSb9/7SLUHt8MNAwREMc0HtW3o19brWt5WW5Swr6YlM=; b=sYkae+qzeo/RVOwpZZNELj1zxem4vOrlfnbTKOD3CkN49HZ7uqLz/ohUu/KfhagZ/rAGhZ BRJZSvy8Mr+LdUASrFNG6Y8nQehwPOkPw6qsr34Zvl0kNYwXO1mSbB/fMeCzcT+oz4jQK7 9ELBhQcJTg6x8zdNnDFSqavtFdUakGE= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55J0ftTQ022043; Thu, 19 Jun 2025 08:49:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=sSb9/7SLUHt8MNAwRE Mc0HtW3o19brWt5WW5Swr6YlM=; b=H5kK8zTUkV40MNvyk/WkM9ryuWycKPYpKZ qtg6A0ZOjNmeC8ITBJ43yc1hT2EW2nAppoKUCT5u+f9QA+gdQUKvk43YocvvWVj7 6lTh6d36QBpALdN9XJEc3rR3LJ33vMjFgHxD6UJxr1pYo0Dkk2G9x9KTmlLfPIPi 4BrKwnD2me0lB/i02RzlZaLvE1jZRJ2u0+G2qoIo+uBnR7yDSPWXDdAAFMEZbVM3 9VGPjEP/GjcmBLy3Zh9ymYElCDWmnGhS8qbqAeNF/hubNWgxbHYRZXzWDQ0X1DOp 6d5ai5iAN7Fk7F3jp6ukU2eAVPCrrG7scLZYy1DRykq3kDl+bsLQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47914eshh0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Jun 2025 08:49:09 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55J7A2rt036406; Thu, 19 Jun 2025 08:49:09 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04on2049.outbound.protection.outlook.com [40.107.101.49]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 478yhj63xc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Jun 2025 08:49:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M4SL42vuatOTTcoDDF0EBEdieaXKqrnGbAHbz2HJYgS6R7kzRFgTPVtq+Zvq4c3nty0sH7dvrgbOZhCJCBylHTBa+9mwGfqW2/f9sIzwPzAFSD8iXHI68mK+6fzBo2wClUlpSe/D2oCgw4u2mUW5vFu+J31K2v7DS5ZfgihRJ42IyQsVCi0xgsv0PEruSITK+MGnUOUw5X8J/vYyolv0q7zuJz88hNhxiMBFK3216p9YDbqSzV0a7PdFXPUGmYMUgzKJaAjT5YpB+tzG+v6+26bE+PtGHlN74uUGheThl+TKeF6VjWptdkOVI+U3MdtGZNOTApNENDkH7AEL4iO45g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sSb9/7SLUHt8MNAwREMc0HtW3o19brWt5WW5Swr6YlM=; b=VT5e6B+c2V+zrSgn3HnpAOHRa6aAeoObwv8gdSlwX8sTq0TwSYkrc7SNZ/OdpG96z7TKZIVopENK+t9d/jan8znYpOg7QHiScE3gumgvAYyRnZREN7/xXe8RVyd78YZ1QeiRAZ9afUMfU7l0KKDF3qbyNi2cEKbSeOQVtR3H/1jY7fOKHx71pzRx/Dek3b3MfkCqdhZwXA4jewb2uSbJDqAKTT7me6o3YcAZib4lq2Du446FUra5PcyMcZvAUnYAfOz4DGGGT6W+Ra0ifkohO3oGmLPuEUeR5WTksDjfbVnW7MYq30ZW7I49MNhc25m/AFqZJMf2QdGgQuKP/DXmzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sSb9/7SLUHt8MNAwREMc0HtW3o19brWt5WW5Swr6YlM=; b=xx8zqzTBIl+wp2kx5vFXeGWgyifUMUAhF2HuEIap5/81aA+1GsKExUiL+Kge5u7qZGGwE/UNJDznSJdV3GmaBwmkjEQi7Z/4oVW8t08TbVnjZg0JRFcdmNVMiAHpUJ4ckCm1NqY2V95VVy7yf0oV9+FrUDxAHyA8DNqOtBR5eVI= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by DM3PPF3494AF07F.namprd10.prod.outlook.com (2603:10b6:f:fc00::c1b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.26; Thu, 19 Jun 2025 08:49:05 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8857.019; Thu, 19 Jun 2025 08:49:05 +0000 Date: Thu, 19 Jun 2025 09:49:03 +0100 From: Lorenzo Stoakes To: Christian Brauner Cc: Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Jan Kara , Kees Cook , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Oscar Salvador , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: change vm_get_page_prot() to accept vm_flags_t argument Message-ID: References: <20250619-unwiederholbar-addition-6875c99fe08d@brauner> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250619-unwiederholbar-addition-6875c99fe08d@brauner> X-ClientProxiedBy: LO4P123CA0409.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::18) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|DM3PPF3494AF07F:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ee308ea-9a99-4a15-ab53-08ddaf0e259c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zehwc2hWklCQzHk3RQAr4cV8oebzABNIFrOdgvJ8ppP/W6IcVFk/ywMVFbjy?= =?us-ascii?Q?u17U1DSb0ojuwIvIzWylC8cVYRI+dDAcRb205k75pb1tzXOFlR5gXTApdueS?= =?us-ascii?Q?6rGsWmtvi01WQyYSvp7FyJbhBcFBrdmhxNRe4aGb/9H0mLMiAmt3iq3VzCQA?= =?us-ascii?Q?4jyRkhYJS1pEp9eORttsy/m4RuN5B+H21V/DTIgKy2EUiMQVNRXSerZgeK60?= =?us-ascii?Q?j05sgijbZti4E0lBgEAmUBNKo7HrzYwpUZdK1yO5amlTe+RCtICmhSjrCb6y?= =?us-ascii?Q?6aKJ4H04hK7jA9u8/hMApYxyFGSm0sQk96gAtzKLaq0e04uppSG3dGygAAH5?= =?us-ascii?Q?M+bHE0W+n5O/kRYw/RaelzVAI8FAuJPo1aEkhmGIVJq2NijjnUq9UJBRuFPl?= =?us-ascii?Q?08ccfnwOgUEYpUUIshkPF7CxTbVcBlvWcHcU1peuPCxH7CU7M50Q7UHxl7M7?= =?us-ascii?Q?srIyZLgoRZ6w05N7lbAw3j5nrDq05o7hQ+nvwKt65GHqaX6g+dQKoeMh6k7n?= =?us-ascii?Q?nSf3HRWqLC2D5Fn7Ql7D8gFiyfsN/I6bWJYvy0Dh71Myq1F3HzAihaGmPeAh?= =?us-ascii?Q?vNPpuhq9KISuSa9JHaqpKSIlek0PM3LoHzBbKUVN9jhhGaZHnxZIsBaL+/ZK?= =?us-ascii?Q?jXL/dzSBQrdBrdYQFfa4CfpxTm123zRHQbRRZ9C7u7X7ExX1r/qLWwDjeZQ8?= =?us-ascii?Q?gWShlduJ/qvT6bI9nPsDGea+GY0DDoU24/Vq8XplfUuYE/6TdPzju0saPXrS?= =?us-ascii?Q?6wRFTd7t5TPWs1B1bLdJ+vXaY74R7qM8VKD5JjBJxcvT3kPpYorF/Iyk4oGR?= =?us-ascii?Q?I0ppmcxpnxjt1p19jWFUF/oGTnD8VVGU0W5dyzbc17Oa95wwRgp1+NcQYOmz?= =?us-ascii?Q?YOjNda4P/YSeYwDpugqXDsgqb32qA1w4Ixp8yx4ytIBZ0yvzJVnH6LWmgN3M?= =?us-ascii?Q?e6uhhwnCo9HViCU53yKueXLkQUPjMe1hCw8GMFwWZS5Qlw0JSyKsy/Pad1wu?= =?us-ascii?Q?+78UgBcE0pksgxNJ/4qSHsi8CyUcD81Mt3xpVlfKLYpHK1KqbOxGoPGpgCYo?= =?us-ascii?Q?WbGIsg1a5dHGzTnTdeye+pcqeQAXii/4OctSU9X9f28ZTnvAsOwOdBNlwRRB?= =?us-ascii?Q?L/M9k+CZaizo//9FMMC/8pjHnBY7BCWU1tlmNfSeIBnT22P/3pCZC8v0VHU9?= =?us-ascii?Q?WNthPNBoqbrYgVOXHdzuzwcK8g+o62pDL8IKtyouS9TYH9JeeelmoLdKYuOO?= =?us-ascii?Q?AfDyS1sNlfzSHtOj43z6L6UiGbQLRB9Hq9r9BtikU0XPDzZuOYdOKvogZnJf?= =?us-ascii?Q?pM48alhXF9U/de7+t0cBX/zUSTGxmMd/3pCnOhcRWOmwyeuwynbiZk0d7W8Z?= =?us-ascii?Q?+MY49ijXnx/0QfY1mXgmiPx4SBne14kDt9dYkt1YPlwXf89iMfKm/0SNTTS7?= =?us-ascii?Q?4FMaYWLobic=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QVCgDlxha2Y3TrS4K7uyQC0pt9chHgS2sRaZEf53uH431MERtyP9iqaBCeGM?= =?us-ascii?Q?xUXSMS/2pr41zGwhSAHY7jtWvXnShyLpeGOHi5OZVriB2LpTuRlOp3WG6w6e?= =?us-ascii?Q?hzMCGuTgvMpNwjRmRGEjwi6vwKFlnHQSOECJhKCb20bmtbflLFPLL+jmm2Z4?= =?us-ascii?Q?Hjzb+iPNK50Gai2M+xaC0Kl2VFRGDwrtB6OM2ti6108BVsEpZCC2QJ+6LhOp?= =?us-ascii?Q?Rk/X/dx2X6ADxz1nYk68t1m5nEjUV+FDOikR3jze2MxmiVLmhkPOWUxMva+o?= =?us-ascii?Q?5i3vlYiOBFEakZRa6HPNmkxdTeqynYW/TZj15qEQyQtlpC9EZrO7H5YgUPR+?= =?us-ascii?Q?t15eGRoyhkAUwA4YX3ihgNsqbcYqehQwwm2lSzuLge3Ux9gckPYJ3X54Xjwh?= =?us-ascii?Q?N66lm1uUpDMfFsZt7TqWvKjUuXS0dhq9057jJ9Mw7iomgd1vLGiBdOxh18rf?= =?us-ascii?Q?FUyDMF6XJZZm732Wx9sRt09KrjsTp4WgYnhZJJwtDEi1J6SwwSPUIXFrUbEd?= =?us-ascii?Q?MvKSu55htnjqE5gRN9djpp3mW6rx4grzEn5zvLBZg6MopbDcKQCvpdlCYKed?= =?us-ascii?Q?4VLOUrkj7AIv7a+MlWc9iMrAQ9K25xo8cmeGTBAq3XZiDt7E4oy+E2UmXdiF?= =?us-ascii?Q?Ichfb0qKm9f8G0Rnxs1I7wAjD6OGE9V+7I6r6kyPapIXBTXh54aAsmv/BiUG?= =?us-ascii?Q?J2GH/sfAbYf4Bh3wE+/ZDEjM2L4jM/B290u/X6BKeCNCby7A1iNtV4tX2kHY?= =?us-ascii?Q?uYqXB9/jbZ/dzpUhb3tHsryzfJ6uerl1ANgXQC2DPDerVxADQUxqxPMASDKq?= =?us-ascii?Q?g1Jm9YL9wc8klxEN1Ibh+rq7S+Wff1ZP4bLngZsoC/gVN9T2Yce596YkuDVq?= =?us-ascii?Q?0OtfmTKdknbdal4C1Y8QbElxCR3WL+xvbo0/+1qKp8qUoFzFGaDr7Q6ch1Ro?= =?us-ascii?Q?FgTrOeXV9E8O+KGgdYoNlyZbSM57llbgTLwz7pqqC2pYCn01LRryU0qLLSLW?= =?us-ascii?Q?9FK8WUo+mK0sUkOPH0d7QjQo+kbc0kJxaL+P0vpnhY4XD/5k5yaGUnn+D3Ej?= =?us-ascii?Q?k0fFZebC/zrK9dW4qvy8cyWpDNcZBzlp9rMqijYurfehtLKTxQhvhe5qudxv?= =?us-ascii?Q?x250Nbdf0vYCtRRIVH4Eeeb1tCFOSLvvs/Jfw5F1F4J/YFU6zLJa5xuJxhLY?= =?us-ascii?Q?bDoomNxO9E/fBjTmzMZQrjyas7Sk2cly37vOPmr2tnqDta1VES4mVecguhuY?= =?us-ascii?Q?X48vnXM0zgET2Gnp5p0gn+1ZYHTNLqrEJ5msh+cpXrSMeH3Ai/6QMAJcn6QL?= =?us-ascii?Q?F/7uiYykMq4wVSukxUnh0pxeZj9aWCzzCF87ScxbfITxudSPljMTDrpEZG5G?= =?us-ascii?Q?n3BhCRFqCsKWZ66rd1E6H7hcEDYOqIJlz2aNJ397TvrLk8OqWi2c26IoRXVC?= =?us-ascii?Q?Lb2M/JxIoanrWl2xh5IBkr/sTbSanlVzzkXPlUrllnmsk1DIlyXOuuX3hwfh?= =?us-ascii?Q?iDANIbgquwRTnt0L2V9J2LCPdTZ/9GnvPi7Pzgde2snaakjkRoVMpys2/jF9?= =?us-ascii?Q?wi1VgIg6KnByK6bqbToaQk02NVuSXvWgKh/sXEi6QcJWH05IP6GBI55ZHqJU?= =?us-ascii?Q?Lw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DdruD3hqqfeqV1eQ0R92B0BrK6kfR55CicmLTcxW00nAt/zKvNsAkU71SzBi8PUWkOs7scglCxNCUhNLm4SH0y0gN6WQJ5SiL0bYeKs9zLjFSshFYrI7OisJ/kdLN50qNTSIGdzQBJ3bcOnuHlyIndKsm2ySzy1EBzPxsj95WfLHg1jDRO5Tbx83JgEJIJCyYG0rDYRm86d5DO6eK16gwzTI2tzGD4pJ0DaGPtmB+JoSCQBFIRiSmAAuIVeRJiOTF+vqICnNa+7bWClhj6Lm5cE4ucGItVShXy/sRRdicWtwsI0Ynzb1wjIaSgJsU47ix3tk2zswFE0qWILqKqTTHJO77EfsgHl2BhCo08SUJl84lhZygqQ5fBBgAaVMgsCkz4vHVB75yY7gxAVvdZrCJxZ1QxCY7HmFaA0yjBCzFdg777YOP584eGQ9GuCT/bbbEp2ZepB8dHIQNdqNT/OqhCjC0rMlEcN4SSQxfCVA4Nhnr4ZzgJC5ZZQB7L40a9Ld1gqHyRII+c4pcG5KKLbSarHsA7YJZ3ou95pYapCAlqwaIMKjOTmmBPYanezTUmDWhANPu7OJSq/zqebsYre54dDa8jx/KTFTJg7RZJ4pZ7g= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee308ea-9a99-4a15-ab53-08ddaf0e259c X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 08:49:05.2603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FUsBsKA+fLV2JkKLyGog0l2QGqWB1iX0rflZAXn8IgxfGjQT6COw7D0wqwEM93Tu8oKGAik6XC0kTA1BggfRX+Xxx9e8qrLd1gTsuD9fikM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF3494AF07F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-19_03,2025-06-18_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506190073 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE5MDA3NCBTYWx0ZWRfX4vk3lqpBa+SE i5ilOo1fir68qV2ZuoR6GLQfTq7sQWy4PnJSXMfIF56GKuqJmqw2LSf+gt4v6PY8xodCi3r5raH YBAaVy+WBcxyT97JUHpwBSZ7fzVGgjSecsQoaxpKp7RAI85QXtWpCcNWLWsU113+bGI4LZLBa/5 Q2E2QzhH7v/eNHCPuOINPORsIEcc+h55dOAkhCcO/1xKWYqUIVJgSJdKoteXRwZeQJNJWf3alSi 6HiHaYkljckM8IixHcAOxVMVymUEruVyQdiC6ErMDNsqbbOzG406yl2Lak6J+VICpX/aKhsUk8v Z3yZlHmBPthnDGRyIBR8yB18DgVwYSfQeHwgE3GH2+m25fZRZ6r+XhiT06OqRdvNv7uKCazN9Z2 WI2m0thRCiHl/byQDp3RRb0yAX0UGhflCf6M42In9MRgH8KKEWvSTcGyTmC/AI4uON3tvVal X-Authority-Analysis: v=2.4 cv=U4CSDfru c=1 sm=1 tr=0 ts=6853cf06 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=k8i7m6ecPFb9PYNpu1wA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:14714 X-Proofpoint-GUID: EJMuhmKuJi4-RkWgIJgmZbgUTP2B2UdQ X-Proofpoint-ORIG-GUID: EJMuhmKuJi4-RkWgIJgmZbgUTP2B2UdQ X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D4BB980005 X-Stat-Signature: w9dbs9jy6m9hbhq44a4m4xcpohzr44uu X-Rspam-User: X-HE-Tag: 1750322994-803028 X-HE-Meta: U2FsdGVkX18rhgZiXZzGcPJ/qRRDXjB5+kSIU+DF0oLvLen4xigO10xQ2zpoUkWGtJPx+RwKpjfD2J+4PZ4jZypx6xSTdbAAMNzwkTBp+IRnyluS97CPI9U6j4f2Q4WvH1UUDP7yxhUSO55WPIxqPWVHyOst3jJe2ML8KlJ8Ujxxbp2N6egdjn/vRuKR+J9JLXlLz+LNBJ8yG6Qp+KsvF4FW0bmCGpI76NIYmBNndx0HsZF6a/8YHHgHneuQc50nLIGHKvheRCLXiVkKZV+JhoJC5y88zsGNSqe9ZCyzWWGJuI+lkAW29i86Tig174vmSycvEUpGhh08Tht/T2OhgzcLgw7crKzMyuV2V4JPtFOhW50PCZY6UeZvzE0j/eEMBHaAMZHxjFTTI+5pF+EyUVqxgjw/FhMcC7uWMXbD3nw0hMzPmKIjaChxbXSA0SUA7KGdjXTf+agFmOcT+S762MA47DKR1DWbGKd5OfFaBYWr8ejsNu8OZ03Z9Vk47S6oTn43Lg+N4qHGgFpRm/6CKrH4qWVEWyNn6L5b0keGEs1Yi61QwJ8veWVsp3orhL1M6edsBScAyFtjPeuwe1ElNDs+e10+xg3n6S+i/ROH7B7sTo5eVhnu4X5tyd72/00xoX9TIwdI8bMV2R9iimPvUNr21Sm+LrpkOA1RNeRLHrHpuMjyChFOtzYI2YCj4UuqgYJwjcbvmvqAvzYrDPmXh1B8Ar3stpp+VI1Y4OFwsQ/xU4U1oMQUgyXdV3/LZ+7K1yUepz7m17SwvpnqK6YqrN2a7lSLKHhtdxTRkckTEjKAdNfqTR0796F0IPtUCRFozdIFE4bRjA7fTz/95YZ3tVaHD4oLAQCt1O6pfc1VwS1VZYPEusJe9Fd9DDOPUFO5ld8Fqql8x8TVxx9oTXq8gIj8AUKLx0uDBczhPHpQjKvtKbIxpq2YooLvrFx+ijYiDgrDmWhC3KseuV7FrYw Z+UpzADZ 2KHBw19R3YhjduRAkEjyKavcFB3w5fZRkAekjlVi2RX6+LfosqLXoiS3b3wbNaN83r6ux6VGlgzg+v02WdMD+R1Vmkr/V12wcuWb1oF9Dc80EDIXytH2XR0g1Zsoe1ZGLm80v/RXnSafTIrY9T0rlAd4uTdvvWjnnI+PSP2jmBxtvTtr0cGkE0LL7HTE+4RnwOF97CD/F0JCFAju1WO9mNiX9uslA+cIVY27CZBXf4hHAremBNDjfYG7CFgH4I3eXBsGeGhEVJoxFxSBHsoDh2s4cxm+iS7ug8YUy8zH3B6uvsCF0ZOAwL7ZQTKKUPH1qJqjv23XNY/k2yc8t4wCpriLvyAh6M+0YIPOXSOfp+OYNBMpP/8We2bBZiDf8OxYqLWOI2v+AKX8DnpJvfs8yydPnlHfMEBoaThW+68ZjrXj8sxkAb/MugrYPOQCv4YqX+hARcPepWNx6RlNNccHz9fJSbMIP4rl9xY00pmwj+u57hq6E0hZXR6HLMH4wFMnTW31tLh9VtXj5JYBTchV0AtD5RQcXmP+BvhnnRqFAcWZ0UV9Z7lrS7a6GuG3blOHGHfZ2dRTw9sBEiLbQokzkyQfo1P8aQqmxD4z0/X2cRPrC71M9BiQ6pbUDlMmjgzBzl5kN8ybSRrvOvakElUAwX3WOrXdPL2/HwcJ+d/0YOLDe6NDV2jSVJBdPTQBv9sR8/6s+oQQFJeWwRxyLlyNkWepCiEvh9+pdjiY99XV7pCk3RlANNx8N1LXbdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 10:42:14AM +0200, Christian Brauner wrote: > If you change vm_flags_t to u64 you probably want to compile with some > of these integer truncation options when you're doing the conversion. > Because otherwise you risk silently truncating the upper 32bits when > assigning to a 32bit variable. We've had had a patch series that almost > introduced a very subtle bug when it tried to add the first flag outside > the 32bit range in the lookup code a while ago. That series never made > it but it just popped back into my head when I read your series. Yeah am very wary of this, it's a real concern. I'm not sure how precisely we might enable such options but only in this instance? Because presumably we are intentionally narrowing in probably quite a few places. Pedro mentioned that there might be compiler options to help so I'm guessing this is the same thing as to what you're thinking here? I also considered a sparse flag, Pedro mentioned bitwise, but then I worry that we'd have to __force in a million places to make that work and it'd be non-obvious. Matthew's original concept for this was to simply wrap an array, but that'd require a complete rework of every single place where we use VMA flags (perhaps we could mitigate it a _bit_ with a vm_flags_val() helper that grabs a u64?) Something like this would be safest, but might be a lot of churn even for me ;) The 'quickest' solution is to use u64 and somehow have a means of telling the compiler 'error out if anybody narrows this'. At any rate, I've gone with doing the safest thing _first_ which is to fixup use of this typedef and neatly deferred all these messy decisions until later :>) I am likely to fiddle around with the different proposed solutions and find the most workable. But I think overall we need _something_ here. > > Acked-by: Christian Brauner > Thanks!