From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16013CE9D78 for ; Tue, 6 Jan 2026 16:25:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D31F6B009E; Tue, 6 Jan 2026 11:25:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67C7B6B00A1; Tue, 6 Jan 2026 11:25:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 554CC6B00A2; Tue, 6 Jan 2026 11:25:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 425BB6B009E for ; Tue, 6 Jan 2026 11:25:04 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D49521A04A7 for ; Tue, 6 Jan 2026 16:25:03 +0000 (UTC) X-FDA: 84302063286.19.2D2FE41 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf06.hostedemail.com (Postfix) with ESMTP id F09CF180009 for ; Tue, 6 Jan 2026 16:25:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Y5Hlqrjr; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1767716701; a=rsa-sha256; cv=none; b=ZbvEwFHxxqp6EEQH3fb7kA0ZvzqRomi3n1shVmN2kkk9TCj8RPpA2ywuYiblzAgxieWCoM I3OyiXEvwGTLQU1PyKW459X5vZ+Kg+w5ejGbSncx0gXaBV+meOSnzCcNFFr8wddgAjdvVX s4nB84V1ZIJSnVdwjQXgWkaxRfP0ZZE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Y5Hlqrjr; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1767716701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bNCubnyXvrIyKWagLM6DIADAUwClpHIbvHDu6/+iLJ0=; b=v5tAVzyKOCxOfMFPUgxLpAWSBdhimLN/zdT9sL4o3CQuT8IFHTvntH+xGyIBoNMnDnKBXs +cqs2XSum13Gxk69I7LceD6gHKD0DkpHYlGWvNgL19/w/Nkq4EhhUbCzLjOFfCoAcGNZGk kT7NC60ot+ekRCDca1GcRiEpTIgmRYE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767716701; x=1799252701; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FgbVbjWstxtVReE+uVrnBgSNR1ljBRwNUEeFtwyXQjA=; b=Y5Hlqrjr9z4XqkBS7NuE7CyrKHCX5rAbq99eIpVJqYOvGEIbxinx6K5S AddCCJtYlnM6MMf3hwORhwDz7AiWqgLMxFpsXObWI3Lnjtf94eecT277R BRNM4TStAYGBxW4LyUoCT/T2Dne940i7infGxGONBLFEKYxwGYBVkC1ab BSZXrSh9i7+paLlsTHA3/7K5bA8xuaViSaNVLoRmyGqomObr7fuRB0Rrf UfdiXleh0xV5PasfhY7WEtVnK5K/l1UNo+Xnd5Hz7rNho7odOUBMveQG5 gc+vAezVnMbQ5ouZl/4ilzmk30/6szs+rZS0NXxz315XQx1RAiRRahCr/ w==; X-CSE-ConnectionGUID: NU46CZAtQhG8gP5O+FR0Iw== X-CSE-MsgGUID: PmMYOq+ETnmErXXVxSmiHw== X-IronPort-AV: E=McAfee;i="6800,10657,11663"; a="79717502" X-IronPort-AV: E=Sophos;i="6.21,206,1763452800"; d="scan'208";a="79717502" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 08:24:59 -0800 X-CSE-ConnectionGUID: 4r2XnTedSR661g4k+b1XLQ== X-CSE-MsgGUID: GBe/ka8KSW2hj94lXax2Ow== X-ExtLoop1: 1 Received: from cjhill-mobl.amr.corp.intel.com (HELO [10.125.109.89]) ([10.125.109.89]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2026 08:24:57 -0800 Message-ID: Date: Tue, 6 Jan 2026 08:24:57 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v3 1/2] mm/tlb: skip redundant IPI when TLB flush already synchronized To: Lance Yang , akpm@linux-foundation.org Cc: david@kernel.org, dave.hansen@linux.intel.com, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, arnd@arndb.de, lorenzo.stoakes@oracle.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, shy828301@gmail.com, riel@surriel.com, jannh@google.com, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ioworker0@gmail.com References: <20260106120303.38124-1-lance.yang@linux.dev> <20260106120303.38124-2-lance.yang@linux.dev> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20260106120303.38124-2-lance.yang@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F09CF180009 X-Stat-Signature: qms7qmg1chr7f4idmx13k95ta797a83z X-Rspam-User: X-HE-Tag: 1767716700-477843 X-HE-Meta: U2FsdGVkX1/iZiXYForYDSfYhm2zQlyNUccOGJllzWilGsKcZd2EVWOPxjKTMPIPP9hXWDFfWEZuF73EZ3xf+BJfU3DXnGSjug9Y9sIJ2nhjF6V/MTOm+K+ITAANM9E+9QuHfn990YjmLRJmv8vO4C2wOJda8wqFDw6OhSQUicRawLIZc/uDWxy7zzlZyicB6ClX0pB5IlCD6/lqjhhTZfSt5lpe65YfKBR+YbhLeBwcFF/cfE4jZ3o6qz2A46NIs1vu5zr3CGjPxTeB1pYJDCzAPStzZd5vkHNvZHWTfKxHqIFbgM+oImpp2RddmqSiYgGXD8QiUBFk8m0/X4I/MUQ9DvZEtKu1fqhvF6vUFl+cWNm1tM96v+FTwchXI6+6mZWaUzkLFX1TcRxjUqAYVzgHT29jsVxNWTBisHe1xfeD1m2p9qgCamqI7h7tknldZExbEjjkozxDzXl22fJenG8h2BeUJH+K2FnYysPr7IQCPgnFmiW8p8i4z72ZV+FlM3jWyJwKXZeOGWLwK3Yy0Z/7lQwxii2HodtEAMEHJl2gaKtetkgvHtKfm4Mfwj8ok+A8xnhhWa2SPbAqkvF5aiNpIowIejmVnFVbVPoDO+GrG6j7NQtzSgD17hMYyVfhzJ1eEhqCxUuj8a4X7wWSmkDagPNJQy7ov1o0XqmOQcP0JOmYMLxTXwqfn07yNuZTco/ly17s/zYrv+v3k55D4KCLcBbqOMi+i+QVSPgto60WCvDe1KpFLurQ07BStHKCBlUMAlavBEe1OAiEu2/plyOH/SApDPXV2OMMERh+KeOdVH3Qz0E6XvhAoPoeBAjJyMQd2Ry/bxm/V3bFdHVkqOUb+eP1aDNN96DDdiDk9u8W8SEObU7t26F8beiJFZ5wwnhO3U0mtn7CuchnsPHqucS0E+C2IeCAAWfT7XaKJkKuUX8nxwvB3wqfByozQuKMuyZo/xgfncYDba/bn30 bu5bzag1 P6DAhUYGUBA3afz4PtcZIzMtSKP68fTLBZvRIyGGvuOHcjRHmI4+8354uaoVAkANfaQbxX5097hKvTuKwHEA9mvsOmraBMAghgfLsalGSIfWVmEnM8mLkbiBj41uSwTj+Odru3QOe1Kx7Xkga0Fwl5puoGgtHzF45i2oaC8p7rxTKRtOpuvahPg3hmjLdWukEdHgS2bqXnZ6xep0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/6/26 04:03, Lance Yang wrote: > From: Lance Yang > > When unsharing hugetlb PMD page tables, we currently send two IPIs: one > for TLB invalidation, and another to synchronize with concurrent GUP-fast > walkers via tlb_remove_table_sync_one(). > > However, if the TLB flush already sent IPIs to all CPUs (when freed_tables > or unshared_tables is true), the second IPI is redundant. GUP-fast runs > with IRQs disabled, so when the TLB flush IPI completes, any concurrent > GUP-fast must have finished. > > To avoid the redundant IPI, we add a flag to mmu_gather to track whether > the TLB flush sent IPIs. We pass the mmu_gather pointer through the TLB > flush path via flush_tlb_info, so native_flush_tlb_multi() can set the > flag when it sends IPIs for freed_tables. We also set the flag for > local-only flushes, since disabling IRQs provides the same guarantee. The lack of imperative voice is killing me. :) > diff --git a/arch/x86/include/asm/tlb.h b/arch/x86/include/asm/tlb.h > index 866ea78ba156..c5950a92058c 100644 > --- a/arch/x86/include/asm/tlb.h > +++ b/arch/x86/include/asm/tlb.h > @@ -20,7 +20,8 @@ static inline void tlb_flush(struct mmu_gather *tlb) > end = tlb->end; > } > > - flush_tlb_mm_range(tlb->mm, start, end, stride_shift, tlb->freed_tables); > + flush_tlb_mm_range(tlb->mm, start, end, stride_shift, > + tlb->freed_tables || tlb->unshared_tables, tlb); > } I think this hunk sums up v3 pretty well. Where there was a single boolean, now there are two. To add to that, the structure that contains the booleans is itself being passed in. The boolean is still named 'freed_tables', and is going from: tlb->freed_tables which is pretty obviously correct to: tlb->freed_tables || tlb->unshared_tables which is _far_ from obviously correct. I'm at a loss for why the patch wouldn't just do this: - flush_tlb_mm_range(tlb->mm, start, end, stride_shift, tlb->freed_tables); + flush_tlb_mm_range(tlb->mm, start, end, stride_shift, tlb); I suspect these were sent out in a bit of haste, which isn't the first time I've gotten that feeling with this series. Could we slow down, please? > static inline void invlpg(unsigned long addr) > diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h > index 00daedfefc1b..83c260c88b80 100644 > --- a/arch/x86/include/asm/tlbflush.h > +++ b/arch/x86/include/asm/tlbflush.h > @@ -220,6 +220,7 @@ struct flush_tlb_info { > * will be zero. > */ > struct mm_struct *mm; > + struct mmu_gather *tlb; > unsigned long start; > unsigned long end; > u64 new_tlb_gen; This also gives me pause. There is a *lot* of redundant information between 'struct mmu_gather' and 'struct tlb_flush_info'. There needs to at least be a description of what the relationship is and how these relate to each other. I would have naively thought that the right move here would be to pull the mmu_gather data out at one discrete time rather than store a pointer to it. What I see here is, I suspect, the most expedient way to do it. I'd _certainly_ have done this myself if I was just hacking something together to play with as quickly as possible. So, in the end, I don't hate the approach here (yet). But it is almost impossible to evaluate it because the series is taking some rather egregious shortcuts and is lacking any real semblance of a refactoring effort.