From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA247C36014 for ; Tue, 1 Apr 2025 08:10:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D29DF280004; Tue, 1 Apr 2025 04:10:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD962280001; Tue, 1 Apr 2025 04:10:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B525F280004; Tue, 1 Apr 2025 04:10:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 97DE3280001 for ; Tue, 1 Apr 2025 04:10:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C4E38819CA for ; Tue, 1 Apr 2025 08:10:11 +0000 (UTC) X-FDA: 83284752222.26.A711F9C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 1F31B100007 for ; Tue, 1 Apr 2025 08:10:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ViaAy1Cl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743495009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4ocXdQPdARRMqahA+z2tu+ROw9TYwR3/5BWBkQ9LqBA=; b=IsZyd5ebpQdyuicCqyx3k3MA+emD4jKuhmpdDGrC1OpcFU/94sZhC7WMklvlIw1+8a3aiP 2MLvcDQ1fa4yrNmIXPZ7UpqgEoP2IZyeadZzXhtIss8cfwD6Cw34TiQYBZLCYna4X3Y62p DT71plYFOznlTnl0Zq5wC++2eZkMAIk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ViaAy1Cl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743495009; a=rsa-sha256; cv=none; b=ISZ/GH5qm4j3L2QFWr5FzYcrGQszMRTJSPqaRy6dypuM7oHwFNmGmJSrgS9BdLT5ZGs6+O GR+RLVioUgrlfbX0sLwA6MdVlrCxUoZ5dULYWdx9wvhR7Yv777i1RPVEkCCFTl5fj5zhOo vRFD2uRD8CblgEgadnxA8jpevb27SIM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743495008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4ocXdQPdARRMqahA+z2tu+ROw9TYwR3/5BWBkQ9LqBA=; b=ViaAy1ClFTG0GdWpdEJPboRilyzLBCFagj9ZIlQsQH1N2WCTRLUh4qC41sPDL/nvgPgVWn kKai89j3i/csPBaNXIRAy49QO7XEVKNDyCISUHO8fI6uNcijy2UwLTS/UDbCakbS6bLRHW 8sxn6itREwl+vTNsRpKyc+6iO/G0t9Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-yAl3HbbqNSiLT48zBXFW2Q-1; Tue, 01 Apr 2025 04:10:06 -0400 X-MC-Unique: yAl3HbbqNSiLT48zBXFW2Q-1 X-Mimecast-MFC-AGG-ID: yAl3HbbqNSiLT48zBXFW2Q_1743495006 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d00017e9dso36472935e9.0 for ; Tue, 01 Apr 2025 01:10:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743495006; x=1744099806; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4ocXdQPdARRMqahA+z2tu+ROw9TYwR3/5BWBkQ9LqBA=; b=jFqpfVA6u8ipWw0t+LBfBdQNanIUlMRPVQb09myYEAudjjHVGlyqQ4huUkNQ0il+0U f5rloJeb+DM650AIxJux8VzBzdo2cZvT1cZ3WZTynyDKr2cBJfhBW3IU/AC17z25taV2 qIdPQwt6UjA6+V4pCvFJzLNdvE/MWrPaaHd5o01OUrlmkrz9Zz2E0u/N0RA3R8CXoXcP O0e9XrqG2c1t8kWTsHKdKfBffjl8pGE3R8BeijFUossBss89wD6BkapK/vUfPAAqc6Ii 5taWgThpIyp4Ao92CI1wWBeERXP6PCgwD4Jv+55GUCRP8aBRH4PtpL3sUwF90TwajKUE 25jw== X-Gm-Message-State: AOJu0YwdgIlCk6XYfeZ5R5G61kbtgsq2VkH4ZWjtyoHzQqRorTw938Cw BQZ2Aw5CU0Bgwbb/sSgIT67x61nlFtD4s9nkPPI0twOn2Y8J/iyY66AqktQL3VFp17my7ssfBZo R1ULmxPGyfGM4etjZ73lKvkCkVFee/83UpvSFX7rbBI2N3HbPr1/SQhYa X-Gm-Gg: ASbGncvu1gAQRysuR5wmezwRwMPIMCJo/fDcTyINWYyez4V05cStZ24kLve5k5Ercoa hBOttoXMRvojopGJnfyarqPw5QSQK3+eARl1Eawx0On8R/gm9qXw228Eh5xdzpLaf116qNaV8uh 4tAoQpCSsS070FRLv70KE1Qqw4hnhehYkFVH/6fz5oTwZmHPff8A5cqRwPzvL+jgC2jYn1UKDQ/ MN5G+5K9eanIU91MHwgjADf7y52tGvC001bkPkPNDsoh7lqXme3sLwef+C3HUO43xqrwX70hHcI g7XtRllUjDqG7TxA39fHecoTnbnoSAdclQQz6Cxt114+6S0UvmAUOHWASNWC+msjZlaq7ue3a76 idyHY37vPvY6NkToL+jahC6cncGjqtKfJOae9jFhp X-Received: by 2002:a05:6000:420a:b0:391:952:c728 with SMTP id ffacd0b85a97d-39c120cc8e3mr8577121f8f.4.1743495005714; Tue, 01 Apr 2025 01:10:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGq96cU4XRBsswMtSfl1ZOg4pF0nNEn5dqfdMKDHEXMtWmWyp6en+f7vxfNgkKKtP1f6uOojg== X-Received: by 2002:a05:6000:420a:b0:391:952:c728 with SMTP id ffacd0b85a97d-39c120cc8e3mr8577102f8f.4.1743495005371; Tue, 01 Apr 2025 01:10:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8fcd03adsm147401165e9.21.2025.04.01.01.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 01:10:04 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 10:10:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() To: Baoquan He , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-2-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250331081327.256412-2-bhe@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bMZ9NTegIH5Xz7j2RRcYpky2BvV_mJbe7xwGEPemD8c_1743495006 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: doeik3dimnhggsf8xb6efau7abydtdyd X-Rspam-User: X-Rspamd-Queue-Id: 1F31B100007 X-HE-Tag: 1743495008-616709 X-HE-Meta: U2FsdGVkX19dRQ8UlUgOSfC78Hm64hF/mg7Ko7mokULEYS58fNdNND7LK0CxYCS+ISuxdjL+Q4jAUNTksnVoYlk8J1+qNt8tDv8mq/Yxkfb7veS7Clr36c3ekYJ2Hqrg0ieE0npG0LVVbdF+O6norWZabmM+sW63PcrMY43HcdSuskiYM4WjOC4FzSbQfdaMjJmPu4pouWigMWyoj+G8QeWqIB9rwx4x7lwiLaKCBXWkE79pQrUEqBTIXbPsQpgDthKVMRo0sriA/EIpX17BfRb0gIQGn2T+ilu7mUiBaqm/JT9mwj95ybgNDkI+8LxbswPeMje83b8wfokGrafyCeJuPXPkNOUGzR0pCTMfJ0F25pOd6nw7k5fNYMS8sH56UQ9GnsfS0aaDA+iubpEDnjuktpqVgBSTe2B9YKBVam2525ERwM4N0sFI3f4v24M5pJkOKw16DzoSCQK4PvMp6bT/zyaSqnYqw/8XgdgXozyl4thRXn//iZrG9OFbnHS/pk1PXb+owTugow8AB4h8FVRQkFM2JCZbp5+YEzozugEFoKJqBlPsvVSzzts81F5vIiBZlFRtgiWzD+XsU3kcQ2JhdF2MZtfuP54/Vl6WORj/usV6G9zR91HA8cu3f319cMtjtAeTeZBtjD8YxnKiF63PkeGu0eBWmHdDz0iFQMW8VKXJhNX8PSl/ACS17dx1fSMJi67X88uOKvtqz1YFJ+Ej0VuTwN+QVzeJLVQ7xWq9x5JJTLdjuRFcwp7nRRFdFdNeH2fG3JebDAQPCaOy/b0CItq7WQ/mbBQGti4aYjDNJX0aW2E7XYR/SFD0Is9Vo6ouiBbfSYNKMQ9xI/FYQclrV+cMcYnBQ5Tt+9bTpwWguaRiP7MvO1IQ58jQu/Sg8luWy11LLoEiFTzy07UD8hnQ7yddBNaglgXd1LTPPaZdt8p0b81AZC4zZeaNz5QuSaVthJ9HbUNRHrw1v+A ffu7/+wN bx0qg6QhLiGxASUuOUKRfrP89SJCbbowp9K9MV9QQUjkPr+k8Jkt93AMOYYEWdQAX1Vlat2P3ci2T+R7s6pQnJbUpY2Qa3TZvhIov9vxVQKcRXp+/Q9IQ7nAgtqSUWCVZMPHmXZNA4E9zFxcqwygzONjS52uBmAw26LOO2QwsuDbOKeM2h1H2iubNlkXpZyLGRVswh9ZPSNG4lFKNyDTipZN7XcdefqgOVd6sWPaxGFG6/4ad6AnUXirX4453hUR44j+OnQLgrud0TRLmd+RiSVxpNW3DAR8K4QHAQnORRINOZXhZyPXn65YwMBBbN+IYaxZlh531J3JDOlCMmoNJmLvMZNJAP3Q3dIQEpWNCS2K+CfjSi0X06Esnji4BS5JjKQXtgaHDAoFjqg7bqSAG40gHND7dyl74QW6EHPH0OUz2/C5O+pWHqZ53nLuP13jsqh6v5z0h61j3ChF1Y/fZJ+sLYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.03.25 10:13, Baoquan He wrote: > Not like fault_in_readable() or fault_in_writeable(), in > fault_in_safe_writeable() local variable 'start' is increased page > by page to loop till the whole address range is handled. However, > it mistakenly calcalates the size of handled range with 'uaddr - start'. > > Fix it here. Fixes: ? Do we know of user-visible effects? > > Signed-off-by: Baoquan He > --- > v1->v2: > - Fix a patch log typo caused by copy-and-paste error. Thanks > to Yanjun. > > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 855ab860f88b..73777b1de679 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2207,8 +2207,8 @@ size_t fault_in_safe_writeable(const char __user *uaddr, size_t size) > } while (start != end); > mmap_read_unlock(mm); > > - if (size > (unsigned long)uaddr - start) > - return size - ((unsigned long)uaddr - start); > + if (size > start - (unsigned long)uaddr) > + return size - (start - (unsigned long)uaddr); > return 0; > } > EXPORT_SYMBOL(fault_in_safe_writeable); Can we instead just use the uaddr and start variables like in fault_in_readable? That is, turn "start" into a const and adjust uaddr instead. (maybe we should also handle the types of these variables similar to as in fault_in_readable) -- Cheers, David / dhildenb