From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68ABC54EBE for ; Tue, 10 Jan 2023 08:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 250878E0002; Tue, 10 Jan 2023 03:02:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2015A8E0001; Tue, 10 Jan 2023 03:02:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A2208E0002; Tue, 10 Jan 2023 03:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF5698E0001 for ; Tue, 10 Jan 2023 03:02:17 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8245C0607 for ; Tue, 10 Jan 2023 08:02:17 +0000 (UTC) X-FDA: 80338146714.15.9F6736B Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by imf15.hostedemail.com (Postfix) with ESMTP id 20065A0011 for ; Tue, 10 Jan 2023 08:02:12 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YwXrGnD4; spf=pass (imf15.hostedemail.com: domain of yishaih@nvidia.com designates 40.107.243.68 as permitted sender) smtp.mailfrom=yishaih@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673337734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SpVoExkcuBcuyoHuL2v4vNLFRvU8SOXJmnl9zJJ8cuE=; b=40tdwF/WmuU3Bm/jH5Id0GstdwRpX3BtvGlij8E7EmlM/udUY85zBSW4Ua4tEC/BL55vdf Xu+Y3fFhVwl4UpNRAwqV1XqkYmYdRJJZ9Zdr1h9JjAzWgnlZ/Mb/MSywPG8B0QFyYlIoKQ JCilHheEwDttFJQ2TbGSf7NgzaxcfE4= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YwXrGnD4; spf=pass (imf15.hostedemail.com: domain of yishaih@nvidia.com designates 40.107.243.68 as permitted sender) smtp.mailfrom=yishaih@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1673337734; a=rsa-sha256; cv=pass; b=ZGVcPJLPGV5EJ+VuB596REi5q06fa4mb6l+woESWFKRZcgFuP2LvYMvOupPOKdVkccodQy s6HxliqV9rPNqe/wTwZ/UC1XPxQZNx44lKDoDGGknOLdXAsv6M6Oi+XxZGTYtEsoBTwqSD s+6QrIXpIA960xPFEUvfu67FwljiHzo= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4u9m0vbNZGlFphIROXaY/jNw1alWhbZXuk+pStv9YbWEPDLari6aNY5cs0Hbjz7jbBkp82NPV5QDyM/tnd7N/NQxppTKMl34y4wG7RTZ/ba2a55+yVdMK10nLSnR3i0g/SOUWMOYbxFfMqHl4UU4Vr0piWWb06lTdFvTIMH3K1HOXYx9KrmZpbMSj4HNwp3aIxFg4EYvB3tJTe8/o1Bl0GctIRJSFLQlGLD03j8uX0mLHEy93+rJFX4Zvd2iFI2tLstRLlxOUITDjfnKlmya2PxHPqz2p3mLxz18Pl8gTyo3e5+ltPyNUsbgCB1oeXwDEWSzL52/OQyOLqpf8A55g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SpVoExkcuBcuyoHuL2v4vNLFRvU8SOXJmnl9zJJ8cuE=; b=T17+JOG3Dtq3HWOJ+jvUagUhLKWM5gHig1yPp6MXlKVB8D2UyeW/LwKYn7irepKv+z3NrRCNhtp+zA9iBM36Z/OwKB2nMIc1y+5mrdIblweFwaRdKql9oN8QsCP8mIUWd/zhK+D1odWRNZ/YnprjZeayOoMOK+cODoLGiNfMAV2vC7PVpbL7wug4HuFHa9gn1KOWLD9cGUp7MVtK/ZDySAIY6I/sFk1Pu7E/2FrfB8IunMCn/6MITzH+e2a8StU16XSjqMch+zpsMI2wa55xsFMglztoRIVJ3gQ3kDNS+DsEgc7iLu2QwGg9uKkOBYltBtqtFbzBWxNQsLXJ61Bsvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=infradead.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SpVoExkcuBcuyoHuL2v4vNLFRvU8SOXJmnl9zJJ8cuE=; b=YwXrGnD4a7aqwt+Eb34R5IeSJsTJOjBTKC5yJoiCEfzRPmTreu1G80198ZxVp6GNocEMAD00iujtBnSUmCQk2HZLeA8bbUpvcPhuq0AFbze8LdfMmrvsmwKLLUg8f6uPBsaaEt5Ng3fFuNnSRsmu/GoZn29zE76OeXl2gMdyBMiAKepF5T6USfN4Bb7v+NGULTyPMuLL65rgipxcitXIpBp11WMHpkL/lfXLV6eajkosz+3vFLLBKlBCkJRL7L9Ri4rVBt18BkLkyYBk/k7Okno+FqA//mP4TjjvWtX4Cj44RBSm6nu9h1RD5Y1lmSyzE3xuAD8KrCqScpMCop+wQQ== Received: from MW4PR03CA0025.namprd03.prod.outlook.com (2603:10b6:303:8f::30) by DS0PR12MB6440.namprd12.prod.outlook.com (2603:10b6:8:c8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 08:02:11 +0000 Received: from CO1NAM11FT099.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::5a) by MW4PR03CA0025.outlook.office365.com (2603:10b6:303:8f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:02:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT099.mail.protection.outlook.com (10.13.175.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Tue, 10 Jan 2023 08:02:10 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 10 Jan 2023 00:01:58 -0800 Received: from [172.27.11.35] (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 10 Jan 2023 00:01:55 -0800 Message-ID: Date: Tue, 10 Jan 2023 10:01:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] lib/scatterlist: Fix to calculate the last_pg properly Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , , References: <20230109144701.83021-1-yishaih@nvidia.com> From: Yishai Hadas In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT099:EE_|DS0PR12MB6440:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c396ac3-cf9d-4d17-aee2-08daf2e0fa25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LUFKLG7b3O5rS8Ew9zanhbldqPhfFh3zXG+eRTEVlyz3BeNi4BBcMu5Kvz+kpGiP+clhpKFXmA7OshR0c4i1CtTdHBvUtMc2IhJIJnnQWyem36p+4tOx0+HmcjjoEJV63k33XBSikKZhRQ9XQfrdsKN1NhksTmNLp50TMoxzWzPtiypYMZMzQKDdiAQwYT5Ivq/pPMpeX8suWcB3eF/6Y6FCeTf/QJTEQ6d1HPGg0mjVUHqW7DURZwrW9pmmglgy1Lo3GUIDiYSg6VjVKzA4YqxyfisQHeuqwglMr8kHdpMLDn4hguMWlnjeiKKKiZbpkOcDeycC7Dn+BTxYGdtoFGH861j+meGTQ8+9ITfrCV8/jvNV/rKqgDG+3TJoENU/MJ2gYfZuVTwNeBzMFRZ7WWb9MuIl0izGoiMJ4NKk9C9e3PqVKU85KGUZgsxy29CkhlJDtQlQess2J60XNFko5fPMaQiu7johbG87dMJGrrCEtzYfWxi1AUcmVZkC1TRJ6uJd0gfhrBz6TrPs8CB/NVH/ISVkaOFwFIFP3JuuJhCed39ZOa1O9ho/VFhCkBqW1WL8ojkIAabGb2cWhLn9vO1aFbPix4mRLkveGAtfT30EIMNRnTK1F/G0UOcNBGG6RrPHWzoRWo7mMft0ojmWY/QJTlTu0nzxB/IvD9DLIqtL4z5koaLlfM8PwLkRTihGqy7sjoEeG3cJe8ykzGBfduipp7TPb3P7hho9Hxwvu6bnGvdWDDceObUVZdvycoY/BBxzo2A1OuuH0Hw+3vatNWtafz6NL/aFO20OjyK2dPJ67h9cMnkV+gKQYwYVx0ZN X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(40460700003)(8936002)(47076005)(2906002)(5660300002)(426003)(7636003)(41300700001)(16576012)(70206006)(4326008)(316002)(70586007)(6916009)(8676002)(356005)(54906003)(26005)(82740400003)(16526019)(40480700001)(2616005)(336012)(31686004)(86362001)(186003)(36860700001)(31696002)(36756003)(966005)(107886003)(478600001)(53546011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 08:02:10.8153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c396ac3-cf9d-4d17-aee2-08daf2e0fa25 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT099.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6440 X-Rspamd-Queue-Id: 20065A0011 X-Stat-Signature: x5ty91p6hqgjwejtpphzctb4q9a6xj9u X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673337732-732196 X-HE-Meta: U2FsdGVkX1+RkbHJXUyL+B3yzSsB/Rzz/JrfIlCvn4yWRGTXjw38Txc7ZZIBx1qK2LiFEdWDVGp7AGLy2IJLaD1KGebIUEdCdkQ0LouuEy5LXREeEDDSsGhIdSbstdLrzf6A5CQiBv0UI5xMyUp2rq7BYn75gL6IPH2ZxX1xip/rhawQv0rFpQBASSjL/q4k0yZj2M/5sG9ehQdU5gL4AwQ6vUzGfD8gsxOZBb4s6DOon1idZPgUm4Un5D90IRypGd2i6ev4eswVeb7fJtsI4L/K23WEPLiwUWORpxFq4ya2S+eNGqtOpSuIySn0PRIkKon6D4MIaWKg28Ji3x0KpGTIM5GwoX9E+ASYVvR1k0G60aWu3GWvGBH7SkGiOWtwJF39IKCp9vXoO+67XU7o/ZPsuJ6d16tQ8A8V8vVBhUu/yGSoGTzHF22hz+sb64724T1cm3uHXZ+OZwbxi3ilLWz0ByZOqLm4CHUc0dIqRFchEkQn4LmTpla43xiyGrqBh2/YaOSFt9zn8UBzHhS7ru6Bg9nZzI9KF34ip/0opcHwn0xvDoINwCpaKHY7SisM4412hamOn0cKRPe589Ss4Aj7FZWyCOWDFDil0oTxwP981cpN6pwdv6CAQL4QU0qYhDTex0DsQvrd1hTalapiuE4iDbGUvQYX7nqvI1PZaEbgKTMDZ9x5YXenU53f6JBMVU+tqXNztNS3uMyumqEMM45eUHcGzee0N2wbgP69kjSjCxgmuL1RJk3RF1Hn0j9REwRGNxjFiYHlp3l/Eku6vBo+zp/pHtTDioywyehzR6ZR12hvy2b3lAIweWjv8xqFBuP7YvRgr7nejGJXzAL/j8qUvqngqKP7dFl77FlSzsfdtePbiETH5q3j6fX3suTwb49SbtgUlSFMZ2Tv/9EZyMJ+IO12uXxAHnMuYiBTdTW0rDNn1/X7AqnnoNVeUGzxNJz7V59zXeIdMY25qJw o2ECo/bS OWlLJuoOMxSuhkJ4KtxpUJZtVIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/01/2023 7:08, Matthew Wilcox wrote: > On Mon, Jan 09, 2023 at 04:47:01PM +0200, Yishai Hadas wrote: >> if (sgt_append->prv) { >> + unsigned long paddr = >> + (page_to_pfn(sg_page(sgt_append->prv)) * PAGE_SIZE + > 1. page_to_pfn() * PAGE_SIZE is spelled page_to_phys() > > 2. physical addresses have type phys_addr_t. Oh, wait, paddr isn't a > physical address, it's a pfn because you divide by PAGE_SIZE at the end. > But you will get truncation on 32-bit, because page_to_pfn() has type > unsigned long. Anyway, this shouldn't be called paddr. Maybe last_pfn > or something? > >> + sgt_append->prv->offset + sgt_append->prv->length) / >> + PAGE_SIZE; In this area of the patch I just reverted to what we had in 6.1 [1] where we were good. I can send V1 and replace the 'paddr' to be called 'last_pfn' if it's really needed. Alternatively, we can stay with this patch version unless you can see here any real issue. What do you suggest ? [1] https://elixir.bootlin.com/linux/v6.1.4/source/lib/scatterlist.c#L462 Yishai