From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A625FC021A0 for ; Wed, 12 Feb 2025 15:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C5EE6B0085; Wed, 12 Feb 2025 10:57:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17601280001; Wed, 12 Feb 2025 10:57:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03E1E6B0089; Wed, 12 Feb 2025 10:57:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D991A6B0085 for ; Wed, 12 Feb 2025 10:57:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8D2F9C217C for ; Wed, 12 Feb 2025 15:57:15 +0000 (UTC) X-FDA: 83111746830.02.503D83B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 77F0240009 for ; Wed, 12 Feb 2025 15:57:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739375834; a=rsa-sha256; cv=none; b=raMehGCRIQmhoHgoV6XExLV+sFRYDO3Er+S3CwFZD4vV7CKFwrDuQgTys04elsb8hF7fyG 2J/GK4biJU0GoqNRkWgrV9ldlI21ODxeXCOjmgPb9gxPDrvhkWuDa3/PcZwV0phKwjknO7 90VgwmqH4vqqVuSAG1Bze7EU0CbUpDc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739375834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=odrzVp8oSBPqKrA6lLgcKOBUl952NaF1veiSZcxBztU=; b=gyNf5be2IssVXzKbxPSCBWyK2wEj18BB18XCjhbM88pjWE/hIst+hVsLxIEZN1ODm6FK1N ssFJQ7EhfpSYCxpJnZpqiIJIuVqSNHzorHEM3mTnl4NVjOxaQQNEYfj/O764ojwrb8P/N2 s7/FFZHZErfe4HRXaLWa4DNxF03npcw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9FEB1E4D; Wed, 12 Feb 2025 07:57:33 -0800 (PST) Received: from [10.163.92.86] (unknown [10.163.92.86]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63F303F6A8; Wed, 12 Feb 2025 07:57:11 -0800 (PST) Message-ID: Date: Wed, 12 Feb 2025 21:27:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/mm_init.c: only align start of ZONE_MOVALBE on nodes with memory To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <20250211082900.10877-1-richard.weiyang@gmail.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250211082900.10877-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 77F0240009 X-Rspamd-Server: rspam12 X-Stat-Signature: 159rndx3aqz3k8qobpz16yr49uytn4ym X-HE-Tag: 1739375833-882691 X-HE-Meta: U2FsdGVkX18qsPEq0e4CIwNEiuhzJun3zJzAgXCI6KjyjUqtEMnY1Lcp/8OJNkTkhS9Owy8BSbVlfgAknadoY/x3Rqgq0XU0XZdurCMq4ZIe+ZvlyWrxoNtJcneBWZcJv/NNXfDIvi7GB7NlxTB2yxWUe7oHkLBz/xr+RRNp0pzXbJPMbb1FSqrrYKtHI0iOUssQK4Ut1EJyTUfL6Ah/tz0oCPSrqUYrGBDwzSyQO+rUYMAPVw46njf5LsQdKJipEdgDK9XYNcDMgCtXnAW1CAu6ho+GwyC3p9nzz46e/2QZ6VpxyLCPGL8upYNsDoBcqSAGW0BVMlBxsgzprAjAmNNrc+Ep+ab9wWzDSiXA70RFj/kG46q0tURv0rqyIO/USxytYHPIjpJs/FgtOQEDSHLQOaQ540nm7UARSmmLdw52x68mwyJxyyAJdxS270CPMhZVAIMtthPxG5PZWjhz47g+aiP+BRtBttDpdpI9smoAAfwYvizw/tfB0WF92ovQWcd39+6JNraDCwmgASdCo3QLC4E3+z3JAHtx/+brpOGHnKo0+ICERHeUUg5efxq63B9Rx8GRKJT+lXvpPI1TUMp1jcw3DVm26ky90wlHIJJZBoDr0trdTu4mCDl43PaEOq2T5BdpBWKf8g08IkEID/X+zVev5W7KvXWpHew8OOKSPOgsh3aBkENPiG28gP/M/uTbv+4woAZTdQ3thDhxkksXGD4yeuVftkMwACIwFoI0DxUTxVZUeMZ6CM5BHhHmKlfbHdjz4EgyoORkK97Lv37UlSLOrWArz6sp69DCPcjhrPIXmVpjuoZEoZHz5EsVJxeZXpUzfWz/d/1x+JYu4JBK9cpEDwSJQaaZvKGWx0bcblFFX5DMFexqW0fR11Y4Jwju0Oiy10NsJBPskbbmwFftX5CbMM3nokg/7Mgb7cUcBlisW7Ep85UeL+7W+KZ+5RKvlF04NuCoBtMk6B4 ZPgDYObs /xcNaJ1Lil1x/TqxQPHafd+Ajf45mcSUkrUsbwAo7iv9/tmzFd835V6ya58QAoh0aakSocP0nqFbLSM+KJl7Kipugv6Fbu1emUV1NJ++huOFf0EWH7+0NxM5AGMs8qu/VR21DduHASpFD/lmFxXM/xf/ZzzHnHMsf4A0G/R+cSd5llDOWP3AVoODficn1qwNj/tx+l8cu7s9WUYg6gbF7nV7q9qgMTZBV5JTO4zGB0JZy7KBtRwRgj3g8pshIECa/M/+nZqu1ij1UO1Ypv/PFtf6ujLrvaPGeyp5cmqv+yzIhEdRt3pGPZ8njOf3iU3kvVtwFwqmKggPPD/qSJ/qO0roosg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/02/25 1:59 pm, Wei Yang wrote: > At the beginning of find_zone_movable_pfns_for_nodes(), it has properly > set node_states[N_MEMORY] in early_calculate_totalpages(). > > Instead of iterate on all possible nodes, we can just do the alignment > on nodes with memory. > > Signed-off-by: Wei Yang > --- > mm/mm_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 35754a8ae6c0..3ec50b5fda12 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -547,7 +547,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > > out2: > /* Align start of ZONE_MOVABLE on all nids to MAX_ORDER_NR_PAGES */ > - for (nid = 0; nid < MAX_NUMNODES; nid++) { > + for_each_node_state(nid, N_MEMORY) { > unsigned long start_pfn, end_pfn; > > zone_movable_pfn[nid] = I have boot tested this, and also read the code and it makes sense: The only flag which gives the possibility of ZONE_MOVABLE is N_MEMORY, and it gets set in early_calculate_totalpages(), and before the label out2, no function plays with node_states[]. So please consider: Reviewed-by: Dev Jain