From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F40FC10F1B for ; Wed, 28 Dec 2022 01:26:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61FA48E0002; Tue, 27 Dec 2022 20:26:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CFE18E0001; Tue, 27 Dec 2022 20:26:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4987B8E0002; Tue, 27 Dec 2022 20:26:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3879F8E0001 for ; Tue, 27 Dec 2022 20:26:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EBDB7C0BB7 for ; Wed, 28 Dec 2022 01:26:27 +0000 (UTC) X-FDA: 80289974814.09.08B295D Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id A125340006 for ; Wed, 28 Dec 2022 01:26:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672190786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ciLVl6oF4OfnACMk1nY0gSGppc6xbMvBTWkvV4ZMmA=; b=h6t0yt5ZzoKQqa9j2EugfzrDLq5C2wIGK0ow0NGjAhUqvHhKIZ2dcR2FsY23BS0WbV91Hv Z5pYR5B4lbja44AZKI0G5rMTluejV4eUxIE3LoAa0xcmf4bnAlf5wStrR3DQZjZCOjQdT5 4oKFa4IMNBCncwrgEVbsFmPAWpvoSHw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672190786; a=rsa-sha256; cv=none; b=MBrI+HKl192OQAI8oJVK6wSDnKKjVrtOojGq3LkCvPQhB3Y9HoQI1bP0QxCcO6oAgQMYqC AkHOYRj+TEDfFyjv4BoS90Upez9/qaA6BVnBmflWoLGw+htYNx6nssY1uf+5gbx4Ik3ysQ wJhwW4Q8/XpxF78+ZCuo5iNt7jXRx/4= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NhYdp6tvSzkX1s; Wed, 28 Dec 2022 09:21:50 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 28 Dec 2022 09:26:22 +0800 Message-ID: Date: Wed, 28 Dec 2022 09:26:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next v2 4/7] mm: damon: paddr: convert damon_pa_*() to use folios Content-Language: en-US To: SeongJae Park CC: Andrew Morton , , , , , References: <20221227195004.2809-1-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20221227195004.2809-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A125340006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: fs4u9pyyqguipt34cxt5gb9an6q7ybfb X-HE-Tag: 1672190785-849136 X-HE-Meta: U2FsdGVkX1+UMsdRzcDRw4u7+CruvC3sCbtTM1KjTmZWGLRARXnV2J5zxa48V6jFrxLJWJkEkA4ssovinoaiq0mPz32x39iBar/57sQ2HHsDjj1UY4edA1NYon3IXEIDYoepIFWgIl1SlZIz9CzSD9ge4fXWgrr2dI8nfNafsyjULnCiXnXUSgM3gkeSPYiV1lsJhniGo+c4ZO6Zo0Jn95B1RHCaq6V0DYQv5ry24c0nINriwFDau2cq+U6yeOBsJXKW+vlQdl7CNq/v4mh+G387AIyFCvyLR++gbrkFcpnaOEpo8C0Qrl+jOzArgzAAN1jBY3VYQYRdpA6T0IbG/slEkizD7GcmO/bhZ+go/nYA+t0q89boU67uT8weMysmYTBjWJdt3qauSnkpbf5oxQ6gtSwjJqTBdJlUAbKEzk4ZyLQC6MUspE/avJLtnqR/A1/DQi4ynRUY/JbjeTvCgAeMu3Td8swH32b2MKpRVQct3REOefcmsywZoq+VsALvAkLHiJ1uNAQjaW+e/t8yQ8D1MpBy89oGcpkOsYXQkOLVTWyoNQhni5nvVY6lf8L7dtQVecLC4Bi6pdHTl3Thef8MbPWRaqSsNpxaK4ZnvC0g8EPIWhMKo4ykRgaYdpgLk+ozi9RoBh6zg7U+FQTHfcJiqQOeQ/d+w0UouzbLxntdlU07k/ffzC18n/i2V8tFudoUAd2r3bPPAjVyftroXUqPIEuXfxTsSC9Vo+T6CXsLACslpOWFdjfK7GSo7TgUULVTnT+SDRaifvKW4xVJmUvaJT6+b7178SoIprsxhWyuKSMFfDlaZ1rPNjrBYWCuYYYIt1TPw5EufGKLQeTrp2YDrQqMHwJxr5eFvXuYrRV7l7sg0KnoGG6M4DKjDEHQLK4oQjSQHgCOXyQvGqlQ67rEQ+0fPlg6KCaduSv1JboEhBGLO9tBlm6D1kpCmGVR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/28 3:50, SeongJae Park wrote: > Hi Kefeng, > >> With damon_get_folio(), let's convert all the damon_pa_*() to use folios. >> >> Signed-off-by: Kefeng Wang >> --- >> mm/damon/paddr.c | 59 +++++++++++++++++++++--------------------------- >> 1 file changed, 26 insertions(+), 33 deletions(-) >> >> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >> index 6334c99e5152..728a96c929fc 100644 >> --- a/mm/damon/paddr.c >> +++ b/mm/damon/paddr.c >> @@ -33,17 +33,15 @@ static bool __damon_pa_mkold(struct folio *folio, struct vm_area_struct *vma, >> >> static void damon_pa_mkold(unsigned long paddr) >> { >> - struct folio *folio; >> - struct page *page = damon_get_page(PHYS_PFN(paddr)); >> + struct folio *folio = damon_get_folio(PHYS_PFN(paddr)); >> struct rmap_walk_control rwc = { >> .rmap_one = __damon_pa_mkold, >> .anon_lock = folio_lock_anon_vma_read, >> }; >> bool need_lock; >> >> - if (!page) >> + if (!folio) >> return; >> - folio = page_folio(page); >> >> if (!folio_mapped(folio) || !folio_raw_mapping(folio)) { >> folio_set_idle(folio); >> @@ -58,7 +56,6 @@ static void damon_pa_mkold(unsigned long paddr) >> >> if (need_lock) >> folio_unlock(folio); >> - > > Seems unnecessary change? oh, will drop this change, thanks > > Thanks, > SJ