From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE87DC71157 for ; Wed, 18 Jun 2025 11:42:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 693896B0093; Wed, 18 Jun 2025 07:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 643AB6B009A; Wed, 18 Jun 2025 07:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B5F6B009C; Wed, 18 Jun 2025 07:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3D02D6B0093 for ; Wed, 18 Jun 2025 07:42:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB288140DAB for ; Wed, 18 Jun 2025 11:42:16 +0000 (UTC) X-FDA: 83568333072.03.F48E372 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 7E410160007 for ; Wed, 18 Jun 2025 11:42:14 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B5tyc3Ed; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750246934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HcMpr3Clw+S+n70QqzmCOKA4fXzf7c01Cd7kiaYINh4=; b=dxq6JOSqb6Ny5ezk9bftNavc6MKKWyAJ8fqaYkrSCEcAml7TsreSnkrCEdhQuaEs5Dx/88 TxuXj2DsusIiHNrnFp1Hpu/7XTiQuoGdZVbTdAqwuQXTbuGvEeUOHhT9iquUplsU+tGJeU n6VV73c+f+EUBLf4xbyp3LgPdvnoH6g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750246934; a=rsa-sha256; cv=none; b=qr6XkVWZHR2hNxwxa4EfXTU9Y9oZYqoQrs8R5ZgFvVTWwnhDc5o836WuiYc4t4XGiTu5ny D5s888hEY8p8vkUSNtvOFpVRw0iaKAoXGQEPjrSJQvP+uJRojmusRGLVe5+SIYWejgqn7A 2dXWQTBrH2Lja49FiRsSzwqd/VuiEmc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B5tyc3Ed; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750246933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HcMpr3Clw+S+n70QqzmCOKA4fXzf7c01Cd7kiaYINh4=; b=B5tyc3EdQgZ4IWskqOmrg+zuODAUt+xwPb6dei4VQo/xmm1TJ8g4L9XpCMS3rNp4IdGNaW kJ5qxpR+2C1nVT0Dn05BYLkd6u6LQaNEWN1PWFIEKIc7fz9w/mh3AMranGSjqeBlCtjh0/ 5Bbxet60oUjVTT0Zh1ySNDsp8KgeuoQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-AwQ2QTQROleJLit6fEZL3Q-1; Wed, 18 Jun 2025 07:42:12 -0400 X-MC-Unique: AwQ2QTQROleJLit6fEZL3Q-1 X-Mimecast-MFC-AGG-ID: AwQ2QTQROleJLit6fEZL3Q_1750246931 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d64026baso46565525e9.1 for ; Wed, 18 Jun 2025 04:42:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750246931; x=1750851731; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HcMpr3Clw+S+n70QqzmCOKA4fXzf7c01Cd7kiaYINh4=; b=KG+itMWK2lOF21Dhr4nJBCgKe6E20Mi/vO4iDXF5r/5thhfMdHzkxUj/kdKYkBGJvL CZpNzAY4Z3qy8ZeV/trVDurxu5P2h2NVk+uzJbTR3cHTxIH5O8N4PwdwN3ZVV4W03aro ue0cHA4ubOGfDunPFZz7YbJKIxpB4tGrqfBN90RdNeLvba5BS76yvI8IAyfMBKM9jxFC /NrM8sqa1JJr+9YG7hz4c7LH2e7Q/SL1dgsM1/BCjrH02aX9db0bp9n2xFlTyaS9QS+N qIV71hiKIxa9t6myOBS9DLz91FKXswGBOO4Own10Ws8CPFnCXIajqznr1kN9WtLNEsIy +sdg== X-Forwarded-Encrypted: i=1; AJvYcCXOI7LTeGL4lAmb+CaZSveB/a7Yh+JkIqNo3pOmzUx1X+KFiOQsLAuo3bM102k9O0oOhk7kPBxY0g==@kvack.org X-Gm-Message-State: AOJu0YwTdok+ZqgsmMffrDu/96LcPOnNAeYy4dj71wlO3iUTJuxEC2w3 TFGiJN+IBgXsE/0FciKMcRoeoCUMkpR751lBXR8j49Ah+OXiKPmhHnUsiMIu4RJVGTgM8incbns QxWZagZAdb1n/YVaNw2sdo0yBIts/ceUgWVdkKKfeRvf+YIEwIUoy X-Gm-Gg: ASbGncvlYDQ3x64yYuKKLOhCXrm3XScnC2tVq58OXDPYKVKj6vL/1S+TtIa+R5V7cfM jnVR+SaKr1RY4scspsu/zkBlR4qqShj9y31cT+XHd8BnCJMGUsT3prwweCBNpwkHSavSpBrEwZk 7y4icvKzxcRfH292p/b72BASpUesTKWoqIY86heNXwoQuSnh7IpgEWAN8mw3H+aysG8w3q60hel 3yHWQ/1uwQhOq+4/zUkdMftN5Y8vKq6WS35VjvCmp1UCH/W0Kp5olhl63dHARV5pZW28v/UhsY8 DaomIcKFOS8F77ShrbN7uwretQhSbtBsGiemN3oQQzWEm9L2VARcMCGE/DWP1ATYkDr7RpVWbzr v1WSLsp3XVngcX2NrGkPcG6Wp47Y+Vj1h6MZX9oAm1P4YnDk= X-Received: by 2002:a05:6000:4387:b0:3a5:2d42:aa23 with SMTP id ffacd0b85a97d-3a5723720aamr11943770f8f.22.1750246931292; Wed, 18 Jun 2025 04:42:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJ0iaVW+p+ARhd57eIQcZrYtRK4jtysJExYXd7VW0dHvY8EIJAcZSkukTfU1LzsnuL7unx5Q== X-Received: by 2002:a05:6000:4387:b0:3a5:2d42:aa23 with SMTP id ffacd0b85a97d-3a5723720aamr11943745f8f.22.1750246930779; Wed, 18 Jun 2025 04:42:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2d:2400:4052:3b5:fff9:4ed0? (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b1bc97sm16813645f8f.68.2025.06.18.04.42.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 04:42:10 -0700 (PDT) Message-ID: Date: Wed, 18 Jun 2025 13:42:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] gup: introduce unpin_user_folio_dirty_locked() From: David Hildenbrand To: Jason Gunthorpe , lizhe.67@bytedance.com Cc: akpm@linux-foundation.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterx@redhat.com References: <20250617152210.GA1552699@ziepe.ca> <20250618062820.8477-1-lizhe.67@bytedance.com> <20250618113626.GK1376515@ziepe.ca> <9c31da33-8579-414a-9b2a-21d7d8049050@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9c31da33-8579-414a-9b2a-21d7d8049050@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: B8oyUwBkwgtgFVKimie9VyMd_ySLhuFKHZ33fOi-ZXI_1750246931 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7E410160007 X-Stat-Signature: 1ccogsb9hws79ubku4ikz5e5cdpd64jo X-Rspam-User: X-HE-Tag: 1750246934-343910 X-HE-Meta: U2FsdGVkX1+MhnmpBxq4alCJnHpx+WLlbchZXIJTCT79G0v7IrqPcvYnbIrsGBPajy0K9K9FXHzgOcMRHvTTTNZ3Xtq4iRCeO84MC9OzAy4A6vtFVZjP64DiDrJdT0mX7cU3ItuBKXpA9Mw6S5pa7Pw3uSsVyFAe6AMLbYMSuwmHmm8LAEX/b1XWfQAu6uCNFwO+5FF3io+JS/1HcEKM0mxOVT6vLxypvJiH+MY7fJb1iS+HAmjvkCeciQJR8tusC1Bg2I4XIvWVZ3V/gfZS/uXLPa4YqtUhnZQqvrPd+2+4OZRzj2aISYrTzKC/IfSjXvLzFi4cozC+cJG04iKkrtRe+1I+4ImSNQQhQHNBgjiLX7NgM7X44BXr/BEVxtorK/tpeAI/UXJ0c+sGLO7bgOS/vV7qUGPNlAtA+P49R0KrgHvVjFVLNnqXHuoFwucDB6ykthsT2BcX3tgypq/n80GRPHuCkkNYIkfOJUMveOVq7B+MJ+5X1eOi0ifHfzQOIh+dO56Aj0MJZFyFtkB0FiL8y59VRE+39dwAaL9KlRkCjtPngT2iOCChzBG2s3ahiXxuWyTDn4kj0zpM32bTk3qOKQzi3YDAHsxMdR6995vvxIZURU1J4WNuZjS5gkTE92atZMCMCWf6dl5jTEUMuVAiMmKF7Z0zojhe5AfTpf+XlUC37FfGN2j8B96CykyfrIRUnWLAoDyH7cdVicC3JprFxazNUUv6UwJN1cc0oJYAqNIyJSbGenQvvgrpQcfrZoLthRkFFWXq0p5plQTFio4qKvKltuMdyvCBWlmOX/ANk5+6RfqOVHnRzto3u+07EDubl82IBBycolSAgLAbO4neMAbBoMOPYgz71rwEg6aUhXQlvhN3gl9xXXptv03WmBdrXtFdjunoD0GpI/N0Ulbzex1YGBYkKGk6/JWEmOR8n+Jg9iM8EKxv34PQFQgG6jTSs1bkolwElf8HSju LfsqPJBs IbJPUJ+qqXJqKrUmkeAqXz7ZLVJtt6BQcKc+wN30XsZuzODqmzW7d8IrEbBNKriat3MhzNg07U/DI++ipP7QCH8aoEqlJd9HGOmty0iRdSzsnM+IBJm+RM3hhwGTeCpcylpcqf7CnigN/5Rfv1R/zq/Awa2cj5Y8juq4mgD44GEpX9q97nqVPv1EOH3DakdcyzPI+Qy9sNjfXG+tkwiCZy53S16tpBIL0T6s7Pj9bcQAEQ/fsxB3pIgMBogxnw2aXNkl8TeP2vRiexsalBFyGV1eKRcgFqXb8CbNAKwNS6VAyp9xtNPV67ylyOqJRzHOouEvWW9K5YYQB63ZxlNBMg81Vo8MFb7/quS2xVpbhCC87FsXAlbZwkh//ik0LfcO63gAAjXVVVk5Ja/I42ww6/64i6eKLxIE8326ZIQ8MegQKK6cFk/rIg791A9uAshlShmnocT1ASheDDKGntgm6qlDvlisDThtVp56N7WgKydYDgLyW5/fVtcJs+3YNRt9b3v7xx7RcyZtCBj6EaCoKXGGa9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 13:40, David Hildenbrand wrote: > On 18.06.25 13:36, Jason Gunthorpe wrote: >> On Wed, Jun 18, 2025 at 02:28:20PM +0800, lizhe.67@bytedance.com wrote: >>> On Tue, 17 Jun 2025 12:22:10 -0300, jgg@ziepe.ca wrote: >>>> + while (npage) { >>>> + long nr_pages = 1; >>>> + >>>> + if (!is_invalid_reserved_pfn(pfn)) { >>>> + struct page *page = pfn_to_page(pfn); >>>> + struct folio *folio = page_folio(page); >>>> + long folio_pages_num = folio_nr_pages(folio); >>>> + >>>> + /* >>>> + * For a folio, it represents a physically >>>> + * contiguous set of bytes, and all of its pages >>>> + * share the same invalid/reserved state. >>>> + * >>>> + * Here, our PFNs are contiguous. Therefore, if we >>>> + * detect that the current PFN belongs to a large >>>> + * folio, we can batch the operations for the next >>>> + * nr_pages PFNs. >>>> + */ >>>> + if (folio_pages_num > 1) >>>> + nr_pages = min_t(long, npage, >>>> + folio_pages_num - >>>> + folio_page_idx(folio, page)); >>>> + >>>> + unpin_user_folio_dirty_locked(folio, nr_pages, >>>> + dma->prot & IOMMU_WRITE); >>> >>> Are you suggesting that we should directly call >>> unpin_user_page_range_dirty_lock() here (patch 3/3) instead? >> >> I'm saying you should not have the word 'folio' inside the VFIO. You >> accumulate a contiguous range of pfns, by only checking the pfn, and >> then call >> >> unpin_user_page_range_dirty_lock(pfn_to_page(first_pfn)...); >> >> No need for any of this. vfio should never look at the struct page >> except as the last moment to pass the range. > > Hah, agreed, that's actually simpler and there is no need to factor > anything out. Ah, no, wait, the problem is that we don't know how many pages we can supply, because there might be is_invalid_reserved_pfn() in the range ... -- Cheers, David / dhildenb