From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2F1C369D5 for ; Mon, 28 Apr 2025 16:49:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9AC76B00A6; Mon, 28 Apr 2025 12:49:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A47166B00A8; Mon, 28 Apr 2025 12:49:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910646B00A9; Mon, 28 Apr 2025 12:49:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 718496B00A6 for ; Mon, 28 Apr 2025 12:49:48 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 474E61C847F for ; Mon, 28 Apr 2025 16:49:49 +0000 (UTC) X-FDA: 83384039298.10.FBF5AF6 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf11.hostedemail.com (Postfix) with ESMTP id 0039340009 for ; Mon, 28 Apr 2025 16:49:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=MYeM9g6C; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of venkat88@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=venkat88@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745858987; a=rsa-sha256; cv=none; b=DJ6aXm6Tj7fmdrS7wNdOgJ7QzSOX0eKa+ksAnNkUjcKPdjQ6rDQ5JQBvwWF4PhhZNWPIjY Fnt/jPzM+tmZOS1c/UtwNDujWEL9RWdDlzu7LnHZ7SIQUwlDUyNicc4UvhgLBRAeAAn06Q 6rucF1uzX0QVOxDJm+FkDImqspUKL6A= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=MYeM9g6C; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of venkat88@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=venkat88@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745858987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ygTqjYJ03RIKTAhwuPR9emo/CxF/ClTtTaFmG2r3wo0=; b=GmVgploWIOwsrYERyyyH/FvqMuPdA7r2U974BT26KtysqJiS0SN7CH4eyYk5Stw77pw6ec nDSw1nOsJmWib5GC/idQy9BH8OOuSTTnYHj7UI/QbkXEW4O0q4A+CvtFcgCnPyVOrWLgUV kS2H6Sl6LYYmxSSrY2UfbkcqgrHjcyI= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53SAwLvB003967; Mon, 28 Apr 2025 16:49:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=ygTqjY J03RIKTAhwuPR9emo/CxF/ClTtTaFmG2r3wo0=; b=MYeM9g6C9vGxWHYGP93kb4 7Ti6MDDwnT6wM6bRr66yC6Z+6whMfJ6NrANS+XaD2DzNDtqPceMW/RgGtXm9pPXK Y5jstlJpHpaC3VuIGl2FSBDsR5DYJnjjuCQRnCGhwXajerOtuwsN7z8jza3QRGua AYyzgSHdSBrOM9Cb8dn7ONJcKYswG5GPV/0jLzJ9950dz8lctgQAXZ58W2H1e7R/ u2iMTzg0ygca1YuiOh6pOH5aPFJvtorGvvzMBwR9oQzF5v3EOAhLKSIr1ITPZ0bd tDYKv23Q/3qxY1riQak5skENJ1VQwQAOUVZ2x7xs5uEiHm8Rb002iadDcPq0TPgA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 469xj0v2xs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 16:49:36 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53SFakuI000678; Mon, 28 Apr 2025 16:49:35 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 469atp7c41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Apr 2025 16:49:35 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53SGnX5L22479518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Apr 2025 16:49:34 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE38D58061; Mon, 28 Apr 2025 16:49:33 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43A5D58043; Mon, 28 Apr 2025 16:49:30 +0000 (GMT) Received: from [9.61.244.200] (unknown [9.61.244.200]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 28 Apr 2025 16:49:29 +0000 (GMT) Message-ID: Date: Mon, 28 Apr 2025 22:19:28 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] selftests/mm: Fix a build failure on powerpc Content-Language: en-GB To: "Nysal Jan K.A." , Andrew Morton , Shuah Khan Cc: Madhavan Srinivasan , Michael Ellerman , Segher Boessenkool , linuxppc-dev@lists.ozlabs.org, Kevin Brodsky , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250428131937.641989-1-nysal@linux.ibm.com> <20250428131937.641989-2-nysal@linux.ibm.com> From: Venkat Rao Bagalkote In-Reply-To: <20250428131937.641989-2-nysal@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: J6ksxhAtcHshXhJfcAb6W-WApMO61Lob X-Authority-Analysis: v=2.4 cv=GJYIEvNK c=1 sm=1 tr=0 ts=680fb1a0 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=NIXEo0iNHiUJsitbC-UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI4MDEzNiBTYWx0ZWRfX7zvjH1N22yRZ MQHKqthnSgK9mU/PNzj6VgZGReWR/Mh/SzooAI3qWaUEeUAgrEk4cdGsICEzYCYzVPz8vsJU1Qj eH92pWxMPQuGMamil1p42avJWmKz1a0E6KrFL+CgTsCvaxRORJ7prLmtoiWo2mBV4aXrY+7CBL9 09NZvYcq17bCqcxqr48iner7oH6kE6kOU0cuD1bMYQmEFdt8xZOTsG/0MTwPmeDncrM+J/Y3zJR C9hpqo7jrc1TxGlwIEUVOab4ghq1HOkF7QYIsA6eE1qm5t22Smx03J+4oaXBPHWaBQUXDRaFaSS 0H9O9gR2y3V1CCl/yqkOFaDcOdtMqXoCXcY0TK7qauvypPQsb8fuTeVJ7vXLZgiIK3mULNthjIX sHb8ic+HuLvA9slHfV2pRDNVgHNtvK9Ot+OUKDhNAalJ2E9qhOH0cCdTmiVcI9jbC+ftJq32 X-Proofpoint-ORIG-GUID: J6ksxhAtcHshXhJfcAb6W-WApMO61Lob X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-28_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504280136 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0039340009 X-Stat-Signature: ay6nqgyr1y43b8r9dwdcss597qwceziw X-Rspam-User: X-HE-Tag: 1745858986-133892 X-HE-Meta: U2FsdGVkX1/ERHne/1kfOIvRL/cCWQP4aMPK6S0EKuDnlUqZkPldpQ2Y+iM9rX9Dj/4uwoeCRhDPHNBg5SK7bhjpyqrihlB0XA32+ets8Zl35ym1KItgO4CQMfiTHV+41Bis3EQZObTuswIoo8MFGDQ9wT85NRRz90C/LdT1AVv8ASUiPMu6BegkjwBtv+Y0C6DyliCEzRDrl5+dfUrpgqirml+emJsfzPq4k9xIn081NXpb8JfZXxqfFe4boPzE0xiRaDsxD7HkPl1+EBaMz/jXhjoGmirSR23Y+IqCpY1TeV/RW7i5433YoohtFU+fokhmQEUMWTQWhJjWnLStWSYaaXnrBtymQDfuWWW4eyHtWGv1lCjzsrv5YyDgUfeURtosx76+xC+Y2zqUAqQrKWJm4NVlzLXPeMt2brZc9wKV5zmH41XsmiydcQFRRqEYnv+pnf9wUvPG8cEuztgHzslF5IWPb8p4G3ktuE0PVrSH2vZVMKIHRcIJ1Fbz9HsQF8Ol4qU6oQRgP5SjCV9Rlzp4FduDodDhNkf0wPonBSuLbhlfst7fivVZJNa5pyv9EmLP4ToFgVBwAsvxqtUIdtNnMJGEcWqNKmlPeroaoZljREhrvp7Z5OqhK8pOihsDesYGLOR8+eNR/JoUHc6YQdIIw8FwDZ/s+jYABWLZ+eqciAK3UTL298OlnnODRlbZp/GelOUzVzQeGkCouVTGpiy493Bi4LDtC35AWJJ/OsPWrhDddf/077bCt5P54MaWO6QZw8dDuM6WjwCWrh/ukaZH36/ZzKP1n4mvFqWL3yuDPCaE+9BOr/+6tbQi97D23fO5p5DJLpWwf/pAIzUy/BtcqDGUumKVLmz5fWJj+c9W9e0OLGMNV854IPzl3j22EIb1ioTa8Z6486Gr6Wkhfhn5GHaq7vKzww65wp9/p1AncyED7Mfp4wY7IpnWuA6od91KhDoRF66+9tjeU6z srCwNpLp 27RaffG6UIoa108dRy9MZQIwHoYdHpsqMCx/8Pm4ifQiBAfmc6KawdcwyWbW6ziLc4ns2GDMLVumH56UqPQvxXqi+OC9l8quyhCC8IZVDlcjKHm5k4nMWIZLb6uOJZ995jnDfXXZvuZxPQYWgcr74yLfPDnHtho3cw3CZLDSIBlE66m9BZUjM5kneoy6j744/hjsc8fEOp272pWJlRGrl4K4t/zj8He1YQ9DKTEgeqI4nStKdOlGd9buxrW1s8mxqazlFa4O9GaL+kp6jNZeLSdb3hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/04/25 6:49 pm, Nysal Jan K.A. wrote: > The compiler is unaware of the size of code generated by the ".rept" > assembler directive. This results in the compiler emitting branch > instructions where the offset to branch to exceeds the maximum allowed > value, resulting in build failures like the following: > > CC protection_keys > /tmp/ccypKWAE.s: Assembler messages: > /tmp/ccypKWAE.s:2073: Error: operand out of range (0x0000000000020158 > is not between 0xffffffffffff8000 and 0x0000000000007ffc) > /tmp/ccypKWAE.s:2509: Error: operand out of range (0x0000000000020130 > is not between 0xffffffffffff8000 and 0x0000000000007ffc) > > Fix the issue by manually adding nop instructions using the preprocessor. > > Fixes: 46036188ea1f5 ("selftests/mm: build with -O2") > Reported-by: Madhavan Srinivasan > Signed-off-by: Nysal Jan K.A. > --- > tools/testing/selftests/mm/pkey-powerpc.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pkey-powerpc.h b/tools/testing/selftests/mm/pkey-powerpc.h > index d8ec906b8120..17bf2d1b0192 100644 > --- a/tools/testing/selftests/mm/pkey-powerpc.h > +++ b/tools/testing/selftests/mm/pkey-powerpc.h > @@ -104,8 +104,18 @@ static inline void expect_fault_on_read_execonly_key(void *p1, int pkey) > return; > } > > +#define REPEAT_8(s) s s s s s s s s > +#define REPEAT_64(s) REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) \ > + REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) REPEAT_8(s) > +#define REPEAT_512(s) REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) \ > + REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) REPEAT_64(s) > +#define REPEAT_4096(s) REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) \ > + REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) REPEAT_512(s) > +#define REPEAT_16384(s) REPEAT_4096(s) REPEAT_4096(s) \ > + REPEAT_4096(s) REPEAT_4096(s) > + > /* 4-byte instructions * 16384 = 64K page */ > -#define __page_o_noops() asm(".rept 16384 ; nop; .endr") > +#define __page_o_noops() asm(REPEAT_16384("nop\n")) > > static inline void *malloc_pkey_with_mprotect_subpage(long size, int prot, u16 pkey) > { Tested this patch by applying on top of mainline kernel v6.15-rc4, and it fixes the build issue. Hence, Tested-by: Venkat Rao Bagalkote Without this Patch:  CC       protection_keys /tmp/ccG0zLKW.s: Assembler messages: /tmp/ccG0zLKW.s:1694: Error: operand out of range (0x0000000000020138 is not between 0xffffffffffff8000 and 0x0000000000007ffc) /tmp/ccG0zLKW.s:2577: Error: operand out of range (0x0000000000020110 is not between 0xffffffffffff8000 and 0x0000000000007ffc) In file included from pkey_util.c:5: With this patch: make -j 33 /bin/sh ./check_config.sh gcc   CC       cow   CC       compaction_test   CC       gup_longterm   CC       gup_test   CC       hmm-tests   CC       hugetlb-madvise   CC       hugetlb-read-hwpoison   CC       hugetlb-soft-offline   CC       hugepage-mmap   CC       hugepage-mremap   CC       hugepage-shm   CC       hugepage-vmemmap   CC       khugepaged   CC       madv_populate   CC       map_fixed_noreplace   CC       map_hugetlb   CC       map_populate   CC       migration   CC       mkdirty   CC       mlock-random-test   CC       mlock2-tests   CC       mrelease_test   CC       mremap_dontunmap   CC       mremap_test   CC       mseal_test   CC       on-fault-limit   CC       pagemap_ioctl   CC       thuge-gen   CC       transhuge-stress   CC       uffd-stress   CC       uffd-unit-tests   CC       uffd-wp-mremap   CC       split_huge_page_test   CC       ksm_tests   CC       ksm_functional_tests   CC       hugetlb_fault_after_madv   CC       hugetlb_madv_vs_map   CC       mdwe_test   CC       hugetlb_dio   CC       droppable   CC       guard-regions   CC       soft-dirty   CC       protection_keys   CC       va_high_addr_switch   CC       virtual_address_range   CC       write_to_hugetlbfs   CC [M]  page_frag_test.o   MODPOST Module.symvers   CC [M]  page_frag_test.mod.o   CC [M]  .module-common.o   LD [M]  page_frag_test.ko Regards, Venkat.