From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A54EC282C5 for ; Mon, 3 Mar 2025 11:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF4C36B0083; Mon, 3 Mar 2025 06:16:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4826B009B; Mon, 3 Mar 2025 06:16:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6CE5280003; Mon, 3 Mar 2025 06:16:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 861A86B0083 for ; Mon, 3 Mar 2025 06:16:43 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 33844160767 for ; Mon, 3 Mar 2025 11:16:43 +0000 (UTC) X-FDA: 83179987086.30.CB78E73 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf28.hostedemail.com (Postfix) with ESMTP id BB765C0010 for ; Mon, 3 Mar 2025 11:16:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741000601; a=rsa-sha256; cv=none; b=rsOQAcCWBRT0cbv8dTC1uUxBzoDqhGdcMXk5zSOPdC3V4Qo7NJKK06MzlKzQsSMgTlj1bf oQkTLIv+SpEgEu/huviKbppwD9htFfQmR5ZrtBHaJKFVnrhKVDM+VBUbOylILOPlc3ab1e wHWQrLWaKu1E5kQUr2gTn8aExs5+8o8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741000601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UYjdnHm7Um6gs1R7zRciHUn43ps0ZPKSZ+mTtLq7RI4=; b=veVR33f/xK6GavhgEE31r1bBhUiEqBJVnkoPGvUyMQ2PnYOTvF9gSqtJZdqEDPA/Lp5k29 ykw8WLaYeIyjg90CPNO5vhokK+QN0WtufQQ6zTh4DCBrXOTBOm/kSB8XdYJVY4iNFQ7rLv kt5sFbDrF49tq723WCMok/EjI7wEBaI= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Z5x536RM1z9wDB; Mon, 3 Mar 2025 19:13:27 +0800 (CST) Received: from kwepemo200002.china.huawei.com (unknown [7.202.195.209]) by mail.maildlp.com (Postfix) with ESMTPS id EF84B1401F0; Mon, 3 Mar 2025 19:16:34 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by kwepemo200002.china.huawei.com (7.202.195.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 3 Mar 2025 19:16:34 +0800 Message-ID: Date: Mon, 3 Mar 2025 19:16:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm/hugetlb: fix surplus pages in dissolve_free_huge_page() To: David Hildenbrand , , , CC: , , References: <20250303060920.2886263-1-tujinjiang@huawei.com> <114987e9-a449-4cc7-b897-b5b00a3cf445@redhat.com> From: Jinjiang Tu In-Reply-To: <114987e9-a449-4cc7-b897-b5b00a3cf445@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemo200002.china.huawei.com (7.202.195.209) X-Rspamd-Queue-Id: BB765C0010 X-Stat-Signature: or3nbpunw5tdmnp33yt8941ukak5g9xf X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741000599-185355 X-HE-Meta: U2FsdGVkX19W0FhmcRzs1iZuPSzXcxM6juqUdBY10mmWWcPY/8yKsQ8MYWXxFwZh2da7KRNiexRFFfLCvBYwAeKz7yHaV1S6TnWcSWlIvEhMpOAkyRpCAWMNTpZRxl3bM2H1aSyjFiaRzNGH6UH4ixyBSuE6JHt4vyUnUpxHKHsqm6QxdPCuqPFHvjkmKTXIqM8Y+c23Rp39Aqp+ug2IXWuzgN7HEoqjC70JW8Oycu4b+aDSE+thfEVtndKJ7NiaKvnKucLw5+i1JwCJsxQp3wqc9RwJI/m6DgqZ5Zwt5+Ipz/MIub9vVXXaTekBVNw1+VYalERvUoxpCRDzFYcxR3b/bRpxGyy8r1GYb034uOLfC7dyzfSUKsUANw/HNc5P51Ko90o9YrmWBG9CvQUOsNYD1jEX8arzZNuVE9gUekGf99d+4XVCJcqo0YSvaLQvrI6ZNuWKexcnzVCxHz8OWWNcNWkRt+wsFmRCru4W8iQeoqY8TpHvRQxOgUs0ylObUC3ErehZyH+8t6CL2aoUCcmfrmpJr3v3LGuQ4mtr50JS6w9oPjuzjisEBPc9/xz/dPtIN3YqOS82Iyc5kue59sfJPKEDlYGx/eU7910IEb2wQXvsm/ttotRDLD7JQ0M9RvOX08pU9cuk1uTpVahisvzy074R6hxh9uFRUsZ3dWwaggZzj/7SfFcmAiHWKuIAWNPYFGmvMzVz8riTPDI+o2wAvCpabJDLcfkkh1RrZp2tp5ITD5XqDalpMewV5gRzrOy3mZ4mfU35MfLJw3MNli2xWKoZcgiYRkXCApTGePYzzGYR9f61+b5+/AX8P1lXNoZ0JnGBiF3pwmdsxJG6HNy5ovxW/fbIKaS8f8phf7jliMNiJYgkL2FOsxDC/HN+MVaW/djMXsS5NbNLZ6oz90crWgKY5AmFmHxJ8Fiwbbmue4YAXfF19KvijEuH9gJjmqO7QtsSNssyzuokQ2Q 21KDFNYW Kruq8jAzrJtZYme0X44F22HdHxv0bnDROVcm8IHpBlHcC3J8FHRwqW+zjfvW3zXe5jHfPLd3U3YhlyNnFWaP/hSCJoUytqQI06vcBdRyS2TsV2UV9Idmd/jNvJHol1n9zhkAs/8I5JnXAoPBdAdh2exrL+SSnPe7XlyfAsx1998+IXCw92zErW9vF3QDU7ceM7Xq9r4rgFqsBits= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/3 18:25, David Hildenbrand 写道: > On 03.03.25 07:09, Jinjiang Tu wrote: >> In dissolve_free_huge_page(), free huge pages are dissolved without >> adjusting surplus count. However, free huge pages may be accounted as >> surplus pages, and will lead to wrong surplus count. >> >> Steps to reproduce: >> 1) create 64 huge pages for node1 >> 2) run a program to reserve (don't consume) all the huge pages >> 3) echo 0 > nr_huge_pages for node1. After this step, free huge pages in >> Node1 are surplus. >> 4) create 80 huge pages for node0 >> 5) offline memory of node1 and kill the program in step 2) > > Can you elaborate the "offline memory" part? How much are you > offlining (the complete node vs a single memory block?) I reproduce this issue on qemu. The memory onlining and offlining operations are: 1）Node1 is memory-less at first. Hot-add memory to node1 by executing the two commands in qemu monitor object_add memory-backend-ram,id=mem1,size=1G device_add pc-dimm,id=dimm1,memdev=mem1,node=1 2）online one memory block of Node1 with： echo online_movable > /sys/devices/system/node/node1/memoryX/state 3) offline the memory block of Node1 with： echo offline > /sys/devices/system/node/node1/memoryX/state > > If I skip the offlining part, it all works as expected on a 6.12 kernel. >