From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD311C74A5B for ; Wed, 29 Mar 2023 23:32:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D4926B0075; Wed, 29 Mar 2023 19:32:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 484486B0078; Wed, 29 Mar 2023 19:32:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FDDB6B007B; Wed, 29 Mar 2023 19:32:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1E9106B0075 for ; Wed, 29 Mar 2023 19:32:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E4C3F1C6560 for ; Wed, 29 Mar 2023 23:32:21 +0000 (UTC) X-FDA: 80623536882.02.07C5CDD Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by imf17.hostedemail.com (Postfix) with ESMTP id 8E5934000B for ; Wed, 29 Mar 2023 23:32:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=IVIrVEB3; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=CzTI5dmK; spf=pass (imf17.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132739; a=rsa-sha256; cv=none; b=jCYAoYk/O+4WCNE+A9xmq8dzF6U5Wl0ZuMcm4xSH5Yytig8gsWplLII1Hy6D29qxiBxNgV A15lT5oge57WtFm/5VLv32PUWUSt1ZiYJDSxUZFNcLacaUw5BwED6YfUhTxMrWSRLRtl8s vwD2hDbwQxY+Vt+k8n938CH0Py0uu4E= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=IVIrVEB3; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=CzTI5dmK; spf=pass (imf17.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.154.42 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PreQGm3kw+Yz5SCWCsPqxJKMJ8hKImN+FmWRLj6WIEM=; b=7GTzr6NvXJbgo0MtPvShIB2tMmKIJc26022mddERUakRgK+8JDTuSJeDyLdJ5stwjmfF+8 1LzhxTMjkw7A9se+5/vlVbl9EhSVG8xss0VhaMqh1IcF55S5UdyP8BgFKLuNNU7q2cyuI9 IH+vZqtlz3mJEUxkJlL9kibu5ReUmaE= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132739; x=1711668739; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2oOVyR5FAdaST7S/q6ZiTs6JWIlaWidrp4+z9soxNLY=; b=IVIrVEB3ZddWUsYs7aRERbqhJI5n9AxCDyq4c2f3uGyp8yfHNap2lEbh mZyhQeXnhQlqP6ISxOPRHo13jc2UoGwEPb859uZy02SnscVrYi629S3eu Kdx3I8wIB9ATpYIWLq7TPwN6ChW8R3FTVis7obMjLOGoKLIk7wK5bfCM5 Ss+is6mKE+5NxIs4x3IuSxSTRpYH+M4Y+t4yetFafX7rfTYYI0xceWlQs ZLEITi1wSgHWObnhS1KfJLc1sGqVjUkt4ljOkXHkcZm4tP8bbPygezXRB Xtl1sZFtbBF8Y4eM6pil1lPTNwYWrlEg7+WAvBuqIzstW9vrD/1m5GWYK A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225113565" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:32:18 +0800 IronPort-SDR: zz+deyc/o9nx8otU4xVF8e7p9qY6lf74VJCV60SbKrMvgePFXRG73qp4pAYrTkCCFWJtD2K6xH voZ+EPnmE3KzGBDM/D/a4nJpKaF/GNze57I52efHUNTBOIXRRxK5Bx92d1pOuj2gmiavkGuIUQ R4lsVRkLgJFMaC0Sfr+Xn4LO52ocO0V/PAV7Kq9HL44sx6pNUdCVZBNTyVj4TLbJN1JNdI5cvg RBlkUYip6T5w/sx05XJHlIxd85qJz1U+0PScximHFbTG1yLiy2ygVu94mluwyKoCN0slmGFJZm 9ss= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:48:27 -0700 IronPort-SDR: MQI9YPs+dxG2nVNla732fjjxjafPsqWgj0jtkTOO19JcaTFnDJzempCW0GspqaWHSffFln1sAu 16igxxh1MUjCbIk9kbFmKOZHjp7jxXxjLiD3QC36CTA1Iu2mTHubg+Tn3DsDPTjeKtrVqMI5XP ZeD6C6h+uN25UkzreCtxAkkSwbooWyXodayv4LZyoP3J8/jzEeWXr9P7DH7uvsjL+ktPW5xBIc /vcUFYQf1H100SP7DZs9YHA/iBnNq+/OG2sf96iXDdt096MoWFcVP7SkrhcHE3llqhZQr3zANu 2Xw= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:32:18 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2ry19h2z1RtW4 for ; Wed, 29 Mar 2023 16:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132737; x=1682724738; bh=2oOVyR5FAdaST7S/q6ZiTs6JWIlaWidrp4+ z9soxNLY=; b=CzTI5dmKz+cz+ra1W91v/vvm1q+lz4VpZaKNJ+ur2JgwvsLgkyz Ag9i1RXpGZQVCWt/gCi8lYEB9yivIbPnlXG6Hkz4MlXf5GZofs5pel3W7YhmzADn y+IYY/j6Lu2Sr8JsZyfjakqTUdNpz293fh+kzLI/QY1JbVuKx8S2nxmI8RNRgCP9 5hP2QzGdEOFg9faNtfShxavTwxvhGcZzFc0K7rJLpJN7Iw5Q9BWad4Y+EX6dqTJt 4igFqUNZin9rq2K2OW32dMdvOFsCycds3Ts6xqe6P+GtL3mkBpHqjGNtHRe59whO D7Vet14/ORgEglG520efiA8j4/Y3c2z2ESg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7_MGhuqhoOSn for ; Wed, 29 Mar 2023 16:32:17 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2rt2gL4z1RtVm; Wed, 29 Mar 2023 16:32:14 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:32:13 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 06/19] md: raid5-log: use __bio_add_page to add single page Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <492cbaf4225065838d25e04f8488528e50a52e3e.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <492cbaf4225065838d25e04f8488528e50a52e3e.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 8E5934000B X-Rspamd-Server: rspam01 X-Stat-Signature: sdudaznercdjjkbifphnjw6c4jxwa1cn X-HE-Tag: 1680132739-137118 X-HE-Meta: U2FsdGVkX1/oH+xemKxDGJA9xMewoQXOI57MmHpDIYwKDmG5AycvX4n0sj0P50FzWlB1KwfTvwrnB0v2w0i4A2n3S30OoIX1IhGK3Cb243MAFLhVLliASgKYHj25829cjquyzRGXIm2E62ptJhz5EjtDh4LWPUbOp4Q3Jbm2zj7hZzfjc5bLB0DThf1OXKEj39SGs2/2CvbcWHZmp0F/GcqctPNIR7Cpayu0bfID6qpKL7cY8/6HvHVAwu4PUGAfBgMkfc4HwCYDy5MazJrqNTrq/Sct1pdwSggwiUqVOMFCkdw2Tc1mMIpp0QXem4BmeGkuCcjKb2xPW7f9OjbbPOo6P26SuAb802BF68cEpWnhcLIGPw/yTmrxBs+TJ10PIpwSpZryiPFwn6uFgSMjrO01Bk7FN9NrkH/FKUw1pjdPnJmJ9bSibTAI3Me+iwX4lLLgPU92zDWOZ+3fT9JjTGxcSfFG7BIAZuLQHDlaGtABn3A2cj6UezKoe1gIF3V0HrpB/LL1/YN9tL2rUaP9il3hv/ZIDc+VUsYE/X64d2NVh+SkFdRYe4xWyLJXl22xOpLcsXNaVaDVDkDDhJuSB7+nVpd6uXwEpenX7lZJVbChq1YVg6myVi+I1bosqYf1RuCfmpQHbxfgZ5qX47r9V+5SJz5eUCTrDNXgg7Q0fzrdQp6O57b7ZE+ZDVrOnslbJx2rOsOfIW1UAmtftowVZKJ3XzrbQLv8smr1uEa3nJWQBs6ZKWCAN1B091z9VUEAXfUw60A90XV2x5N5qVf3UdGPI54F9CdOiqVni01aXVTv62V98vETAdBNJg9LZ/EEqGgYYCuMH9LVQrfCCUicWCM2i/NP1hll6qzX086Q8Wc6U0UT+GmiiRW7VjjuNKnfcaqMxcyZi0NojNKwv8UGxEG5+brMAvuf0jjSsTqyPwryFl/huKAQxf52LTS7b6/WOqQGHI1ubWFde1ZuVF4 6QOxox5E U8qpyGrpS9uEuxuoAp5kV8iNezv/DSXBKwpkBaxAV0SfJRr1dHqTmqUObjMp1YL6/HxKWbORK4qemqylFwp5hkKVJZrCFyoZ+6hqeT9Lc3z+b4anyHL+WTIZuDCuoO4nSFoqtdQuWneiXbTBgCZzELRvGNbFuwZTEPHVDuzl6MYaqrrEQh73ETiEyWD0ICXEA9SFiU8T11T8BuHIdJROhoVk+EofEzpNKGMYrqPxaMt8Qi9HvuyIzV9IVpZ60j7tuooVS1bgesBDwnqrOfCDBWS/qusc47V+QStfycT9AvnwgyFft6IW6ONDSyf9I8P6AAMA7iq4HUy4eIhsyaE9IjgE3yRUL78OQFfqFYQqtGMOBmYS/rv4sD6Icm8qtQN1D8QFQOhpDXl4ZcNvxeH/XQPdNQS8qG/RdH9CfMTr4+5KsGf2AQaBlOnV83k24A+lZLtrHOlLnQKRjKZ0xxXjUrSvr9jsnB9azGpgRK/mVxfDWzjSmxtiek1BU71K6PNYbvvDJ1FZGiluTEwsGrKyMQzVeZewB6A/Iep704djzCDW0eOGbvFL+g0jQBW7ln4Jm4QBc0kAeKWU5toR+vhDm8FzW/3SvWe1GB/dqUcSwVIhxaDNN0nU6gPN80fxpeDqwqBBuBuCeXCqO8C8RM4vAP/u/Fb9SEHiIevmsLiDRRlPXaw7B26bGLIOjMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The raid5 log metadata submission code uses bio_add_page() to add a page > to a newly created bio. bio_add_page() can fail, but the return value is > never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research