From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA2CCC001DE for ; Fri, 4 Aug 2023 05:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C57192802C6; Fri, 4 Aug 2023 01:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C08182802BC; Fri, 4 Aug 2023 01:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD00D2802C6; Fri, 4 Aug 2023 01:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9EA272802BC for ; Fri, 4 Aug 2023 01:20:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6803A1404FD for ; Fri, 4 Aug 2023 05:20:10 +0000 (UTC) X-FDA: 81085270980.08.C4E50A6 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf13.hostedemail.com (Postfix) with ESMTP id 7747B20004 for ; Fri, 4 Aug 2023 05:20:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zKsHCcX4; spf=pass (imf13.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691126408; a=rsa-sha256; cv=none; b=ARlMmSZLc18EUUUFD1cF4yo+DQZMBMO2RLeIwFgJpbl5XrP3CHoOFsF2VuZOCUrW6L8Krn 0/85+H09n+fi32UmJqpDXHwpoFDtw8TAl0WQnmRpys7C3MhCInu2oSX0PKxhU2PT2MMRR0 BjaUZIRYnwUyu2kKlC9EyzaXFv4YJ6I= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=zKsHCcX4; spf=pass (imf13.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.42 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691126408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=g/azxbjU48alN7RCsivjCgkRTH8UZaCezXDGgcFlKkA=; b=Ro2pbN+iVPezY4FnJW2b9DWByQETLw3SrslBzwW+R3iFm8Dpf6ShK4hKW0fQrpsQ9ggKhC yIJoiNhxIr5Mjg+Smaj/J/ZLuUiRUfY9MQboj5Kqwfa/PFbFUcqL3YmKDlv4KpJABvfsYt M4nWvHvmzW/qIFEaU1oQAW6Mh4HeJ8Q= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3174aac120aso1471849f8f.2 for ; Thu, 03 Aug 2023 22:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691126407; x=1691731207; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=g/azxbjU48alN7RCsivjCgkRTH8UZaCezXDGgcFlKkA=; b=zKsHCcX4gqdpdIKzTJM/pyeZFZwvQXpBefkbDaXgWucF2XAxafcOnXlTEUHxDsLDeb 93NcCnfdAXju9Pb5wyHH/Rk70LZ1yYTwxeQPwuBlXKOfgtey6hQ6xM1MmDjv/3YClqXU dg/wdtvT5MBJTli6X8X03PSlbCJCLKHzE4raJO4N6mpUwzyscWIFciSZvCd8tSWUxUvv 91sQvxL3Xs1j4wzvboDVsjqQ7ae2p8553pXzwcyX1OlLYc1l6Gq0Bq5L70XGqOmFgv/r p1Ahm1eZd6fCdf9OLc4FVY7hzSozGZSsh0F0IqRBPV+qbpDwzkK6kNXJ4ZUVLG0oSQhZ EWXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691126407; x=1691731207; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g/azxbjU48alN7RCsivjCgkRTH8UZaCezXDGgcFlKkA=; b=HKRyOyTjANo+9HMsvYBI6Fe4W8CRU+EHrfLUw1a0WguNjdAXbQGYhDdhv0I6dwVY1n OkvmiGWiGGDT6CfStarGVrYbKtRz2OUnu5FBb3zj1+zyhqLfXOII9lqTRnitiiZQCpLU J66LpK4CJcyrndfMLWpho60C4kx2RdlQnASIN8QH8EyOwvS0d1rWE+05tYodn05Ouboj e7HEpPDYL1sMNARHMgwMBATUN+/jJRG4GM6SDs4j0LPvMHFzPYPw5Y55iEz+OIDXwf6u q6ZmVvucFlx7URF5ukAkOn9FaB8t1VbnBHjEjp6ETyG9tOqnDmCHu8PuQThmRQIAdMOi j7cA== X-Gm-Message-State: AOJu0YyigMtVYbbK/FImDpRS3Q6JeqajEA49ZBRM8stQ3FSCjykgNzHJ 3QXKEEBp24ylIk66qLZGOlX9QA== X-Google-Smtp-Source: AGHT+IEmqVF8qGeEfmnIY+0mIneIix3hdl20UIum3fTzSAwnErhOsveCmkFon1vau4W95puFdT5W4A== X-Received: by 2002:adf:d844:0:b0:314:21b:1ea2 with SMTP id k4-20020adfd844000000b00314021b1ea2mr341391wrl.39.1691126406835; Thu, 03 Aug 2023 22:20:06 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id b3-20020adfee83000000b0031773e3cf46sm1518910wro.61.2023.08.03.22.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 22:20:06 -0700 (PDT) Date: Fri, 4 Aug 2023 08:20:04 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Roi Dayan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Saeed Mahameed , Eli Cohen , Shay Drory Subject: [linux-next:master 4511/6910] drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:264 mlx5_devcom_send_event() warn: variable dereferenced before IS_ERR check 'devcom' (see line 259) Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7747B20004 X-Stat-Signature: ztemr5sx6zse3ybpij4drhz183hze8da X-Rspam-User: X-HE-Tag: 1691126408-597158 X-HE-Meta: U2FsdGVkX1+9eLS3rmPlO0Fh87CRZ6tMMjcy0V8zaRkI0IFonGYDFMa4rM9/4IbOmXqyeQpNHa/ui0od6kA2gOqosf9ikTPeVBBz0MrEKuxQidFkPsjdZaMJfXtvJV+Xj56Q/tEzKJdobDpYbZ0gksSo/6RCseP0t+O1MWxbrrsT/APlSD/xZ9wWZj5E26tVk+ZhL8hf6Oxk5Q/gv4/JlsMOTEZ94hJqQWU+wrfuxdDKpKL/0QJB9EAxVygVOGkaDU9RCdSPfZhsOlUBRMKCAx6u1hNY27qZvSM4i5FUHJTP9p+Hak8mR4zoOxJJTwKOUOYty433Hgrl2gduLO1O9rxCghBcebt42RAZ3Ja7wrVQnQMcIyn1PS/YwYA1Sw+D99TIs0c3veXe9PSaZGCZP20XfeszIhl+rEQQXJmsED5MPlRrvVPWt+a20JzanA+YH7S5ItyEc4Wh5MEhde0QD2OtzUZYvsWQaNsJUdHNBsJAVDgBNApl272IkqNCgroJZArqVB4pJ/VZg+7/2Kn2ItUnxSphEvixBS4L3z9HrzKnXl+wdxi5z8PaK9OTVklzBTFNoWDlsQWu77qf4SW74cgi3tRVUgO/Qt5w8Jz1Ri3sW5Tyqwb+8+nCp2sHiVftxZGJvbIlzHLXxsEfb90rI/qHMjnycp8AmAKJ4uKPoP2brB4/bZu7mVgRYDEzei17NG6GTSm3FxZ5+TP7CKZoxZuy501YmMI6ZqTbQ23JvFRoKLtNnbIHdhu6h1gZ/NGe/y5CZ+rxt8tg1hnCQh5/rMQ/AY3UDq1Xi4W9kCynFTNBVJAJ9aHJPOhiOp9rEJeyO/Usx59nugpKo6V1B6+ueFgqyXf42jCrJ167C80Qvy7OY3SLzDQcBJIous80FQ+KZa5qzxtb9vTkbXWjrngfIMNM31cLp7Vcs3I5M5ttJEJHya3qJHn5mxgFK3v9N1yNFGRcnnMsS1VPMATj/xT MeNd+AqF H1mLrZje6Lx9jnrAL4i0e5rJsMGDxCn+FpmuYT6dL5wU7Xa3KaEVHyPoetnkmeQ52e4s715l4R4dLr6gOSkMHnJEvItXhIvz5x+v0UtoXfUUplJODdZ4WrzDmfMpMTf9hr2gLVuAGjU1dTUCXWW4AR2asKQOnvvTw/a18/fv11zUt2ozfWalGT7u3RpbGCluYoS/MKzf2ASEGLBBKfikwvgBjJDnA/h2TGShcPR17YtKRM4daZxpLOx8+aFBdjeiOd7G72PEksKU4+hE+UezwqCxT6z2ct/lJ5b7xBICmRWHnl3Nm2Qc9e1lzN/cn6MwJ+xMqQcsE9EFE2pa7OwnPajY16vzz+mF1nEtNa/59ufTVM8fm52xRjVVrjm5tMJws1uDCnFYJ6memN+6j+jy6x4oqFprJWbEGgt1VVfeNViVAHuylmWR2it90BC+0qfW/h9EDp4ZrXre3j7K7y/2+a8m+BncGBYABvlAdoWz9l2VDsXy8/QMbBdbCVm7Eq4aE757Nx8pSVMAWKJjr9icQiO0GokeZ9UWluuPOCE9trpIN56pLSc1AEUY//NbkC0KIPhHL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: fb4327106e5250ee360d0d8b056c1eef7eeb9a98 commit: 88d162b479815f5d6b6a4ff5fdb07aec9dc6280c [4511/6910] net/mlx5: Devcom, Infrastructure changes config: x86_64-randconfig-m001-20230803 (https://download.01.org/0day-ci/archive/20230804/202308041028.AkXYDwJ6-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230804/202308041028.AkXYDwJ6-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202308041028.AkXYDwJ6-lkp@intel.com/ smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:264 mlx5_devcom_send_event() warn: variable dereferenced before IS_ERR check 'devcom' (see line 259) vim +/devcom +264 drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c 88d162b479815f Roi Dayan 2023-05-04 255 int mlx5_devcom_send_event(struct mlx5_devcom_comp_dev *devcom, e2a82bf8a42816 Shay Drory 2023-02-06 256 int event, int rollback_event, fadd59fc50d010 Aviv Heller 2018-12-04 257 void *event_data) fadd59fc50d010 Aviv Heller 2018-12-04 258 { 88d162b479815f Roi Dayan 2023-05-04 @259 struct mlx5_devcom_comp *comp = devcom->comp; ^^^^^^^^^^^^ Dereference 88d162b479815f Roi Dayan 2023-05-04 260 struct mlx5_devcom_comp_dev *pos; 88d162b479815f Roi Dayan 2023-05-04 261 int err = 0; 88d162b479815f Roi Dayan 2023-05-04 262 void *data; fadd59fc50d010 Aviv Heller 2018-12-04 263 fadd59fc50d010 Aviv Heller 2018-12-04 @264 if (IS_ERR_OR_NULL(devcom)) ^^^^^^ Checked too late 88d162b479815f Roi Dayan 2023-05-04 265 return -ENODEV; fadd59fc50d010 Aviv Heller 2018-12-04 266 fadd59fc50d010 Aviv Heller 2018-12-04 267 down_write(&comp->sem); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki